Skip to contentSkip to conversation

block/rbd: fix type of task->complete

PATCH In review Peter Lieven 4 participants 7 messages Jul 7, 2021 – Jul 8, 2021 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block/rbd: fix type of task->complete

task->complete is a bool not an integer.

---
 block/rbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
block/rbd.c +1 -1
index 01a7b94d62..dcf82b15b8 100644
@@ -1066,7 +1066,7 @@ static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size)
 static void qemu_rbd_finish_bh(void *opaque)
 {
     RBDTask *task = opaque;
-    task->complete = 1;
+    task->complete = true;
     aio_co_wake(task->co);
 }
 
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#2 lore raw

Re: [PATCH] MAINTAINERS: update block/rbd.c maintainer

Quoted 21 lines · Peter Lieven

adding myself as a designated reviewer.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -1
index 516db737d1..cfda57e825 100644
@@ -3058,6 +3058,7 @@ F: block/vmdk.c
 
 RBD
 M: Ilya Dryomov <[email protected]>
+R: Peter Lieven <[email protected]>
 L: [email protected]
 S: Supported
 F: block/rbd.c
--
Quoted 3 lines

2.17.1

Nit: I would change the title to "MAINTAINERS: add block/rbd.c reviewer" or something like that.

Thanks again for volunteering!

Ilya

#3 lore raw

Re: [PATCH] MAINTAINERS: update block/rbd.c maintainer

Am 08.07.2021 um 12:44 hat Ilya Dryomov geschrieben:

Quoted 15 lines · Peter Lieven
Quoted 14 lines

adding myself as a designated reviewer.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 516db737d1..cfda57e825 100644
@@ -3058,6 +3058,7 @@ F: block/vmdk.c
 
Quoted 9 lines

MAINTAINERS F: block/vmdk.c · line 3064

Quoted 6 lines
MAINTAINERS +1 -0
 RBD
 M: Ilya Dryomov <[email protected]>
+R: Peter Lieven <[email protected]>
 L: [email protected]
 S: Supported
 F: block/rbd.c

Nit: I would change the title to "MAINTAINERS: add block/rbd.c reviewer" or something like that.

Yes, this is better. I've changed it in my queue.

Kevin

#4 lore raw
In reply to Peter Lieven
Quoted 13 lines · Peter Lieven

task->complete is a bool not an integer.

---
 block/rbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
block/rbd.c +0 -0
index 01a7b94d62..dcf82b15b8 100644

block/rbd.c static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size) · line 1072

Quoted 8 lines
block/rbd.c +1 -1
@@ -1066,7 +1066,7 @@ static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size)
 static void qemu_rbd_finish_bh(void *opaque)
 {
     RBDTask *task = opaque;
-    task->complete = 1;
+    task->complete = true;
     aio_co_wake(task->co);
 }
 

Hi Peter,

What tree/QEMU git sha does this apply to? I am having trouble finding definitions for RBDTask and qemu_rbd_finish_bh; and the patch won't apply to my few-minutes-old clone of upstream.

Connor

#5 lore raw

Am 07.07.2021 um 23:51 hat Connor Kuehl geschrieben:

Quoted 25 lines · Peter Lieven
Quoted 13 lines

task->complete is a bool not an integer.

---
 block/rbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
block/rbd.c +0 -0
index 01a7b94d62..dcf82b15b8 100644

block/rbd.c static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size) · line 1072

Quoted 8 lines
block/rbd.c +1 -1
@@ -1066,7 +1066,7 @@ static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size)
 static void qemu_rbd_finish_bh(void *opaque)
 {
     RBDTask *task = opaque;
-    task->complete = 1;
+    task->complete = true;
     aio_co_wake(task->co);
 }
 

Hi Peter,

Quoted 3 lines

What tree/QEMU git sha does this apply to? I am having trouble finding definitions for RBDTask and qemu_rbd_finish_bh; and the patch won't apply to my few-minutes-old clone of upstream.

It is on top of:

[PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support
Message-Id: <[email protected]>

Also, thanks, applied to the block branch.

Kevin

Reviewed-by on v1 1/1
#6 lore raw
In reply to Peter Lieven
Quoted 22 lines · Peter Lieven

task->complete is a bool not an integer.

---
 block/rbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
block/rbd.c +1 -2
index 01a7b94d62..dcf82b15b8 100644
@@ -1066,7 +1066,7 @@ static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size)
 static void qemu_rbd_finish_bh(void *opaque)
 {
     RBDTask *task = opaque;
-    task->complete = 1;
+    task->complete = true;
     aio_co_wake(task->co);
 }
 
--
Quoted 3 lines

2.17.1

Thanks,

Ilya