HID: amd_sfh: Use correct MMIO register for DMA address
Subsystems (2)
PATCH 1/1 HID: amd_sfh: Use correct MMIO register for DMA address
amd_stop_sensor_v2 accidentally used a different MMIO register than amd_start_sensor_v2 for the DMA address.
--- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/amd-sfh-hid/amd_sfh_pcie.c +1 -1
@@ -58,7 +58,7 @@ static void amd_stop_sensor_v2(struct amd_mp2_dev *privdata, u16 sensor_idx) cmd_base.cmd_v2.sensor_id = sensor_idx; cmd_base.cmd_v2.length =16 ; -writeq (0x0 , privdata->mmio +AMD_C2P_MSG2 ); +writeq (0x0 , privdata->mmio +AMD_C2P_MSG1 );writel (cmd_base.ul, privdata->mmio +AMD_C2P_MSG0 ); }
Signature · 1 line
2.31.1
PATCH 1/1 HID: amd_sfh: Use correct MMIO register for DMA address
amd_stop_sensor_v2 accidentally used a different MMIO register than amd_start_sensor_v2 for the DMA address.
--- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/amd-sfh-hid/amd_sfh_pcie.c +1 -1
@@ -58,7 +58,7 @@ static void amd_stop_sensor_v2(struct amd_mp2_dev *privdata, u16 sensor_idx) cmd_base.cmd_v2.sensor_id = sensor_idx; cmd_base.cmd_v2.length =16 ; -writeq (0x0 , privdata->mmio +AMD_C2P_MSG2 ); +writeq (0x0 , privdata->mmio +AMD_C2P_MSG1 );writel (cmd_base.ul, privdata->mmio +AMD_C2P_MSG0 ); }
Signature · 1 line
2.31.1
hi
Quoted 6 lines · Dylan MacKenzie
[CAUTION: External Email]
amd_stop_sensor_v2accidentally used a different MMIO register thanamd_start_sensor_v2for the DMA address.Signed-off-by Dylan MacKenzie <[email protected]>
Looks good to me. Can you please add a "Fixes:" tag too? With that addressed,
Quoted 20 lines
--- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hid/amd-sfh-hid/amd_sfh_pcie.c +1
-2@@ -58,7 +58,7 @@ static void amd_stop_sensor_v2(struct amd_mp2_dev *privdata, u16 sensor_idx) cmd_base.cmd_v2.sensor_id = sensor_idx; cmd_base.cmd_v2.length =16 ; -writeq (0x0 , privdata->mmio +AMD_C2P_MSG2 ); +writeq (0x0 , privdata->mmio +AMD_C2P_MSG1 );writel (cmd_base.ul, privdata->mmio +AMD_C2P_MSG0 ); } --2.31.1
Jiri Kosina
maintainerQuoted 9 lines · Basavaraj Natikar
Quoted 4 lines
amd_stop_sensor_v2accidentally used a different MMIO register thanamd_start_sensor_v2for the DMA address.Signed-off-by Dylan MacKenzie <[email protected]>Looks good to me. Can you please add a "Fixes:" tag too? With that addressed,
I've added the proper Fixes: tag and applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs