Skip to contentSkip to conversation

HID: amd_sfh: Use correct MMIO register for DMA address

PATCH New Dylan MacKenzie 3 participants 4 messages Jul 13, 2021 – Jul 15, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: amd_sfh: Use correct MMIO register for DMA address

amd_stop_sensor_v2 accidentally used a different MMIO register than amd_start_sensor_v2 for the DMA address.

---
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/amd-sfh-hid/amd_sfh_pcie.c +1 -1
index 96e2577fa37e..8d68796aa905 100644
@@ -58,7 +58,7 @@ static void amd_stop_sensor_v2(struct amd_mp2_dev *privdata, u16 sensor_idx)
 	cmd_base.cmd_v2.sensor_id = sensor_idx;
 	cmd_base.cmd_v2.length  = 16;
 
-	writeq(0x0, privdata->mmio + AMD_C2P_MSG2);
+	writeq(0x0, privdata->mmio + AMD_C2P_MSG1);
 	writel(cmd_base.ul, privdata->mmio + AMD_C2P_MSG0);
 }
 
Signature · 1 line
2.31.1
#1 lore raw

PATCH 1/1 HID: amd_sfh: Use correct MMIO register for DMA address

amd_stop_sensor_v2 accidentally used a different MMIO register than amd_start_sensor_v2 for the DMA address.

---
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/amd-sfh-hid/amd_sfh_pcie.c +1 -1
index 96e2577fa37e..8d68796aa905 100644
@@ -58,7 +58,7 @@ static void amd_stop_sensor_v2(struct amd_mp2_dev *privdata, u16 sensor_idx)
 	cmd_base.cmd_v2.sensor_id = sensor_idx;
 	cmd_base.cmd_v2.length  = 16;
 
-	writeq(0x0, privdata->mmio + AMD_C2P_MSG2);
+	writeq(0x0, privdata->mmio + AMD_C2P_MSG1);
 	writel(cmd_base.ul, privdata->mmio + AMD_C2P_MSG0);
 }
 
Signature · 1 line
2.31.1
Acked-by on v1 1/1
#2 lore raw

hi

Quoted 6 lines · Dylan MacKenzie

[CAUTION: External Email]

amd_stop_sensor_v2 accidentally used a different MMIO register than amd_start_sensor_v2 for the DMA address.

Looks good to me. Can you please add a "Fixes:" tag too? With that addressed,

Quoted 20 lines
---
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/amd-sfh-hid/amd_sfh_pcie.c +1 -2
index 96e2577fa37e..8d68796aa905 100644
@@ -58,7 +58,7 @@ static void amd_stop_sensor_v2(struct amd_mp2_dev *privdata, u16 sensor_idx)
        cmd_base.cmd_v2.sensor_id = sensor_idx;
        cmd_base.cmd_v2.length  = 16;
 
-       writeq(0x0, privdata->mmio + AMD_C2P_MSG2);
+       writeq(0x0, privdata->mmio + AMD_C2P_MSG1);
        writel(cmd_base.ul, privdata->mmio + AMD_C2P_MSG0);
 }
 
--

2.31.1

maintainer
#3 lore raw
Quoted 9 lines · Basavaraj Natikar
Quoted 4 lines

amd_stop_sensor_v2 accidentally used a different MMIO register than amd_start_sensor_v2 for the DMA address.

Looks good to me. Can you please add a "Fixes:" tag too? With that addressed,

I've added the proper Fixes: tag and applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs