fpga: dfl: fme: Fix cpu hotplug issue in performance reporting
Subsystems (3)
PATCH v3 1/1 fpga: dfl: fme: Fix cpu hotplug issue in performance reporting
The performance reporting driver added cpu hotplug feature but it didn't add pmu migration call in cpu offline function.
This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.
Patch fixed this issue by adding pmu_migrate_context call in fme_perf_offline_cpu function.
--- drivers/fpga/dfl-fme-perf.c | 2 ++ 1 file changed, 2 insertions(+)
---
Changelog:
v2 -> v3:
- Added Acked-by tag
- Removed comment as suggested by Wu Hao
- Link to patch v2: https://lkml.org/lkml/2021/7/9/143
v1 -> v2:
- Add [email protected] in cc list
- Link to patch v1: https://lkml.org/lkml/2021/6/28/275
RFC -> PATCH v1
- Remove RFC tag
- Did nits changes on subject and commit message as suggested by Xu Yilun
- Added Tested-by tag
- Link to rfc patch: https://lkml.org/lkml/2021/6/28/112
---
drivers/fpga/dfl-fme-perf.c +2 -0
@@ -953,6 +953,8 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)return 0 ; priv->cpu = target; +perf_pmu_migrate_context (&priv->pmu, cpu, target); +return 0 ; }
Signature · 1 line
2.31.1
Quoted 13 lines · Kajol Jain
The performance reporting driver added cpu hotplug feature but it didn't add pmu migration call in cpu offline function.
This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.Patch fixed this issue by adding
pmu_migrate_contextcall infme_perf_offline_cpufunction.
Quoted 6 lines
Fixes 724142f8c42a ("fpga: dfl: fme: add performance reporting support")Tested-by Xu Yilun <[email protected]>Acked-by Wu Hao <[email protected]>Signed-off-by Kajol Jain <[email protected]>---
Any update on this patch? Please let me know if any changes required.
Thanks,
Kajol Jain
Quoted 35 lines
drivers/fpga/dfl-fme-perf.c | 2 ++ 1 file changed, 2 insertions(+)---
Changelog:
v2 -> v3:
- Added Acked-by tag
- Removed comment as suggested by Wu Hao
- Link to patch v2: https://lkml.org/lkml/2021/7/9/143v1 -> v2:
- Add [email protected] in cc list
- Link to patch v1: https://lkml.org/lkml/2021/6/28/275RFC -> PATCH v1
- Remove RFC tag
- Did nits changes on subject and commit message as suggested by Xu Yilun
- Added Tested-by tag
- Link to rfc patch: https://lkml.org/lkml/2021/6/28/112
---drivers/fpga/dfl-fme-perf.c +2
-0@@ -953,6 +953,8 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)return 0 ; priv->cpu = target; +perf_pmu_migrate_context (&priv->pmu, cpu, target); +return 0 ; }
Moritz Fischer
maintainerQuoted 23 lines · kajoljain
Quoted 13 lines · Kajol Jain
The performance reporting driver added cpu hotplug feature but it didn't add pmu migration call in cpu offline function.
This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.Patch fixed this issue by adding
pmu_migrate_contextcall infme_perf_offline_cpufunction.Quoted 6 lines
Fixes 724142f8c42a ("fpga: dfl: fme: add performance reporting support")Tested-by Xu Yilun <[email protected]>Acked-by Wu Hao <[email protected]>Signed-off-by Kajol Jain <[email protected]>---
Quoted 4 lines
Any update on this patch? Please let me know if any changes required.
Thanks,
Kajol Jain
It's in my 'fixes' branch.
- Moritz
Quoted 24 lines · Moritz Fischer
Quoted 23 lines · kajoljain
Quoted 19 lines · Kajol Jain
The performance reporting driver added cpu hotplug feature but it didn't add pmu migration call in cpu offline function.
This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.Patch fixed this issue by adding
pmu_migrate_contextcall infme_perf_offline_cpufunction.Fixes 724142f8c42a ("fpga: dfl: fme: add performance reporting support")Tested-by Xu Yilun <[email protected]>Acked-by Wu Hao <[email protected]>Signed-off-by Kajol Jain <[email protected]>---
Quoted 6 lines
Quoted 4 lines
Any update on this patch? Please let me know if any changes required.
Thanks,
Kajol JainIt's in my 'fixes' branch.
Thanks Moritz for informing me.
Thanks,
Kajol Jain
Quoted 3 lines
- Moritz