fpga: dfl: fme: Fix cpu hotplug issue in performance reporting
Subsystems (3)
PATCH v2 1/1 fpga: dfl: fme: Fix cpu hotplug issue in performance reporting
The performance reporting driver added cpu hotplug feature but it didn't add pmu migration call in cpu offline function.
This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.
Patch fixed this issue by adding pmu_migrate_context call in fme_perf_offline_cpu function.
--- drivers/fpga/dfl-fme-perf.c | 4 ++++ 1 file changed, 4 insertions(+)
---
Changelog:
v1 -> v2:
- Add [email protected] in cc list
RFC -> PATCH v1
- Remove RFC tag
- Did nits changes on subject and commit message as suggested by Xu Yilun
- Added Tested-by tag
- Link to rfc patch: https://lkml.org/lkml/2021/6/28/112
---
drivers/fpga/dfl-fme-perf.c +4 -0
@@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)return 0 ; priv->cpu = target; + +/* Migrate fme_perf pmu events to the new target cpu */ +perf_pmu_migrate_context (&priv->pmu, cpu, target); +return 0 ; }
Signature · 1 line
2.31.1
Quoted 13 lines
Subject: [PATCH v2] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting
The performance reporting driver added cpu hotplug feature but it didn't add pmu migration call in cpu offline function.
This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.
Quoted 6 lines
Patch fixed this issue by adding
pmu_migrate_contextcall infme_perf_offline_cpufunction.Fixes 724142f8c42a ("fpga: dfl: fme: add performance reporting support")Tested-by Xu Yilun <[email protected]>Signed-off-by Kajol Jain <[email protected]>
Thanks for this fixing! And thanks Yilun for the verification too. : )
Quoted 21 lines
--- drivers/fpga/dfl-fme-perf.c | 4 ++++ 1 file changed, 4 insertions(+)---
Changelog:
v1 -> v2:
- Add [email protected] in cc listRFC -> PATCH v1
- Remove RFC tag
- Did nits changes on subject and commit message as suggested by Xu Yilun
- Added Tested-by tag
- Link to rfc patch: https://lkml.org/lkml/2021/6/28/112
---drivers/fpga/dfl-fme-perf.c +0
-0
drivers/fpga/dfl-fme-perf.c static int fme_perf_offline_cpu(unsigned int cpu, struct · line 958
Quoted 6 lines
drivers/fpga/dfl-fme-perf.c +2
-0@@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)return 0 ; priv->cpu = target; + +/* Migrate fme_perf pmu events to the new target cpu */
Only one minor item, this line is not needed. : )
After remove it,
Thanks
Hao
Quoted 7 lines
drivers/fpga/dfl-fme-perf.c +2
-1+perf_pmu_migrate_context (&priv->pmu, cpu, target); +return 0 ; } --2.31.1
Quoted 46 lines · Hao
Quoted 13 lines
Subject: [PATCH v2] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting
The performance reporting driver added cpu hotplug feature but it didn't add pmu migration call in cpu offline function.
This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.Quoted 6 lines
Patch fixed this issue by adding
pmu_migrate_contextcall infme_perf_offline_cpufunction.Fixes 724142f8c42a ("fpga: dfl: fme: add performance reporting support")Tested-by Xu Yilun <[email protected]>Signed-off-by Kajol Jain <[email protected]>Thanks for this fixing! And thanks Yilun for the verification too. : )
Quoted 24 lines
--- drivers/fpga/dfl-fme-perf.c | 4 ++++ 1 file changed, 4 insertions(+)---
Changelog:
v1 -> v2:
- Add [email protected] in cc listRFC -> PATCH v1
- Remove RFC tag
- Did nits changes on subject and commit message as suggested by Xu Yilun
- Added Tested-by tag
- Link to rfc patch: https://lkml.org/lkml/2021/6/28/112
---drivers/fpga/dfl-fme-perf.c +0
-0@@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)return 0 ;
Quoted 8 lines
drivers/fpga/dfl-fme-perf.c static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node) · line 957
Quoted 3 lines
drivers/fpga/dfl-fme-perf.c +2
-0priv->cpu = target; + +/* Migrate fme_perf pmu events to the new target cpu */ Only one minor item, this line is not needed. : )
After remove it,
Acked-by Wu Hao <[email protected]>
Hi Wu Hao,
Sure I will remove this comment and send new patch.
Thanks,
Kajol Jain
Quoted 12 lines
Thanks
HaoQuoted 7 lines
drivers/fpga/dfl-fme-perf.c +2
-1+perf_pmu_migrate_context (&priv->pmu, cpu, target); +return 0 ; } --2.31.1