Skip to contentSkip to conversation

fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

PATCH Superseded Kajol Jain 2 participants 3 messages Jul 9, 2021 – Jul 13, 2021

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Kajol Jain

author
#0 lore raw

PATCH v2 1/1 fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

The performance reporting driver added cpu hotplug feature but it didn't add pmu migration call in cpu offline function.
This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.

Patch fixed this issue by adding pmu_migrate_context call in fme_perf_offline_cpu function.

Fixes 724142f8c42a ("fpga: dfl: fme: add performance reporting support")
---
 drivers/fpga/dfl-fme-perf.c | 4 ++++
 1 file changed, 4 insertions(+)

---
Changelog:
v1 -> v2:
- Add [email protected] in cc list

RFC -> PATCH v1
- Remove RFC tag
- Did nits changes on subject and commit message as suggested by Xu Yilun
- Added Tested-by tag
- Link to rfc patch: https://lkml.org/lkml/2021/6/28/112
---

drivers/fpga/dfl-fme-perf.c +4 -0
index 4299145ef347..b9a54583e505 100644
@@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)
 		return 0;
 
 	priv->cpu = target;
+
+	/* Migrate fme_perf pmu events to the new target cpu */
+	perf_pmu_migrate_context(&priv->pmu, cpu, target);
+
 	return 0;
 }
 
Signature · 1 line
2.31.1
Acked-by on v2 1/1
#1 lore raw
Quoted 13 lines

Subject: [PATCH v2] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

The performance reporting driver added cpu hotplug feature but it didn't add pmu migration call in cpu offline function.
This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.

Quoted 6 lines

Patch fixed this issue by adding pmu_migrate_context call in fme_perf_offline_cpu function.

Fixes 724142f8c42a ("fpga: dfl: fme: add performance reporting support")

Thanks for this fixing! And thanks Yilun for the verification too. : )

Quoted 21 lines
---
 drivers/fpga/dfl-fme-perf.c | 4 ++++
 1 file changed, 4 insertions(+)

---
Changelog:
v1 -> v2:
- Add [email protected] in cc list

RFC -> PATCH v1
- Remove RFC tag
- Did nits changes on subject and commit message as suggested by Xu Yilun
- Added Tested-by tag
- Link to rfc patch: https://lkml.org/lkml/2021/6/28/112
---

drivers/fpga/dfl-fme-perf.c +0 -0
index 4299145ef347..b9a54583e505 100644

drivers/fpga/dfl-fme-perf.c static int fme_perf_offline_cpu(unsigned int cpu, struct · line 958

Quoted 6 lines
drivers/fpga/dfl-fme-perf.c +2 -0
@@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct
 hlist_node *node)
 		return 0;
 
 	priv->cpu = target;
+
+	/* Migrate fme_perf pmu events to the new target cpu */

Only one minor item, this line is not needed. : )

After remove it,

Thanks
Hao

Quoted 7 lines
drivers/fpga/dfl-fme-perf.c +2 -1
+	perf_pmu_migrate_context(&priv->pmu, cpu, target);
+
 	return 0;
 }
 
--

2.31.1

author
#2 lore raw
Quoted 46 lines · Hao
Quoted 13 lines

Subject: [PATCH v2] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

The performance reporting driver added cpu hotplug feature but it didn't add pmu migration call in cpu offline function.
This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.

Quoted 6 lines

Patch fixed this issue by adding pmu_migrate_context call in fme_perf_offline_cpu function.

Fixes 724142f8c42a ("fpga: dfl: fme: add performance reporting support")

Thanks for this fixing! And thanks Yilun for the verification too. : )

Quoted 24 lines
---
 drivers/fpga/dfl-fme-perf.c | 4 ++++
 1 file changed, 4 insertions(+)

---
Changelog:
v1 -> v2:
- Add [email protected] in cc list

RFC -> PATCH v1
- Remove RFC tag
- Did nits changes on subject and commit message as suggested by Xu Yilun
- Added Tested-by tag
- Link to rfc patch: https://lkml.org/lkml/2021/6/28/112
---

drivers/fpga/dfl-fme-perf.c +0 -0
index 4299145ef347..b9a54583e505 100644
@@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct
 hlist_node *node)
 		return 0;
 
Quoted 8 lines

drivers/fpga/dfl-fme-perf.c static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node) · line 957

Quoted 3 lines
drivers/fpga/dfl-fme-perf.c +2 -0
 	priv->cpu = target;
+
+	/* Migrate fme_perf pmu events to the new target cpu */

Only one minor item, this line is not needed. : )

After remove it,

Hi Wu Hao,
Sure I will remove this comment and send new patch.

Thanks,
Kajol Jain

Quoted 12 lines

Thanks
Hao

Quoted 7 lines
drivers/fpga/dfl-fme-perf.c +2 -1
+	perf_pmu_migrate_context(&priv->pmu, cpu, target);
+
 	return 0;
 }
 
--

2.31.1