tools: Use a single target-independent config to enable OpenSSL
PATCH v2 1/1 tools: Use a single target-independent config to enable OpenSSL
Host tool features, such as mkimage's ability to sign FIT images were enabled or disabled based on the target configuration. However, this misses the point of a target-agnostic host tool.
A target's ability to verify FIT signatures is independent of mkimage's ability to create those signatures. In fact, u-boot's build system doesn't sign images. The target code can be successfully built without relying on any ability to sign such code.
Conversely, mkimage's ability to sign images does not require that those images will only work on targets which support FIT verification. Linking mkimage cryptographic features to target support for FIT verification is misguided.
Without loss of generality, we can say that host features are and should be independent of target features.
While we prefer that a host tool always supports the same feature set, we recognize the following
- some users prefer to build u-boot without a dependency on OpenSSL.
- some distros prefer to ship mkimage without linking to OpenSSL
To allow these use cases, introduce a host-only Kconfig which is used to select or deselect libcrypto support. Some mkimage features or some host tools might not be available, but this shouldn't affect the u-boot build.
I also considered setting the default of this config based on FIT_SIGNATURE. While it would preserve the old behaviour it's also contrary to the goals of this change. I decided to enable it by default, so that the default build yields the most feature-complete mkimage.
---
Changes since v1:
* Drop the verb "_USE_" from the Kconfig option name
tools/Kconfig | 11 +++++++++++ tools/Makefile | 46 ++++++++++++++++++++++++++++++---------------- 2 files changed, 41 insertions(+), 16 deletions(-)
tools/Kconfig +11 -0
@@ -9,4 +9,15 @@ config MKIMAGE_DTC_PATH some cases the system dtc may not support all required features and the path to a different version should be given here. +config TOOLS_LIBCRYPTO + bool "Use OpenSSL's libcrypto library for host tools" + default y + help + Cryptographic signature, verification, and encryption of images is + provided by host tools using OpenSSL's libcrypto. Select 'n' here if + you wish to build host tools without OpenSSL. mkimage will not have + the ability to sign images. + This selection does not affect target features, such as runtime FIT + signature verification. + endmenu
tools/Makefile +30 -16
95 lines not on this page · raw message
Signature · 1 line
2.31.1
Quoted 27 lines · Alexandru Gagniuc
Host tool features, such as mkimage's ability to sign FIT images were enabled or disabled based on the target configuration. However, this misses the point of a target-agnostic host tool.
A target's ability to verify FIT signatures is independent of mkimage's ability to create those signatures. In fact, u-boot's build system doesn't sign images. The target code can be successfully built without relying on any ability to sign such code.
Conversely, mkimage's ability to sign images does not require that those images will only work on targets which support FIT verification. Linking mkimage cryptographic features to target support for FIT verification is misguided.
Without loss of generality, we can say that host features are and should be independent of target features.
While we prefer that a host tool always supports the same feature set, we recognize the following
- some users prefer to build u-boot without a dependency on OpenSSL.
- some distros prefer to ship mkimage without linking to OpenSSLTo allow these use cases, introduce a host-only
Kconfigwhich is used to select or deselect libcrypto support. Some mkimage features or some host tools might not be available, but this shouldn't affect the u-boot build.
Quoted 7 lines
I also considered setting the default of this config based on
FIT_SIGNATURE. While it would preserve the old behaviour it's also contrary to the goals of this change. I decided to enable it by default, so that the default build yields the most feature-complete mkimage.Signed-off-by Alexandru Gagniuc <[email protected]>
This doesn't apply cleanly right now, and while I thought I had fixed that up correctly, building rpi_3_32b for example in the CI contains fails very loudly/badly with this change. Please rebase, thanks!
Signature · 1 line
Tom
v3 cover tools: Use a single config for Host OpenSSL (plus dependent patches)
This series combines
[PATCH v2] tools: Use a single target-independent config to enable OpenSSL and its dependencies.
Changes since v2:
* Replace FIT_OBJS-$(CONFIG_...) with FIT_OBJS-y to resolve rpi buld issue
Alexandru Gagniuc (11):
common: Move host-only logic in image-sig.c to separate file
common: image-sig.c: Remove host-specific logic and #ifdefs
image: Add support for placing crypto_algo in linker lists
image: rsa: Move verification algorithm to a linker list
image: image-sig.c: Remove crypto_algos array
lib: ecdsa: Remove #ifdefs from ecdsa.h
lib: rsa: Remove #ifdefs from rsa.h
image: Eliminate IMAGE_ENABLE_VERIFY macro
image: Eliminate IMAGE_ENABLE_VERIFY_ECDSA macro
image: Add support for relocating crypto_algos in linker lists
tools: Use a single target-independent config to enable OpenSSL
Simon Glass (8):
image: Shorten FIT_ENABLE_SHAxxx_SUPPORT
image: Rename SPL_SHAxxx_SUPPORT to SPL_FIT_SHAxxx
image: Rename CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT
Kconfig: Rename SPL_CRC32_SUPPORT to SPL_CRC32
Kconfig: Rename SPL_MD5_SUPPORT to SPL_MD5
image: Drop IMAGE_ENABLE_SHA1
image: Drop IMAGE_ENABLE_SHAxxx
image: Drop IMAGE_ENABLE_BEST_MATCH
common/Kconfig.boot | 8 +- common/image-fit.c | 10 +- common/image-sig.c | 76 +++---------- common/spl/Kconfig | 14 +-- configs/axm_defconfig | 2 +- configs/bcm963158_ram_defconfig | 2 +- configs/chromebit_mickey_defconfig | 2 +- configs/chromebook_jerry_defconfig | 2 +- configs/chromebook_minnie_defconfig | 2 +- configs/chromebook_speedy_defconfig | 2 +- configs/evb-px30_defconfig | 2 +- configs/firefly-px30_defconfig | 2 +- configs/imxrt1020-evk_defconfig | 2 +- configs/imxrt1050-evk_defconfig | 2 +- configs/mt8516_pumpkin_defconfig | 2 +- configs/odroid-go2_defconfig | 2 +- configs/px30-core-ctouch2-px30_defconfig | 2 +- configs/px30-core-edimm2.2-px30_defconfig | 2 +- configs/sandbox_defconfig | 2 +- configs/socfpga_agilex_atf_defconfig | 2 +- configs/socfpga_agilex_vab_defconfig | 2 +- configs/socfpga_stratix10_atf_defconfig | 2 +- configs/taurus_defconfig | 2 +- include/image.h | 59 ++-------- include/u-boot/ecdsa.h | 25 ---- include/u-boot/rsa.h | 51 +-------- lib/rsa/rsa-sign.c | 4 +- lib/rsa/rsa-verify.c | 18 ++- tools/Kconfig | 11 ++ tools/Makefile | 48 +++++--- tools/image-sig-host.c | 133 ++++++++++++++++++++++ 31 files changed, 259 insertions(+), 236 deletions(-) create mode 100644 tools/image-sig-host.c
Signature · 1 line
2.31.1
PATCH v3 1/19 image: Shorten FIT_ENABLE_SHAxxx_SUPPORT
In reply to Tom RiniFrom: Simon Glass <[email protected]>
The ENABLE part of this name is redundant, since all boolean Kconfig options serve to enable something. The SUPPORT part is also redundant since Kconfigs can be assumed to enable support for something. Together they just serve to make these options overly long and inconsistent with other options.
Rename FIT_ENABLE_SHAxxx_SUPPORT to FIT_SHAxxx
--- common/Kconfig.boot | 6 +++--- configs/mt8516_pumpkin_defconfig | 2 +- include/image.h | 12 ++++++------ 3 files changed, 10 insertions(+), 10 deletions(-)
common/Kconfig.boot +3 -3
@@ -35,7 +35,7 @@ config FIT_EXTERNAL_OFFSET could be put in the hole between data payload and fit image header, such as CSF data on i.MX platform. -config FIT_ENABLE_SHA256_SUPPORT +config FIT_SHA256 bool "Support SHA256 checksum of FIT image contents" default y select SHA256
@@ -44,7 +44,7 @@ config FIT_ENABLE_SHA256_SUPPORT SHA256 checksum is a 256-bit (32-byte) hash value used to check that the image contents have not been corrupted. -config FIT_ENABLE_SHA384_SUPPORT +config FIT_SHA384 bool "Support SHA384 checksum of FIT image contents" default n select SHA384
@@ -54,7 +54,7 @@ config FIT_ENABLE_SHA384_SUPPORT the image contents have not been corrupted. Use this for the highest security. -config FIT_ENABLE_SHA512_SUPPORT +config FIT_SHA512 bool "Support SHA512 checksum of FIT image contents" default n select SHA512
configs/mt8516_pumpkin_defconfig +1 -1
@@ -13,7 +13,7 @@ CONFIG_DEBUG_UART_CLOCK=26000000 # CONFIG_PSCI_RESET is not set CONFIG_DEBUG_UART=y CONFIG_FIT=y -# CONFIG_FIT_ENABLE_SHA256_SUPPORT is not set +# CONFIG_FIT_SHA256 is not set # CONFIG_ARCH_FIXUP_FDT_MEMORY is not set CONFIG_DEFAULT_FDT_FILE="mt8516-pumpkin" # CONFIG_DISPLAY_BOARDINFO is not set
include/image.h +6 -6
@@ -31,9 +31,9 @@ struct fdt_region;#define IMAGE_ENABLE_OF_LIBFDT 1#define CONFIG_FIT_VERBOSE 1/* enable fit_format_{error,warning}() */ #define CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT 1 -#define CONFIG_FIT_ENABLE_SHA256_SUPPORT -#define CONFIG_FIT_ENABLE_SHA384_SUPPORT -#define CONFIG_FIT_ENABLE_SHA512_SUPPORT +#define CONFIG_FIT_SHA256 +#define CONFIG_FIT_SHA384 +#define CONFIG_FIT_SHA512 #define CONFIG_SHA1 #define CONFIG_SHA256 #define CONFIG_SHA384
@@ -89,21 +89,21 @@ struct fdt_region;#define IMAGE_ENABLE_SHA1 0#endif -#if defined(CONFIG_FIT_ENABLE_SHA256_SUPPORT ) || \ +#if defined(CONFIG_FIT_SHA256 ) || \ defined(CONFIG_SPL_SHA256_SUPPORT )#define IMAGE_ENABLE_SHA256 1#else #define IMAGE_ENABLE_SHA256 0#endif -#if defined(CONFIG_FIT_ENABLE_SHA384_SUPPORT ) || \ +#if defined(CONFIG_FIT_SHA384 ) || \ defined(CONFIG_SPL_SHA384_SUPPORT )#define IMAGE_ENABLE_SHA384 1#else #define IMAGE_ENABLE_SHA384 0#endif -#if defined(CONFIG_FIT_ENABLE_SHA512_SUPPORT ) || \ +#if defined(CONFIG_FIT_SHA512 ) || \ defined(CONFIG_SPL_SHA512_SUPPORT )#define IMAGE_ENABLE_SHA512 1#else
Signature · 1 line
2.31.1
Re: [PATCH v3 01/19] image: Shorten FIT_ENABLE_SHAxxx_SUPPORT
Quoted 8 lines · Alexandru Gagniuc
From: Simon Glass <[email protected]>
The ENABLE part of this name is redundant, since all boolean
Kconfigoptions serve to enable something. The SUPPORT part is also redundant since Kconfigs can be assumed to enable support for something. Together they just serve to make these options overly long and inconsistent with other options.
Quoted 5 lines
Rename
FIT_ENABLE_SHAxxx_SUPPORTtoFIT_SHAxxxSigned-off-by Simon Glass <[email protected]>Reviewed-by Alexandru Gagniuc <[email protected]>Signed-off-by Alexandru Gagniuc <[email protected]>
For the series, applied to u-boot/master, thanks!
Signature · 1 line
Tom
PATCH v3 2/19 image: Rename SPL_SHAxxx_SUPPORT to SPL_FIT_SHAxxx
In reply to Tom RiniFrom: Simon Glass <[email protected]>
These option are named inconsistently with other SPL options, thus making them incompatible with the CONFIG_IS_ENABLED() macro. Rename them.
--- common/spl/Kconfig | 8 ++++---- include/image.h | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-)
common/spl/Kconfig +4 -4
@@ -429,7 +429,7 @@ config SPL_MD5_SUPPORT applications where images may be changed maliciously, you should consider SHA256 or SHA384. -config SPL_SHA1_SUPPORT +config SPL_FIT_SHA1 bool "Support SHA1" depends on SPL_FIT select SHA1
@@ -441,7 +441,7 @@ config SPL_SHA1_SUPPORT due to the expanding computing power available to brute-force attacks. For more security, consider SHA256 or SHA384. -config SPL_SHA256_SUPPORT +config SPL_FIT_SHA256 bool "Support SHA256" depends on SPL_FIT select SHA256
@@ -450,7 +450,7 @@ config SPL_SHA256_SUPPORT checksum is a 256-bit (32-byte) hash value used to check that the image contents have not been corrupted. -config SPL_SHA384_SUPPORT +config SPL_FIT_SHA384 bool "Support SHA384" depends on SPL_FIT select SHA384
@@ -461,7 +461,7 @@ config SPL_SHA384_SUPPORT image contents have not been corrupted. Use this for the highest security. -config SPL_SHA512_SUPPORT +config SPL_FIT_SHA512 bool "Support SHA512" depends on SPL_FIT select SHA512
include/image.h +4 -4
@@ -68,7 +68,7 @@ struct fdt_region;# ifdef CONFIG_SPL_MD5_SUPPORT # define IMAGE_ENABLE_MD5 1# endif -# ifdef CONFIG_SPL_SHA1_SUPPORT +# ifdef CONFIG_SPL_FIT_SHA1 # define IMAGE_ENABLE_SHA1 1# endif # else
@@ -90,21 +90,21 @@ struct fdt_region;#endif #if defined(CONFIG_FIT_SHA256 ) || \ - defined(CONFIG_SPL_SHA256_SUPPORT ) + defined(CONFIG_SPL_FIT_SHA256 )#define IMAGE_ENABLE_SHA256 1#else #define IMAGE_ENABLE_SHA256 0#endif #if defined(CONFIG_FIT_SHA384 ) || \ - defined(CONFIG_SPL_SHA384_SUPPORT ) + defined(CONFIG_SPL_FIT_SHA384 )#define IMAGE_ENABLE_SHA384 1#else #define IMAGE_ENABLE_SHA384 0#endif #if defined(CONFIG_FIT_SHA512 ) || \ - defined(CONFIG_SPL_SHA512_SUPPORT ) + defined(CONFIG_SPL_FIT_SHA512 )#define IMAGE_ENABLE_SHA512 1#else #define IMAGE_ENABLE_SHA512 0
Signature · 1 line
2.31.1
PATCH v3 3/19 image: Rename CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT
In reply to Tom RiniFrom: Simon Glass <[email protected]>
Drop the ENABLE and SUPPORT parts of this, which are redundant.
--- common/Kconfig.boot | 2 +- common/image-sig.c | 4 ++-- configs/bcm963158_ram_defconfig | 2 +- configs/sandbox_defconfig | 2 +- include/image.h | 2 +- include/u-boot/rsa.h | 8 ++++---- lib/rsa/rsa-sign.c | 4 ++-- lib/rsa/rsa-verify.c | 2 +- 8 files changed, 13 insertions(+), 13 deletions(-)
common/Kconfig.boot +1 -1
@@ -103,7 +103,7 @@ config FIT_SIGNATURE_MAX_SIZE device memory. Assure this size does not extend past expected storage space. -config FIT_ENABLE_RSASSA_PSS_SUPPORT +config FIT_RSASSA_PSS bool "Support rsassa-pss signature scheme of FIT image contents" depends on FIT_SIGNATURE default n
common/image-sig.c +2 -2
@@ -99,12 +99,12 @@ struct padding_algo padding_algos[] = { .name = "pkcs-1.5", .verify = padding_pkcs_15_verify, }, -#ifdef CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT +#ifdef CONFIG_FIT_RSASSA_PSS { .name = "pss", .verify = padding_pss_verify, } -#endif /* CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT */ +#endif /* CONFIG_FIT_RSASSA_PSS */ };struct checksum_algo *image_get_checksum_algo (const char *full_name)
configs/bcm963158_ram_defconfig +1 -1
@@ -11,7 +11,7 @@ CONFIG_TARGET_BCM963158=y CONFIG_ENV_VARS_UBOOT_CONFIG=y CONFIG_FIT=y CONFIG_FIT_SIGNATURE=y -CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT=y +CONFIG_FIT_RSASSA_PSS=y CONFIG_FIT_VERBOSE=y CONFIG_LEGACY_IMAGE_FORMAT=y CONFIG_SUPPORT_RAW_INITRD=y
configs/sandbox_defconfig +1 -1
@@ -10,7 +10,7 @@ CONFIG_DEBUG_UART=y CONFIG_DISTRO_DEFAULTS=y CONFIG_FIT=y CONFIG_FIT_SIGNATURE=y -CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT=y +CONFIG_FIT_RSASSA_PSS=y CONFIG_FIT_CIPHER=y CONFIG_FIT_VERBOSE=y CONFIG_BOOTSTAGE=y
include/image.h +1 -1
@@ -30,7 +30,7 @@ struct fdt_region;#define IMAGE_ENABLE_FIT 1#define IMAGE_ENABLE_OF_LIBFDT 1#define CONFIG_FIT_VERBOSE 1/* enable fit_format_{error,warning}() */ -#define CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT 1 +#define CONFIG_FIT_RSASSA_PSS 1#define CONFIG_FIT_SHA256 #define CONFIG_FIT_SHA384 #define CONFIG_FIT_SHA512
include/u-boot/rsa.h +4 -4
@@ -119,11 +119,11 @@ int padding_pkcs_15_verify(struct image_sign_info *info, uint8_t *msg, int msg_len, const uint8_t *hash, int hash_len); -#ifdef CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT +#ifdef CONFIG_FIT_RSASSA_PSS int padding_pss_verify (struct image_sign_info *info,uint8_t *msg,int msg_len,const uint8_t *hash,int hash_len); -#endif /* CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT */ +#endif /* CONFIG_FIT_RSASSA_PSS */ #else static inline int rsa_verify_hash(struct image_sign_info *info, const uint8_t *hash,
@@ -146,14 +146,14 @@ static inline int padding_pkcs_15_verify(struct image_sign_info *info, return -ENXIO; } -#ifdef CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT +#ifdef CONFIG_FIT_RSASSA_PSS static inline int padding_pss_verify (struct image_sign_info *info,uint8_t *msg,int msg_len,const uint8_t *hash,int hash_len) {return -ENXIO ; } -#endif /* CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT */ +#endif /* CONFIG_FIT_RSASSA_PSS */ #endif #define RSA_DEFAULT_PADDING_NAME "pkcs-1.5"
lib/rsa/rsa-sign.c +2 -2
@@ -442,7 +442,7 @@ static int rsa_sign_with_key(EVP_PKEY *pkey, struct padding_algo *padding_algo, goto err_sign; } -#ifdef CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT +#ifdef CONFIG_FIT_RSASSA_PSS if (padding_algo && !strcmp (padding_algo->name,"pss" )) {if (EVP_PKEY_CTX_set_rsa_padding (ckey,RSA_PKCS1_PSS_PADDING ) <=0 ) {
@@ -450,7 +450,7 @@ static int rsa_sign_with_key(EVP_PKEY *pkey, struct padding_algo *padding_algo, goto err_sign; } } -#endif /* CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT */ +#endif /* CONFIG_FIT_RSASSA_PSS */ for (i = 0; i < region_count; i++) { if (!EVP_DigestSignUpdate(context, region[i].data,
lib/rsa/rsa-verify.c +1 -1
@@ -95,7 +95,7 @@ int padding_pkcs_15_verify(struct image_sign_info *info,return 0 ; } -#ifdef CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT +#ifdef CONFIG_FIT_RSASSA_PSS static void u32_i2osp (uint32_t val,uint8_t *buf) { buf[0 ] = (uint8_t )((val >>24 ) &0xff );
Signature · 1 line
2.31.1
PATCH v3 4/19 Kconfig: Rename SPL_CRC32_SUPPORT to SPL_CRC32
In reply to Tom RiniFrom: Simon Glass <[email protected]>
Drop the _SUPPORT suffix so we can use CONFIG_IS_ENABLED() with this option.
--- common/spl/Kconfig | 4 ++-- configs/axm_defconfig | 2 +- configs/chromebit_mickey_defconfig | 2 +- configs/chromebook_jerry_defconfig | 2 +- configs/chromebook_minnie_defconfig | 2 +- configs/chromebook_speedy_defconfig | 2 +- configs/evb-px30_defconfig | 2 +- configs/firefly-px30_defconfig | 2 +- configs/imxrt1020-evk_defconfig | 2 +- configs/imxrt1050-evk_defconfig | 2 +- configs/odroid-go2_defconfig | 2 +- configs/px30-core-ctouch2-px30_defconfig | 2 +- configs/px30-core-edimm2.2-px30_defconfig | 2 +- configs/socfpga_agilex_atf_defconfig | 2 +- configs/socfpga_agilex_vab_defconfig | 2 +- configs/socfpga_stratix10_atf_defconfig | 2 +- configs/taurus_defconfig | 2 +- include/image.h | 2 +- 18 files changed, 19 insertions(+), 19 deletions(-)
common/spl/Kconfig +2 -2
@@ -204,7 +204,7 @@ config SPL_LEGACY_IMAGE_SUPPORT config SPL_LEGACY_IMAGE_CRC_CHECK bool "Check CRC of Legacy images" depends on SPL_LEGACY_IMAGE_SUPPORT - select SPL_CRC32_SUPPORT + select SPL_CRC32 help Enable this to check the CRC of Legacy images. While this increases reliability, it affects both code size and boot duration.
@@ -407,7 +407,7 @@ config SYS_MMCSD_RAW_MODE_EMMC_BOOT_PARTITION the eMMC EXT_CSC_PART_CONFIG selection should be overridden in SPL by user defined partition number. -config SPL_CRC32_SUPPORT +config SPL_CRC32 bool "Support CRC32" default y if SPL_LEGACY_IMAGE_SUPPORT help
configs/axm_defconfig +1 -1
@@ -32,7 +32,7 @@ CONFIG_BOOTCOMMAND="run flash_self" CONFIG_BOARD_EARLY_INIT_F=y # CONFIG_SPL_LEGACY_IMAGE_SUPPORT is not set CONFIG_SPL_SYS_MALLOC_SIMPLE=y -CONFIG_SPL_CRC32_SUPPORT=y +CONFIG_SPL_CRC32=y CONFIG_SPL_NAND_SUPPORT=y CONFIG_SPL_NAND_DRIVERS=y CONFIG_SPL_NAND_ECC=y
configs/chromebit_mickey_defconfig +1 -1
@@ -25,7 +25,7 @@ CONFIG_BOARD_EARLY_INIT_R=y CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set -# CONFIG_SPL_CRC32_SUPPORT is not set +# CONFIG_SPL_CRC32 is not set CONFIG_SPL_SPI_LOAD=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y
configs/chromebook_jerry_defconfig +1 -1
@@ -26,7 +26,7 @@ CONFIG_BOARD_EARLY_INIT_R=y CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set -# CONFIG_SPL_CRC32_SUPPORT is not set +# CONFIG_SPL_CRC32 is not set CONFIG_SPL_SPI_LOAD=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y
configs/chromebook_minnie_defconfig +1 -1
@@ -26,7 +26,7 @@ CONFIG_BOARD_EARLY_INIT_R=y CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set -# CONFIG_SPL_CRC32_SUPPORT is not set +# CONFIG_SPL_CRC32 is not set CONFIG_SPL_SPI_LOAD=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y
configs/chromebook_speedy_defconfig +1 -1
@@ -26,7 +26,7 @@ CONFIG_BOARD_EARLY_INIT_R=y CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set -# CONFIG_SPL_CRC32_SUPPORT is not set +# CONFIG_SPL_CRC32 is not set CONFIG_SPL_SPI_LOAD=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y
configs/evb-px30_defconfig +1 -1
@@ -29,7 +29,7 @@ CONFIG_SPL_BOOTROM_SUPPORT=y # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set CONFIG_SPL_STACK_R=y # CONFIG_TPL_BANNER_PRINT is not set -CONFIG_SPL_CRC32_SUPPORT=y +CONFIG_SPL_CRC32=y CONFIG_SPL_ATF=y # CONFIG_TPL_FRAMEWORK is not set # CONFIG_CMD_BOOTD is not set
configs/firefly-px30_defconfig +1 -1
@@ -30,7 +30,7 @@ CONFIG_SPL_BOOTROM_SUPPORT=y # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set CONFIG_SPL_STACK_R=y # CONFIG_TPL_BANNER_PRINT is not set -CONFIG_SPL_CRC32_SUPPORT=y +CONFIG_SPL_CRC32=y CONFIG_SPL_ATF=y # CONFIG_TPL_FRAMEWORK is not set # CONFIG_CMD_BOOTD is not set
configs/imxrt1020-evk_defconfig +1 -1
@@ -24,7 +24,7 @@ CONFIG_SPL_BOARD_INIT=y CONFIG_SPL_SYS_MALLOC_SIMPLE=y CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR=y CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x100 -# CONFIG_SPL_CRC32_SUPPORT is not set +# CONFIG_SPL_CRC32 is not set # CONFIG_BOOTM_NETBSD is not set # CONFIG_BOOTM_PLAN9 is not set # CONFIG_BOOTM_RTEMS is not set
configs/imxrt1050-evk_defconfig +1 -1
@@ -27,7 +27,7 @@ CONFIG_SPL_BOARD_INIT=y CONFIG_SPL_SYS_MALLOC_SIMPLE=y CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR=y CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x100 -# CONFIG_SPL_CRC32_SUPPORT is not set +# CONFIG_SPL_CRC32 is not set # CONFIG_BOOTM_NETBSD is not set # CONFIG_BOOTM_PLAN9 is not set # CONFIG_BOOTM_RTEMS is not set
configs/odroid-go2_defconfig +1 -1
@@ -33,7 +33,7 @@ CONFIG_SPL_BOOTROM_SUPPORT=y # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set CONFIG_SPL_STACK_R=y # CONFIG_TPL_BANNER_PRINT is not set -CONFIG_SPL_CRC32_SUPPORT=y +CONFIG_SPL_CRC32=y CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_POWER_SUPPORT=y CONFIG_SPL_ATF=y
configs/px30-core-ctouch2-px30_defconfig +1 -1
@@ -30,7 +30,7 @@ CONFIG_SPL_BOOTROM_SUPPORT=y # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set CONFIG_SPL_STACK_R=y # CONFIG_TPL_BANNER_PRINT is not set -CONFIG_SPL_CRC32_SUPPORT=y +CONFIG_SPL_CRC32=y CONFIG_SPL_ATF=y # CONFIG_TPL_FRAMEWORK is not set # CONFIG_CMD_BOOTD is not set
configs/px30-core-edimm2.2-px30_defconfig +1 -1
@@ -30,7 +30,7 @@ CONFIG_SPL_BOOTROM_SUPPORT=y # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set CONFIG_SPL_STACK_R=y # CONFIG_TPL_BANNER_PRINT is not set -CONFIG_SPL_CRC32_SUPPORT=y +CONFIG_SPL_CRC32=y CONFIG_SPL_ATF=y # CONFIG_TPL_FRAMEWORK is not set # CONFIG_CMD_BOOTD is not set
configs/socfpga_agilex_atf_defconfig +1 -1
@@ -23,7 +23,7 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="earlycon" CONFIG_USE_BOOTCOMMAND=y CONFIG_BOOTCOMMAND="run fatscript; run mmcfitload; run linux_qspi_enable; run mmcfitboot" -CONFIG_SPL_CRC32_SUPPORT=y +CONFIG_SPL_CRC32=y CONFIG_SPL_CACHE=y CONFIG_SPL_SPI_LOAD=y CONFIG_SPL_ATF=y
configs/socfpga_agilex_vab_defconfig +1 -1
@@ -24,7 +24,7 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="earlycon" CONFIG_USE_BOOTCOMMAND=y CONFIG_BOOTCOMMAND="run fatscript; run mmcfitload; run mmcfitboot" -CONFIG_SPL_CRC32_SUPPORT=y +CONFIG_SPL_CRC32=y CONFIG_SPL_CACHE=y CONFIG_SPL_SPI_LOAD=y CONFIG_SPL_ATF=y
configs/socfpga_stratix10_atf_defconfig +1 -1
@@ -23,7 +23,7 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="earlycon" CONFIG_USE_BOOTCOMMAND=y CONFIG_BOOTCOMMAND="run fatscript; run mmcfitload; run linux_qspi_enable; run mmcfitboot" -CONFIG_SPL_CRC32_SUPPORT=y +CONFIG_SPL_CRC32=y CONFIG_SPL_SPI_LOAD=y CONFIG_SPL_ATF=y CONFIG_SPL_ATF_NO_PLATFORM_PARAM=y
configs/taurus_defconfig +1 -1
@@ -36,7 +36,7 @@ CONFIG_BOOTCOMMAND="nand read 0x22000000 0x200000 0x300000; bootm" CONFIG_BOARD_EARLY_INIT_F=y # CONFIG_SPL_LEGACY_IMAGE_SUPPORT is not set CONFIG_SPL_SYS_MALLOC_SIMPLE=y -CONFIG_SPL_CRC32_SUPPORT=y +CONFIG_SPL_CRC32=y CONFIG_SPL_NAND_SUPPORT=y CONFIG_SPL_NAND_DRIVERS=y CONFIG_SPL_NAND_ECC=y
include/image.h +1 -1
@@ -62,7 +62,7 @@ struct fdt_region;#include <linux/libfdt.h> #include <fdt_support.h> # ifdef CONFIG_SPL_BUILD -# ifdef CONFIG_SPL_CRC32_SUPPORT +# ifdef CONFIG_SPL_CRC32 # define IMAGE_ENABLE_CRC32 1# endif # ifdef CONFIG_SPL_MD5_SUPPORT
Signature · 1 line
2.31.1
PATCH v3 5/19 Kconfig: Rename SPL_MD5_SUPPORT to SPL_MD5
In reply to Tom RiniFrom: Simon Glass <[email protected]>
Drop the _SUPPORT suffix so we can use CONFIG_IS_ENABLED() with this option.
--- common/spl/Kconfig | 2 +- include/image.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
common/spl/Kconfig +1 -1
@@ -417,7 +417,7 @@ config SPL_CRC32 for detected accidental image corruption. For secure applications you should consider SHA1 or SHA256. -config SPL_MD5_SUPPORT +config SPL_MD5 bool "Support MD5" depends on SPL_FIT help
include/image.h +1 -1
@@ -65,7 +65,7 @@ struct fdt_region;# ifdef CONFIG_SPL_CRC32 # define IMAGE_ENABLE_CRC32 1# endif -# ifdef CONFIG_SPL_MD5_SUPPORT +# ifdef CONFIG_SPL_MD5 # define IMAGE_ENABLE_MD5 1# endif # ifdef CONFIG_SPL_FIT_SHA1
Signature · 1 line
2.31.1
PATCH v3 6/19 image: Drop IMAGE_ENABLE_SHA1
In reply to Tom RiniFrom: Simon Glass <[email protected]>
We already have a host Kconfig for SHA1. Use CONFIG_IS_ENABLED(SHA1) directly in the code shared with the host build, so we can drop the unnecessary indirection.
--- common/image-fit.c | 2 +- include/image.h | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-)
common/image-fit.c +1 -1
@@ -1218,7 +1218,7 @@ int calculate_hash(const void *data, int data_len, const char *algo, CHUNKSZ_CRC32); *((uint32_t *)value) =cpu_to_uimage (*((uint32_t *)value)); *value_len =4 ; - }else if (IMAGE_ENABLE_SHA1 &&strcmp (algo,"sha1" ) ==0 ) { + }else if (CONFIG_IS_ENABLED (SHA1 ) &&strcmp (algo,"sha1" ) ==0 ) {sha1_csum_wd ((unsigned char *)data, data_len, (unsigned char *)value,CHUNKSZ_SHA1 ); *value_len =20 ;
include/image.h +0 -8
@@ -68,13 +68,9 @@ struct fdt_region;# ifdef CONFIG_SPL_MD5 # define IMAGE_ENABLE_MD5 1# endif -# ifdef CONFIG_SPL_FIT_SHA1 -# define IMAGE_ENABLE_SHA1 1 -# endif # else # define IMAGE_ENABLE_CRC32 1# define IMAGE_ENABLE_MD5 1 -# define IMAGE_ENABLE_SHA1 1# endif #ifndef IMAGE_ENABLE_CRC32
@@ -85,10 +81,6 @@ struct fdt_region;#define IMAGE_ENABLE_MD5 0#endif -#ifndef IMAGE_ENABLE_SHA1 -#define IMAGE_ENABLE_SHA1 0 -#endif -#if defined(CONFIG_FIT_SHA256 ) || \ defined(CONFIG_SPL_FIT_SHA256 )#define IMAGE_ENABLE_SHA256 1
Signature · 1 line
2.31.1
PATCH v3 7/19 image: Drop IMAGE_ENABLE_SHAxxx
In reply to Tom RiniFrom: Simon Glass <[email protected]>
We already have a host Kconfig for these SHA options. Use CONFIG_IS_ENABLED(SHAxxx) directly in the code shared with the host build, so we can drop the unnecessary indirections.
--- common/image-fit.c | 6 +++--- include/image.h | 21 --------------------- 2 files changed, 3 insertions(+), 24 deletions(-)
common/image-fit.c +3 -3
@@ -1222,15 +1222,15 @@ int calculate_hash(const void *data, int data_len, const char *algo,sha1_csum_wd ((unsigned char *)data, data_len, (unsigned char *)value,CHUNKSZ_SHA1 ); *value_len =20 ; - }else if (IMAGE_ENABLE_SHA256 &&strcmp (algo,"sha256" ) ==0 ) { + }else if (CONFIG_IS_ENABLED (SHA256 ) &&strcmp (algo,"sha256" ) ==0 ) {sha256_csum_wd ((unsigned char *)data, data_len, (unsigned char *)value,CHUNKSZ_SHA256 ); *value_len =SHA256_SUM_LEN ; - }else if (IMAGE_ENABLE_SHA384 &&strcmp (algo,"sha384" ) ==0 ) { + }else if (CONFIG_IS_ENABLED (SHA384 ) &&strcmp (algo,"sha384" ) ==0 ) {sha384_csum_wd ((unsigned char *)data, data_len, (unsigned char *)value,CHUNKSZ_SHA384 ); *value_len =SHA384_SUM_LEN ; - }else if (IMAGE_ENABLE_SHA512 &&strcmp (algo,"sha512" ) ==0 ) { + }else if (CONFIG_IS_ENABLED (SHA512 ) &&strcmp (algo,"sha512" ) ==0 ) {sha512_csum_wd ((unsigned char *)data, data_len, (unsigned char *)value,CHUNKSZ_SHA512 ); *value_len =SHA512_SUM_LEN ;
include/image.h +0 -21
@@ -81,27 +81,6 @@ struct fdt_region;#define IMAGE_ENABLE_MD5 0#endif -#if defined(CONFIG_FIT_SHA256 ) || \ - defined(CONFIG_SPL_FIT_SHA256 ) -#define IMAGE_ENABLE_SHA256 1 -#else -#define IMAGE_ENABLE_SHA256 0 -#endif - -#if defined(CONFIG_FIT_SHA384 ) || \ - defined(CONFIG_SPL_FIT_SHA384 ) -#define IMAGE_ENABLE_SHA384 1 -#else -#define IMAGE_ENABLE_SHA384 0 -#endif - -#if defined(CONFIG_FIT_SHA512 ) || \ - defined(CONFIG_SPL_FIT_SHA512 ) -#define IMAGE_ENABLE_SHA512 1 -#else -#define IMAGE_ENABLE_SHA512 0 -#endif -#endif /* IMAGE_ENABLE_FIT */ #ifdef CONFIG_SYS_BOOT_GET_CMDLINE
Signature · 1 line
2.31.1
PATCH v3 8/19 image: Drop IMAGE_ENABLE_BEST_MATCH
In reply to Tom RiniFrom: Simon Glass <[email protected]>
This is not needed with Kconfig, since we can use IS_ENABLED() easily enough. Drop it.
--- common/image-fit.c | 2 +- include/image.h | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-)
common/image-fit.c +1 -1
@@ -2026,7 +2026,7 @@ int fit_image_load(bootm_headers_t *images, ulong addr,* fit_conf_get_node() will try to find default config node */ bootstage_mark (bootstage_id +BOOTSTAGE_SUB_NO_UNIT_NAME ); -if (IMAGE_ENABLE_BEST_MATCH && !fit_uname_config) { +if (IS_ENABLED (CONFIG_FIT_BEST_MATCH ) && !fit_uname_config) { cfg_noffset =fit_conf_find_compat (fit,gd_fdt_blob ()); }else { cfg_noffset = fit_conf_get_node(fit,
include/image.h +0 -5
@@ -1221,11 +1221,6 @@ void image_set_host_blob(void *host_blob);# define gd_fdt_blob () (gd->fdt_blob)#endif -#ifdef CONFIG_FIT_BEST_MATCH -#define IMAGE_ENABLE_BEST_MATCH 1 -#else -#define IMAGE_ENABLE_BEST_MATCH 0 -#endif #endif /* IMAGE_ENABLE_FIT */ /*
Signature · 1 line
2.31.1
PATCH v3 9/19 common: Move host-only logic in image-sig.c to separate file
In reply to Tom Riniimage-sig.c is used to map a hash or crypto algorithm name to a handler of that algorithm. There is some similarity between the host and target variants, with the differences worked out by #ifdefs. The purpose of this change is to remove those ifdefs.
First, copy the file to a host-only version, and remove target specific code. Although it looks like we are duplicating code, subsequent patches will change the way target algorithms are searched. Besides we are only duplicating three string to struct mapping functions. This isn't something to fuss about.
--- tools/Makefile | 2 +- tools/image-sig-host.c | 133 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 134 insertions(+), 1 deletion(-) create mode 100644 tools/image-sig-host.c
tools/Makefile +1 -1
@@ -58,7 +58,7 @@ hostprogs-$(CONFIG_FIT_SIGNATURE) += fit_info fit_check_sign hostprogs-$(CONFIG_CMD_BOOTEFI_SELFTEST) += file2include FIT_OBJS-$(CONFIG_FIT) := fit_common.o fit_image.o image-host.o common/image-fit.o -FIT_SIG_OBJS-$(CONFIG_FIT_SIGNATURE) := common/image-sig.o common/image-fit-sig.o +FIT_SIG_OBJS-$(CONFIG_FIT_SIGNATURE) := image-sig-host.o common/image-fit-sig.o FIT_CIPHER_OBJS-$(CONFIG_FIT_CIPHER) := common/image-cipher.o # The following files are synced with upstream DTC.
tools/image-sig-host.c new file +133 -0
133 lines not on this page · raw message
Signature · 1 line
2.31.1
PATCH v3 10/19 common: image-sig.c: Remove host-specific logic and #ifdefs
In reply to Tom RiniRemove any ifdefs in image-sig.c that were previously used to differentiate from the host code. Note that all code dedicated to relocating ->sign() and ->add_verify_data)_ can be safely removed, as signing is not supported target-side.
NOTE that although it appears we are removing ecdsa256 support, this is intentional. ecdsa_verify() is a no-op on the target, and is currently only used by host code.
--- common/image-sig.c | 39 ++------------------------------------- 1 file changed, 2 insertions(+), 37 deletions(-)
common/image-sig.c +2 -37
@@ -3,18 +3,11 @@* Copyright (c) 2013, Google Inc. */ -#ifdef USE_HOSTCC -#include "mkimage.h" -#include <fdt_support.h> -#include <time.h> -#include <linux/libfdt.h> -#else #include <common.h> #include <log.h> #include <malloc.h> #include <asm/global_data.h> DECLARE_GLOBAL_DATA_PTR ; -#endif /* !USE_HOSTCC*/ #include <image.h> #include <u-boot/ecdsa.h> #include <u-boot/rsa.h>
@@ -28,9 +21,6 @@ struct checksum_algo checksum_algos[] = { .checksum_len = SHA1_SUM_LEN, .der_len = SHA1_DER_LEN, .der_prefix = sha1_der_prefix, -#if IMAGE_ENABLE_SIGN - .calculate_sign = EVP_sha1, -#endif .calculate = hash_calculate, }, {
@@ -38,9 +28,6 @@ struct checksum_algo checksum_algos[] = { .checksum_len = SHA256_SUM_LEN, .der_len = SHA256_DER_LEN, .der_prefix = sha256_der_prefix, -#if IMAGE_ENABLE_SIGN - .calculate_sign = EVP_sha256, -#endif .calculate = hash_calculate, },#ifdef CONFIG_SHA384
@@ -49,9 +36,6 @@ struct checksum_algo checksum_algos[] = { .checksum_len = SHA384_SUM_LEN, .der_len = SHA384_DER_LEN, .der_prefix = sha384_der_prefix, -#if IMAGE_ENABLE_SIGN - .calculate_sign = EVP_sha384, -#endif .calculate = hash_calculate, },#endif
@@ -61,9 +45,6 @@ struct checksum_algo checksum_algos[] = { .checksum_len = SHA512_SUM_LEN, .der_len = SHA512_DER_LEN, .der_prefix = sha512_der_prefix, -#if IMAGE_ENABLE_SIGN - .calculate_sign = EVP_sha512, -#endif .calculate = hash_calculate, },#endif
@@ -74,24 +55,13 @@ struct crypto_algo crypto_algos[] = { { .name = "rsa2048", .key_len = RSA2048_BYTES, - .sign = rsa_sign, - .add_verify_data = rsa_add_verify_data, .verify = rsa_verify, }, { .name = "rsa4096", .key_len = RSA4096_BYTES, - .sign = rsa_sign, - .add_verify_data = rsa_add_verify_data, .verify = rsa_verify, }, - { - .name = "ecdsa256", - .key_len = ECDSA256_BYTES, - .sign = ecdsa_sign, - .add_verify_data = ecdsa_add_verify_data, - .verify = ecdsa_verify, - }, }; struct padding_algo padding_algos[] = {
@@ -112,16 +82,13 @@ struct checksum_algo *image_get_checksum_algo(const char *full_name)int i;const char *name; -#if !defined(USE_HOSTCC ) && defined(CONFIG_NEEDS_MANUAL_RELOC ) +#if defined(CONFIG_NEEDS_MANUAL_RELOC )static bool done;if (!done) { done = true;for (i =0 ; i <ARRAY_SIZE (checksum_algos); i++) { checksum_algos[i].name += gd->reloc_off; -#if IMAGE_ENABLE_SIGN - checksum_algos[i].calculate_sign += gd->reloc_off; -#endif checksum_algos[i].calculate += gd->reloc_off; } }
@@ -143,15 +110,13 @@ struct crypto_algo *image_get_crypto_algo(const char *full_name)int i;const char *name; -#if !defined(USE_HOSTCC ) && defined(CONFIG_NEEDS_MANUAL_RELOC ) +#if defined(CONFIG_NEEDS_MANUAL_RELOC )static bool done;if (!done) { done = true;for (i =0 ; i <ARRAY_SIZE (crypto_algos); i++) { crypto_algos[i].name += gd->reloc_off; - crypto_algos[i].sign += gd->reloc_off; - crypto_algos[i].add_verify_data += gd->reloc_off; crypto_algos[i].verify += gd->reloc_off; } }
Signature · 1 line
2.31.1
PATCH v3 11/19 image: Add support for placing crypto_algo in linker lists
In reply to Tom RiniThe purpose of this change is to enable crypto algorithms to be placed in linker lists, rather than be declared as a static array. The goal is to remove the crypto_algos array in a subsequent patch.
Create a new linker list named "cryptos", and search it when image_get_crypto_algo() is invoked.
NOTE that adding support for manual relocation of crypto_algos within linker lists is beyond the scope of this patch.
--- common/image-sig.c | 9 +++++++++ include/image.h | 5 +++++ 2 files changed, 14 insertions(+)
common/image-sig.c +9 -0
@@ -107,6 +107,7 @@ struct checksum_algo *image_get_checksum_algo(const char *full_name)struct crypto_algo *image_get_crypto_algo (const char *full_name) { +struct crypto_algo *crypto, *end;int i;const char *name;
@@ -133,6 +134,14 @@ struct crypto_algo *image_get_crypto_algo(const char *full_name)return &crypto_algos[i]; } + crypto = ll_entry_start(struct crypto_algo, cryptos); + end = ll_entry_end(struct crypto_algo, cryptos); +for (; crypto < end; crypto++) { +if (!strcmp (crypto->name, name)) +return crypto; + } + +/* Not found */ return NULL ; }
include/image.h +5 -0
@@ -47,6 +47,7 @@ struct fdt_region;#include <lmb.h> #include <asm/u-boot.h> #include <command.h> +#include <linker_lists.h> /* Take notice of the 'ignore' property for hashes */ #define IMAGE_ENABLE_IGNORE 1
@@ -1328,6 +1329,10 @@ struct crypto_algo { uint8_t *sig, uint sig_len); }; +/* Declare a new U-Boot crypto algorithm handler */ +#define U_BOOT_CRYPTO_ALGO (__name) \ +ll_entry_declare(struct crypto_algo, __name, cryptos) +struct padding_algo {const char *name; int (*verify)(struct image_sign_info *info,
Signature · 1 line
2.31.1
PATCH v3 12/19 image: rsa: Move verification algorithm to a linker list
In reply to Tom RiniMove the RSA verification crytpo_algo structure out of the crypto_algos array, and into a linker list.
Although it appears we are adding an #ifdef to rsa-verify.c, the gains outweigh this small inconvenience. This is because rsa_verify() is defined differently based on #ifdefs. This change allows us to have a single definition of rsa_verify().
--- common/image-sig.c | 9 --------- lib/rsa/rsa-verify.c | 16 ++++++++++++++++ 2 files changed, 16 insertions(+), 9 deletions(-)
common/image-sig.c +0 -9
@@ -53,15 +53,6 @@ struct checksum_algo checksum_algos[] = {struct crypto_algo crypto_algos[] = { { - .name ="rsa2048" , - .key_len =RSA2048_BYTES , - .verify = rsa_verify, - }, - { - .name ="rsa4096" , - .key_len =RSA4096_BYTES , - .verify = rsa_verify, - }, }; struct padding_algo padding_algos[] = {
lib/rsa/rsa-verify.c +16 -0
@@ -571,3 +571,19 @@ int rsa_verify(struct image_sign_info *info,return rsa_verify_hash (info, hash, sig, sig_len); } + +#ifndef USE_HOSTCC + +U_BOOT_CRYPTO_ALGO (rsa2048) = { + .name ="rsa2048" , + .key_len =RSA2048_BYTES , + .verify = rsa_verify, +}; + +U_BOOT_CRYPTO_ALGO (rsa4096) = { + .name ="rsa4096" , + .key_len =RSA4096_BYTES , + .verify = rsa_verify, +}; + +#endif
Signature · 1 line
2.31.1
PATCH v3 13/19 image: image-sig.c: Remove crypto_algos array
In reply to Tom RiniCrytographic algorithms (currently RSA), are stored in linker lists. The crypto_algos array is unused, so remove it, and any logic associated with it.
--- common/image-sig.c | 22 ---------------------- 1 file changed, 22 deletions(-)
common/image-sig.c +0 -22
@@ -51,10 +51,6 @@ struct checksum_algo checksum_algos[] = { }; -struct crypto_algo crypto_algos[] = { - { -}; -struct padding_algo padding_algos[] = { { .name ="pkcs-1.5" ,
@@ -99,32 +95,14 @@ struct checksum_algo *image_get_checksum_algo(const char *full_name)struct crypto_algo *image_get_crypto_algo (const char *full_name) {struct crypto_algo *crypto, *end; -int i;const char *name; -#if defined(CONFIG_NEEDS_MANUAL_RELOC ) -static bool done; - -if (!done) { - done = true; -for (i =0 ; i <ARRAY_SIZE (crypto_algos); i++) { - crypto_algos[i].name += gd->reloc_off; - crypto_algos[i].verify += gd->reloc_off; - } - } -#endif -/* Move name to after the comma */ name =strchr (full_name,',' );if (!name)return NULL ; name +=1 ; -for (i =0 ; i <ARRAY_SIZE (crypto_algos); i++) { -if (!strcmp (crypto_algos[i].name, name)) -return &crypto_algos[i]; - } - crypto = ll_entry_start(struct crypto_algo, cryptos); end = ll_entry_end(struct crypto_algo, cryptos);for (; crypto < end; crypto++) {
Signature · 1 line
2.31.1
PATCH v3 14/19 lib: ecdsa: Remove #ifdefs from ecdsa.h
In reply to Tom RiniIt is no longer necessary to implement ecdsa_() functions as no-ops depending on config options. It is merely sufficient to provide the prototypes, as the ecdsa code is no longer linked when unused.
--- include/u-boot/ecdsa.h | 25 ------------------------- 1 file changed, 25 deletions(-)
include/u-boot/ecdsa.h +0 -25
@@ -15,7 +15,6 @@* @see "struct crypto_algo" * @{ */ -#if IMAGE_ENABLE_SIGN /** * sign() - calculate and return signature for given input data *
@@ -49,22 +48,7 @@ int ecdsa_sign(struct image_sign_info *info, const struct image_region region[],* other -ve value on error */ int ecdsa_add_verify_data (struct image_sign_info *info,void *keydest); -#else -static inline -int ecdsa_sign (struct image_sign_info *info,const struct image_region region[], -int region_count,uint8_t **sigp,uint *sig_len) -{ -return -ENXIO ; -} - -static inline -int ecdsa_add_verify_data (struct image_sign_info *info,void *keydest) -{ -return -ENXIO ; -} -#endif -#if IMAGE_ENABLE_VERIFY_ECDSA /** * verify() - Verify a signature against some data *
@@ -78,15 +62,6 @@ int ecdsa_add_verify_data(struct image_sign_info *info, void *keydest)int ecdsa_verify (struct image_sign_info *info,const struct image_region region[],int region_count,uint8_t *sig,uint sig_len); -#else -static inline -int ecdsa_verify (struct image_sign_info *info, -const struct image_region region[],int region_count, -uint8_t *sig,uint sig_len) -{ -return -ENXIO ; -} -#endif /** @} */ #define ECDSA256_BYTES (256 / 8)
Signature · 1 line
2.31.1
PATCH v3 15/19 lib: rsa: Remove #ifdefs from rsa.h
In reply to Tom RiniIt is no longer necessary to implement rsa_() functions as no-ops depending on config options. It is merely sufficient to provide the prototypes, as the rsa code is no longer linked when unused.
--- include/u-boot/rsa.h | 47 -------------------------------------------- 1 file changed, 47 deletions(-)
include/u-boot/rsa.h +0 -47
@@ -31,7 +31,6 @@ struct rsa_public_key {struct image_sign_info ; -#if IMAGE_ENABLE_SIGN /** * sign() - calculate and return signature for given input data *
@@ -66,22 +65,7 @@ int rsa_sign(struct image_sign_info *info,other -ve value on error */ int rsa_add_verify_data (struct image_sign_info *info,void *keydest); -#else -static inline int rsa_sign (struct image_sign_info *info, -const struct image_region region[],int region_count, -uint8_t **sigp,uint *sig_len) -{ -return -ENXIO ; -} - -static inline int rsa_add_verify_data (struct image_sign_info *info, -void *keydest) -{ -return -ENXIO ; -} -#endif -#if IMAGE_ENABLE_VERIFY /** * rsa_verify_hash() - Verify a signature against a hash *
@@ -124,37 +108,6 @@ int padding_pss_verify(struct image_sign_info *info, uint8_t *msg, int msg_len, const uint8_t *hash, int hash_len);#endif /* CONFIG_FIT_RSASSA_PSS */ -#else -static inline int rsa_verify_hash (struct image_sign_info *info, -const uint8_t *hash, -uint8_t *sig,uint sig_len) -{ -return -ENXIO ; -} - -static inline int rsa_verify (struct image_sign_info *info, -const struct image_region region[],int region_count, -uint8_t *sig,uint sig_len) -{ -return -ENXIO ; -} - -static inline int padding_pkcs_15_verify (struct image_sign_info *info, -uint8_t *msg,int msg_len, -const uint8_t *hash,int hash_len) -{ -return -ENXIO ; -} - -#ifdef CONFIG_FIT_RSASSA_PSS -static inline int padding_pss_verify (struct image_sign_info *info, -uint8_t *msg,int msg_len, -const uint8_t *hash,int hash_len) -{ -return -ENXIO ; -} -#endif /* CONFIG_FIT_RSASSA_PSS */ -#endif #define RSA_DEFAULT_PADDING_NAME "pkcs-1.5"
Signature · 1 line
2.31.1
PATCH v3 16/19 image: Eliminate IMAGE_ENABLE_VERIFY macro
In reply to Tom RiniThis macro is no longer needed for code flow or #ifdefs. Remove it.
--- include/image.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
include/image.h +1 -4
@@ -1196,19 +1196,16 @@ int calculate_hash(const void *data, int data_len, const char *algo,#if defined(USE_HOSTCC )# if defined(CONFIG_FIT_SIGNATURE )# define IMAGE_ENABLE_SIGN 1 -# define IMAGE_ENABLE_VERIFY 1# define IMAGE_ENABLE_VERIFY_ECDSA 1# define FIT_IMAGE_ENABLE_VERIFY 1# include <openssl/evp.h> # else # define IMAGE_ENABLE_SIGN 0 -# define IMAGE_ENABLE_VERIFY 0# define IMAGE_ENABLE_VERIFY_ECDSA 0# define FIT_IMAGE_ENABLE_VERIFY 0# endif #else # define IMAGE_ENABLE_SIGN 0 -# define IMAGE_ENABLE_VERIFY CONFIG_IS_ENABLED(RSA_VERIFY)# define IMAGE_ENABLE_VERIFY_ECDSA 0# define FIT_IMAGE_ENABLE_VERIFY CONFIG_IS_ENABLED(FIT_SIGNATURE)#endif
@@ -1260,7 +1257,7 @@ struct image_region {int size; }; -#if IMAGE_ENABLE_VERIFY +#if FIT_IMAGE_ENABLE_VERIFY # include <u-boot/hash-checksum.h> #endif struct checksum_algo {
Signature · 1 line
2.31.1
PATCH v3 17/19 image: Eliminate IMAGE_ENABLE_VERIFY_ECDSA macro
In reply to Tom RiniThis macro is no longer needed for code flow or #ifdefs. Remove it.
--- include/image.h | 3 --- 1 file changed, 3 deletions(-)
include/image.h +0 -3
@@ -1196,17 +1196,14 @@ int calculate_hash(const void *data, int data_len, const char *algo,#if defined(USE_HOSTCC )# if defined(CONFIG_FIT_SIGNATURE )# define IMAGE_ENABLE_SIGN 1 -# define IMAGE_ENABLE_VERIFY_ECDSA 1# define FIT_IMAGE_ENABLE_VERIFY 1# include <openssl/evp.h> # else # define IMAGE_ENABLE_SIGN 0 -# define IMAGE_ENABLE_VERIFY_ECDSA 0# define FIT_IMAGE_ENABLE_VERIFY 0# endif #else # define IMAGE_ENABLE_SIGN 0 -# define IMAGE_ENABLE_VERIFY_ECDSA 0# define FIT_IMAGE_ENABLE_VERIFY CONFIG_IS_ENABLED(FIT_SIGNATURE)#endif
Signature · 1 line
2.31.1
PATCH v3 18/19 image: Add support for relocating crypto_algos in linker lists
In reply to Tom RiniFunction pointers from crypto_algos array are relocated, when NEEDS_MANUAL_RELOC is set. This relocation doesn't happen if the algo is placed in a linker list. Implement this relocation.
--- common/image-sig.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
common/image-sig.c +13 -0
@@ -97,6 +97,19 @@ struct crypto_algo *image_get_crypto_algo(const char *full_name)struct crypto_algo *crypto, *end;const char *name; +#if defined(CONFIG_NEEDS_MANUAL_RELOC ) +static bool done; + +if (!done) { + crypto = ll_entry_start(struct crypto_algo, cryptos); + end = ll_entry_end(struct crypto_algo, cryptos); +for (; crypto < end; crypto++) { + crypto->name += gd->reloc_off; + crypto->verify += gd->reloc_off; + } + } +#endif +/* Move name to after the comma */ name =strchr (full_name,',' );if (!name)
Signature · 1 line
2.31.1
PATCH v3 19/19 tools: Use a single target-independent config to enable OpenSSL
In reply to Tom RiniHost tool features, such as mkimage's ability to sign FIT images were enabled or disabled based on the target configuration. However, this misses the point of a target-agnostic host tool.
A target's ability to verify FIT signatures is independent of mkimage's ability to create those signatures. In fact, u-boot's build system doesn't sign images. The target code can be successfully built without relying on any ability to sign such code.
Conversely, mkimage's ability to sign images does not require that those images will only work on targets which support FIT verification. Linking mkimage cryptographic features to target support for FIT verification is misguided.
Without loss of generality, we can say that host features are and should be independent of target features.
While we prefer that a host tool always supports the same feature set, we recognize the following
- some users prefer to build u-boot without a dependency on OpenSSL.
- some distros prefer to ship mkimage without linking to OpenSSL
To allow these use cases, introduce a host-only Kconfig which is used to select or deselect libcrypto support. Some mkimage features or some host tools might not be available, but this shouldn't affect the u-boot build.
I also considered setting the default of this config based on FIT_SIGNATURE. While it would preserve the old behaviour it's also contrary to the goals of this change. I decided to enable it by default, so that the default build yields the most feature-complete mkimage.
--- tools/Kconfig | 11 +++++++++++ tools/Makefile | 48 +++++++++++++++++++++++++++++++----------------- 2 files changed, 42 insertions(+), 17 deletions(-)
tools/Kconfig +11 -0
@@ -9,4 +9,15 @@ config MKIMAGE_DTC_PATH some cases the system dtc may not support all required features and the path to a different version should be given here. +config TOOLS_LIBCRYPTO + bool "Use OpenSSL's libcrypto library for host tools" + default y + help + Cryptographic signature, verification, and encryption of images is + provided by host tools using OpenSSL's libcrypto. Select 'n' here if + you wish to build host tools without OpenSSL. mkimage will not have + the ability to sign images. + This selection does not affect target features, such as runtime FIT + signature verification. + endmenu
tools/Makefile +31 -17
96 lines not on this page · raw message
Signature · 1 line
2.31.1
Hi all,
Am Do., 15. Juli 2021 um 00:09 Uhr schrieb Alexandru Gagniuc <[email protected]>:
Quoted 28 lines
Host tool features, such as mkimage's ability to sign FIT images were enabled or disabled based on the target configuration. However, this misses the point of a target-agnostic host tool.
A target's ability to verify FIT signatures is independent of mkimage's ability to create those signatures. In fact, u-boot's build system doesn't sign images. The target code can be successfully built without relying on any ability to sign such code.
Conversely, mkimage's ability to sign images does not require that those images will only work on targets which support FIT verification. Linking mkimage cryptographic features to target support for FIT verification is misguided.
Without loss of generality, we can say that host features are and should be independent of target features.
While we prefer that a host tool always supports the same feature set, we recognize the following
- some users prefer to build u-boot without a dependency on OpenSSL.
- some distros prefer to ship mkimage without linking to OpenSSLTo allow these use cases, introduce a host-only
Kconfigwhich is used to select or deselect libcrypto support. Some mkimage features or some host tools might not be available, but this shouldn't affect the u-boot build.
Quoted 7 lines
I also considered setting the default of this config based on
FIT_SIGNATURE. While it would preserve the old behaviour it's also contrary to the goals of this change. I decided to enable it by default, so that the default build yields the most feature-complete mkimage.Signed-off-by Alexandru Gagniuc <[email protected]>
Since this patch was applied to master the build target "flash.bin" for e.g. the imx8mq_evk_defconfig fails.
--- 8< ---
MKIMAGE u-boot.itb
u-boot.its:7.11-15.5: Warning (unit_address_vs_reg): /images/uboot@1:
node has a unit name, but no reg property
u-boot.its:16.9-21.5: Warning (unit_address_vs_reg): /images/fdt@1:
node has a unit name, but no reg property
u-boot.its:22.9-31.5: Warning (unit_address_vs_reg): /images/atf@1:
node has a unit name, but no reg property
u-boot.its:36.12-41.5: Warning (unit_address_vs_reg):
/configurations/config@1: node has a unit name, but no reg property ./tools/mkimage: verify_header failed for FIT Image support with exit code 1
make: *** [Makefile:1440: u-boot.itb] Error 1
make: *** Deleting file 'u-boot.itb'
make: *** Waiting for unfinished jobs....
--- 8< ---
Does I miss here something?
Signature · 1 line
Heiko
Quoted 132 lines
--- tools/Kconfig | 11 +++++++++++ tools/Makefile | 48 +++++++++++++++++++++++++++++++----------------- 2 files changed, 42 insertions(+), 17 deletions(-)tools/Kconfig +11
-0@@ -9,4 +9,15 @@ config MKIMAGE_DTC_PATH some cases the system dtc may not support all required features and the path to a different version should be given here. +config TOOLS_LIBCRYPTO + bool "Use OpenSSL's libcrypto library for host tools" + default y + help + Cryptographic signature, verification, and encryption of images is + provided by host tools using OpenSSL's libcrypto. Select 'n' here if + you wish to build host tools without OpenSSL. mkimage will not have + the ability to sign images. + This selection does not affect target features, such as runtime FIT + signature verification. + endmenutools/Makefile +31
-18@@ -3,6 +3,25 @@ # (C) Copyright 2000-2006 # Wolfgang Denk, DENX Software Engineering, [email protected]. +# A note on target vs host configuration: +# +# Host tools can be used across multiple targets, or different configurations +# of the same target. Thus, host tools must be able to handle any combination +# of target configurations. To prevent having different variations of the same +# tool, the tool build options may not depend on target configuration. +# +# Some linux distributions package these utilities as u-boot-tools, and it +# would be unmaintainable to have a different tool variation for each +# arch or configuration. +# +# A couple of simple rules: +# +# 1) Do not use target CONFIG_* options to enable or disable features in host +# tools. Only use the configs from tools/Kconfig +# 2) It's okay to use target configs to disable building specific tools. +# That's as long as the features of those tools aren't modified. +# + # Enable all the config-independent tools ifneq ($(HOST_TOOLS_ALL),) CONFIG_ARCH_KIRKWOOD = y@@ -53,30 +72,30 @@ hostprogs-y += mkenvimage mkenvimage-objs := mkenvimage.o os_support.o lib/crc32.o hostprogs-y += dumpimage mkimage -hostprogs-$(CONFIG_FIT_SIGNATURE) += fit_info fit_check_sign +hostprogs-$(CONFIG_TOOLS_LIBCRYPTO) += fit_info fit_check_sign hostprogs-$(CONFIG_CMD_BOOTEFI_SELFTEST) += file2include -FIT_OBJS-$(CONFIG_FIT) := fit_common.o fit_image.o image-host.o common/image-fit.o -FIT_SIG_OBJS-$(CONFIG_FIT_SIGNATURE) := image-sig-host.o common/image-fit-sig.o -FIT_CIPHER_OBJS-$(CONFIG_FIT_CIPHER) := common/image-cipher.o +FIT_OBJS-y := fit_common.o fit_image.o image-host.o common/image-fit.o +FIT_SIG_OBJS-$(CONFIG_TOOLS_LIBCRYPTO) := image-sig-host.o common/image-fit-sig.o +FIT_CIPHER_OBJS-$(CONFIG_TOOLS_LIBCRYPTO) := common/image-cipher.o # The following files are synced with upstream DTC. # Use synced versions from scripts/dtc/libfdt/. LIBFDT_OBJS := $(addprefix libfdt/, fdt.o fdt_ro.o fdt_wip.o fdt_sw.o fdt_rw.o \ fdt_strerror.o fdt_empty_tree.o fdt_addresses.o fdt_overlay.o) -RSA_OBJS-$(CONFIG_FIT_SIGNATURE) := $(addprefix lib/rsa/, \ +RSA_OBJS-$(CONFIG_TOOLS_LIBCRYPTO) := $(addprefix lib/rsa/, \ rsa-sign.o rsa-verify.o \ rsa-mod-exp.o) -ECDSA_OBJS-$(CONFIG_FIT_SIGNATURE) := $(addprefix lib/ecdsa/, ecdsa-libcrypto.o) +ECDSA_OBJS-$(CONFIG_TOOLS_LIBCRYPTO) := $(addprefix lib/ecdsa/, ecdsa-libcrypto.o) -AES_OBJS-$(CONFIG_FIT_CIPHER) := $(addprefix lib/aes/, \ +AES_OBJS-$(CONFIG_TOOLS_LIBCRYPTO) := $(addprefix lib/aes/, \ aes-encrypt.o aes-decrypt.o) # Cryptographic helpers that depend on openssl/libcrypto -LIBCRYPTO_OBJS-$(CONFIG_FIT_SIGNATURE) := $(addprefix lib/, \ +LIBCRYPTO_OBJS-$(CONFIG_TOOLS_LIBCRYPTO) := $(addprefix lib/, \ fdt-libcrypto.o) ROCKCHIP_OBS = lib/rc4.o rkcommon.o rkimage.o rksd.o rkspi.o@@ -136,22 +155,17 @@ fit_info-objs := $(dumpimage-mkimage-objs) fit_info.o fit_check_sign-objs := $(dumpimage-mkimage-objs) fit_check_sign.o file2include-objs := file2include.o -ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_FIT_SIGNATURE),) +ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_TOOLS_LIBCRYPTO),) # Add CONFIG_MXS into host CFLAGS, so we can check whether or not register # the mxsimage support within tools/mxsimage.c . HOSTCFLAGS_mxsimage.o += -DCONFIG_MXS endif -ifdef CONFIG_FIT_SIGNATURE +ifdef CONFIG_TOOLS_LIBCRYPTO # This affects include/image.h, but including the board config file # is tricky, so manually define this options here. HOST_EXTRACFLAGS += -DCONFIG_FIT_SIGNATURE -HOST_EXTRACFLAGS += -DCONFIG_FIT_SIGNATURE_MAX_SIZE=$(CONFIG_FIT_SIGNATURE_MAX_SIZE) -endif - -ifdef CONFIG_FIT_CIPHER -# This affects include/image.h, but including the board config file -# is tricky, so manually define this options here. +HOST_EXTRACFLAGS += -DCONFIG_FIT_SIGNATURE_MAX_SIZE=0xffffffff HOST_EXTRACFLAGS += -DCONFIG_FIT_CIPHER endif@@ -164,7 +178,7 @@ HOSTCFLAGS_kwbimage.o += -DCONFIG_KWB_SECURE endif # MXSImage needs LibSSL -ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_ARMADA_38X)$(CONFIG_FIT_SIGNATURE)$(CONFIG_FIT_CIPHER),) +ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_ARMADA_38X)$(CONFIG_TOOLS_LIBCRYPTO),) HOSTCFLAGS_kwbimage.o += \ $(shell pkg-config --cflags libssl libcrypto 2> /dev/null || echo "") HOSTLDLIBS_mkimage += \ --2.31.1
Quoted 59 lines · Heiko Thiery
Hi all,
Am Do., 15. Juli 2021 um 00:09 Uhr schrieb Alexandru Gagniuc <[email protected]>:
Quoted 28 lines
Host tool features, such as mkimage's ability to sign FIT images were enabled or disabled based on the target configuration. However, this misses the point of a target-agnostic host tool.
A target's ability to verify FIT signatures is independent of mkimage's ability to create those signatures. In fact, u-boot's build system doesn't sign images. The target code can be successfully built without relying on any ability to sign such code.
Conversely, mkimage's ability to sign images does not require that those images will only work on targets which support FIT verification. Linking mkimage cryptographic features to target support for FIT verification is misguided.
Without loss of generality, we can say that host features are and should be independent of target features.
While we prefer that a host tool always supports the same feature set, we recognize the following
- some users prefer to build u-boot without a dependency on OpenSSL.
- some distros prefer to ship mkimage without linking to OpenSSLTo allow these use cases, introduce a host-only
Kconfigwhich is used to select or deselect libcrypto support. Some mkimage features or some host tools might not be available, but this shouldn't affect the u-boot build.Quoted 7 lines
I also considered setting the default of this config based on
FIT_SIGNATURE. While it would preserve the old behaviour it's also contrary to the goals of this change. I decided to enable it by default, so that the default build yields the most feature-complete mkimage.Signed-off-by Alexandru Gagniuc <[email protected]>Since this patch was applied to master the build target "flash.bin" for e.g. the
imx8mq_evk_defconfigfails.--- 8< ---
MKIMAGE u-boot.itb
u-boot.its:7.11-15.5: Warning (unit_address_vs_reg): /images/uboot@1:
node has a unit name, but no reg property
u-boot.its:16.9-21.5: Warning (unit_address_vs_reg): /images/fdt@1:
node has a unit name, but no reg property
u-boot.its:22.9-31.5: Warning (unit_address_vs_reg): /images/atf@1:
node has a unit name, but no reg property
u-boot.its:36.12-41.5: Warning (unit_address_vs_reg):
/configurations/config@1: node has a unit name, but no reg property./tools/mkimage:verify_headerfailed for FIT Image support with exit code 1
make: *** [Makefile:1440: u-boot.itb] Error 1
make: *** Deleting file 'u-boot.itb'
make: *** Waiting for unfinished jobs....
Quoted 3 lines
--- 8< ---
Does I miss here something?
Are you sure it's this patch? I don't see how this change affects this issue, but I did notice invalid FIT node names [1] in your build.
Alex
[1] https://source.denx.de/u-boot/u-boot/-/commit/3f04db891a353f4b127ed57279279f851c6b4917
Hi Alex,
Am Di., 27. Juli 2021 um 16:34 Uhr schrieb Alex G. <[email protected]>:
Quoted 63 lines · Heiko Thiery
Quoted 59 lines
Hi all,
Am Do., 15. Juli 2021 um 00:09 Uhr schrieb Alexandru Gagniuc <[email protected]>:
Quoted 28 lines
Host tool features, such as mkimage's ability to sign FIT images were enabled or disabled based on the target configuration. However, this misses the point of a target-agnostic host tool.
A target's ability to verify FIT signatures is independent of mkimage's ability to create those signatures. In fact, u-boot's build system doesn't sign images. The target code can be successfully built without relying on any ability to sign such code.
Conversely, mkimage's ability to sign images does not require that those images will only work on targets which support FIT verification. Linking mkimage cryptographic features to target support for FIT verification is misguided.
Without loss of generality, we can say that host features are and should be independent of target features.
While we prefer that a host tool always supports the same feature set, we recognize the following
- some users prefer to build u-boot without a dependency on OpenSSL.
- some distros prefer to ship mkimage without linking to OpenSSLTo allow these use cases, introduce a host-only
Kconfigwhich is used to select or deselect libcrypto support. Some mkimage features or some host tools might not be available, but this shouldn't affect the u-boot build.Quoted 7 lines
I also considered setting the default of this config based on
FIT_SIGNATURE. While it would preserve the old behaviour it's also contrary to the goals of this change. I decided to enable it by default, so that the default build yields the most feature-complete mkimage.Signed-off-by Alexandru Gagniuc <[email protected]>Since this patch was applied to master the build target "flash.bin" for e.g. the
imx8mq_evk_defconfigfails.--- 8< ---
MKIMAGE u-boot.itb
u-boot.its:7.11-15.5: Warning (unit_address_vs_reg): /images/uboot@1:
node has a unit name, but no reg property
u-boot.its:16.9-21.5: Warning (unit_address_vs_reg): /images/fdt@1:
node has a unit name, but no reg property
u-boot.its:22.9-31.5: Warning (unit_address_vs_reg): /images/atf@1:
node has a unit name, but no reg property
u-boot.its:36.12-41.5: Warning (unit_address_vs_reg):
/configurations/config@1: node has a unit name, but no reg property./tools/mkimage:verify_headerfailed for FIT Image support with exit code 1
make: *** [Makefile:1440: u-boot.itb] Error 1
make: *** Deleting file 'u-boot.itb'
make: *** Waiting for unfinished jobs....
Quoted 7 lines
Quoted 3 lines
--- 8< ---
Does I miss here something?
Are you sure it's this patch? I don't see how this change affects this issue, but I did notice invalid FIT node names [1] in your build.
Indeed, when fixing the FIT nodes the build issue is gone.
Quoted 4 lines
Alex
[1]
https://source.denx.de/u-boot/u-boot/-/commit/3f04db891a353f4b127ed57279279f851c6b4917
Thank you
Signature · 1 line
Heiko