net_sched: use %px to print skb address in trace_qdisc_dequeue()
Subsystems (3)
PATCH RESEND v2 1/1 net_sched: use %px to print skb address in trace_qdisc_dequeue()
From: Qitao Xu <[email protected]>
Print format of skbaddr is changed to %px from %p, because we want to use skb address as a quick way to identify a packet.
Note, trace ring buffer is only accessible to privileged users, it is safe to use a real kernel address here.
--- include/trace/events/qdisc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/trace/events/qdisc.h +1 -1
@@ -41,7 +41,7 @@ TRACE_EVENT(qdisc_dequeue, __entry->txq_state = txq->state; ), -TP_printk ("dequeue ifindex=%d qdisc handle=0x%X parent=0x%X txq_state=0x%lX packets=%d skbaddr=%p" , +TP_printk ("dequeue ifindex=%d qdisc handle=0x%X parent=0x%X txq_state=0x%lX packets=%d skbaddr=%px" , __entry->ifindex, __entry->handle, __entry->parent, __entry->txq_state, __entry->packets, __entry->skbaddr ) );
Signature · 1 line
2.27.0
Quoted 7 lines · Cong Wang
From: Qitao Xu <[email protected]>
Print format of skbaddr is changed to %px from %p, because we want to use skb address as a quick way to identify a packet.
Note, trace ring buffer is only accessible to privileged users, it is safe to use a real kernel address here.
Does it make more sense to use %pK?
see: https://lwn.net/Articles/420403/
Quoted 21 lines
Reviewed-by Cong Wang <[email protected]>Signed-off-by Qitao Xu <[email protected]>--- include/trace/events/qdisc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/trace/events/qdisc.h +1
-1@@ -41,7 +41,7 @@ TRACE_EVENT(qdisc_dequeue, __entry->txq_state = txq->state; ), -TP_printk ("dequeue ifindex=%d qdisc handle=0x%X parent=0x%X txq_state=0x%lX packets=%d skbaddr=%p" , +TP_printk ("dequeue ifindex=%d qdisc handle=0x%X parent=0x%X txq_state=0x%lX packets=%d skbaddr=%px" , __entry->ifindex, __entry->handle, __entry->parent, __entry->txq_state, __entry->packets, __entry->skbaddr ) );
Quoted 7 lines · Yunsheng Lin
Quoted 5 lines · Cong Wang
From: Qitao Xu <[email protected]>
Print format of skbaddr is changed to %px from %p, because we want to use skb address as a quick way to identify a packet.
Quoted 6 lines
Quoted 2 lines
Note, trace ring buffer is only accessible to privileged users, it is safe to use a real kernel address here.
Does it make more sense to use %pK?
I think you have the answer:
+ * %pK cannot be used in IRQ context because it tests
+ * CAP_SYSLOG.
;) So, no.
Thanks.
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 9 lines · On Wed, 14 Jul 2021 23:00:21 -0700 you wrote:
From: Qitao Xu <[email protected]>
Print format of skbaddr is changed to %px from %p, because we want to use skb address as a quick way to identify a packet.
Note, trace ring buffer is only accessible to privileged users, it is safe to use a real kernel address here.
[...]
Here is the summary with links:
- [net-next,resend,v2] net_sched: use %px to print skb address in trace_qdisc_dequeue()
https://git.kernel.org/netdev/net/c/851f36e40962
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html