arm64: dts: mt8183: kukui: Use aliases to mmc nodes
Subsystems (2)
PATCH v3 1/2 arm64: dts: mt8183: kukui: Use aliases to mmc nodes
fa2d0aa96941 ("mmc: core: Allow setting slot index via device tree alias") allows the use of aliases to number SD/MMC slots. This patch use aliases to mmc nodes so the partition name for eMMC and SD card will be consistent across boots.
---v2->v3: fix indentation error and add more commit message.
--- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +2 -0
@@ -13,6 +13,8 @@ / { aliases { serial0 = &uart0; + mmc0 = &mmc0; + mmc1 = &mmc1; }; chosen {
Signature · 1 line
2.32.0.432.gabb21c7263-goog
PATCH 2/2 arm64: dts: mt8173: elm: Use aliases to mmc nodes
fa2d0aa96941 ("mmc: core: Allow setting slot index via device tree alias") allows the use of aliases to number SD/MMC slots. This patch use aliases to mmc nodes so the partition name for eMMC and SD card will be consistent across boots.
---v2->v3: add more commit message.
--- arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +6 -0
@@ -10,6 +10,12 @@ #include "mt8173.dtsi" / { + aliases { + mmc0 = &mmc0; + mmc1 = &mmc1; + mmc2 = &mmc3; + }; + memory@40000000 { device_type = "memory"; reg = <0 0x40000000 0 0x80000000>;
Signature · 1 line
2.32.0.432.gabb21c7263-goog
Re: [PATCH 2/2] arm64: dts: mt8173: elm: Use aliases to mmc nodes
Hi,
The subject for this patch wasn't tagged with v3. This might cause some issues with scripted tooling.
Quoted 5 lines · Hsin-Yi Wang
fa2d0aa96941("mmc: core: Allow setting slot index via device tree alias") allows the use of aliases to number SD/MMC slots. This patch use aliases to mmc nodes so the partition name for eMMC and SD card will be consistent across boots.
Device trees are supposed to be a description of the hardware and therefore should be implementation agnostic. The commit logs should be the same, unless the implementation details influenced the changes made.
The MMC binding change already specified that aliases provide a way to assign fixed mmcN indices, so the log should reference the binding change commit instead.
ChenYu
Quoted 33 lines
Signed-off-by Hsin-Yi Wang <[email protected]>Reviewed-by Chen-Yu Tsai <[email protected]>---
v2->v3: add more commit message.--- arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +6
-1@@ -10,6 +10,12 @@ #include "mt8173.dtsi" / { + aliases { + mmc0 = &mmc0; + mmc1 = &mmc1; + mmc2 = &mmc3; + }; + memory@40000000 { device_type = "memory"; reg = <0 0x40000000 0 0x80000000>; --2.32.0.432.gabb21c7263-goog
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek