Skip to contentSkip to conversation

arm64: dts: mt8173: elm: Use aliases to mmc nodes

PATCH Applied Hsin-Yi Wang 3 participants 3 messages Jul 26, 2021 – Aug 4, 2021

Subsystems (2)

v2 of 4 Applied Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: dts: mt8173: elm: Use aliases to mmc nodes

Use aliases to mmc nodes so the partition name for eMMC and SD card will be consistent across boots.

---
v1->v2: skip unused mmc2.

---
 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +6 -0
index 21452c51a20a8..d5a2cad39c9c7 100644
@@ -10,6 +10,12 @@
 #include "mt8173.dtsi"
 
 / {
+	aliases {
+		mmc0 = &mmc0;
+		mmc1 = &mmc1;
+		mmc2 = &mmc3;
+	};
+
 	memory@40000000 {
 		device_type = "memory";
 		reg = <0 0x40000000 0 0x80000000>;
Signature · 1 line
2.32.0.432.gabb21c7263-goog
Reviewed-by on v2 1/1
#1 lore raw

Hi,

Quoted 3 lines · Hsin-Yi Wang

Use aliases to mmc nodes so the partition name for eMMC and SD card will be consistent across boots.

To be honest I think this deserves a bit more pretext:

There used to be no way to specify the order of MMC controllers, and the numbering was based on how the implementations added the devices. For Linux, this changed when asynchronous probing was enabled for most drivers, resulting in mmc device numbers jumping around.

With commit 1796164fac7e ("dt-bindings: mmc: document alias support"), a way to specify fixed index numbers was provided.

Otherwise,

Same for the mt8183-kukui patch.

Quoted 32 lines

---
v1->v2: skip unused mmc2.

---
 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +6 -1
index 21452c51a20a8..d5a2cad39c9c7 100644
@@ -10,6 +10,12 @@
 #include "mt8173.dtsi"
 
 / {
+       aliases {
+               mmc0 = &mmc0;
+               mmc1 = &mmc1;
+               mmc2 = &mmc3;
+       };
+
        memory@40000000 {
                device_type = "memory";
                reg = <0 0x40000000 0 0x80000000>;
--

2.32.0.432.gabb21c7263-goog

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

maintainer Applied
#2 lore raw
In reply to Hsin-Yi Wang
Quoted 4 lines · Hsin-Yi Wang

Use aliases to mmc nodes so the partition name for eMMC and SD card will be consistent across boots.

applied to v5.14-next/dts64

Thanks

Quoted 24 lines

---
v1->v2: skip unused mmc2.

---
 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +6 -0
index 21452c51a20a8..d5a2cad39c9c7 100644
@@ -10,6 +10,12 @@
 #include "mt8173.dtsi"
 
 / {
+	aliases {
+		mmc0 = &mmc0;
+		mmc1 = &mmc1;
+		mmc2 = &mmc3;
+	};
+
 	memory@40000000 {
 		device_type = "memory";
 		reg = <0 0x40000000 0 0x80000000>;