hwmon: (pmbus/ibm-cffps) Fix write bits for LED control
PATCH 1/1 hwmon: (pmbus/ibm-cffps) Fix write bits for LED control
From: "B. J. Wyman" <[email protected]>
When doing a PMBus write for the LED control on the IBM Common Form Factor Power Supplies (ibm-cffps), the DAh command requires that bit 7 be low and bit 6 be high in order to indicate that you are truly attempting to do a write.
--- drivers/hwmon/pmbus/ibm-cffps.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/hwmon/pmbus/ibm-cffps.c +3 -3
@@ -50,9 +50,9 @@#define CFFPS_MFR_VAUX_FAULT BIT(6)#define CFFPS_MFR_CURRENT_SHARE_WARNING BIT(7) -#define CFFPS_LED_BLINK BIT(0) -#define CFFPS_LED_ON BIT(1) -#define CFFPS_LED_OFF BIT(2) +#define CFFPS_LED_BLINK (BIT(0) | BIT(6)) +#define CFFPS_LED_ON (BIT(1) | BIT(6)) +#define CFFPS_LED_OFF (BIT(2) | BIT(6))#define CFFPS_BLINK_RATE_MS 250enum {
Signature · 1 line
2.25.1
Guenter Roeck
maintainerQuoted 8 lines · Brandon Wyman
From: "B. J. Wyman" <[email protected]>
When doing a PMBus write for the LED control on the IBM Common Form Factor Power Supplies (ibm-cffps), the DAh command requires that bit 7 be low and bit 6 be high in order to indicate that you are truly attempting to do a write.
Signed-off-by B. J. Wyman <[email protected]>
Please be consistent and use "Brandon Wyman".
Guenter
Quoted 22 lines
--- drivers/hwmon/pmbus/ibm-cffps.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/hwmon/pmbus/ibm-cffps.c +3
-3@@ -50,9 +50,9 @@#define CFFPS_MFR_VAUX_FAULT BIT(6)#define CFFPS_MFR_CURRENT_SHARE_WARNING BIT(7) -#define CFFPS_LED_BLINK BIT(0) -#define CFFPS_LED_ON BIT(1) -#define CFFPS_LED_OFF BIT(2) +#define CFFPS_LED_BLINK (BIT(0) | BIT(6)) +#define CFFPS_LED_ON (BIT(1) | BIT(6)) +#define CFFPS_LED_OFF (BIT(2) | BIT(6))#define CFFPS_BLINK_RATE_MS 250enum {
Quoted 4 lines · Guenter Roeck
Quoted 2 lines · Brandon Wyman
From: "B. J. Wyman" <[email protected]>
Quoted 8 lines
Quoted 6 lines
When doing a PMBus write for the LED control on the IBM Common Form Factor Power Supplies (ibm-cffps), the DAh command requires that bit 7 be low and bit 6 be high in order to indicate that you are truly attempting to do a write.
Signed-off-by B. J. Wyman <[email protected]>Please be consistent and use "Brandon Wyman".
Ack. Curiously, that is the first time someone has pointed out that inconsistency.
Quoted 26 lines
Guenter
Quoted 22 lines
--- drivers/hwmon/pmbus/ibm-cffps.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/hwmon/pmbus/ibm-cffps.c +3
-3@@ -50,9 +50,9 @@#define CFFPS_MFR_VAUX_FAULT BIT(6)#define CFFPS_MFR_CURRENT_SHARE_WARNING BIT(7) -#define CFFPS_LED_BLINK BIT(0) -#define CFFPS_LED_ON BIT(1) -#define CFFPS_LED_OFF BIT(2) +#define CFFPS_LED_BLINK (BIT(0) | BIT(6)) +#define CFFPS_LED_ON (BIT(1) | BIT(6)) +#define CFFPS_LED_OFF (BIT(2) | BIT(6))#define CFFPS_BLINK_RATE_MS 250enum {