ARM: ep93xx: remove MaverickCrunch support
Subsystems (6)
PATCH 1/1 ARM: ep93xx: remove MaverickCrunch support
From: Arnd Bergmann <[email protected]>
The MaverickCrunch support for ep93xx never made it into glibc and was removed from gcc in its 4.8 release in 2012. It is now one of the last parts of arch/arm/ that fails to build with the clang integrated assembler, which is unlikely to ever want to support it.
The two alternatives are to force the use of binutils/gas when building the crunch support, or to remove it entirely.
According to Hartley Sweeten:
"Martin Guy did a lot of work trying to get the maverick crunch working
but I was never able to successfully use it for anything. It "kind" of works but depending on the EP93xx silicon revision there are still a number of hardware bugs that either give imprecise or garbage results.
I have no problem with removing the kernel support for the maverick crunch."
Unless someone else comes up with a good reason to keep it around, remove it now. This touches mostly the ep93xx platform, but removes a bit of code from ARM common ptrace and signal frame handling as well.
If there are remaining users of MaverickCrunch, they can use LTS kernels for at least another five years before kernel support ends.
---
I was reminded that this is still in my backlog of patches.
Russell, if you don't see any problems with the arch/arm/{include,kernel}/ bits, I'd apply this to the soc tree directly.
arch/arm/configs/ep93xx_defconfig | 1 - arch/arm/include/asm/fpstate.h | 8 - arch/arm/include/asm/thread_info.h | 8 - arch/arm/include/asm/ucontext.h | 14 -- arch/arm/include/uapi/asm/hwcap.h | 2 +- arch/arm/include/uapi/asm/ptrace.h | 4 +- arch/arm/kernel/asm-offsets.c | 3 - arch/arm/kernel/entry-armv.S | 6 - arch/arm/kernel/ptrace.c | 36 ---- arch/arm/kernel/signal.c | 42 ---- arch/arm/mach-ep93xx/Kconfig | 5 - arch/arm/mach-ep93xx/Makefile | 3 - arch/arm/mach-ep93xx/adssphere.c | 1 - arch/arm/mach-ep93xx/core.c | 5 - arch/arm/mach-ep93xx/crunch-bits.S | 310 --------------------------- arch/arm/mach-ep93xx/crunch.c | 86 -------- arch/arm/mach-ep93xx/edb93xx.c | 8 - arch/arm/mach-ep93xx/gesbc9312.c | 1 - arch/arm/mach-ep93xx/micro9.c | 4 - arch/arm/mach-ep93xx/platform.h | 7 - arch/arm/mach-ep93xx/simone.c | 1 - arch/arm/mach-ep93xx/snappercl15.c | 1 - arch/arm/mach-ep93xx/ts72xx.c | 2 - arch/arm/mach-ep93xx/vision_ep9307.c | 1 - arch/arm64/include/asm/hwcap.h | 2 +- 25 files changed, 4 insertions(+), 557 deletions(-) delete mode 100644 arch/arm/mach-ep93xx/crunch-bits.S delete mode 100644 arch/arm/mach-ep93xx/crunch.c
arch/arm/configs/ep93xx_defconfig +0 -1
@@ -12,7 +12,6 @@ CONFIG_MODULE_FORCE_UNLOAD=y # CONFIG_BLK_DEV_BSG is not set CONFIG_PARTITION_ADVANCED=y CONFIG_ARCH_EP93XX=y -CONFIG_CRUNCH=y CONFIG_MACH_ADSSPHERE=y CONFIG_MACH_EDB9301=y CONFIG_MACH_EDB9302=y
arch/arm/include/asm/fpstate.h +0 -8
@@ -77,14 +77,6 @@ union fp_state {#define FP_SIZE (sizeof(union fp_state) / sizeof(int)) -struct crunch_state { -unsigned int mvdx[16 ][2 ]; -unsigned int mvax[4 ][3 ]; -unsigned int dspsc[2 ]; -}; - -#define CRUNCH_SIZE sizeof(struct crunch_state) -#endif #endif
arch/arm/include/asm/thread_info.h +0 -8
@@ -65,9 +65,6 @@ struct thread_info {__u32 syscall;/* syscall number */ __u8 used_cp[16 ];/* thread used copro */ unsigned long tp_value[2 ];/* TLS registers */ -#ifdef CONFIG_CRUNCH -struct crunch_state crunchstate; -#endif union fp_state fpstate __attribute__((aligned(8)));union vfp_state vfpstate;#ifdef CONFIG_ARM_THUMBEE
@@ -107,11 +104,6 @@ static inline struct thread_info *current_thread_info(void) ((unsigned long)(task_thread_info(tsk)->cpu_context.r7))#endif -extern void crunch_task_disable (struct thread_info *); -extern void crunch_task_copy (struct thread_info *,void *); -extern void crunch_task_restore (struct thread_info *,void *); -extern void crunch_task_release (struct thread_info *); -extern void iwmmxt_task_disable (struct thread_info *);extern void iwmmxt_task_copy (struct thread_info *,void *);extern void iwmmxt_task_restore (struct thread_info *,void *);
arch/arm/include/asm/ucontext.h +0 -14
@@ -43,17 +43,6 @@ struct ucontext {*/ #define DUMMY_MAGIC 0xb0d9ed01 -#ifdef CONFIG_CRUNCH -#define CRUNCH_MAGIC 0x5065cf03 -#define CRUNCH_STORAGE_SIZE (CRUNCH_SIZE + 8) - -struct crunch_sigframe { -unsigned long magic; -unsigned long size; -struct crunch_state storage; -} __attribute__((__aligned__ (8 ))); -#endif -#ifdef CONFIG_IWMMXT /* iwmmxt_area is 0x98 bytes long, preceded by 8 bytes of signature */ #define IWMMXT_MAGIC 0x12ef842a
@@ -92,9 +81,6 @@ struct vfp_sigframe* one of these. */ struct aux_sigframe { -#ifdef CONFIG_CRUNCH -struct crunch_sigframe crunch; -#endif #ifdef CONFIG_IWMMXT struct iwmmxt_sigframe iwmmxt;#endif
arch/arm/include/uapi/asm/hwcap.h +1 -1
@@ -15,7 +15,7 @@#define HWCAP_EDSP (1 << 7)#define HWCAP_JAVA (1 << 8)#define HWCAP_IWMMXT (1 << 9) -#define HWCAP_CRUNCH (1 << 10) +#define HWCAP_CRUNCH (1 << 10)/* Obsolete */ #define HWCAP_THUMBEE (1 << 11)#define HWCAP_NEON (1 << 12)#define HWCAP_VFPv3 (1 << 13)
arch/arm/include/uapi/asm/ptrace.h +2 -2
@@ -26,8 +26,8 @@#define PTRACE_GET_THREAD_AREA 22#define PTRACE_SET_SYSCALL 23/* PTRACE_SYSCALL is 24 */ -#define PTRACE_GETCRUNCHREGS 25 -#define PTRACE_SETCRUNCHREGS 26 +#define PTRACE_GETCRUNCHREGS 25/* obsolete */ +#define PTRACE_SETCRUNCHREGS 26/* obsolete */ #define PTRACE_GETVFPREGS 27#define PTRACE_SETVFPREGS 28#define PTRACE_GETHBPREGS 29
arch/arm/kernel/asm-offsets.c +0 -3
@@ -63,9 +63,6 @@ int main(void)#ifdef CONFIG_IWMMXT DEFINE(TI_IWMMXT_STATE, offsetof(struct thread_info, fpstate.iwmmxt));#endif -#ifdef CONFIG_CRUNCH -DEFINE (TI_CRUNCH_STATE , offsetof(struct thread_info , crunchstate)); -#endif #ifdef CONFIG_STACKPROTECTOR_PER_TASK DEFINE (TI_STACK_CANARY , offsetof(struct thread_info , stack_canary));#endif
arch/arm/kernel/entry-armv.S +0 -6
@@ -618,15 +618,9 @@ call_fpe: W(b) do_fpe @ CP#1 (FPE) W(b) do_fpe @ CP#2 (FPE) ret.w lr @ CP#3 -#ifdef CONFIG_CRUNCH - b crunch_task_enable @ CP#4 (MaverickCrunch) - b crunch_task_enable @ CP#5 (MaverickCrunch) - b crunch_task_enable @ CP#6 (MaverickCrunch) -#else ret.w lr @ CP#4 ret.w lr @ CP#5 ret.w lr @ CP#6 -#endif ret.w lr @ CP#7 ret.w lr @ CP#8 ret.w lr @ CP#9
arch/arm/kernel/ptrace.c +0 -36
@@ -318,32 +318,6 @@ static int ptrace_setwmmxregs(struct task_struct *tsk, void __user *ufp)#endif -#ifdef CONFIG_CRUNCH -/* -* Get the child Crunch state. -*/ -static int ptrace_getcrunchregs (struct task_struct *tsk,void __user *ufp) -{ -struct thread_info *thread =task_thread_info (tsk); - -crunch_task_disable (thread);/* force it to ram */ -return copy_to_user (ufp, &thread->crunchstate,CRUNCH_SIZE ) - ? -EFAULT :0 ; -} - -/* -* Set the child Crunch state. -*/ -static int ptrace_setcrunchregs (struct task_struct *tsk,void __user *ufp) -{ -struct thread_info *thread =task_thread_info (tsk); - -crunch_task_release (thread);/* force a reload */ -return copy_from_user (&thread->crunchstate, ufp,CRUNCH_SIZE ) - ? -EFAULT :0 ; -} -#endif -#ifdef CONFIG_HAVE_HW_BREAKPOINT /* * Convert a virtual register number into an index for a thread_info
@@ -815,16 +789,6 @@ long arch_ptrace(struct task_struct *child, long request, ret =0 ;break ; -#ifdef CONFIG_CRUNCH -case PTRACE_GETCRUNCHREGS : - ret =ptrace_getcrunchregs (child, datap); -break ; - -case PTRACE_SETCRUNCHREGS : - ret =ptrace_setcrunchregs (child, datap); -break ; -#endif -#ifdef CONFIG_VFP case PTRACE_GETVFPREGS : ret = copy_regset_to_user(child,
arch/arm/kernel/signal.c +0 -42
60 lines not on this page · raw message
arch/arm/mach-ep93xx/Kconfig +0 -5
@@ -9,11 +9,6 @@ config EP93XX_SOC_COMMON select SOC_BUS select LEDS_GPIO_REGISTER -config CRUNCH - bool "Support for MaverickCrunch" - help - Enable kernel support for MaverickCrunch. - comment "EP93xx Platforms" config MACH_ADSSPHERE
arch/arm/mach-ep93xx/Makefile +0 -3
@@ -6,9 +6,6 @@ obj-y := core.o clock.o timer-ep93xx.o obj-$(CONFIG_EP93XX_DMA) += dma.o -obj-$(CONFIG_CRUNCH) += crunch.o crunch-bits.o -AFLAGS_crunch-bits.o := -Wa,-mcpu=ep9312 - obj-$(CONFIG_MACH_ADSSPHERE) += adssphere.o obj-$(CONFIG_MACH_EDB93XX) += edb93xx.o obj-$(CONFIG_MACH_GESBC9312) += gesbc9312.o
arch/arm/mach-ep93xx/adssphere.c +0 -1
@@ -36,6 +36,5 @@ MACHINE_START(ADSSPHERE, "ADS Sphere board") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = adssphere_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart,MACHINE_END
arch/arm/mach-ep93xx/core.c +0 -5
@@ -1004,8 +1004,3 @@ void ep93xx_restart(enum reboot_mode mode, const char *cmd)while (1 ) ; } - -void __init ep93xx_init_late (void ) -{ -crunch_init (); -}
arch/arm/mach-ep93xx/crunch-bits.S deleted +0 -310
310 lines not on this page · raw message
arch/arm/mach-ep93xx/crunch.c deleted +0 -86
86 lines not on this page · raw message
arch/arm/mach-ep93xx/edb93xx.c +0 -8
@@ -247,7 +247,6 @@ MACHINE_START(EDB9301, "Cirrus Logic EDB9301 Evaluation Board") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = edb93xx_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart, MACHINE_END#endif
@@ -260,7 +259,6 @@ MACHINE_START(EDB9302, "Cirrus Logic EDB9302 Evaluation Board") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = edb93xx_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart, MACHINE_END#endif
@@ -273,7 +271,6 @@ MACHINE_START(EDB9302A, "Cirrus Logic EDB9302A Evaluation Board") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = edb93xx_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart, MACHINE_END#endif
@@ -286,7 +283,6 @@ MACHINE_START(EDB9307, "Cirrus Logic EDB9307 Evaluation Board") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = edb93xx_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart, MACHINE_END#endif
@@ -299,7 +295,6 @@ MACHINE_START(EDB9307A, "Cirrus Logic EDB9307A Evaluation Board") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = edb93xx_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart, MACHINE_END#endif
@@ -312,7 +307,6 @@ MACHINE_START(EDB9312, "Cirrus Logic EDB9312 Evaluation Board") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = edb93xx_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart, MACHINE_END#endif
@@ -325,7 +319,6 @@ MACHINE_START(EDB9315, "Cirrus Logic EDB9315 Evaluation Board") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = edb93xx_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart, MACHINE_END#endif
@@ -338,7 +331,6 @@ MACHINE_START(EDB9315A, "Cirrus Logic EDB9315A Evaluation Board") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = edb93xx_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart, MACHINE_END#endif
arch/arm/mach-ep93xx/gesbc9312.c +0 -1
@@ -36,6 +36,5 @@ MACHINE_START(GESBC9312, "Glomation GESBC-9312-sx") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = gesbc9312_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart,MACHINE_END
arch/arm/mach-ep93xx/micro9.c +0 -4
@@ -80,7 +80,6 @@ MACHINE_START(MICRO9, "Contec Micro9-High") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = micro9_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart, MACHINE_END#endif
@@ -93,7 +92,6 @@ MACHINE_START(MICRO9M, "Contec Micro9-Mid") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = micro9_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart, MACHINE_END#endif
@@ -106,7 +104,6 @@ MACHINE_START(MICRO9L, "Contec Micro9-Lite") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = micro9_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart, MACHINE_END#endif
@@ -119,7 +116,6 @@ MACHINE_START(MICRO9S, "Contec Micro9-Slim") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = micro9_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart, MACHINE_END#endif
arch/arm/mach-ep93xx/platform.h +0 -7
@@ -38,12 +38,5 @@ struct device *ep93xx_init_devices(void);extern void ep93xx_timer_init (void );void ep93xx_restart (enum reboot_mode ,const char *); -void ep93xx_init_late (void ); - -#ifdef CONFIG_CRUNCH -int crunch_init (void ); -#else -static inline int crunch_init (void ) {return 0 ; } -#endif #endif
arch/arm/mach-ep93xx/simone.c +0 -1
@@ -123,6 +123,5 @@ MACHINE_START(SIM_ONE, "Simplemachines Sim.One Board") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = simone_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart,MACHINE_END
arch/arm/mach-ep93xx/snappercl15.c +0 -1
@@ -157,6 +157,5 @@ MACHINE_START(SNAPPER_CL15, "Bluewater Systems Snapper CL15") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = snappercl15_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart,MACHINE_END
arch/arm/mach-ep93xx/ts72xx.c +0 -2
@@ -354,7 +354,6 @@ MACHINE_START(TS72XX, "Technologic Systems TS-72xx SBC") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = ts72xx_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart,MACHINE_END
@@ -418,6 +417,5 @@ MACHINE_START(BK3, "Liebherr controller BK3.1") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = bk3_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart,MACHINE_END
arch/arm/mach-ep93xx/vision_ep9307.c +0 -1
@@ -306,6 +306,5 @@ MACHINE_START(VISION_EP9307, "Vision Engraving Systems EP9307") .init_irq = ep93xx_init_irq, .init_time = ep93xx_timer_init, .init_machine = vision_init_machine, - .init_late = ep93xx_init_late, .restart = ep93xx_restart,MACHINE_END
arch/arm64/include/asm/hwcap.h +1 -1
@@ -18,7 +18,7 @@#define COMPAT_HWCAP_EDSP (1 << 7)#define COMPAT_HWCAP_JAVA (1 << 8)#define COMPAT_HWCAP_IWMMXT (1 << 9) -#define COMPAT_HWCAP_CRUNCH (1 << 10) +#define COMPAT_HWCAP_CRUNCH (1 << 10)/* Obsolete */ #define COMPAT_HWCAP_THUMBEE (1 << 11)#define COMPAT_HWCAP_NEON (1 << 12)#define COMPAT_HWCAP_VFPv3 (1 << 13)
Signature · 1 line
2.29.2
Quoted 1 line · Arnd Bergmann
The MaverickCrunch support for ep93xx never made it into glibc
This is true, but is not needed except for preserving FP registers in catch/throw exeptions or longjmps.
Quoted 1 line
was removed from gcc in its 4.8 release in 2012.
I was sad about that, as I had managed to get it working correctly in 4.2 4.3 and 4.4.
Unfortunately the GCC ARM maintainer at the time was paid by ARM, and they had no interest in it, as I gather the ARM-Cirrus partnership ended up disappointingly.
Quoted 3 lines
It is now one of
the last parts ofarch/arm/that fails to build with the clang integrated assembler
Even if crunch support is not configured?
Quoted 6 lines
According to Hartley Sweeten:
"Martin Guy did a lot of work trying to get the maverick crunch working
but I was never able to successfully use it for anything.It "kind" of works but depending on the EP93xx silicon revision
It works fine on all production revisions except D0 (the first one) which is so rare as to be unfindable. All the others from D1 on have the exact same HW bugs.
Quoted 1 line
there are still a number of hardware bugs that either give imprecise or garbage results.
Not my experience, See http://martinwguy.net/crunch/#CorrectnessTests
If "imprecise" means "doesn't handle unnormalized FP values correctly" then yes, that's a feature if you need the 2.5 to 4gimes speedup it provides.
But I would be interested (Hartley) if you have a concrete example.
Quoted 1 line
This touches mostly the ep93xx platform,
The ep93xx is the only chip series it was ever included in.
Quoted 2 lines
If there are remaining users of MaverickCrunch, they can use LTS kernels for at least another five years before kernel support ends.
The only user ! am aware of is the HEAT deep space telescope in the Antarctic
http://martinwguy.blogspot.com/2015/10/maverickcrunch-code-runs-on-heat-deep.html
Personally I have no problem with removing kernel support if that makes people's lives easier in some way.
M
M
I forward opinion from people currently producing and supporting EP93XX boards:
From: Technologic Systems Support Team <[email protected]>
To: [email protected]
Cc: [email protected]
Quoted 7 lines
I expect our customers would care if support was dropped. Unfortunately I don't know to what extent. I'd like to bring Jerome Oufella of Savoir Faire Linux into the conversation here, as he runs the software company who most of our customers contract through when they need a modern Linux kernel running on one of our Cirrus Logic EP93XX series single board computers. I expect his opinion will be more valuable than mine.
>
Quoted 7 lines
Good morning Jerome,
A member of the Linux Kernel Development community reached out to us this morning letting us know the community has suggested dropping support for the MavericCrunch FPU on the EP9302 processor. Would this impact any of the development your team has been doing for some of our mutual customers?
From: Jerome Oufella<[email protected]>
Quoted 10 lines
I am aware of a few companies who rely on variants of the TS-7250 running not-too-old LTS releases (4.19, 5.4) to cope with their patch policies.
With Linux 5.10 being the next "Super LTS", this presumably brings its support lifespan until about 2030, which (I believe) they would be comfortable with considering the age of the platform.
Jerome Oufella
Vice-President, Technologies
www.savoirfairelinux.com
Quoted 2 lines · Martin Guy
I forward opinion from people currently producing and supporting EP93XX boards:
Thanks a lot for bringing them in. I definitely don't want to remove support for something that is actively being used, and we don't have to merge the patch if they currently rely on MaverickCrunch on older platforms.
It does sound however like Jerome's customers are using a normal (softfloat) Linus distro on EP93xx, rather than one using the original MaverickCrunch FPU instructions. There are no plans to discontinue EP93xx support, there is actually a good amount of recent work going into updating the platform.
Jerome, please let me know if I understood you correctly here. If your customers do rely on MaverickCrunch support in user space, I would leave that in the kernel for as long as ep93xx itself is supported, and instead require building support with the GNU assembler to avoid having to add support to the clang integrated assembler. If you don't know of anyone using MaverickCrunch, I would go ahead with my patch to remove kernel support.
Arnd
Quoted 31 lines
From: Technologic Systems Support Team <[email protected]>
To: [email protected]
Cc: [email protected]Quoted 8 lines
I expect our customers would care if support was dropped. Unfortunately I don't know to what extent. I'd like to bring Jerome Oufella of Savoir Faire Linux into the conversation here, as he runs the software company who most of our customers contract through when they need a modern Linux kernel running on one of our Cirrus Logic EP93XX series single board computers. I expect his opinion will be more valuable than mine.
Quoted 7 lines
Good morning Jerome,
A member of the Linux Kernel Development community reached out to us this morning letting us know the community has suggested dropping support for the MavericCrunch FPU on the EP9302 processor. Would this impact any of the development your team has been doing for some of our mutual customers?
From: Jerome Oufella<[email protected]>
Quoted 10 lines
I am aware of a few companies who rely on variants of the TS-7250 running not-too-old LTS releases (4.19, 5.4) to cope with their patch policies.
With Linux 5.10 being the next "Super LTS", this presumably brings its support lifespan until about 2030, which (I believe) they would be comfortable with considering the age of the platform.
Jerome Oufella
Vice-President, Technologies
www.savoirfairelinux.com
Quoted 21 lines · On Aug 3, 2021, at 7:58 AM, Arnd Bergmann [email protected] wrote:
Quoted 2 lines · Martin Guy
I forward opinion from people currently producing and supporting EP93XX boards:
Thanks a lot for bringing them in. I definitely don't want to remove support for something that is actively being used, and we don't have to merge the patch if they currently rely on MaverickCrunch on older platforms.
It does sound however like Jerome's customers are using a normal (softfloat) Linus distro on EP93xx, rather than one using the original MaverickCrunch FPU instructions. There are no plans to discontinue EP93xx support, there is actually a good amount of recent work going into updating the platform.
Jerome, please let me know if I understood you correctly here. If your customers do rely on MaverickCrunch support in user space, I would leave that in the kernel for as long as ep93xx itself is supported, and instead require building support with the GNU assembler to avoid having to add support to the clang integrated assembler. If you don't know of anyone using MaverickCrunch, I would go ahead with my patch to remove kernel support.
Quoted 1 line
Arnd
Arnd,
You are correct on assuming usage of softfloat toolchains and not using the MaverickCrunch unit. AFAIK, I am not aware of active users of this FPU on recent setups.
Jerome
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 4 lines · Jerome Oufella
You are correct on assuming usage of softfloat toolchains and not using the MaverickCrunch unit. AFAIK, I am not aware of active users of this FPU on recent setups.
Ok, thank you for the confirmation, I'll queue it up in the soc tree then.
Of course, as there is nothing wrong with the feature other than it probably having no users and breaking the build when using the clang integrated assembler, I don't mind reverting it later if we end up finding a user that does rely on ancient MaverickCrunch binaries to run on future kernels.
Arnd
Quoted 7 lines · Martin Guy
Quoted 1 line
was removed from gcc in its 4.8 release in 2012.
I was sad about that, as I had managed to get it working correctly in 4.2 4.3 and 4.4.
Unfortunately the GCC ARM maintainer at the time was paid by ARM, and they had no interest in it, as I gather the ARM-Cirrus partnership ended up disappointingly.
Political issues aside, have you considered contributing support to LLVM instead?
It currently doesn't even support ARMv4 AFAIK but reportedly has an easier to use and maintain back-end. (I do not know if this is true, I just browsed this:
https://llvm.org/docs/WritingAnLLVMBackend.html ) Current ARM Targets are here:
https://github.com/llvm/llvm-project/tree/main/llvm/lib/Target/ARM
And they have a very clear and straight-forward developer policy:
https://llvm.org/docs/DeveloperPolicy.html
If ARMv4 support could be added to LLVM, that would solve a lot of my headaches for ARM32, where we have things like SA110 being actively maintained.
Yours,
Linus Walleij
Quoted 23 lines · Linus Walleij
Quoted 7 lines · Martin Guy
Quoted 1 line
was removed from gcc in its 4.8 release in 2012.
I was sad about that, as I had managed to get it working correctly in 4.2 4.3 and 4.4.
Unfortunately the GCC ARM maintainer at the time was paid by ARM, and they had no interest in it, as I gather the ARM-Cirrus partnership ended up disappointingly.Political issues aside, have you considered contributing support to LLVM instead?
It currently doesn't even support ARMv4 AFAIK but reportedly has an easier to use and maintain back-end. (I do not know if this is true, I just browsed this:
https://llvm.org/docs/WritingAnLLVMBackend.html ) Current ARM Targets are here:
https://github.com/llvm/llvm-project/tree/main/llvm/lib/Target/ARM
And they have a very clear and straight-forward developer policy:
https://llvm.org/docs/DeveloperPolicy.html
Quoted 3 lines
If ARMv4 support could be added to LLVM, that would solve a lot of my headaches for ARM32, where we have things like SA110 being actively maintained.
I think for ARMv4 support, the only thing we need from llvm is to have R_ARM_V4BX relocations, and for lld to support the --fix-v4bx switch that turns 'bx' instructions into 'mov' when those relocations are found. This is something that we have previously discussed with the llvm developers and that may easily happen.
For the Crunch support, I don't think it's worth spending any effort on adding that to llvm. If there are any remaining users, they have probably stopped upgrading their user space long ago (to be confirmed). The SoC itself has been "not recommended for new design" since 2019, so we are unlikely to see new users of the platform in the future, and I think existing users are equally unlikely to move from softfp to crunch even if they have the option.
Arnd