target/riscv: Correct a comment in riscv_csrrw()
PATCH 1/1 target/riscv: Correct a comment in riscv_csrrw()
When privilege check fails, RISCV_EXCP_ILLEGAL_INST is returned, not -1 (RISCV_EXCP_NONE).
Signed-off-by Bin Meng <[email protected]>
---
target/riscv/csr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
target/riscv/csr.c +1 -1
@@ -1423,7 +1423,7 @@ RISCVException riscv_csrrw(CPURISCVState *env, int csrno,target_ulong old_value;RISCVCPU *cpu =env_archcpu (env); -/* check privileges and return -1 if check fails */ +/* check privileges and return RISCV_EXCP_ILLEGAL_INST if check fails */ #if !defined(CONFIG_USER_ONLY )int effective_priv = env->priv;int read_only =get_field (csrno,0xC00 ) ==3 ;
Signature · 1 line
2.25.1
Quoted 5 lines · Bin Meng
When privilege check fails,
RISCV_EXCP_ILLEGAL_INSTis returned, not -1 (RISCV_EXCP_NONE).Signed-off-by Bin Meng <[email protected]>
Reviewed-by Alistair Francis <[email protected]>
Alistair
Quoted 22 lines
---
target/riscv/csr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)target/riscv/csr.c +1
-2@@ -1423,7 +1423,7 @@ RISCVException riscv_csrrw(CPURISCVState *env, int csrno,target_ulong old_value;RISCVCPU *cpu =env_archcpu (env); -/* check privileges and return -1 if check fails */ +/* check privileges and return RISCV_EXCP_ILLEGAL_INST if check fails */ #if !defined(CONFIG_USER_ONLY )int effective_priv = env->priv;int read_only =get_field (csrno,0xC00 ) ==3 ; --2.25.1
Alistair Francis
AppliedQuoted 5 lines · Bin Meng
When privilege check fails,
RISCV_EXCP_ILLEGAL_INSTis returned, not -1 (RISCV_EXCP_NONE).Signed-off-by Bin Meng <[email protected]>
Thanks!
Applied to riscv-to-apply.next
Alistair
Quoted 22 lines
---
target/riscv/csr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)target/riscv/csr.c +1
-2@@ -1423,7 +1423,7 @@ RISCVException riscv_csrrw(CPURISCVState *env, int csrno,target_ulong old_value;RISCVCPU *cpu =env_archcpu (env); -/* check privileges and return -1 if check fails */ +/* check privileges and return RISCV_EXCP_ILLEGAL_INST if check fails */ #if !defined(CONFIG_USER_ONLY )int effective_priv = env->priv;int read_only =get_field (csrno,0xC00 ) ==3 ; --2.25.1