Skip to contentSkip to conversation

trace-cmd: Add dependencies to BUILDING section in README

PATCH Superseded [email protected] 2 participants 3 messages Aug 13, 2021 – Aug 20, 2021

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 trace-cmd: Add dependencies to BUILDING section in README

From: Victor Cora Colombo <[email protected]>

KernelShark has instructions in its README on how to get necessary dependencies to build it. trace-cmd could follow this example and also add more information on how to build it.

This patch adds instructions to README on how to get necessary libraries and dependencies to build trace-cmd.

---
 README | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
README +17 -0
index 1153152..094fce1 100644
@@ -24,6 +24,23 @@ Lesser General Public License 2.1 (See COPYING.LIB).
 
 BUILDING:
 
+In order to install build dependencies on Ubuntu do the following:
+    sudo apt-get install build-essential git pkg-config -y
+
+In order to install build dependencies on Fedora, as root do the following:
+    dnf install gcc make git pkg-config -y
+
+To install required dependencies:
+    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
+    cd libtraceevent
+    make
+    sudo make install
+
+    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
+    cd libtracefs
+    make
+    sudo make install
+
 To make trace-cmd
     make
 
Signature · 1 line
2.32.0
#1 lore raw
Quoted 1 line · On Fri, 13 Aug 2021 16:25:16 -0300 [email protected] wrote:

From: Victor Cora Colombo <[email protected]>

I finally got some time to look at this.

Quoted 18 lines

KernelShark has instructions in its README on how to get necessary dependencies to build it. trace-cmd could follow this example and also add more information on how to build it.

This patch adds instructions to README on how to get necessary libraries and dependencies to build trace-cmd.

---
 README | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
README +0 -0
index 1153152..094fce1 100644

README Lesser General Public License 2.1 (See COPYING.LIB). · line 31

Quoted 8 lines
README +5 -0
@@ -24,6 +24,23 @@ Lesser General Public License 2.1 (See COPYING.LIB).
 
 BUILDING:
 
+In order to install build dependencies on Ubuntu do the following:
+    sudo apt-get install build-essential git pkg-config -y
+
+In order to install build dependencies on Fedora, as root do the following:
+    dnf install gcc make git pkg-config -y

I would actually add above libtracefs-devel and libtraceevent-devel for fedora, and possibly libtracefs-dev and libtraceevent-dev for ubuntu / debian. Oh, I would say that too, as I don't use Ubuntu thus, state "on Debian / Ubuntu do the following".

README Lesser General Public License 2.1 (See COPYING.LIB). · line 33

Quoted 2 lines
README +2 -0
+
+To install required dependencies:

Then you can say here.

In case the distribution does not have the required libtracefs and libtraceevent libraries, install them manually:

Or something to that nature.

-- Steve

Quoted 13 lines
README +10 -0
+    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
+    cd libtraceevent
+    make
+    sudo make install
+
+    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
+    cd libtracefs
+    make
+    sudo make install
+
 To make trace-cmd
     make
 
#2 lore raw
Quoted 6 lines · Steven Rostedt
Quoted 1 line · On Fri, 13 Aug 2021 16:25:16 -0300 [email protected] wrote:

From: Victor Cora Colombo <[email protected]>

I finally got some time to look at this.

No problem!

Quoted 39 lines
Quoted 19 lines

KernelShark has instructions in its README on how to get necessary dependencies to build it. trace-cmd could follow this example and also add more information on how to build it.

This patch adds instructions to README on how to get necessary libraries and dependencies to build trace-cmd.

---
  README | 17 +++++++++++++++++
  1 file changed, 17 insertions(+)
README +0 -0
index 1153152..094fce1 100644

README Lesser General Public License 2.1 (See COPYING.LIB). · line 31

Quoted 8 lines
README +5 -0
@@ -24,6 +24,23 @@ Lesser General Public License 2.1 (See COPYING.LIB).
 
  BUILDING:
 
+In order to install build dependencies on Ubuntu do the following:
+    sudo apt-get install build-essential git pkg-config -y
+
+In order to install build dependencies on Fedora, as root do the following:
+    dnf install gcc make git pkg-config -y

I would actually add above libtracefs-devel and libtraceevent-devel for fedora, and possibly libtracefs-dev and libtraceevent-dev for ubuntu / debian. Oh, I would say that too, as I don't use Ubuntu thus, state "on Debian / Ubuntu do the following".

README Lesser General Public License 2.1 (See COPYING.LIB). · line 33

Quoted 2 lines
README +2 -0
+
+To install required dependencies:

Then you can say here.

Quoted 6 lines

In case the distribution does not have the required libtracefs and libtraceevent libraries, install them manually:

Or something to that nature.

-- Steve

That is a great idea, I'll take a look at it.
Thanks again!

-- Victor

Quoted 16 lines
Quoted 15 lines
README +10 -0
+    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
+    cd libtraceevent
+    make
+    sudo make install
+
+    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
+    cd libtracefs
+    make
+    sudo make install
+
  To make trace-cmd
      make