Skip to contentSkip to conversation

trace-cmd: Add dependencies to BUILDING section in README

PATCH Superseded [email protected] 2 participants 3 messages Aug 12, 2021 – Aug 13, 2021

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trace-cmd: Add dependencies to BUILDING section in README

From: Victor Cora Colombo <[email protected]>

KernelShark has instructions in its README on how to get necessary dependencies to build it. trace-cmd could follow this example and also add more information on how to build it.

This patch adds instructions to README on how to get necessary libraries and dependencies to build trace-cmd.

---
 README | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
README +14 -0
index 1153152..16aedac 100644
@@ -24,6 +24,20 @@ Lesser General Public License 2.1 (See COPYING.LIB).
 
 BUILDING:
 
+In order to install build dependencies on Ubuntu do the following:
+    sudo apt-get install build-essential git pkg-config bison flex -y
+
+To install required dependencies:
+    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
+    cd libtraceevent
+    make
+    sudo make install
+
+    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
+    cd libtracefs
+    make
+    sudo make install
+
 To make trace-cmd
     make
 
Signature · 1 line
2.32.0
#1 lore raw
Quoted 8 lines · On Thu, 12 Aug 2021 19:33:53 -0300 [email protected] wrote:

From: Victor Cora Colombo <[email protected]>

KernelShark has instructions in its README on how to get necessary dependencies to build it. trace-cmd could follow this example and also add more information on how to build it.

This patch adds instructions to README on how to get necessary libraries and dependencies to build trace-cmd.

Thanks for sending this.

Quoted 11 lines
---
 README | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
README +0 -0
index 1153152..16aedac 100644

README Lesser General Public License 2.1 (See COPYING.LIB). · line 28

Quoted 5 lines
README +2 -0
@@ -24,6 +24,20 @@ Lesser General Public License 2.1 (See COPYING.LIB).
 
 BUILDING:
 
+In order to install build dependencies on Ubuntu do the following:
+    sudo apt-get install build-essential git pkg-config bison flex -y

Note, once the libtracefs settles down, I plan on committing the files that are generated by bison and flex, so it shouldn't be a requirement once libtracefs 1.3 is officially released. That is, because the files generated by flex and bison will be included in the repository, you do not need to include bison or flex to build it. Unless you plan on modifying the bison and flex source files.

Also, can we have a Fedora version? If you don't know what that is, I could come up with the equivalents.

-- Steve

Quoted 15 lines
README +12 -0
+
+To install required dependencies:
+    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
+    cd libtraceevent
+    make
+    sudo make install
+
+    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
+    cd libtracefs
+    make
+    sudo make install
+
 To make trace-cmd
     make
 
#2 lore raw
Quoted 38 lines · Steven Rostedt
Quoted 8 lines · On Thu, 12 Aug 2021 19:33:53 -0300 [email protected] wrote:

From: Victor Cora Colombo <[email protected]>

KernelShark has instructions in its README on how to get necessary dependencies to build it. trace-cmd could follow this example and also add more information on how to build it.

This patch adds instructions to README on how to get necessary libraries and dependencies to build trace-cmd.

Thanks for sending this.

Quoted 11 lines
---
  README | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
README +0 -0
index 1153152..16aedac 100644

README Lesser General Public License 2.1 (See COPYING.LIB). · line 28

Quoted 5 lines
README +2 -0
@@ -24,6 +24,20 @@ Lesser General Public License 2.1 (See COPYING.LIB).
 
  BUILDING:
 
+In order to install build dependencies on Ubuntu do the following:
+    sudo apt-get install build-essential git pkg-config bison flex -y

Note, once the libtracefs settles down, I plan on committing the files that are generated by bison and flex, so it shouldn't be a requirement once libtracefs 1.3 is officially released. That is, because the files generated by flex and bison will be included in the repository, you do not need to include bison or flex to build it. Unless you plan on modifying the bison and flex source files.

Quoted 5 lines

Also, can we have a Fedora version? If you don't know what that is, I could come up with the equivalents.

-- Steve

Hello Steve, thanks for your kind reply.

I will come up with a Fedora version and send the updated patch tomorrow.
Also, given what you said, I think it is better then to remove bison and flex from this patch, and I will also do this when I send the updated patch.

Best regards,

-- Victor

Quoted 17 lines
Quoted 16 lines
README +12 -0
+
+To install required dependencies:
+    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
+    cd libtraceevent
+    make
+    sudo make install
+
+    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
+    cd libtracefs
+    make
+    sudo make install
+
  To make trace-cmd
      make