Skip to contentSkip to conversation

unexport memcg locking helpers

PATCH In review Christoph Hellwig 2 participants 4 messages Aug 20, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi all,

neither the old page-based nor the new folio-based memcg locking helpers are used in modular code at all, so drop the exports.

#1 lore raw

PATCH 1/2 mm: unexport folio_memcg_{,un}lock

These are only used in built-in core mm code.

---
 mm/memcontrol.c | 2 --
 1 file changed, 2 deletions(-)
mm/memcontrol.c +0 -2
index 45a160894a035..4cb4349065931 100644
@@ -2014,7 +2014,6 @@ void folio_memcg_lock(struct folio *folio)
 	memcg->move_lock_task = current;
 	memcg->move_lock_flags = flags;
 }
-EXPORT_SYMBOL(folio_memcg_lock);
 
 void lock_page_memcg(struct page *page)
 {
@@ -2048,7 +2047,6 @@ void folio_memcg_unlock(struct folio *folio)
 {
 	__folio_memcg_unlock(folio_memcg(folio));
 }
-EXPORT_SYMBOL(folio_memcg_unlock);
 
 void unlock_page_memcg(struct page *page)
 {
Signature · 1 line
2.30.2
#2 lore raw

PATCH 2/2 mm: unexport {,un}lock_page_memcg

In reply to Christoph Hellwig

These are only used in built-in core mm code.

---
 mm/memcontrol.c | 2 --
 1 file changed, 2 deletions(-)
mm/memcontrol.c +0 -2
index 4cb4349065931..6a74a180e3eae 100644
@@ -2019,7 +2019,6 @@ void lock_page_memcg(struct page *page)
 {
 	folio_memcg_lock(page_folio(page));
 }
-EXPORT_SYMBOL(lock_page_memcg);
 
 static void __folio_memcg_unlock(struct mem_cgroup *memcg)
 {
@@ -2052,7 +2051,6 @@ void unlock_page_memcg(struct page *page)
 {
 	folio_memcg_unlock(page_folio(page));
 }
-EXPORT_SYMBOL(unlock_page_memcg);
 
 struct obj_stock {
 #ifdef CONFIG_MEMCG_KMEM
Signature · 1 line
2.30.2