unexport memcg locking helpers
Subsystems (3)
Hi all,
neither the old page-based nor the new folio-based memcg locking helpers are used in modular code at all, so drop the exports.
PATCH 1/2 mm: unexport folio_memcg_{,un}lock
These are only used in built-in core mm code.
Signed-off-by Christoph Hellwig <[email protected]>
--- mm/memcontrol.c | 2 -- 1 file changed, 2 deletions(-)
mm/memcontrol.c +0 -2
@@ -2014,7 +2014,6 @@ void folio_memcg_lock(struct folio *folio) memcg->move_lock_task = current; memcg->move_lock_flags = flags; } -EXPORT_SYMBOL (folio_memcg_lock);void lock_page_memcg (struct page *page) {
@@ -2048,7 +2047,6 @@ void folio_memcg_unlock(struct folio *folio) {__folio_memcg_unlock (folio_memcg (folio)); } -EXPORT_SYMBOL (folio_memcg_unlock);void unlock_page_memcg (struct page *page) {
Signature · 1 line
2.30.2
PATCH 2/2 mm: unexport {,un}lock_page_memcg
In reply to Christoph HellwigThese are only used in built-in core mm code.
Signed-off-by Christoph Hellwig <[email protected]>
--- mm/memcontrol.c | 2 -- 1 file changed, 2 deletions(-)
mm/memcontrol.c +0 -2
@@ -2019,7 +2019,6 @@ void lock_page_memcg(struct page *page) {folio_memcg_lock (page_folio (page)); } -EXPORT_SYMBOL (lock_page_memcg);static void __folio_memcg_unlock (struct mem_cgroup *memcg) {
@@ -2052,7 +2051,6 @@ void unlock_page_memcg(struct page *page) {folio_memcg_unlock (page_folio (page)); } -EXPORT_SYMBOL (unlock_page_memcg);struct obj_stock {#ifdef CONFIG_MEMCG_KMEM
Signature · 1 line
2.30.2
Re: [PATCH 2/2] mm: unexport {,un}lock_page_memcg
Quoted 3 lines · Christoph Hellwig
These are only used in built-in core mm code.
Signed-off-by Christoph Hellwig <[email protected]>
Good catch.
It was initially exported for xfs dirtying, and is no longer needed after that switched to iomap (and now __set_page_dirty_nobuffers).
Acked-by Johannes Weiner <[email protected]>