Per client GPU stats
Subsystems (5)
cover Per client GPU stats
From: Tvrtko Ursulin <[email protected]>
Same old work but now rebased and series ending with some DRM docs proposing the common specification which should enable nice common userspace tools to be written.
For the moment I only have intel_gpu_top converted to use this and that seems to work okay.
v2:
* Added prototype of possible amdgpu changes and spec updates to align with the common spec.
v3:
* Documented that 'drm-driver' tag shall correspond with struct drm_driver.name.
Tvrtko Ursulin (8):
drm/i915: Explicitly track DRM clients
drm/i915: Make GEM contexts track DRM clients
drm/i915: Track runtime spent in closed and unreachable GEM contexts drm/i915: Track all user contexts per client
drm/i915: Track context current active time
drm: Document fdinfo format specification
drm/i915: Expose client engine utilisation via fdinfo drm/amdgpu: Convert to common fdinfo format
Documentation/gpu/amdgpu.rst | 26 ++++ Documentation/gpu/drm-usage-stats.rst | 108 +++++++++++++ Documentation/gpu/i915.rst | 27 ++++ Documentation/gpu/index.rst | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 19 ++- drivers/gpu/drm/i915/Makefile | 5 +- drivers/gpu/drm/i915/gem/i915_gem_context.c | 42 ++++- .../gpu/drm/i915/gem/i915_gem_context_types.h | 6 + drivers/gpu/drm/i915/gt/intel_context.c | 27 +++- drivers/gpu/drm/i915/gt/intel_context.h | 15 +- drivers/gpu/drm/i915/gt/intel_context_types.h | 24 ++- .../drm/i915/gt/intel_execlists_submission.c | 23 ++- .../gpu/drm/i915/gt/intel_gt_clock_utils.c | 4 + drivers/gpu/drm/i915/gt/intel_lrc.c | 27 ++-- drivers/gpu/drm/i915/gt/intel_lrc.h | 24 +++ drivers/gpu/drm/i915/gt/selftest_lrc.c | 10 +- drivers/gpu/drm/i915/i915_drm_client.c | 143 ++++++++++++++++++ drivers/gpu/drm/i915/i915_drm_client.h | 66 ++++++++ drivers/gpu/drm/i915/i915_drv.c | 9 ++ drivers/gpu/drm/i915/i915_drv.h | 5 + drivers/gpu/drm/i915/i915_gem.c | 21 ++- drivers/gpu/drm/i915/i915_gpu_error.c | 9 +- drivers/gpu/drm/i915/i915_gpu_error.h | 2 +- 23 files changed, 582 insertions(+), 61 deletions(-) create mode 100644 Documentation/gpu/drm-usage-stats.rst create mode 100644 drivers/gpu/drm/i915/i915_drm_client.c create mode 100644 drivers/gpu/drm/i915/i915_drm_client.h
Signature · 1 line
2.30.2
RFC 1/8 drm/i915: Explicitly track DRM clients
From: Tvrtko Ursulin <[email protected]>
Tracking DRM clients more explicitly will allow later patches to accumulate past and current GPU usage in a centralised place and also consolidate access to owning task pid/name.
Unique client id is also assigned for the purpose of distinguishing/ consolidating between multiple file descriptors owned by the same process.
v2:
Chris Wilson:
* Enclose new members into dedicated structs.
* Protect against failed sysfs registration.
v3:
* sysfs_attr_init.
v4:
* Fix for internal clients.
v5:
* Use cyclic ida for client id. (Chris)
* Do not leak pid reference. (Chris)
* Tidy code with some locals.
v6:
* Use xa_alloc_cyclic to simplify locking. (Chris)
* No need to unregister individial sysfs files. (Chris)
* Rebase on top of fpriv kref.
* Track client closed status and reflect in sysfs.
v7:
* Make drm_client more standalone concept.
v8:
* Simplify sysfs show. (Chris)
* Always track name and pid.
v9:
* Fix cyclic id assignment.
v10:
* No need for a mutex around xa_alloc_cyclic.
* Refactor sysfs into own function.
* Unregister sysfs before freeing pid and name.
* Move clients setup into own function.
v11:
* Call clients init directly from driver init. (Chris)
v12:
* Do not fail client add on id wrap. (Maciej)
v13 (Lucas): Rebase.
v14:
* Dropped sysfs bits.
v15:
* Dropped tracking of pid/ and name.
* Dropped RCU freeing of the client object.
--- drivers/gpu/drm/i915/Makefile | 5 +- drivers/gpu/drm/i915/i915_drm_client.c | 68 ++++++++++++++++++++++++++ drivers/gpu/drm/i915/i915_drm_client.h | 50 +++++++++++++++++++ drivers/gpu/drm/i915/i915_drv.c | 6 +++ drivers/gpu/drm/i915/i915_drv.h | 5 ++ drivers/gpu/drm/i915/i915_gem.c | 21 ++++++-- 6 files changed, 150 insertions(+), 5 deletions(-) create mode 100644 drivers/gpu/drm/i915/i915_drm_client.c create mode 100644 drivers/gpu/drm/i915/i915_drm_client.h
drivers/gpu/drm/i915/Makefile +3 -2
@@ -33,8 +33,9 @@ subdir-ccflags-y += -I$(srctree)/$(src) # Please keep these build lists sorted! # core driver code -i915-y += i915_drv.o \ - i915_config.o \ +i915-y += i915_config.o \ + i915_drm_client.o \ + i915_drv.o \ i915_irq.o \ i915_getparam.o \ i915_mitigations.o \
drivers/gpu/drm/i915/i915_drm_client.c new file +68 -0
68 lines not on this page · raw message
drivers/gpu/drm/i915/i915_drm_client.h new file +50 -0
50 lines not on this page · raw message
drivers/gpu/drm/i915/i915_drv.c +6 -0
@@ -68,6 +68,7 @@#include "gt/intel_rc6.h" #include "i915_debugfs.h" +#include "i915_drm_client.h" #include "i915_drv.h" #include "i915_ioc32.h" #include "i915_irq.h"
@@ -344,6 +345,8 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv)intel_gt_init_early (&dev_priv->gt, dev_priv); +i915_drm_clients_init (&dev_priv->clients, dev_priv); +i915_gem_init_early (dev_priv);/* This must be called before any calls to HAS_PCH_* */
@@ -363,6 +366,7 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv) err_gem:i915_gem_cleanup_early (dev_priv); +i915_drm_clients_fini (&dev_priv->clients);intel_gt_driver_late_release (&dev_priv->gt);intel_region_ttm_device_fini (dev_priv); err_ttm:
@@ -382,6 +386,7 @@ static void i915_driver_late_release(struct drm_i915_private *dev_priv)intel_irq_fini (dev_priv);intel_power_domains_cleanup (dev_priv);i915_gem_cleanup_early (dev_priv); +i915_drm_clients_fini (&dev_priv->clients);intel_gt_driver_late_release (&dev_priv->gt);intel_region_ttm_device_fini (dev_priv);vlv_suspend_cleanup (dev_priv);
@@ -999,6 +1004,7 @@ static void i915_driver_postclose(struct drm_device *dev, struct drm_file *file)struct drm_i915_file_private *file_priv = file->driver_priv;i915_gem_context_close (file); +i915_drm_client_put (file_priv->client);kfree_rcu (file_priv, rcu);
drivers/gpu/drm/i915/i915_drv.h +5 -0
@@ -96,6 +96,7 @@#include "intel_wakeref.h" #include "intel_wopcm.h" +#include "i915_drm_client.h" #include "i915_gem.h" #include "i915_gem_gtt.h" #include "i915_gpu_error.h"
@@ -284,6 +285,8 @@ struct drm_i915_file_private {/** ban_score: Accumulated score of all ctx bans and fast hangs. */ atomic_t ban_score;unsigned long hang_timestamp; + +struct i915_drm_client *client; };/* Interface history:
@@ -1216,6 +1219,8 @@ struct drm_i915_private {struct i915_pmu pmu; +struct i915_drm_clients clients; +struct i915_hdcp_comp_master *hdcp_master;bool hdcp_comp_added;
drivers/gpu/drm/i915/i915_gem.c +18 -3
@@ -1179,25 +1179,40 @@ void i915_gem_cleanup_early(struct drm_i915_private *dev_priv)int i915_gem_open (struct drm_i915_private *i915,struct drm_file *file) {struct drm_i915_file_private *file_priv; -int ret; +struct i915_drm_client *client; +int ret = -ENOMEM ;DRM_DEBUG ("\n" ); file_priv =kzalloc (sizeof (*file_priv),GFP_KERNEL );if (!file_priv) -return -ENOMEM ; + goto err_alloc; + + client =i915_drm_client_add (&i915->clients); +if (IS_ERR (client)) { + ret =PTR_ERR (client); + goto err_client; + } file->driver_priv = file_priv; file_priv->dev_priv = i915; file_priv->file = file; + file_priv->client = client; file_priv->bsd_engine =-1 ; file_priv->hang_timestamp = jiffies; ret =i915_gem_context_open (i915, file);if (ret) -kfree (file_priv); + goto err_context; + +return 0 ; +err_context: +i915_drm_client_put (client); +err_client: +kfree (file_priv); +err_alloc:return ret; }
Signature · 1 line
2.30.2
RFC 2/8 drm/i915: Make GEM contexts track DRM clients
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Make GEM contexts keep a reference to i915_drm_client for the whole of of their lifetime which will come handy in following patches.
v2: Don't bother supporting selftests contexts from debugfs. (Chris) v3 (Lucas): Finish constructing ctx before adding it to the list v4 (Ram): Rebase.
v5: Trivial rebase for proto ctx changes.
v6: Rebase after clients no longer track name and pid.
--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 +++++ drivers/gpu/drm/i915/gem/i915_gem_context_types.h | 3 +++ 2 files changed, 8 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_context.c +5 -0
@@ -993,6 +993,9 @@ void i915_gem_context_release(struct kref *ref)trace_i915_context_free (ctx);GEM_BUG_ON (!i915_gem_context_is_closed (ctx)); +if (ctx->client) +i915_drm_client_put (ctx->client); +mutex_destroy (&ctx->engines_mutex);mutex_destroy (&ctx->lut_mutex);
@@ -1398,6 +1401,8 @@ static void gem_context_register(struct i915_gem_context *ctx, ctx->file_priv = fpriv; ctx->pid =get_task_pid (current,PIDTYPE_PID ); + ctx->client =i915_drm_client_get (fpriv->client); +snprintf (ctx->name,sizeof (ctx->name),"%s[%d]" , current->comm,pid_nr (ctx->pid));
drivers/gpu/drm/i915/gem/i915_gem_context_types.h +3 -0
@@ -277,6 +277,9 @@ struct i915_gem_context {/** @link: place with &drm_i915_private.context_list */ struct list_head link; +/** @client: struct i915_drm_client */ +struct i915_drm_client *client; +/** * @ref: reference count *
Signature · 1 line
2.30.2
RFC 3/8 drm/i915: Track runtime spent in closed and unreachable GEM contexts
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
As contexts are abandoned we want to remember how much GPU time they used (per class) so later we can used it for smarter purposes.
As GEM contexts are closed we want to have the DRM client remember how much GPU time they used (per class) so later we can used it for smarter purposes.
--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 25 +++++++++++++++++++-- drivers/gpu/drm/i915/i915_drm_client.h | 7 ++++++ 2 files changed, 30 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_context.c +23 -2
@@ -846,23 +846,44 @@ static void free_engines_rcu(struct rcu_head *rcu)free_engines (engines); } +static void accumulate_runtime (struct i915_drm_client *client, +struct i915_gem_engines *engines) +{ +struct i915_gem_engines_iter it; +struct intel_context *ce; + +if (!client) +return ; + +/* Transfer accumulated runtime to the parent GEM context. */ +for_each_gem_engine (ce, engines, it) { +unsigned int class = ce->engine->uabi_class; + +GEM_BUG_ON (class >=ARRAY_SIZE (client->past_runtime)); +atomic64_add (intel_context_get_total_runtime_ns (ce), + &client->past_runtime[class]); + } +} + static int __i915_sw_fence_callengines_notify (struct i915_sw_fence *fence,enum i915_sw_fence_notify state) {struct i915_gem_engines *engines =container_of (fence,typeof (*engines), fence); +struct i915_gem_context *ctx = engines->ctx;switch (state) {case FENCE_COMPLETE :if (!list_empty (&engines->link)) { -struct i915_gem_context *ctx = engines->ctx;unsigned long flags;spin_lock_irqsave (&ctx->stale.lock, flags);list_del (&engines->link);spin_unlock_irqrestore (&ctx->stale.lock, flags); } -i915_gem_context_put (engines->ctx); +accumulate_runtime (ctx->client, engines); +i915_gem_context_put (ctx); +break ;case FENCE_FREE :
drivers/gpu/drm/i915/i915_drm_client.h +7 -0
@@ -9,6 +9,8 @@#include <linux/kref.h> #include <linux/xarray.h> +#include "gt/intel_engine_types.h" +struct drm_i915_private ;struct i915_drm_clients {
@@ -24,6 +26,11 @@ struct i915_drm_client {unsigned int id;struct i915_drm_clients *clients; + +/** +* @past_runtime: Accumulation of pphwsp runtimes from closed contexts. +*/ +atomic64_t past_runtime[MAX_ENGINE_CLASS +1 ]; }; void i915_drm_clients_init(struct i915_drm_clients *clients,
Signature · 1 line
2.30.2
RFC 4/8 drm/i915: Track all user contexts per client
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
We soon want to start answering questions like how much GPU time is the context belonging to a client which exited still using.
To enable this we start tracking all context belonging to a client on a separate list.
--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 12 ++++++++++++ drivers/gpu/drm/i915/gem/i915_gem_context_types.h | 3 +++ drivers/gpu/drm/i915/i915_drm_client.c | 2 ++ drivers/gpu/drm/i915/i915_drm_client.h | 5 +++++ 4 files changed, 22 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_context.c +12 -0
@@ -1220,6 +1220,7 @@ static void set_closed_name(struct i915_gem_context *ctx)static void context_close (struct i915_gem_context *ctx) { +struct i915_drm_client *client;struct i915_address_space *vm;/* Flush any concurrent set_engines() */
@@ -1252,6 +1253,13 @@ static void context_close(struct i915_gem_context *ctx)list_del (&ctx->link);spin_unlock (&ctx->i915->gem.contexts.lock); + client = ctx->client; +if (client) { +spin_lock (&client->ctx_lock); +list_del_rcu (&ctx->client_link); +spin_unlock (&client->ctx_lock); + } +mutex_unlock (&ctx->mutex);/*
@@ -1431,6 +1439,10 @@ static void gem_context_register(struct i915_gem_context *ctx, old =xa_store (&fpriv->context_xa, id, ctx,GFP_KERNEL );WARN_ON (old); +spin_lock (&ctx->client->ctx_lock); +list_add_tail_rcu (&ctx->client_link, &ctx->client->ctx_list); +spin_unlock (&ctx->client->ctx_lock); +spin_lock (&i915->gem.contexts.lock);list_add_tail (&ctx->link, &i915->gem.contexts.list);spin_unlock (&i915->gem.contexts.lock);
drivers/gpu/drm/i915/gem/i915_gem_context_types.h +3 -0
@@ -280,6 +280,9 @@ struct i915_gem_context {/** @client: struct i915_drm_client */ struct i915_drm_client *client; +/** link: &drm_client.context_list */ +struct list_head client_link; +/** * @ref: reference count *
drivers/gpu/drm/i915/i915_drm_client.c +2 -0
@@ -38,6 +38,8 @@ struct i915_drm_client *i915_drm_client_add(struct i915_drm_clients *clients) goto err;kref_init (&client->kref); +spin_lock_init (&client->ctx_lock); +INIT_LIST_HEAD (&client->ctx_list); client->clients = clients;return client;
drivers/gpu/drm/i915/i915_drm_client.h +5 -0
@@ -7,6 +7,8 @@#define __I915_DRM_CLIENT_H__#include <linux/kref.h> +#include <linux/list.h> +#include <linux/spinlock.h> #include <linux/xarray.h> #include "gt/intel_engine_types.h"
@@ -25,6 +27,9 @@ struct i915_drm_client {unsigned int id; +spinlock_t ctx_lock;/* For add/remove from ctx_list. */ +struct list_head ctx_list;/* List of contexts belonging to client. */ +struct i915_drm_clients *clients;/**
Signature · 1 line
2.30.2
RFC 5/8 drm/i915: Track context current active time
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Track context active (on hardware) status together with the start timestamp.
This will be used to provide better granularity of context runtime reporting in conjunction with already tracked pphwsp accumulated runtime.
The latter is only updated on context save so does not give us visibility to any currently executing work.
As part of the patch the existing runtime tracking data is moved under the new ce->stats member and updated under the seqlock. This provides the ability to atomically read out accumulated plus active runtime.
v2:
* Rename and make __intel_context_get_active_time unlocked.
v3:
* Use GRAPHICS_VER.
--- drivers/gpu/drm/i915/gt/intel_context.c | 27 ++++++++++++++++++- drivers/gpu/drm/i915/gt/intel_context.h | 15 ++++------- drivers/gpu/drm/i915/gt/intel_context_types.h | 24 +++++++++++------ .../drm/i915/gt/intel_execlists_submission.c | 23 ++++++++++++---- .../gpu/drm/i915/gt/intel_gt_clock_utils.c | 4 +++ drivers/gpu/drm/i915/gt/intel_lrc.c | 27 ++++++++++--------- drivers/gpu/drm/i915/gt/intel_lrc.h | 24 +++++++++++++++++ drivers/gpu/drm/i915/gt/selftest_lrc.c | 10 +++---- drivers/gpu/drm/i915/i915_gpu_error.c | 9 +++---- drivers/gpu/drm/i915/i915_gpu_error.h | 2 +- 10 files changed, 116 insertions(+), 49 deletions(-)
drivers/gpu/drm/i915/gt/intel_context.c +26 -1
@@ -382,7 +382,7 @@ intel_context_init(struct intel_context *ce, struct intel_engine_cs *engine) ce->ring =NULL ; ce->ring_size =SZ_4K ; -ewma_runtime_init (&ce->runtime.avg); +ewma_runtime_init (&ce->stats.runtime.avg); ce->vm =i915_vm_get (engine->gt->vm);
@@ -533,6 +533,31 @@ struct i915_request *intel_context_find_active_request(struct intel_context *ce)return active; } +u64 intel_context_get_total_runtime_ns (const struct intel_context *ce) +{ +u64 total, active; + + total = ce->stats.runtime.total; +if (ce->ops->flags &COPS_RUNTIME_CYCLES ) + total *= ce->engine->gt->clock_period_ns; + + active =READ_ONCE (ce->stats.active); +if (active) + active =intel_context_clock () - active; + +return total + active; +} + +u64 intel_context_get_avg_runtime_ns (struct intel_context *ce) +{ +u64 avg =ewma_runtime_read (&ce->stats.runtime.avg); + +if (ce->ops->flags &COPS_RUNTIME_CYCLES ) + avg *= ce->engine->gt->clock_period_ns; + +return avg; +} +#if IS_ENABLED (CONFIG_DRM_I915_SELFTEST )#include "selftest_context.c" #endif
drivers/gpu/drm/i915/gt/intel_context.h +5 -10
@@ -296,18 +296,13 @@ intel_context_clear_nopreempt(struct intel_context *ce) clear_bit(CONTEXT_NOPREEMPT, &ce->flags); } -static inline u64 intel_context_get_total_runtime_ns (struct intel_context *ce) -{ -const u32 period = ce->engine->gt->clock_period_ns; - -return READ_ONCE (ce->runtime.total) * period; -} +u64 intel_context_get_total_runtime_ns (const struct intel_context *ce); +u64 intel_context_get_avg_runtime_ns (struct intel_context *ce); -static inline u64 intel_context_get_avg_runtime_ns (struct intel_context *ce) +static inline u64 intel_context_clock (void ) { -const u32 period = ce->engine->gt->clock_period_ns; - -return mul_u32_u32 (ewma_runtime_read (&ce->runtime.avg), period); +/* As we mix CS cycles with CPU clocks, use the raw monotonic clock. */ +return ktime_get_raw_fast_ns (); }#endif /* __INTEL_CONTEXT_H__ */
drivers/gpu/drm/i915/gt/intel_context_types.h +16 -8
@@ -35,6 +35,9 @@ struct intel_context_ops {#define COPS_HAS_INFLIGHT_BIT 0#define COPS_HAS_INFLIGHT BIT(COPS_HAS_INFLIGHT_BIT) +#define COPS_RUNTIME_CYCLES_BIT 1 +#define COPS_RUNTIME_CYCLES BIT(COPS_RUNTIME_CYCLES_BIT) +int (*alloc)(struct intel_context *ce);void (*ban)(struct intel_context *ce,struct i915_request *rq);
@@ -127,14 +130,19 @@ struct intel_context { } lrc;u32 tag;/* cookie passed to HW to track this context on submission */ -/* Time on GPU as tracked by the hw. */ -struct { -struct ewma_runtime avg; -u64 total; -u32 last; - I915_SELFTEST_DECLARE(u32 num_underflow); - I915_SELFTEST_DECLARE(u32 max_underflow); - } runtime; +/** stats: Context GPU engine busyness tracking. */ +struct intel_context_stats { +u64 active; + +/* Time on GPU as tracked by the hw. */ +struct { +struct ewma_runtime avg; +u64 total; +u32 last; + I915_SELFTEST_DECLARE(u32 num_underflow); + I915_SELFTEST_DECLARE(u32 max_underflow); + } runtime; + } stats;unsigned int active_count;/* protected by timeline->mutex */
drivers/gpu/drm/i915/gt/intel_execlists_submission.c +18 -5
@@ -621,8 +621,6 @@ static void __execlists_schedule_out(struct i915_request * const rq,GEM_BUG_ON (test_bit (ccid -1 , &engine->context_tag));__set_bit (ccid -1 , &engine->context_tag); } - -lrc_update_runtime (ce);intel_engine_context_out (engine);execlists_context_status_change (rq,INTEL_CONTEXT_SCHEDULE_OUT );if (engine->fw_domain && !--engine->fw_active)
@@ -2003,8 +2001,23 @@ process_csb(struct intel_engine_cs *engine, struct i915_request **inactive)* and merits a fresh timeslice. We reinstall the timer after * inspecting the queue to see if we need to resumbit. */ -if (*prev != *execlists->active)/* elide lite-restores */ +if (*prev != *execlists->active) {/* elide lite-restores */ +/* +* Note the inherent discrepancy between the HW runtime, +* recorded as part of the context switch, and the CPU +* adjustment for active contexts. We have to hope that +* the delay in processing the CS event is very small +* and consistent. It works to our advantage to have +* the CPU adjustment _undershoot_ (i.e. start later than) +* the CS timestamp so we never overreport the runtime +* and correct overselves later when updating from HW. +*/ +if (*prev) +lrc_runtime_stop ((*prev)->context); +if (*execlists->active) +lrc_runtime_start ((*execlists->active)->context);new_timeslice (execlists); + }return inactive; }
@@ -2602,7 +2615,7 @@ static void execlists_context_cancel_request(struct intel_context *ce, }static const struct intel_context_ops execlists_context_ops = { - .flags =COPS_HAS_INFLIGHT , + .flags =COPS_HAS_INFLIGHT |COPS_RUNTIME_CYCLES , .alloc = execlists_context_alloc,
@@ -3620,7 +3633,7 @@ virtual_get_sibling(struct intel_engine_cs *engine, unsigned int sibling) }static const struct intel_context_ops virtual_context_ops = { - .flags =COPS_HAS_INFLIGHT , + .flags =COPS_HAS_INFLIGHT |COPS_RUNTIME_CYCLES , .alloc = virtual_context_alloc,
drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c +4 -0
@@ -159,6 +159,10 @@ void intel_gt_init_clock_frequency(struct intel_gt *gt)if (gt->clock_frequency) gt->clock_period_ns =intel_gt_clock_interval_to_ns (gt,1 ); +/* Icelake appears to use another fixed frequency for CTX_TIMESTAMP */ +if (GRAPHICS_VER (gt->i915) ==11 ) + gt->clock_period_ns =NSEC_PER_SEC /13750000 ; + GT_TRACE(gt, "Using clock frequency: %dkHz, period: %dns, wrap: %lldms\n", gt->clock_frequency / 1000,
drivers/gpu/drm/i915/gt/intel_lrc.c +14 -13
@@ -693,7 +693,7 @@ static void init_common_regs(u32 * const regs, CTX_CTRL_RS_CTX_ENABLE); regs[CTX_CONTEXT_CONTROL ] = ctl; - regs[CTX_TIMESTAMP ] = ce->runtime.last; + regs[CTX_TIMESTAMP ] = ce->stats.runtime.last; } static void init_wa_bb_regs(u32 * const regs,
@@ -1586,35 +1586,36 @@ void lrc_init_wa_ctx(struct intel_engine_cs *engine) } } -static void st_update_runtime_underflow (struct intel_context *ce,s32 dt) +static void st_runtime_underflow (struct intel_context_stats *stats,s32 dt) {#if IS_ENABLED (CONFIG_DRM_I915_SELFTEST ) - ce->runtime.num_underflow++; - ce->runtime.max_underflow =max_t (u32, ce->runtime.max_underflow, -dt); + stats->runtime.num_underflow++; + stats->runtime.max_underflow = +max_t (u32, stats->runtime.max_underflow, -dt);#endif }void lrc_update_runtime (struct intel_context *ce) { +struct intel_context_stats *stats = &ce->stats;u32 old;s32 dt; -if (intel_context_is_barrier (ce)) + old = stats->runtime.last; + stats->runtime.last =lrc_get_runtime (ce); + dt = stats->runtime.last - old; +if (!dt)return ; - old = ce->runtime.last; - ce->runtime.last =lrc_get_runtime (ce); - dt = ce->runtime.last - old; -if (unlikely (dt <0 )) {CE_TRACE (ce,"runtime underflow: last=%u, new=%u, delta=%d\n" , - old, ce->runtime.last, dt); -st_update_runtime_underflow (ce, dt); + old, stats->runtime.last, dt); +st_runtime_underflow (stats, dt);return ; } -ewma_runtime_add (&ce->runtime.avg, dt); - ce->runtime.total += dt; +ewma_runtime_add (&stats->runtime.avg, dt); + stats->runtime.total += dt; }#if IS_ENABLED (CONFIG_DRM_I915_SELFTEST )
drivers/gpu/drm/i915/gt/intel_lrc.h +24 -0
@@ -79,4 +79,28 @@ static inline u32 lrc_get_runtime(const struct intel_context *ce) return READ_ONCE(ce->lrc_reg_state[CTX_TIMESTAMP]); } +static inline void lrc_runtime_start (struct intel_context *ce) +{ +struct intel_context_stats *stats = &ce->stats; + +if (intel_context_is_barrier (ce)) +return ; + +if (stats->active) +return ; + +WRITE_ONCE (stats->active,intel_context_clock ()); +} + +static inline void lrc_runtime_stop (struct intel_context *ce) +{ +struct intel_context_stats *stats = &ce->stats; + +if (!stats->active) +return ; + +lrc_update_runtime (ce); +WRITE_ONCE (stats->active,0 ); +} +#endif /* __INTEL_LRC_H__ */
drivers/gpu/drm/i915/gt/selftest_lrc.c +5 -5
@@ -1751,8 +1751,8 @@ static int __live_pphwsp_runtime(struct intel_engine_cs *engine)if (IS_ERR (ce))return PTR_ERR (ce); - ce->runtime.num_underflow =0 ; - ce->runtime.max_underflow =0 ; + ce->stats.runtime.num_underflow =0 ; + ce->stats.runtime.max_underflow =0 ; do { unsigned int loop = 1024;
@@ -1790,11 +1790,11 @@ static int __live_pphwsp_runtime(struct intel_engine_cs *engine) intel_context_get_avg_runtime_ns(ce)); err =0 ; -if (ce->runtime.num_underflow) { +if (ce->stats.runtime.num_underflow) {pr_err ("%s: pphwsp underflow %u time(s), max %u cycles!\n" , engine->name, - ce->runtime.num_underflow, - ce->runtime.max_underflow); + ce->stats.runtime.num_underflow, + ce->stats.runtime.max_underflow);GEM_TRACE_DUMP (); err = -EOVERFLOW ; }
drivers/gpu/drm/i915/i915_gpu_error.c +3 -6
@@ -504,13 +504,10 @@ static void error_print_context(struct drm_i915_error_state_buf *m, const char *header, const struct i915_gem_context_coredump *ctx) { - const u32 period = m->i915->gt.clock_period_ns; - err_printf(m, "%s%s[%d] prio %d, guilty %d active %d, runtime total %lluns, avg %lluns\n", header, ctx->comm, ctx->pid, ctx->sched_attr.priority, ctx->guilty, ctx->active, - ctx->total_runtime * period, -mul_u32_u32 (ctx->avg_runtime, period)); + ctx->total_runtime, ctx->avg_runtime); } static struct i915_vma_coredump *
@@ -1308,8 +1305,8 @@ static bool record_context(struct i915_gem_context_coredump *e, e->guilty =atomic_read (&ctx->guilty_count); e->active =atomic_read (&ctx->active_count); - e->total_runtime = rq->context->runtime.total; - e->avg_runtime =ewma_runtime_read (&rq->context->runtime.avg); + e->total_runtime =intel_context_get_total_runtime_ns (rq->context); + e->avg_runtime =intel_context_get_avg_runtime_ns (rq->context); simulated =i915_gem_context_no_error_capture (ctx);
drivers/gpu/drm/i915/i915_gpu_error.h +1 -1
@@ -90,7 +90,7 @@ struct intel_engine_coredump {char comm[TASK_COMM_LEN ];u64 total_runtime; -u32 avg_runtime; +u64 avg_runtime;pid_t pid;int active;
Signature · 1 line
2.30.2
RFC 6/8 drm: Document fdinfo format specification
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Proposal to standardise the fdinfo text format as optionally output by DRM drivers.
Idea is that a simple but, well defined, spec will enable generic userspace tools to be written while at the same time avoiding a more heavy handed approach of adding a mid-layer to DRM.
i915 implements a subset of the spec, everything apart from the memory stats currently, and a matching intel_gpu_top tool exists.
Open is to see if AMD can migrate to using the proposed GPU utilisation key-value pairs, or if they are not workable to see whether to go vendor specific, or if a standardised alternative can be found which is workable for both drivers.
Same for the memory utilisation key-value pairs proposal.
v2:
* Update for removal of name and pid.
v3:
* 'Drm-driver' tag will be obtained from struct drm_driver.name. (Daniel)
--- Documentation/gpu/drm-usage-stats.rst | 97 +++++++++++++++++++++++++++ Documentation/gpu/index.rst | 1 + 2 files changed, 98 insertions(+) create mode 100644 Documentation/gpu/drm-usage-stats.rst
Documentation/gpu/drm-usage-stats.rst new file +97 -0
@@ -0,0 +1,97 @@ +.. _drm-client-usage-stats: + +====================== +DRM client usage stats +====================== + +DRM drivers can choose to export partly standardised text output via the +`fops->show_fdinfo()` as part of the driver specific file operations registered +in the `struct drm_driver` object registered with the DRM core. + +One purpose of this output is to enable writing as generic as practicaly +feasible `top(1)` like userspace monitoring tools. + +Given the differences between various DRM drivers the specification of the +output is split between common and driver specific parts. Having said that, +wherever possible effort should still be made to standardise as much as +possible. + +File format specification +========================= + +- File shall contain one key value pair per one line of text. +- Colon character (`:`) must be used to delimit keys and values. +- All keys shall be prefixed with `drm-`. +- Whitespace between the delimiter and first non-whitespace character shall be + ignored when parsing. +- Neither keys or values are allowed to contain whitespace characters. +- Numerical key value pairs can end with optional unit string. +- Data type of the value is fixed as defined in the specification. + +Key types +--------- + +1. Mandatory, fully standardised. +2. Optional, fully standardised. +3. Driver specific. + +Data types +---------- + +- <uint> - Unsigned integer without defining the maximum value. +- <str> - String excluding any above defined reserved characters or whitespace. + +Mandatory fully standardised keys +--------------------------------- + +- drm-driver: <str> + +String shall contain the name this driver registered as via the respective +`struct drm_driver` data structure. + +Optional fully standardised keys +-------------------------------- + +- drm-pdev: <aaaa:bb.cc.d> + +For PCI devices this should contain the PCI slot address of the device in +question. + +- drm-client-id: <uint> + +Unique value relating to the open DRM file descriptor used to distinguish +duplicated and shared file descriptors. Conceptually the value should map 1:1 +to the in kernel representation of `struct drm_file` instances. + +Uniqueness of the value shall be either globally unique, or unique within the +scope of each device, in which case `drm-pdev` shall be present as well. + +Userspace should make sure to not double account any usage statistics by using +the above described criteria in order to associate data to individual clients. + +- drm-engine-<str>: <uint> ns + +GPUs usually contain multiple execution engines. Each shall be given a stable +and unique name (str), with possible values documented in the driver specific +documentation. + +Value shall be in specified time units which the respective GPU engine spent +busy executing workloads belonging to this client. + +Values are not required to be constantly monotonic if it makes the driver +implementation easier, but are required to catch up with the previously reported +larger value within a reasonable period. Upon observing a value lower than what +was previously read, userspace is expected to stay with that larger previous +value until a monotonic update is seen. + +- drm-memory-<str>: <uint> [KiB|MiB] + +Each possible memory type which can be used to store buffer objects by the +GPU in question shall be given a stable and unique name to be returned as the +string here. + +Value shall reflect the amount of storage currently consumed by the buffer +object belong to this client, in the respective memory region. + +Default unit shall be bytes with optional unit specifiers of 'KiB' or 'MiB' +indicating kibi- or mebi-bytes.
Documentation/gpu/index.rst +1 -0
@@ -10,6 +10,7 @@ Linux GPU Driver Developer's Guide drm-kms drm-kms-helpers drm-uapi + drm-usage-stats driver-uapi drm-client drivers
Signature · 1 line
2.30.2
Christian König
maintainerRe: [RFC 6/8] drm: Document fdinfo format specification
Am 23.08.21 um 13:28 schrieb Tvrtko Ursulin:
Quoted 22 lines
From: Tvrtko Ursulin <[email protected]>
Proposal to standardise the fdinfo text format as optionally output by DRM drivers.
Idea is that a simple but, well defined, spec will enable generic userspace tools to be written while at the same time avoiding a more heavy handed approach of adding a mid-layer to DRM.
i915 implements a subset of the spec, everything apart from the memory stats currently, and a matching
intel_gpu_toptool exists.Open is to see if AMD can migrate to using the proposed GPU utilisation key-value pairs, or if they are not workable to see whether to go vendor specific, or if a standardised alternative can be found which is workable for both drivers.
Same for the memory utilisation key-value pairs proposal.
v2:
* Update for removal of name and pid.
Quoted 8 lines
v3:
* 'Drm-driver' tag will be obtained from struct drm_driver.name. (Daniel)Signed-off-by Tvrtko Ursulin <[email protected]>Cc David M Nieto <[email protected]>Cc Christian König <[email protected]>Cc Daniel Vetter <[email protected]>Cc Daniel Stone <[email protected]>
I'm not an expert on that stuff, but as far as I can see this totally makes sense to me.
Feel free to add an Acked-by: Christian König <[email protected]> to those three patches.
Regards,
Christian.
Quoted 121 lines
--- Documentation/gpu/drm-usage-stats.rst | 97 +++++++++++++++++++++++++++ Documentation/gpu/index.rst | 1 + 2 files changed, 98 insertions(+)create mode 100644
Documentation/gpu/drm-usage-stats.rstDocumentation/gpu/drm-usage-stats.rst new file +97
-0@@ -0,0 +1,97 @@ +.. _drm-client-usage-stats: + +====================== +DRM client usage stats +====================== + +DRM drivers can choose to export partly standardised text output via the +`fops->show_fdinfo()` as part of the driver specific file operations registered +in the `struct drm_driver` object registered with the DRM core. + +One purpose of this output is to enable writing as generic as practicaly +feasible `top(1)` like userspace monitoring tools. + +Given the differences between various DRM drivers the specification of the +output is split between common and driver specific parts. Having said that, +wherever possible effort should still be made to standardise as much as +possible. + +File format specification +========================= + +- File shall contain one key value pair per one line of text. +- Colon character (`:`) must be used to delimit keys and values. +- All keys shall be prefixed with `drm-`. +- Whitespace between the delimiter and first non-whitespace character shall be + ignored when parsing. +- Neither keys or values are allowed to contain whitespace characters. +- Numerical key value pairs can end with optional unit string. +- Data type of the value is fixed as defined in the specification. + +Key types +--------- + +1. Mandatory, fully standardised. +2. Optional, fully standardised. +3. Driver specific. + +Data types +---------- + +- <uint> - Unsigned integer without defining the maximum value. +- <str> - String excluding any above defined reserved characters or whitespace. + +Mandatory fully standardised keys +--------------------------------- + +- drm-driver: <str> + +String shall contain the name this driver registered as via the respective +`struct drm_driver` data structure. + +Optional fully standardised keys +-------------------------------- + +- drm-pdev: <aaaa:bb.cc.d> + +For PCI devices this should contain the PCI slot address of the device in +question. + +- drm-client-id: <uint> + +Unique value relating to the open DRM file descriptor used to distinguish +duplicated and shared file descriptors. Conceptually the value should map 1:1 +to the in kernel representation of `struct drm_file` instances. + +Uniqueness of the value shall be either globally unique, or unique within the +scope of each device, in which case `drm-pdev` shall be present as well. + +Userspace should make sure to not double account any usage statistics by using +the above described criteria in order to associate data to individual clients. + +- drm-engine-<str>: <uint> ns + +GPUs usually contain multiple execution engines. Each shall be given a stable +and unique name (str), with possible values documented in the driver specific +documentation. + +Value shall be in specified time units which the respective GPU engine spent +busy executing workloads belonging to this client. + +Values are not required to be constantly monotonic if it makes the driver +implementation easier, but are required to catch up with the previously reported +larger value within a reasonable period. Upon observing a value lower than what +was previously read, userspace is expected to stay with that larger previous +value until a monotonic update is seen. + +- drm-memory-<str>: <uint> [KiB|MiB] + +Each possible memory type which can be used to store buffer objects by the +GPU in question shall be given a stable and unique name to be returned as the +string here. + +Value shall reflect the amount of storage currently consumed by the buffer +object belong to this client, in the respective memory region. + +Default unit shall be bytes with optional unit specifiers of 'KiB' or 'MiB' +indicating kibi- or mebi-bytes.Documentation/gpu/index.rst +1
-0@@ -10,6 +10,7 @@ Linux GPU Driver Developer's Guide drm-kms drm-kms-helpers drm-uapi + drm-usage-stats driver-uapi drm-client drivers
Re: [RFC 6/8] drm: Document fdinfo format specification
Quoted 26 lines · Christian König
Am 23.08.21 um 13:28 schrieb Tvrtko Ursulin:
Quoted 25 lines
From: Tvrtko Ursulin <[email protected]>
Proposal to standardise the fdinfo text format as optionally output by DRM drivers.
Idea is that a simple but, well defined, spec will enable generic userspace tools to be written while at the same time avoiding a more heavy handed approach of adding a mid-layer to DRM.
i915 implements a subset of the spec, everything apart from the memory stats currently, and a matching
intel_gpu_toptool exists.Open is to see if AMD can migrate to using the proposed GPU utilisation key-value pairs, or if they are not workable to see whether to go vendor specific, or if a standardised alternative can be found which is workable for both drivers.
Same for the memory utilisation key-value pairs proposal.
v2:
* Update for removal of name and pid.v3:
* 'Drm-driver' tag will be obtained from struct drm_driver.name. (Daniel)
Quoted 7 lines
Quoted 5 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc David M Nieto <[email protected]>Cc Christian König <[email protected]>Cc Daniel Vetter <[email protected]>Cc Daniel Stone <[email protected]>I'm not an expert on that stuff, but as far as I can see this totally makes sense to me.
Thanks!
Quoted 1 line
Feel free to add an Acked-by: Christian König <[email protected]> to those three patches.
However note that the last one is full of TODO markers, including the commit message, where I was hoping to nudge the feature owners of the amdgpu side to fill in the blanks in my understanding of how things work over there. At least the different semantics need to be documented so random userspace can interpret the amdgpu values correctly.
Or alternatively I drop the last patch and if someone is interested they can resurrect and complete it at their leisure.
Just not sure how Daniel would accept this since his push was to gate i915 addition behind a drive for common solution.
Regards,
Tvrtko
Quoted 145 lines
Quoted 144 lines
---
Documentation/gpu/drm-usage-stats.rst| 97 +++++++++++++++++++++++++++ Documentation/gpu/index.rst | 1 +2 files changed, 98 insertions(+)create mode 100644
Documentation/gpu/drm-usage-stats.rstDocumentation/gpu/drm-usage-stats.rst new file +8
-0@@ -0,0 +1,97 @@ +.. _drm-client-usage-stats: + +====================== +DRM client usage stats +====================== + +DRM drivers can choose to export partly standardised text output via the +`fops->show_fdinfo()` as part of the driver specific file operationsregistered
Documentation/gpu/drm-usage-stats.rst new file +6
-0+in the `struct drm_driver` object registered with the DRM core. + +One purpose of this output is to enable writing as generic as practicaly +feasible `top(1)` like userspace monitoring tools. + +Given the differences between various DRM drivers the specificationof the
+output is split between common and driver specific parts. Having said that,Documentation/gpu/drm-usage-stats.rst new file +10
-0+wherever possible effort should still be made to standardise as much as +possible. + +File format specification +========================= + +- File shall contain one key value pair per one line of text. +- Colon character (`:`) must be used to delimit keys and values. +- All keys shall be prefixed with `drm-`. +- Whitespace between the delimiter and first non-whitespace charactershall be
+ ignored when parsing.+- Neither keys or values are allowed to contain whitespace characters. +- Numerical key value pairs can end with optional unit string. +- Data type of the value is fixed as defined in the specification.Documentation/gpu/drm-usage-stats.rst new file +13
-0+ +Key types +--------- + +1. Mandatory, fully standardised. +2. Optional, fully standardised. +3. Driver specific. + +Data types +---------- + +- <uint> - Unsigned integer without defining the maximum value. +- <str> - String excluding any above defined reserved characters orwhitespace.
Documentation/gpu/drm-usage-stats.rst new file +7
-0+ +Mandatory fully standardised keys +--------------------------------- + +- drm-driver: <str> + +String shall contain the name this driver registered as via therespective
+struct drm_driverdata structure.Documentation/gpu/drm-usage-stats.rst new file +7
-0+ +Optional fully standardised keys +-------------------------------- + +- drm-pdev: <aaaa:bb.cc.d> + +For PCI devices this should contain the PCI slot address of thedevice in
Documentation/gpu/drm-usage-stats.rst new file +5
-0+question. + +- drm-client-id: <uint> + +Unique value relating to the open DRM file descriptor used todistinguish
+duplicated and shared file descriptors. Conceptually the value should map 1:1Documentation/gpu/drm-usage-stats.rst new file +3
-0+to the in kernel representation of `struct drm_file` instances. + +Uniqueness of the value shall be either globally unique, or uniquewithin the
Documentation/gpu/drm-usage-stats.rst new file +3
-0+scope of each device, in which case `drm-pdev` shall be present as well. + +Userspace should make sure to not double account any usage statisticsby using
+the above described criteria in order to associate data to individual clients.Documentation/gpu/drm-usage-stats.rst new file +4
-0+ +- drm-engine-<str>: <uint> ns + +GPUs usually contain multiple execution engines. Each shall be givena stable
+and unique name (str), with possible values documented in the driver specificDocumentation/gpu/drm-usage-stats.rst new file +3
-0+documentation. + +Value shall be in specified time units which the respective GPUengine spent
Documentation/gpu/drm-usage-stats.rst new file +3
-0+busy executing workloads belonging to this client. + +Values are not required to be constantly monotonic if it makes thedriver
+implementation easier, but are required to catch up with the previously reported
+larger value within a reasonable period. Upon observing a value lower than what
+was previously read, userspace is expected to stay with that larger previousDocumentation/gpu/drm-usage-stats.rst new file +5
-0+value until a monotonic update is seen. + +- drm-memory-<str>: <uint> [KiB|MiB] + +Each possible memory type which can be used to store buffer objectsby the
+GPU in question shall be given a stable and unique name to be returned as theDocumentation/gpu/drm-usage-stats.rst new file +3
-0+string here. + +Value shall reflect the amount of storage currently consumed by thebuffer
Documentation/gpu/drm-usage-stats.rst new file +3
-0+object belong to this client, in the respective memory region. + +Default unit shall be bytes with optional unit specifiers of 'KiB' or'MiB'
Documentation/gpu/drm-usage-stats.rst new file +1
-0+indicating kibi- or mebi-bytes.Documentation/gpu/index.rst +0
-0@@ -10,6 +10,7 @@ Linux GPU Driver Developer's Guidedrm-kms
drm-kms-helpers
drm-uapi
+ drm-usage-stats
driver-uapi
drm-client
drivers
Christian König
maintainerRe: [RFC 6/8] drm: Document fdinfo format specification
Am 24.08.21 um 11:25 schrieb Tvrtko Ursulin:
Quoted 34 lines · Christian König
Quoted 32 lines
Am 23.08.21 um 13:28 schrieb Tvrtko Ursulin:
Quoted 30 lines
From: Tvrtko Ursulin <[email protected]>
Proposal to standardise the fdinfo text format as optionally output by DRM drivers.
Idea is that a simple but, well defined, spec will enable generic userspace tools to be written while at the same time avoiding a more heavy handed approach of adding a mid-layer to DRM.
i915 implements a subset of the spec, everything apart from the memory stats currently, and a matching
intel_gpu_toptool exists.Open is to see if AMD can migrate to using the proposed GPU utilisation key-value pairs, or if they are not workable to see whether to go vendor specific, or if a standardised alternative can be found which is workable for both drivers.
Same for the memory utilisation key-value pairs proposal.
v2:
* Update for removal of name and pid.v3:
* 'Drm-driver' tag will be obtained from struct drm_driver.name. (Daniel)Signed-off-by Tvrtko Ursulin <[email protected]>Cc David M Nieto <[email protected]>Cc Christian König <[email protected]>Cc Daniel Vetter <[email protected]>Cc Daniel Stone <[email protected]>
Quoted 7 lines
Quoted 1 line
I'm not an expert on that stuff, but as far as I can see this totally makes sense to me.
Thanks!
Quoted 1 line
Feel free to add an Acked-by: Christian König <[email protected]> to those three patches.
However note that the last one is full of TODO markers, including the commit message, where I was hoping to nudge the feature owners of the amdgpu side to fill in the blanks in my understanding of how things work over there. At least the different semantics need to be documented so random userspace can interpret the amdgpu values correctly.
Yeah, that's the reason why I only dare to give an ack. David is driving this at AMD.
If you ask me exposing ns like the i915 wants to do is perfectly sufficient for us as well.
Regards,
Christian.
Quoted 159 lines
Or alternatively I drop the last patch and if someone is interested they can resurrect and complete it at their leisure.
Just not sure how Daniel would accept this since his push was to gate i915 addition behind a drive for common solution.
Regards,
Tvrtko
Quoted 150 lines
Quoted 149 lines
---
Documentation/gpu/drm-usage-stats.rst| 97
+++++++++++++++++++++++++++
Documentation/gpu/index.rst | 1 +2 files changed, 98 insertions(+)create mode 100644
Documentation/gpu/drm-usage-stats.rstDocumentation/gpu/drm-usage-stats.rst new file +7
-0@@ -0,0 +1,97 @@ +.. _drm-client-usage-stats: + +====================== +DRM client usage stats +====================== + +DRM drivers can choose to export partly standardised text outputvia the
+fops->show_fdinfo()as part of the driver specific file operations registeredDocumentation/gpu/drm-usage-stats.rst new file +3
-0+in the `struct drm_driver` object registered with the DRM core. + +One purpose of this output is to enable writing as generic aspracticaly
Documentation/gpu/drm-usage-stats.rst new file +3
-0+feasible `top(1)` like userspace monitoring tools. + +Given the differences between various DRM drivers the specificationof the
+output is split between common and driver specific parts. Having said that,
+wherever possible effort should still be made to standardise as much asDocumentation/gpu/drm-usage-stats.rst new file +9
-0+possible. + +File format specification +========================= + +- File shall contain one key value pair per one line of text. +- Colon character (`:`) must be used to delimit keys and values. +- All keys shall be prefixed with `drm-`. +- Whitespace between the delimiter and first non-whitespacecharacter shall be
+ ignored when parsing.+- Neither keys or values are allowed to contain whitespace characters. +- Numerical key value pairs can end with optional unit string. +- Data type of the value is fixed as defined in the specification.Documentation/gpu/drm-usage-stats.rst new file +13
-0+ +Key types +--------- + +1. Mandatory, fully standardised. +2. Optional, fully standardised. +3. Driver specific. + +Data types +---------- + +- <uint> - Unsigned integer without defining the maximum value. +- <str> - String excluding any above defined reserved characters orwhitespace.
Documentation/gpu/drm-usage-stats.rst new file +7
-0+ +Mandatory fully standardised keys +--------------------------------- + +- drm-driver: <str> + +String shall contain the name this driver registered as via therespective
+struct drm_driverdata structure.Documentation/gpu/drm-usage-stats.rst new file +7
-0+ +Optional fully standardised keys +-------------------------------- + +- drm-pdev: <aaaa:bb.cc.d> + +For PCI devices this should contain the PCI slot address of thedevice in
Documentation/gpu/drm-usage-stats.rst new file +5
-0+question. + +- drm-client-id: <uint> + +Unique value relating to the open DRM file descriptor used todistinguish
+duplicated and shared file descriptors. Conceptually the value should map 1:1Documentation/gpu/drm-usage-stats.rst new file +3
-0+to the in kernel representation of `struct drm_file` instances. + +Uniqueness of the value shall be either globally unique, or uniquewithin the
+scope of each device, in which casedrm-pdevshall be present as well.Documentation/gpu/drm-usage-stats.rst new file +2
-0+ +Userspace should make sure to not double account any usagestatistics by using
+the above described criteria in order to associate data to individual clients.Documentation/gpu/drm-usage-stats.rst new file +4
-0+ +- drm-engine-<str>: <uint> ns + +GPUs usually contain multiple execution engines. Each shall begiven a stable
+and unique name (str), with possible values documented in the driver specificDocumentation/gpu/drm-usage-stats.rst new file +3
-0+documentation. + +Value shall be in specified time units which the respective GPUengine spent
Documentation/gpu/drm-usage-stats.rst new file +3
-0+busy executing workloads belonging to this client. + +Values are not required to be constantly monotonic if it makes thedriver
+implementation easier, but are required to catch up with the previously reported
+larger value within a reasonable period. Upon observing a value lower than what
+was previously read, userspace is expected to stay with that larger previousDocumentation/gpu/drm-usage-stats.rst new file +5
-0+value until a monotonic update is seen. + +- drm-memory-<str>: <uint> [KiB|MiB] + +Each possible memory type which can be used to store buffer objectsby the
+GPU in question shall be given a stable and unique name to be returned as theDocumentation/gpu/drm-usage-stats.rst new file +3
-0+string here. + +Value shall reflect the amount of storage currently consumed by thebuffer
Documentation/gpu/drm-usage-stats.rst new file +3
-0+object belong to this client, in the respective memory region. + +Default unit shall be bytes with optional unit specifiers of 'KiB'or 'MiB'
Documentation/gpu/drm-usage-stats.rst new file +1
-0+indicating kibi- or mebi-bytes.Documentation/gpu/index.rst +0
-0@@ -10,6 +10,7 @@ Linux GPU Driver Developer's Guidedrm-kms
drm-kms-helpers
drm-uapi
+ drm-usage-stats
driver-uapi
drm-client
drivers
RFC 7/8 drm/i915: Expose client engine utilisation via fdinfo
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Similar to AMD commit
874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the infrastructure added in previous patches, we add basic client info and GPU engine utilisation for i915.
Example of the output:
pos: 0
flags: 0100002
mnt_id: 21
drm-driver: i915
drm-pdev: 0000:00:02.0
drm-client-id: 7 drm-engine-render: 9288864723 ns drm-engine-copy: 2035071108 ns drm-engine-video: 0 ns
drm-engine-video-enhance: 0 ns
v2:
* Update for removal of name and pid.
v3:
* Use drm_driver.name.
--- Documentation/gpu/drm-usage-stats.rst | 6 +++ Documentation/gpu/i915.rst | 27 ++++++++++ drivers/gpu/drm/i915/i915_drm_client.c | 73 ++++++++++++++++++++++++++ drivers/gpu/drm/i915/i915_drm_client.h | 4 ++ drivers/gpu/drm/i915/i915_drv.c | 3 ++ 5 files changed, 113 insertions(+)
Documentation/gpu/drm-usage-stats.rst +6 -0
@@ -95,3 +95,9 @@ object belong to this client, in the respective memory region. Default unit shall be bytes with optional unit specifiers of 'KiB' or 'MiB' indicating kibi- or mebi-bytes. + +=============================== +Driver specific implementations +=============================== + +:ref:`i915-usage-stats`
Documentation/gpu/i915.rst +27 -0
@@ -701,3 +701,30 @@ The style guide for ``i915_reg.h``. .. kernel-doc:: drivers/gpu/drm/i915/i915_reg.h :doc: The i915 register macro definition style guide + +.. _i915-usage-stats: + +i915 DRM client usage stats implementation +========================================== + +The drm/i915 driver implements the DRM client usage stats specification as +documented in :ref:`drm-client-usage-stats`. + +Example of the output showing the implemented key value pairs and entirety of +the currenly possible format options: + +:: + + pos: 0 + flags: 0100002 + mnt_id: 21 + drm-driver: i915 + drm-pdev: 0000:00:02.0 + drm-client-id: 7 + drm-engine-render: 9288864723 ns + drm-engine-copy: 2035071108 ns + drm-engine-video: 0 ns + drm-engine-video-enhance: 0 ns + +Possible `drm-engine-` key names are: `render`, `copy`, `video` and +`video-enhance`.
drivers/gpu/drm/i915/i915_drm_client.c +73 -0
82 lines not on this page · raw message
drivers/gpu/drm/i915/i915_drm_client.h +4 -0
@@ -57,6 +57,10 @@ static inline void i915_drm_client_put(struct i915_drm_client *client)struct i915_drm_client *i915_drm_client_add (struct i915_drm_clients *clients); +#ifdef CONFIG_PROC_FS +void i915_drm_client_fdinfo (struct seq_file *m,struct file *f); +#endif +void i915_drm_clients_fini (struct i915_drm_clients *clients);#endif /* !__I915_DRM_CLIENT_H__ */
drivers/gpu/drm/i915/i915_drv.c +3 -0
@@ -1713,6 +1713,9 @@ static const struct file_operations i915_driver_fops = { .read = drm_read, .compat_ioctl = i915_ioc32_compat_ioctl, .llseek = noop_llseek, +#ifdef CONFIG_PROC_FS + .show_fdinfo = i915_drm_client_fdinfo, +#endif }; static int
Signature · 1 line
2.30.2
RFC 8/8 drm/amdgpu: Convert to common fdinfo format
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Convert fdinfo format to one documented in drm-usage-stats.rst.
Opens:
* Does it work for AMD?
* What are the semantics of AMD engine utilisation reported in percents? Can it align with what i915 does or needs to document the alternative in the specification document?
--- Documentation/gpu/amdgpu.rst | 26 ++++++++++++++++++++++ Documentation/gpu/drm-usage-stats.rst | 7 +++++- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 19 +++++++++++----- 3 files changed, 46 insertions(+), 6 deletions(-)
Documentation/gpu/amdgpu.rst +26 -0
@@ -322,3 +322,29 @@ smartshift_bias .. kernel-doc:: drivers/gpu/drm/amd/pm/amdgpu_pm.c :doc: smartshift_bias + +.. _amdgpu-usage-stats: + +amdgpu DRM client usage stats implementation +============================================ + +The amdgpu driver implements the DRM client usage stats specification as +documented in :ref:`drm-client-usage-stats`. + +Example of the output showing the implemented key value pairs and entirety of +the currenly possible format options: + +:: + + pos: 0 + flags: 0100002 + mnt_id: 21 + drm-driver: amdgpu + drm-pdev: 0000:00:02.0 + drm-client-id: 7 + drm-engine-... TODO + drm-memory-... TODO + +Possible `drm-engine-` key names are: ``,... TODO. + +Possible `drm-memory-` key names are: ``,... TODO.
Documentation/gpu/drm-usage-stats.rst +6 -1
@@ -69,7 +69,7 @@ scope of each device, in which case `drm-pdev` shall be present as well. Userspace should make sure to not double account any usage statistics by using the above described criteria in order to associate data to individual clients. -- drm-engine-<str>: <uint> ns +- drm-engine-<str>: <uint> [ns|%] GPUs usually contain multiple execution engines. Each shall be given a stable and unique name (str), with possible values documented in the driver specific
@@ -84,6 +84,9 @@ larger value within a reasonable period. Upon observing a value lower than what was previously read, userspace is expected to stay with that larger previous value until a monotonic update is seen. +Where time unit is given as a percentage...[AMD folks to fill the semantics +and interpretation of that]... + - drm-memory-<str>: <uint> [KiB|MiB] Each possible memory type which can be used to store buffer objects by the
@@ -101,3 +104,5 @@ Driver specific implementations =============================== :ref:`i915-usage-stats` + +:ref:`amdgpu-usage-stats`
drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c +14 -5
@@ -32,6 +32,7 @@#include <drm/amdgpu_drm.h> #include <drm/drm_debugfs.h> +#include <drm/drm_drv.h> #include "amdgpu.h" #include "amdgpu_vm.h"
@@ -76,11 +77,19 @@ void amdgpu_show_fdinfo(struct seq_file *m, struct file *f) }amdgpu_vm_get_memory (&fpriv->vm, &vram_mem, >t_mem, &cpu_mem);amdgpu_bo_unreserve (fpriv->vm.root.bo); -seq_printf (m,"pdev:\t%04x:%02x:%02x.%d\npasid:\t%u\n" , domain, bus, + +/* +* ****************************************************************** +* For text output format description please see drm-usage-stats.rst! +* ****************************************************************** +*/ + +seq_printf (m,"drm-driver:\t%s\n" , file->minor->dev->driver->name); +seq_printf (m,"drm-pdev:\t%04x:%02x:%02x.%d\npasid:\t%u\n" , domain, bus, dev, fn, fpriv->vm.pasid); -seq_printf (m,"vram mem:\t%llu kB\n" , vram_mem/1024UL ); -seq_printf (m,"gtt mem:\t%llu kB\n" , gtt_mem/1024UL ); -seq_printf (m,"cpu mem:\t%llu kB\n" , cpu_mem/1024UL ); +seq_printf (m,"drm-memory-vram:\t%llu KiB\n" , vram_mem/1024UL ); +seq_printf (m,"drm-memory-gtt:\t%llu KiB\n" , gtt_mem/1024UL ); +seq_printf (m,"drm-memory-cpu:\t%llu KiB\n" , cpu_mem/1024UL );for (i =0 ; i <AMDGPU_HW_IP_NUM ; i++) {uint32_t count = amdgpu_ctx_num_entities[i];int idx =0 ;
@@ -96,7 +105,7 @@ void amdgpu_show_fdinfo(struct seq_file *m, struct file *f) perc =div64_u64 (10000 * total, min); frac = perc %100 ; -seq_printf (m,"%s%d:\t%d.%d%%\n" , +seq_printf (m,"drm-engine-%s%d:\t%d.%d %%\n" , amdgpu_ip_name[i], idx, perc/100 , frac); }
Signature · 1 line
2.30.2
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per client GPU stats (rev3)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: Per client GPU stats (rev3)
URL : https://patchwork.freedesktop.org/series/92574/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 49a66f85df5f drm/i915: Explicitly track DRM clients -:88: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #88: new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 231 lines checked 7d9a4a3e14a9 drm/i915: Make GEM contexts track DRM clients dacba354d7fa drm/i915: Track runtime spent in closed and unreachable GEM contexts 0d712486d694 drm/i915: Track all user contexts per client 8c26c910fb9e drm/i915: Track context current active time
-:139: WARNING:LINE_SPACING: Missing a blank line after declarations #139: FILE: drivers/gpu/drm/i915/gt/intel_context_types.h:142:
+ u32 last;
+ I915_SELFTEST_DECLARE(u32 num_underflow);
total: 0 errors, 1 warnings, 0 checks, 296 lines checked34192e190c21 drm: Document fdinfo format specification
-:39: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #39:
new file mode 100644
-:44: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #44: FILE: Documentation/gpu/drm-usage-stats.rst:1:
+.. _drm-client-usage-stats:
total: 0 errors, 2 warnings, 0 checks, 104 lines checkedf2e468ae7d93 drm/i915: Expose client engine utilisation via fdinfo
-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 874442541133 ("drm/amdgpu: Add show_fdinfo() interface")' #10:
874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the
total: 1 errors, 0 warnings, 0 checks, 140 lines checked 7da55165a74d drm/amdgpu: Convert to common fdinfo format
-:111: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #111: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c:89:
+ seq_printf(m, "drm-pdev:\t%04x:%02x:%02x.%d\npasid:\t%u\n", domain, bus,
dev, fn, fpriv->vm.pasid);
-:115: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #115: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c:90:
+ seq_printf(m, "drm-memory-vram:\t%llu KiB\n", vram_mem/1024UL);
^
-:116: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #116: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c:91:
+ seq_printf(m, "drm-memory-gtt:\t%llu KiB\n", gtt_mem/1024UL);
^
-:117: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #117: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c:92:
+ seq_printf(m, "drm-memory-cpu:\t%llu KiB\n", cpu_mem/1024UL);
^
-:127: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #127: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c:109:
+ seq_printf(m, "drm-engine-%s%d:\t%d.%d %%\n",
amdgpu_ip_name[i],
total: 0 errors, 0 warnings, 5 checks, 89 lines checked
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Per client GPU stats (rev3)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: Per client GPU stats (rev3)
URL : https://patchwork.freedesktop.org/series/92574/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +drivers/gpu/drm/i915/display/intel_display.c:1902:21: expected struct i915_vma *[assigned] vma +drivers/gpu/drm/i915/display/intel_display.c:1902:21: got void [noderef] __iomem *[assigned] iomem +drivers/gpu/drm/i915/display/intel_display.c:1902:21: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gem/i915_gem_context.c:1406:34: expected struct i915_address_space *vm +drivers/gpu/drm/i915/gem/i915_gem_context.c:1406:34: got struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/i915_gem_context.c:1406:34: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: expected struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: got struct i915_address_space * +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: expected struct i915_address_space *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: got struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_reset.c:1392:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/gt/intel_ring_submission.c:1268:24: warning: Using plain integer as NULL pointer +drivers/gpu/drm/i915/i915_perf.c:1442:15: warning: memset with byte count of 16777216 +drivers/gpu/drm/i915/i915_perf.c:1496:15: warning: memset with byte count of 16777216 +./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080) +./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080) +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined
Patchwork
CI[Intel-gfx] ✗ Fi.CI.DOCS: warning for Per client GPU stats (rev3)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: Per client GPU stats (rev3)
URL : https://patchwork.freedesktop.org/series/92574/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:367: warning: Function parameter or member 'client_link' not described in 'i915_gem_context'
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for Per client GPU stats (rev3)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: Per client GPU stats (rev3)
URL : https://patchwork.freedesktop.org/series/92574/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10506 -> Patchwork_20873
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/index.html
Known issues
------------
Here are the changes found in Patchwork_20873 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +22 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/fi-kbl-soraka/igt@gem_exec_fence@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/fi-kbl-soraka/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][3] ([i915#1886] / [i915#2291])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [fdo#111827]) +8 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/fi-kbl-soraka/igt@[email protected]
- fi-icl-u2: [PASS][5] -> [DMESG-WARN][6] ([i915#2868])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-icl-u2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/fi-icl-u2/igt@[email protected]
* igt@kms_flip@basic-plain-flip:
- fi-rkl-11600: NOTRUN -> [SKIP][7] ([i915#3669])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/fi-rkl-11600/igt@[email protected]
* igt@kms_force_connector_basic@force-connector-state:
- fi-rkl-11600: [PASS][8] -> [FAIL][9] ([i915#3983])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-rkl-11600/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/fi-rkl-11600/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#533])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/fi-kbl-soraka/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [DMESG-WARN][11] ([i915#3958]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
#### Warnings ####
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [SKIP][13] ([fdo#109271]) -> [FAIL][14] ([i915#579])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-kbl-guc/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/fi-kbl-guc/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966
[i915#3669]: https://gitlab.freedesktop.org/drm/intel/issues/3669
[i915#3958]: https://gitlab.freedesktop.org/drm/intel/issues/3958
[i915#3983]: https://gitlab.freedesktop.org/drm/intel/issues/3983
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
Participating hosts (38 -> 33)
------------------------------
Additional (1): fi-kbl-soraka
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-tgl-1115g4 fi-bsw-cyan fi-bdw-samus bat-jsl-1
Build changes
-------------
* Linux: CI_DRM_10506 -> Patchwork_20873
CI-20190529: 20190529
CI_DRM_10506: d6681095a2aa987fa64c6d0ed991674745589c06 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6181: e7a9ab2f21a67b1ab3f4093ec0bd775647308ba6 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20873: 7da55165a74dbf0e3c3c6225a56aeb69431c7eaf @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
7da55165a74d drm/amdgpu: Convert to common fdinfo format f2e468ae7d93 drm/i915: Expose client engine utilisation via fdinfo 34192e190c21 drm: Document fdinfo format specification8c26c910fb9e drm/i915: Track context current active time 0d712486d694 drm/i915: Track all user contexts per client dacba354d7fa drm/i915: Track runtime spent in closed and unreachable GEM contexts 7d9a4a3e14a9 drm/i915: Make GEM contexts track DRM clients 49a66f85df5f drm/i915: Explicitly track DRM clients
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for Per client GPU stats (rev3)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: Per client GPU stats (rev3)
URL : https://patchwork.freedesktop.org/series/92574/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10506_full -> Patchwork_20873_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_20873_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-snb7/igt@[email protected]
* igt@gem_eio@in-flight-1us:
- shard-skl: [PASS][2] -> [TIMEOUT][3] ([i915#3063])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl2/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl8/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][4] -> [FAIL][5] ([i915#2846])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk9/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-glk7/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][6] ([i915#2846])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl6/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-tglb3/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-tglb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk7/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-glk1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][11] ([i915#2842]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-iclb1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_suspend@basic-s3:
- shard-apl: NOTRUN -> [DMESG-WARN][12] ([i915#180])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl3/igt@[email protected]
* igt@gem_media_vme:
- shard-skl: NOTRUN -> [SKIP][13] ([fdo#109271]) +58 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl4/igt@gem_media_vme.html
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][14] ([i915#2658])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl6/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-skl: NOTRUN -> [WARN][15] ([i915#2658])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl7/igt@[email protected]
* igt@gem_userptr_blits@vma-merge:
- shard-apl: NOTRUN -> [FAIL][16] ([i915#3318])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl3/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][17] ([i915#1886] / [i915#2291])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl7/igt@i915_selftest@live@gt_pm.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][18] ([i915#3722])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl7/igt@[email protected]
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#3886]) +4 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl4/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#3886]) +5 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl3/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs:
- shard-snb: NOTRUN -> [SKIP][21] ([fdo#109271]) +445 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-snb7/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html
* igt@kms_chamelium@hdmi-hpd-fast:
- shard-snb: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +24 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-snb7/igt@[email protected]
* igt@kms_chamelium@vga-hpd:
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +15 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl6/igt@[email protected]
* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: [PASS][24] -> [DMESG-WARN][25] ([i915#1982])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl9/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl4/igt@[email protected]
* igt@kms_color_chamelium@pipe-d-degamma:
- shard-skl: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +5 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl4/igt@[email protected]
* igt@kms_content_protection@legacy:
- shard-apl: NOTRUN -> [TIMEOUT][27] ([i915#1319])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl3/igt@[email protected]
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][28] ([i915#2105])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl6/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: NOTRUN -> [FAIL][29] ([i915#2346])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl7/igt@[email protected]
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a:
- shard-iclb: [PASS][30] -> [SKIP][31] ([i915#3788])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb1/igt@kms_dither@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-iclb2/igt@kms_dither@[email protected]
* igt@kms_dsc@basic-dsc-enable@edp-1-pipe-c:
- shard-iclb: NOTRUN -> [DMESG-WARN][32] ([i915#1226]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-iclb2/igt@kms_dsc@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [PASS][33] -> [FAIL][34] ([i915#79])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl9/igt@kms_flip@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl9/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][35] -> [DMESG-WARN][36] ([i915#180]) +7 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-kbl2/igt@kms_flip@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-kbl6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-kbl: [PASS][37] -> [DMESG-WARN][38] ([i915#165] / [i915#180])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-kbl2/igt@kms_flip@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-kbl6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [PASS][39] -> [DMESG-WARN][40] ([i915#180]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl2/igt@kms_flip@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl7/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@a-edp1:
- shard-skl: [PASS][41] -> [INCOMPLETE][42] ([i915#146] / [i915#198] / [i915#2910])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl6/igt@kms_flip@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl5/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: NOTRUN -> [FAIL][43] ([i915#2122])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#2672])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][45] -> [FAIL][46] ([i915#1188])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl5/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][47] ([i915#265])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][48] -> [FAIL][49] ([fdo#108145] / [i915#265]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl9/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl9/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][50] ([fdo#108145] / [i915#265])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][51] ([fdo#108145] / [i915#265]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl3/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#658])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl6/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-skl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#658]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl4/igt@[email protected]
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][54] -> [SKIP][55] ([fdo#109441]) +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#2437])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl3/igt@[email protected]
* igt@perf@short-reads:
- shard-skl: [PASS][57] -> [FAIL][58] ([i915#51])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl2/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl8/igt@[email protected]
* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271]) +161 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl3/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html
* igt@sysfs_clients@busy:
- shard-skl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2994])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl7/igt@[email protected]
* igt@sysfs_clients@fair-3:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#2994])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl7/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][62] ([i915#2842]) -> [PASS][63] +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-kbl4/igt@gem_exec_fair@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-kbl4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][64] ([i915#2842]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk8/igt@gem_exec_fair@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-glk5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][66] ([i915#2849]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb1/igt@gem_exec_fair@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-iclb8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-wc-read:
- shard-apl: [DMESG-WARN][68] ([i915#165]) -> [PASS][69] +12 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl1/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl1/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][70] ([i915#3921]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-snb5/igt@i915_selftest@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-snb7/igt@i915_selftest@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [DMESG-WARN][72] ([i915#180]) -> [PASS][73] +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl8/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl7/igt@[email protected]
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-glk: [DMESG-WARN][74] ([i915#118] / [i915#95]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk1/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-glk5/igt@[email protected]
* igt@kms_color@pipe-c-ctm-0-75:
- shard-skl: [DMESG-WARN][76] ([i915#1982]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl8/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl1/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-apl: [DMESG-WARN][78] ([i915#203]) -> [PASS][79] +8 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl1/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl1/igt@[email protected]
* igt@kms_flip@flip-vs-absolute-wf_vblank@b-edp1:
- shard-skl: [FAIL][80] ([i915#2122]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl4/igt@kms_flip@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl8/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [FAIL][82] ([i915#79]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk4/igt@kms_flip@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-glk7/igt@kms_flip@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][84] ([i915#1188]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl6/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl5/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid:
- shard-apl: [DMESG-WARN][86] ([i915#165] / [i915#180] / [i915#62]) -> [PASS][87] +23 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl1/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][88] ([fdo#108145] / [i915#265]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl8/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl1/igt@[email protected]
* igt@kms_plane_cursor@pipe-a-overlay-size-64:
- shard-apl: [DMESG-WARN][90] ([i915#180] / [i915#203] / [i915#62]) -> [PASS][91] +2 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl1/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl1/igt@[email protected]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][92] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb6/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-iclb2/igt@[email protected]
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][94] ([fdo#109441]) -> [PASS][95] +3 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb1/igt@kms_psr@psr2_cursor_plane_onoff.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][96] ([i915#180] / [i915#295]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl3/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl1/igt@[email protected]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-skl: [INCOMPLETE][98] ([i915#198] / [i915#2828]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl3/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl7/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-glk: [FAIL][100] ([i915#1542]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk8/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-glk7/igt@[email protected]
* igt@perf@polling-small-buf:
- shard-skl: [FAIL][102] ([i915#1722]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl7/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl10/igt@[email protected]
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][104] ([i915#658]) -> [SKIP][105] ([i915#588])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb6/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-iclb2/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][106] ([i915#1804] / [i915#2684]) -> [WARN][107] ([i915#2684])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb4/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-iclb5/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: [FAIL][108] ([i915#3743]) -> [FAIL][109] ([i915#3722])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl2/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl7/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-iclb: [SKIP][110] ([i915#2920]) -> [SKIP][111] ([i915#658])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb2/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-iclb3/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-iclb: [SKIP][112] ([i915#658]) -> [SKIP][113] ([i915#2920]) +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb1/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: [FAIL][114] ([i915#3002] / [i915#3363]) -> ([FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-kbl7/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-kbl4/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-kbl6/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-kbl6/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-kbl6/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-kbl6/igt@[email protected]
- shard-apl: ([FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][124], [FAIL][125]) ([i915#180] / [i915#3363])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl2/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl3/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl3/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl8/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl3/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-apl7/igt@[email protected]
- shard-skl: [FAIL][126] ([i915#3002] / [i915#3363]) -> ([FAIL][127], [FAIL][128]) ([i915#1814] / [i915#2029] / [i915#3002] / [i915#3363])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl8/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl3/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/shard-skl3/igt@[email protected]
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2828]: https://gitlab.freedesktop.org/drm/intel/issues/2828
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2910]: https://gitlab.freedesktop.org/drm/intel/issues/2910
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3722]: https://gitlab.freedesktop.org/drm/intel/issues/3722
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3788]: https://gitlab.freedesktop.org/drm/intel/issues/3788
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 10)
------------------------------
Missing (1): shard-rkl
Build changes
-------------
* Linux: CI_DRM_10506 -> Patchwork_20873
CI-20190529: 20190529
CI_DRM_10506: d6681095a2aa987fa64c6d0ed991674745589c06 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6181: e7a9ab2f21a67b1ab3f4093ec0bd775647308ba6 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20873: 7da55165a74dbf0e3c3c6225a56aeb69431c7eaf @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20873/index.html