Skip to content

RFC Per client GPU stats

Tvrtko Ursulin dri-devel intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 3 repliesIn review

v2 from the cover letter

* Added prototype of possible amdgpu changes and spec updates to align with the common spec.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/i915: Explicitly track DRM clientsdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/i915_drm_client.c drivers/gpu/drm/i915/i915_drm_client.h +3 more+150 -50 replies
2/8drm/i915: Make GEM contexts track DRM clientsdrivers/gpu/drm/i915/gem/i915_gem_context.c drivers/gpu/drm/i915/gem/i915_gem_context_types.h+8 -00 replies
3/8drm/i915: Track runtime spent in closed and unreachable GEM contextsdrivers/gpu/drm/i915/gem/i915_gem_context.c drivers/gpu/drm/i915/i915_drm_client.h+30 -20 replies
4/8drm/i915: Track all user contexts per clientdrivers/gpu/drm/i915/gem/i915_gem_context.c drivers/gpu/drm/i915/gem/i915_gem_context_types.h drivers/gpu/drm/i915/i915_drm_client.c +1 more+22 -00 replies
5/8drm/i915: Track context current active timedrivers/gpu/drm/i915/gt/intel_context.c drivers/gpu/drm/i915/gt/intel_context.h drivers/gpu/drm/i915/gt/intel_context_types.h +7 more+116 -490 replies
6/8drm: Document fdinfo format specificationDocumentation/gpu/drm-usage-stats.rst Documentation/gpu/index.rst+98 -03 replies
7/8drm/i915: Expose client engine utilisation via fdinfoDocumentation/gpu/drm-usage-stats.rst Documentation/gpu/i915.rst drivers/gpu/drm/i915/i915_drm_client.c +2 more+113 -00 replies
8/8drm/amdgpu: Convert to common fdinfo formatDocumentation/gpu/amdgpu.rst Documentation/gpu/drm-usage-stats.rst drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c+46 -60 replies

Reviews trailers per patch

5 of 8 patches have a Reviewed-by or Acked-by.

PatchChris WilsonAravind Iddamsetty
1/8R-b R-b
2/8R-b R-b
3/8R-b R-b
4/8R-b R-b
5/8R-b R-b
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 0/8] Per client GPU stats

From: Tvrtko Ursulin <[email protected]>

Same old work but now rebased and series ending with some DRM docs proposing the common specification which should enable nice common userspace tools to be written.

For the moment I only have intel_gpu_top converted to use this and that seems to work okay.

v2:
* Added prototype of possible amdgpu changes and spec updates to align with the common spec.

v3:
* Documented that 'drm-driver' tag shall correspond with struct drm_driver.name.

Tvrtko Ursulin (8):
drm/i915: Explicitly track DRM clients
drm/i915: Make GEM contexts track DRM clients
drm/i915: Track runtime spent in closed and unreachable GEM contexts drm/i915: Track all user contexts per client
drm/i915: Track context current active time
drm: Document fdinfo format specification
drm/i915: Expose client engine utilisation via fdinfo drm/amdgpu: Convert to common fdinfo format

 Documentation/gpu/amdgpu.rst                  |  26 ++++
 Documentation/gpu/drm-usage-stats.rst         | 108 +++++++++++++
 Documentation/gpu/i915.rst                    |  27 ++++
 Documentation/gpu/index.rst                   |   1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c    |  19 ++-
 drivers/gpu/drm/i915/Makefile                 |   5 +-
 drivers/gpu/drm/i915/gem/i915_gem_context.c   |  42 ++++-
 .../gpu/drm/i915/gem/i915_gem_context_types.h |   6 +
 drivers/gpu/drm/i915/gt/intel_context.c       |  27 +++-
 drivers/gpu/drm/i915/gt/intel_context.h       |  15 +-
 drivers/gpu/drm/i915/gt/intel_context_types.h |  24 ++-
 .../drm/i915/gt/intel_execlists_submission.c  |  23 ++-
 .../gpu/drm/i915/gt/intel_gt_clock_utils.c    |   4 +
 drivers/gpu/drm/i915/gt/intel_lrc.c           |  27 ++--
 drivers/gpu/drm/i915/gt/intel_lrc.h           |  24 +++
 drivers/gpu/drm/i915/gt/selftest_lrc.c        |  10 +-
 drivers/gpu/drm/i915/i915_drm_client.c        | 143 ++++++++++++++++++
 drivers/gpu/drm/i915/i915_drm_client.h        |  66 ++++++++
 drivers/gpu/drm/i915/i915_drv.c               |   9 ++
 drivers/gpu/drm/i915/i915_drv.h               |   5 +
 drivers/gpu/drm/i915/i915_gem.c               |  21 ++-
 drivers/gpu/drm/i915/i915_gpu_error.c         |   9 +-
 drivers/gpu/drm/i915/i915_gpu_error.h         |   2 +-
 23 files changed, 582 insertions(+), 61 deletions(-)
 create mode 100644 Documentation/gpu/drm-usage-stats.rst
 create mode 100644 drivers/gpu/drm/i915/i915_drm_client.c
 create mode 100644 drivers/gpu/drm/i915/i915_drm_client.h
Signature · 1 line
2.30.2