Skip to contentSkip to conversation

perf tools: Add missing newline at the end of file

PATCH Applied Nghia Le 3 participants 3 messages Aug 24, 2021 perf events

lore
Share & tools
lore

Nghia Le

author
#0 lore raw

PATCH 1/1 perf tools: Add missing newline at the end of file

Add missing newline at the end of file parse-sublevel-options.h. Thus removing relevant warning reported by checkpatch.

---
 tools/perf/util/parse-sublevel-options.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/parse-sublevel-options.h +1 -1
index 9b9efcc2aaad..578b18ef03bb 100644
@@ -8,4 +8,4 @@ struct sublevel_option {
 
 int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);
 
-#endif
\ No newline at end of file
+#endif
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Nghia Le

Add missing newline at the end of file parse-sublevel-options.h. Thus removing relevant warning reported by checkpatch.

This addresses the only instance of a "no newline at the end of the file" throughout the kernel tree.

This is part of a larger effort to identify all rules that checkpatch warns about and that are never false positives (compared to the many rules in checkpatch that are heuristics or are known to be ignored by the current development community and hence, cause many false positives). We could use such rules to be enforced in the submission process.

Lukas
Lukas

Quoted 18 lines
---
 tools/perf/util/parse-sublevel-options.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/parse-sublevel-options.h +1 -2
index 9b9efcc2aaad..578b18ef03bb 100644
@@ -8,4 +8,4 @@ struct sublevel_option {
 
 int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);
 
-#endif
\ No newline at end of file
+#endif
--

2.25.1

maintainer Applied
#2 lore raw

Em Tue, Aug 24, 2021 at 04:37:19PM +0200, Lukas Bulwahn escreveu:

Quoted 8 lines · Nghia Le
Quoted 5 lines

Add missing newline at the end of file parse-sublevel-options.h. Thus removing relevant warning reported by checkpatch.

Thanks, applied.

- Arnaldo

Quoted 30 lines

This addresses the only instance of a "no newline at the end of the file" throughout the kernel tree.

This is part of a larger effort to identify all rules that checkpatch warns about and that are never false positives (compared to the many rules in checkpatch that are heuristics or are known to be ignored by the current development community and hence, cause many false positives). We could use such rules to be enforced in the submission process.

Lukas
Lukas

Quoted 18 lines
---
 tools/perf/util/parse-sublevel-options.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/parse-sublevel-options.h +1 -2
index 9b9efcc2aaad..578b18ef03bb 100644
@@ -8,4 +8,4 @@ struct sublevel_option {
 
 int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);
 
-#endif
\ No newline at end of file
+#endif
--

2.25.1

Signature · 1 line
- Arnaldo