perf tools: Add missing newline at the end of file
PATCH 1/1 perf tools: Add missing newline at the end of file
Add missing newline at the end of file parse-sublevel-options.h. Thus removing relevant warning reported by checkpatch.
--- tools/perf/util/parse-sublevel-options.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/parse-sublevel-options.h +1 -1
@@ -8,4 +8,4 @@ struct sublevel_option {int perf_parse_sublevel_options (const char *str,struct sublevel_option *opts); -#endif +#endif
Signature · 1 line
2.25.1
Quoted 5 lines · Nghia Le
Add missing newline at the end of file
parse-sublevel-options.h. Thus removing relevant warning reported by checkpatch.Signed-off-by Nghia Le <[email protected]>
This addresses the only instance of a "no newline at the end of the file" throughout the kernel tree.
This is part of a larger effort to identify all rules that checkpatch warns about and that are never false positives (compared to the many rules in checkpatch that are heuristics or are known to be ignored by the current development community and hence, cause many false positives). We could use such rules to be enforced in the submission process.
Lukas
Lukas
Quoted 18 lines
--- tools/perf/util/parse-sublevel-options.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/parse-sublevel-options.h +1
-2@@ -8,4 +8,4 @@ struct sublevel_option {int perf_parse_sublevel_options (const char *str,struct sublevel_option *opts); -#endif +#endif --2.25.1
Em Tue, Aug 24, 2021 at 04:37:19PM +0200, Lukas Bulwahn escreveu:
Quoted 8 lines · Nghia Le
Quoted 5 lines
Add missing newline at the end of file
parse-sublevel-options.h. Thus removing relevant warning reported by checkpatch.Signed-off-by Nghia Le <[email protected]>Reviewed-by Lukas Bulwahn <[email protected]>
Thanks, applied.
- Arnaldo
Quoted 30 lines
This addresses the only instance of a "no newline at the end of the file" throughout the kernel tree.
This is part of a larger effort to identify all rules that checkpatch warns about and that are never false positives (compared to the many rules in checkpatch that are heuristics or are known to be ignored by the current development community and hence, cause many false positives). We could use such rules to be enforced in the submission process.
Lukas
LukasQuoted 18 lines
--- tools/perf/util/parse-sublevel-options.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/parse-sublevel-options.h +1
-2@@ -8,4 +8,4 @@ struct sublevel_option {int perf_parse_sublevel_options (const char *str,struct sublevel_option *opts); -#endif +#endif --2.25.1
Signature · 1 line
- Arnaldo