Skip to contentSkip to conversation

staging: r8188eu: core: remove null check before vfree

PATCH In review Saurav Girepunje 4 participants 7 messages Aug 29, 2021 – Sep 4, 2021 Staging

lore
Share & tools
lore

Saurav Girepunje

author
#0 lore raw

PATCH v4 1/1 staging: r8188eu: core: remove null check before vfree

Remove NULL check. NULL check before freeing function is not needed. Correct the indentation.

Signed-off-by Saurav Girepunje <[email protected]>

---

ChangeLog V4:
- Add Change log below --- line

ChangeLog V3:
- Add change log.

ChangeLog V2:
- Correct the indentation.

 drivers/staging/r8188eu/core/rtw_sta_mgt.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/r8188eu/core/rtw_sta_mgt.c +2 -3
index f6dffed53a60..c3600cb1790a 100644
@@ -155,9 +155,8 @@ u32	_rtw_free_sta_priv(struct	sta_priv *pstapriv)
 		spin_unlock_bh(&pstapriv->sta_hash_lock);
 		/*===============================*/
 
-		if (pstapriv->pallocated_stainfo_buf)
-			vfree(pstapriv->pallocated_stainfo_buf);
-		}
+		vfree(pstapriv->pallocated_stainfo_buf);
+	}
 
 	return _SUCCESS;
 }

--
2.32.0

#1 lore raw
Quoted 6 lines · Saurav Girepunje

Remove NULL check. NULL check before freeing function is not needed. Correct the indentation.

Signed-off-by Saurav Girepunje <[email protected]>

---

Quoted 8 lines

ChangeLog V4:
- Add Change log below --- line

ChangeLog V3:
- Add change log.

ChangeLog V2:
- Correct the indentation.

You need "---" here also. So everything what is between

---
here
---

will be ignored when you apply patch. This is good place to write changelog, if you have tested this with real hardware, if you have any guestions about your own implementation etc.

Quoted 23 lines
 drivers/staging/r8188eu/core/rtw_sta_mgt.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/r8188eu/core/rtw_sta_mgt.c +2 -4
index f6dffed53a60..c3600cb1790a 100644
@@ -155,9 +155,8 @@ u32	_rtw_free_sta_priv(struct	sta_priv *pstapriv)
 		spin_unlock_bh(&pstapriv->sta_hash_lock);
 		/*===============================*/
 
-		if (pstapriv->pallocated_stainfo_buf)
-			vfree(pstapriv->pallocated_stainfo_buf);
-		}
+		vfree(pstapriv->pallocated_stainfo_buf);
+	}
 
 	return _SUCCESS;
 }
--

2.32.0

#2 lore raw
Quoted 10 lines · Kari Argillander
Quoted 9 lines · Saurav Girepunje

Remove NULL check. NULL check before freeing function is not needed. Correct the indentation.

Signed-off-by Saurav Girepunje <[email protected]>

---

ChangeLog V4:
- Add Change log below --- line

Quoted 8 lines
Quoted 5 lines

ChangeLog V3:
- Add change log.

ChangeLog V2:
- Correct the indentation.

You need "---" here also.

No. It works fine. I applied it myself with git am just to be 100% sure in case I was missing something.

regards,
dan carpenter