Skip to contentSkip to conversation

clk: imx: use module_platform_driver

PATCH Superseded Miles Chen 2 participants 3 messages Sep 4, 2021

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Miles Chen

author
#0 lore raw

PATCH v2 1/1 clk: imx: use module_platform_driver

Replace builtin_platform_driver_probe with module_platform_driver_probe because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).

Fixes c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
Fixes 1e3121bfe51a ("clk: imx: add imx8qxp lpcg driver")
Cc Stephen Boyd <[email protected]>

---

Change since v1:
Add Fixes tags

---
 drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
 drivers/clk/imx/clk-imx8qxp.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/clk/imx/clk-imx8qxp-lpcg.c +1 -1
index d3e905cf867d..b23758083ce5 100644
@@ -370,7 +370,7 @@ static struct platform_driver imx8qxp_lpcg_clk_driver = {
 	.probe = imx8qxp_lpcg_clk_probe,
 };
 
-builtin_platform_driver(imx8qxp_lpcg_clk_driver);
+module_platform_driver(imx8qxp_lpcg_clk_driver);
 
 MODULE_AUTHOR("Aisheng Dong <[email protected]>");
 MODULE_DESCRIPTION("NXP i.MX8QXP LPCG clock driver");
drivers/clk/imx/clk-imx8qxp.c +1 -1
index c53a688d8ccc..40a2efb1329b 100644
@@ -308,7 +308,7 @@ static struct platform_driver imx8qxp_clk_driver = {
 	},
 	.probe = imx8qxp_clk_probe,
 };
-builtin_platform_driver(imx8qxp_clk_driver);
+module_platform_driver(imx8qxp_clk_driver);
 
 MODULE_AUTHOR("Aisheng Dong <[email protected]>");
 MODULE_DESCRIPTION("NXP i.MX8QXP clock driver");
Signature · 1 line
2.18.0
reviewer
#1 lore raw

Hi Miles,

Quoted 6 lines · Miles Chen

Replace builtin_platform_driver_probe with module_platform_driver_probe because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).

Fixes c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
Fixes 1e3121bfe51a ("clk: imx: add imx8qxp lpcg driver")

The correct Fixes tag would be:

Fixes e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock

driver as module")

Thanks

author
#2 lore raw
Quoted 9 lines · Fabio Estevam

Hi Miles,

Quoted 5 lines · Miles Chen

Replace builtin_platform_driver_probe with module_platform_driver_probe
because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).

Quoted 8 lines
Quoted 2 lines
Fixes c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
Fixes 1e3121bfe51a ("clk: imx: add imx8qxp lpcg driver")

The correct Fixes tag would be:

Fixes e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock

driver as module")

Thanks, I will fix the tag in next patch.

Miles

Quoted 1 line

Thanks