Skip to contentSkip to conversation

clk: imx: use module_platform_driver

PATCH In review Miles Chen 4 participants 7 messages Sep 4, 2021 – Dec 13, 2021

Subsystems (4)
lore
Share & tools
lore

Miles Chen

author
#0 lore raw

PATCH v3 1/1 clk: imx: use module_platform_driver

Replace builtin_platform_driver_probe with module_platform_driver_probe because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).

Fixes e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc Fabio Estevam <[email protected]>
Cc Stephen Boyd <[email protected]>

---

Change since v2:
use correct Fixes tag

Change since v1:
Add Fixes tags

---
 drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
 drivers/clk/imx/clk-imx8qxp.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/clk/imx/clk-imx8qxp-lpcg.c +1 -1
index d3e905cf867d..b23758083ce5 100644
@@ -370,7 +370,7 @@ static struct platform_driver imx8qxp_lpcg_clk_driver = {
 	.probe = imx8qxp_lpcg_clk_probe,
 };
 
-builtin_platform_driver(imx8qxp_lpcg_clk_driver);
+module_platform_driver(imx8qxp_lpcg_clk_driver);
 
 MODULE_AUTHOR("Aisheng Dong <[email protected]>");
 MODULE_DESCRIPTION("NXP i.MX8QXP LPCG clock driver");
drivers/clk/imx/clk-imx8qxp.c +1 -1
index c53a688d8ccc..40a2efb1329b 100644
@@ -308,7 +308,7 @@ static struct platform_driver imx8qxp_clk_driver = {
 	},
 	.probe = imx8qxp_clk_probe,
 };
-builtin_platform_driver(imx8qxp_clk_driver);
+module_platform_driver(imx8qxp_clk_driver);
 
 MODULE_AUTHOR("Aisheng Dong <[email protected]>");
 MODULE_DESCRIPTION("NXP i.MX8QXP clock driver");
Signature · 1 line
2.18.0
reviewer Reviewed-by on v3 1/1
#1 lore raw

Hi Miles,

Quoted 8 lines · Miles Chen

Replace builtin_platform_driver_probe with module_platform_driver_probe because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).

Fixes e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc Fabio Estevam <[email protected]>
Cc Stephen Boyd <[email protected]>
maintainer Reviewed-by on v3 1/1
#2 lore raw
In reply to Miles Chen

Quoting Miles Chen (2021-09-04 16:54:18)

Quoted 9 lines

Replace builtin_platform_driver_probe with module_platform_driver_probe because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).

Fixes e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc Fabio Estevam <[email protected]>
Cc Stephen Boyd <[email protected]>

---

#4 lore raw
Quoted 9 lines · On 21-11-05 13:59:32, [email protected] wrote:

From: Miles Chen <[email protected]>

Hi Stephen,

Quoted 4 lines
Quoted 4 lines
Fixes e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc Fabio Estevam <[email protected]>
Cc Stephen Boyd <[email protected]>
Quoted 4 lines
Quoted 1 line

Thanks for doing the review, I cannot find this patch in clk-imx tree, Would you pick this patch, please?

Sorry for the delay.

Fixes are usually picked up directly by Stephen,
therefore they're not going through clk-imx tree.

Stephen, can you pick this one up please?

Quoted 2 lines

Miles

maintainer
#5 lore raw

Quoting Abel Vesa (2021-11-20 12:37:24)

Quoted 15 lines · On 21-11-05 13:59:32, [email protected] wrote:
Quoted 9 lines

From: Miles Chen <[email protected]>

Hi Stephen,

Quoted 4 lines
Quoted 4 lines
Fixes e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc Fabio Estevam <[email protected]>
Cc Stephen Boyd <[email protected]>
Quoted 4 lines
Quoted 1 line

Thanks for doing the review, I cannot find this patch in clk-imx tree, Would you pick this patch, please?

Quoted 7 lines

Sorry for the delay.

Fixes are usually picked up directly by Stephen,
therefore they're not going through clk-imx tree.

Stephen, can you pick this one up please?

It doesn't look like a very critical fix but ok. I suppose someone could try to use =m for these files?

#6 lore raw
Quoted 18 lines · Stephen Boyd

Quoting Abel Vesa (2021-11-20 12:37:24)

Quoted 17 lines · On 21-11-05 13:59:32, [email protected] wrote:
Quoted 9 lines

From: Miles Chen <[email protected]>

Hi Stephen,

Quoted 4 lines
Quoted 4 lines
Fixes e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock driver as module")
Cc Fabio Estevam <[email protected]>
Cc Stephen Boyd <[email protected]>
Quoted 4 lines
Quoted 1 line

Thanks for doing the review, I cannot find this patch in clk-imx tree, Would you pick this patch, please?

Sorry for the delay.

Quoted 8 lines
Quoted 5 lines

Fixes are usually picked up directly by Stephen,
therefore they're not going through clk-imx tree.

Stephen, can you pick this one up please?

It doesn't look like a very critical fix but ok. I suppose someone could try to use =m for these files?

Yes. I think this is for GKI.