Skip to contentSkip to conversation

MIPS: loongson64: make LOONGSON64 depends on MIPS_FP_SUPPORT

PATCH Superseded Jackie Liu 2 participants 3 messages Sep 13, 2021 MIPS

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Jackie Liu

author
#0 lore raw

PATCH 1/1 MIPS: loongson64: make LOONGSON64 depends on MIPS_FP_SUPPORT

From: Jackie Liu <[email protected]>

mach/loongson64 fails to build when the FPU support is disabled:

arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration] arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’

Fixes ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage")
---
 arch/mips/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/mips/Kconfig +1 -0
index 24e374266fdc..1164c32fd87b 100644
@@ -487,6 +487,7 @@ config MACH_LOONGSON64
 	select ISA
 	select I8259
 	select IRQ_MIPS_CPU
+	select MIPS_FP_SUPPORT
 	select NO_EXCEPT_FILL
 	select NR_CPUS_DEFAULT_64
 	select USE_GENERIC_EARLY_PRINTK_8250
Signature · 1 line
2.25.1
#1 lore raw

Hi, Jackie,

Quoted 15 lines · Jackie Liu

From: Jackie Liu <[email protected]>

mach/loongson64 fails to build when the FPU support is disabled:

arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration] arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’

Quoted 1 line
Fixes ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage")

I suggest moving this config option to CPU_LOONGSON64.

Huacai

Quoted 21 lines
---
 arch/mips/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/mips/Kconfig +1 -1
index 24e374266fdc..1164c32fd87b 100644
@@ -487,6 +487,7 @@ config MACH_LOONGSON64
        select ISA
        select I8259
        select IRQ_MIPS_CPU
+       select MIPS_FP_SUPPORT
        select NO_EXCEPT_FILL
        select NR_CPUS_DEFAULT_64
        select USE_GENERIC_EARLY_PRINTK_8250
--

2.25.1

author
#2 lore raw

Hi, Huacai.

Quoted 18 lines · Huacai Chen

Hi, Jackie,

Quoted 15 lines · Jackie Liu

From: Jackie Liu <[email protected]>

mach/loongson64 fails to build when the FPU support is disabled:

arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration] arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’

Quoted 2 lines
Quoted 1 line
Fixes ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage")

I suggest moving this config option to CPU_LOONGSON64.

Looks correct, thanks for the suggestion.

--
Jackie Liu

Quoted 24 lines

Huacai

Quoted 21 lines
---
  arch/mips/Kconfig | 1 +
  1 file changed, 1 insertion(+)
arch/mips/Kconfig +1 -1
index 24e374266fdc..1164c32fd87b 100644
@@ -487,6 +487,7 @@ config MACH_LOONGSON64
         select ISA
         select I8259
         select IRQ_MIPS_CPU
+       select MIPS_FP_SUPPORT
         select NO_EXCEPT_FILL
         select NR_CPUS_DEFAULT_64
         select USE_GENERIC_EARLY_PRINTK_8250
--

2.25.1