Skip to contentSkip to conversation

MIPS: loongson64: make CPU_LOONGSON64 depends on MIPS_FP_SUPPORT

PATCH Applied Jackie Liu 2 participants 3 messages Sep 13, 2021 – Sep 23, 2021 MIPS

lore
Share & tools
lore

Jackie Liu

author
#0 lore raw

PATCH v4 1/1 MIPS: loongson64: make CPU_LOONGSON64 depends on MIPS_FP_SUPPORT

From: Jackie Liu <[email protected]>

mach/loongson64 fails to build when the FPU support is disabled:

arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration] arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’

Fixes ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage")

---
v1->v2:
move MIPS_FP_SUPPORT from MACH_LOONGSON64 to CPU_LOONGSON64

v2->v3:
add Huacai Chen <[email protected]>'s suggest label.

v3->v4:
update Huacai Chen's email address.

 arch/mips/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/mips/Kconfig +1 -0
index 24e374266fdc..aea3aa16a38e 100644
@@ -1408,6 +1408,7 @@ config CPU_LOONGSON64
 	select MIPS_ASID_BITS_VARIABLE
 	select MIPS_PGD_C0_CONTEXT
 	select MIPS_L1_CACHE_SHIFT_6
+	select MIPS_FP_SUPPORT
 	select GPIOLIB
 	select SWIOTLB
 	select HAVE_KVM
Signature · 1 line
2.25.1
author
#1 lore raw

ping, would anyone take this patch?

Quoted 45 lines · Jackie Liu

From: Jackie Liu <[email protected]>

mach/loongson64 fails to build when the FPU support is disabled:

arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration] arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’

Fixes ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage")

---
v1->v2:
move MIPS_FP_SUPPORT from MACH_LOONGSON64 to CPU_LOONGSON64

v2->v3:
add Huacai Chen <[email protected]>'s suggest label.

v3->v4:
update Huacai Chen's email address.

  arch/mips/Kconfig | 1 +
  1 file changed, 1 insertion(+)
arch/mips/Kconfig +1 -0
index 24e374266fdc..aea3aa16a38e 100644
@@ -1408,6 +1408,7 @@ config CPU_LOONGSON64
  	select MIPS_ASID_BITS_VARIABLE
  	select MIPS_PGD_C0_CONTEXT
  	select MIPS_L1_CACHE_SHIFT_6
+	select MIPS_FP_SUPPORT
  	select GPIOLIB
  	select SWIOTLB
  	select HAVE_KVM
maintainer Applied
#2 lore raw
In reply to Jackie Liu
Quoted 23 lines · Jackie Liu

From: Jackie Liu <[email protected]>

mach/loongson64 fails to build when the FPU support is disabled:

arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration] arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’

Fixes ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage")

---
v1->v2:
move MIPS_FP_SUPPORT from MACH_LOONGSON64 to CPU_LOONGSON64

Quoted 8 lines

v2->v3:
add Huacai Chen <[email protected]>'s suggest label.

v3->v4:
update Huacai Chen's email address.

 arch/mips/Kconfig | 1 +
 1 file changed, 1 insertion(+)

applied to mips-next.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]