Skip to contentSkip to conversation

Revert "arm64: Layerscape: Survive LPI one-way reset workaround"

PATCH In review Tom Rini 5 participants 6 messages Aug 25, 2021 – Oct 24, 2021 Arm (32-bit)

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 Revert "arm64: Layerscape: Survive LPI one-way reset workaround"

Ad-hoc bindings that are not part of the upstream device tree / bindings are not allowed in-tree. Only bindings that are in-progress with upstream and then re-synced once agreed upon are.

This reverts commit af288cb291da3abef6be0875527729296f7de7a0.

---
 arch/arm/cpu/armv8/fsl-layerscape/soc.c | 17 +----------------
 arch/arm/dts/fsl-ls1028a.dtsi           |  6 ------
 arch/arm/dts/fsl-ls1088a.dtsi           |  6 ------
 arch/arm/dts/fsl-ls2080a.dtsi           |  6 ------
 arch/arm/dts/fsl-lx2160a.dtsi           |  6 ------
 5 files changed, 1 insertion(+), 40 deletions(-)
arch/arm/cpu/armv8/fsl-layerscape/soc.c +1 -16
index 42a096854629..166662a64baf 100644
@@ -43,22 +43,7 @@ DECLARE_GLOBAL_DATA_PTR;
 #ifdef CONFIG_GIC_V3_ITS
 int ls_gic_rd_tables_init(void *blob)
 {
-	struct fdt_memory lpi_base;
-	fdt_addr_t addr;
-	fdt_size_t size;
-	int offset, ret;
-
-	offset = fdt_path_offset(gd->fdt_blob, "/syscon@0x80000000");
-	addr = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, offset, "reg",
-						  0, &size, false);
-
-	lpi_base.start = addr;
-	lpi_base.end = addr + size - 1;
-	ret = fdtdec_add_reserved_memory(blob, "lpi_rd_table", &lpi_base, NULL, false);
-	if (ret) {
-		debug("%s: failed to add reserved memory\n", __func__);
-		return ret;
-	}
+	int ret;
 
 	ret = gic_lpi_tables_init();
 	if (ret)
arch/arm/dts/fsl-ls1028a.dtsi +0 -6
index 50f9b527cde1..53b052ed3271 100644
@@ -44,12 +44,6 @@
 					 IRQ_TYPE_LEVEL_LOW)>;
 	};
 
-	gic_lpi_base: syscon@0x80000000 {
-		compatible = "gic-lpi-base";
-		reg = <0x0 0x80000000 0x0 0x100000>;
-		max-gic-redistributors = <2>;
-	};
-
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) |
arch/arm/dts/fsl-ls1088a.dtsi +0 -6
index 64caa600ad77..3a5a50fb8313 100644
@@ -27,12 +27,6 @@
 		interrupts = <1 9 0x4>;
 	};
 
-	gic_lpi_base: syscon@0x80000000 {
-		compatible = "gic-lpi-base";
-		reg = <0x0 0x80000000 0x0 0x100000>;
-		max-gic-redistributors = <8>;
-	};
-
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
arch/arm/dts/fsl-ls2080a.dtsi +0 -6
index 7374d580e07e..278daeeb6eea 100644
@@ -27,12 +27,6 @@
 		interrupts = <1 9 0x4>;
 	};
 
-	gic_lpi_base: syscon@0x80000000 {
-		compatible = "gic-lpi-base";
-		reg = <0x0 0x80000000 0x0 0x100000>;
-		max-gic-redistributors = <8>;
-	};
-
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
arch/arm/dts/fsl-lx2160a.dtsi +0 -6
index a6f0e9bc56be..3b5f0d119e76 100644
@@ -43,12 +43,6 @@
 		interrupts = <1 9 0x4>;
 	};
 
-	gic_lpi_base: syscon@0x80000000 {
-		compatible = "gic-lpi-base";
-		reg = <0x0 0x80000000 0x0 0x200000>;
-		max-gic-redistributors = <16>;
-	};
-
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
Signature · 1 line
2.17.1
#1 lore raw

+ author of gic_lpi_syscon driver

Hi Rayagonda,

Please add the binding for gic_lpi_syscon driver.

Thanks,
Zhiqiang

Quoted 126 lines

-----Original Message-----
From: Tom Rini <[email protected]>
Sent: 2021年8月26日 5:05
To: [email protected]
Cc: Z.Q. Hou <[email protected]>; Priyanka Jain <[email protected]>
Subject: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround"

Ad-hoc bindings that are not part of the upstream device tree / bindings are not allowed in-tree. Only bindings that are in-progress with upstream and then re-synced once agreed upon are.

This reverts commit af288cb291da3abef6be0875527729296f7de7a0.

---
 arch/arm/cpu/armv8/fsl-layerscape/soc.c | 17 +----------------
 arch/arm/dts/fsl-ls1028a.dtsi           |  6 ------
 arch/arm/dts/fsl-ls1088a.dtsi           |  6 ------
 arch/arm/dts/fsl-ls2080a.dtsi           |  6 ------
 arch/arm/dts/fsl-lx2160a.dtsi           |  6 ------
 5 files changed, 1 insertion(+), 40 deletions(-)
arch/arm/cpu/armv8/fsl-layerscape/soc.c +1 -16
index 42a096854629..166662a64baf 100644
@@ -43,22 +43,7 @@ DECLARE_GLOBAL_DATA_PTR;  #ifdef
 CONFIG_GIC_V3_ITS  int ls_gic_rd_tables_init(void *blob)  {
-	struct fdt_memory lpi_base;
-	fdt_addr_t addr;
-	fdt_size_t size;
-	int offset, ret;
-
-	offset = fdt_path_offset(gd->fdt_blob, "/syscon@0x80000000");
-	addr = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, offset,
 "reg",
-						  0, &size, false);
-
-	lpi_base.start = addr;
-	lpi_base.end = addr + size - 1;
-	ret = fdtdec_add_reserved_memory(blob, "lpi_rd_table", &lpi_base,
 NULL, false);
-	if (ret) {
-		debug("%s: failed to add reserved memory\n", __func__);
-		return ret;
-	}
+	int ret;
 
 	ret = gic_lpi_tables_init();
 	if (ret)
arch/arm/dts/fsl-ls1028a.dtsi +0 -6
index 50f9b527cde1..53b052ed3271 100644
@@ -44,12 +44,6 @@
 					 IRQ_TYPE_LEVEL_LOW)>;
 	};
 
-	gic_lpi_base: syscon@0x80000000 {
-		compatible = "gic-lpi-base";
-		reg = <0x0 0x80000000 0x0 0x100000>;
-		max-gic-redistributors = <2>;
-	};
-
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | diff --git

a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi index 64caa600ad77..3a5a50fb8313 100644

arch/arm/dts/fsl-ls1088a.dtsi +0 -7
@@ -27,12 +27,6 @@
 		interrupts = <1 9 0x4>;
 	};
 
-	gic_lpi_base: syscon@0x80000000 {
-		compatible = "gic-lpi-base";
-		reg = <0x0 0x80000000 0x0 0x100000>;
-		max-gic-redistributors = <8>;
-	};
-
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
--git a/arch/arm/dts/fsl-ls2080a.dtsi b/arch/arm/dts/fsl-ls2080a.dtsi index

7374d580e07e..278daeeb6eea 100644

arch/arm/dts/fsl-ls2080a.dtsi +0 -7
@@ -27,12 +27,6 @@
 		interrupts = <1 9 0x4>;
 	};
 
-	gic_lpi_base: syscon@0x80000000 {
-		compatible = "gic-lpi-base";
-		reg = <0x0 0x80000000 0x0 0x100000>;
-		max-gic-redistributors = <8>;
-	};
-
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
--git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl-lx2160a.dtsi index

a6f0e9bc56be..3b5f0d119e76 100644

arch/arm/dts/fsl-lx2160a.dtsi +0 -7
@@ -43,12 +43,6 @@
 		interrupts = <1 9 0x4>;
 	};
 
-	gic_lpi_base: syscon@0x80000000 {
-		compatible = "gic-lpi-base";
-		reg = <0x0 0x80000000 0x0 0x200000>;
-		max-gic-redistributors = <16>;
-	};
-
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
--

2.17.1

#2 lore raw
Quoted 138 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Z.Q. Hou
Sent: Friday, September 10, 2021 12:13 PM
To: Tom Rini <[email protected]>; [email protected]; [email protected]
Cc: Priyanka Jain <[email protected]>
Subject: RE: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround"

+ author of gic_lpi_syscon driver

Hi Rayagonda,

Please add the binding for gic_lpi_syscon driver.

Thanks,
Zhiqiang

arch/arm/cpu/armv8/fsl-layerscape/soc.c DECLARE_GLOBAL_DATA_PTR; #ifdef

Quoted 33 lines

-----Original Message-----
From: Tom Rini <[email protected]>
Sent: 2021年8月26日 5:05
To: [email protected]
Cc: Z.Q. Hou <[email protected]>; Priyanka Jain <[email protected]>
Subject: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround"

Ad-hoc bindings that are not part of the upstream device tree / bindings are not allowed in-tree. Only bindings that are in-progress with upstream and then re-synced once agreed upon are.

This reverts commit af288cb291da3abef6be0875527729296f7de7a0.

---
 arch/arm/cpu/armv8/fsl-layerscape/soc.c | 17 +----------------
 arch/arm/dts/fsl-ls1028a.dtsi           |  6 ------
 arch/arm/dts/fsl-ls1088a.dtsi           |  6 ------
 arch/arm/dts/fsl-ls2080a.dtsi           |  6 ------
 arch/arm/dts/fsl-lx2160a.dtsi           |  6 ------
 5 files changed, 1 insertion(+), 40 deletions(-)
arch/arm/cpu/armv8/fsl-layerscape/soc.c +0 -0
index 42a096854629..166662a64baf 100644
@@ -43,22 +43,7 @@ DECLARE_GLOBAL_DATA_PTR;  #ifdef

CONFIG_GIC_V3_ITS

Quoted 84 lines
arch/arm/cpu/armv8/fsl-layerscape/soc.c +1 -16
 int ls_gic_rd_tables_init(void *blob)  {
-	struct fdt_memory lpi_base;
-	fdt_addr_t addr;
-	fdt_size_t size;
-	int offset, ret;
-
-	offset = fdt_path_offset(gd->fdt_blob, "/syscon@0x80000000");
-	addr = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, offset,
 "reg",
-						  0, &size, false);
-
-	lpi_base.start = addr;
-	lpi_base.end = addr + size - 1;
-	ret = fdtdec_add_reserved_memory(blob, "lpi_rd_table", &lpi_base,
 NULL, false);
-	if (ret) {
-		debug("%s: failed to add reserved memory\n", __func__);
-		return ret;
-	}
+	int ret;
 
 	ret = gic_lpi_tables_init();
 	if (ret)
(quoted diff) +0 -0

b/arch/arm/dts/fsl-ls1028a.dtsi index 50f9b527cde1..53b052ed3271 100644

arch/arm/dts/fsl-ls1028a.dtsi +0 -6
@@ -44,12 +44,6 @@
 					 IRQ_TYPE_LEVEL_LOW)>;
 	};
 
-	gic_lpi_base: syscon@0x80000000 {
-		compatible = "gic-lpi-base";
-		reg = <0x0 0x80000000 0x0 0x100000>;
-		max-gic-redistributors = <2>;
-	};
-
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | diff --git

a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi index 64caa600ad77..3a5a50fb8313 100644

arch/arm/dts/fsl-ls1088a.dtsi +0 -7
@@ -27,12 +27,6 @@
 		interrupts = <1 9 0x4>;
 	};
 
-	gic_lpi_base: syscon@0x80000000 {
-		compatible = "gic-lpi-base";
-		reg = <0x0 0x80000000 0x0 0x100000>;
-		max-gic-redistributors = <8>;
-	};
-
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
--git a/arch/arm/dts/fsl-ls2080a.dtsi b/arch/arm/dts/fsl-ls2080a.dtsi

index 7374d580e07e..278daeeb6eea 100644

arch/arm/dts/fsl-ls2080a.dtsi +0 -7
@@ -27,12 +27,6 @@
 		interrupts = <1 9 0x4>;
 	};
 
-	gic_lpi_base: syscon@0x80000000 {
-		compatible = "gic-lpi-base";
-		reg = <0x0 0x80000000 0x0 0x100000>;
-		max-gic-redistributors = <8>;
-	};
-
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
--git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl-lx2160a.dtsi

index
a6f0e9bc56be..3b5f0d119e76 100644

arch/arm/dts/fsl-lx2160a.dtsi +0 -0
@@ -43,12 +43,6 @@
 		interrupts = <1 9 0x4>;
 	};
 
Quoted 11 lines
Quoted 11 lines
arch/arm/dts/fsl-lx2160a.dtsi +0 -7
-	gic_lpi_base: syscon@0x80000000 {
-		compatible = "gic-lpi-base";
-		reg = <0x0 0x80000000 0x0 0x200000>;
-		max-gic-redistributors = <16>;
-	};
-
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
--

2.17.1

Tom,

I agree that bindings patch is essential for device-tree changes. But merging this patch will break Layerscape Platforms.
We have requested Rayagonda to submit Binding patch to upstream for review.

If first patch of binding gets submitted timely, can we defer this patch.

Regards
Priyanka

#3 lore raw
Quoted 154 lines · Priyanka Jain (OSS)
Quoted 139 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Z.Q. Hou
Sent: Friday, September 10, 2021 12:13 PM
To: Tom Rini <[email protected]>; [email protected]; [email protected]
Cc: Priyanka Jain <[email protected]>
Subject: RE: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround"

+ author of gic_lpi_syscon driver

Hi Rayagonda,

Please add the binding for gic_lpi_syscon driver.

Thanks,
Zhiqiang

arch/arm/cpu/armv8/fsl-layerscape/soc.c DECLARE_GLOBAL_DATA_PTR; #ifdef

Quoted 33 lines

-----Original Message-----
From: Tom Rini <[email protected]>
Sent: 2021年8月26日 5:05
To: [email protected]
Cc: Z.Q. Hou <[email protected]>; Priyanka Jain <[email protected]>
Subject: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround"

Ad-hoc bindings that are not part of the upstream device tree / bindings are not allowed in-tree. Only bindings that are in-progress with upstream and then re-synced once agreed upon are.

This reverts commit af288cb291da3abef6be0875527729296f7de7a0.

---
 arch/arm/cpu/armv8/fsl-layerscape/soc.c | 17 +----------------
 arch/arm/dts/fsl-ls1028a.dtsi           |  6 ------
 arch/arm/dts/fsl-ls1088a.dtsi           |  6 ------
 arch/arm/dts/fsl-ls2080a.dtsi           |  6 ------
 arch/arm/dts/fsl-lx2160a.dtsi           |  6 ------
 5 files changed, 1 insertion(+), 40 deletions(-)
arch/arm/cpu/armv8/fsl-layerscape/soc.c +0 -0
index 42a096854629..166662a64baf 100644
@@ -43,22 +43,7 @@ DECLARE_GLOBAL_DATA_PTR;  #ifdef

CONFIG_GIC_V3_ITS

Quoted 84 lines
arch/arm/cpu/armv8/fsl-layerscape/soc.c +1 -16
 int ls_gic_rd_tables_init(void *blob)  {
-    struct fdt_memory lpi_base;
-    fdt_addr_t addr;
-    fdt_size_t size;
-    int offset, ret;
-
-    offset = fdt_path_offset(gd->fdt_blob, "/syscon@0x80000000");
-    addr = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, offset,
 "reg",
-                                              0, &size, false);
-
-    lpi_base.start = addr;
-    lpi_base.end = addr + size - 1;
-    ret = fdtdec_add_reserved_memory(blob, "lpi_rd_table", &lpi_base,
 NULL, false);
-    if (ret) {
-            debug("%s: failed to add reserved memory\n", __func__);
-            return ret;
-    }
+    int ret;
 
     ret = gic_lpi_tables_init();
     if (ret)
(quoted diff) +0 -0

b/arch/arm/dts/fsl-ls1028a.dtsi index 50f9b527cde1..53b052ed3271 100644

arch/arm/dts/fsl-ls1028a.dtsi +0 -6
@@ -44,12 +44,6 @@
                                      IRQ_TYPE_LEVEL_LOW)>;
     };
 
-    gic_lpi_base: syscon@0x80000000 {
-            compatible = "gic-lpi-base";
-            reg = <0x0 0x80000000 0x0 0x100000>;
-            max-gic-redistributors = <2>;
-    };
-
     timer {
             compatible = "arm,armv8-timer";
             interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | diff --git

a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi index 64caa600ad77..3a5a50fb8313 100644

arch/arm/dts/fsl-ls1088a.dtsi +0 -7
@@ -27,12 +27,6 @@
             interrupts = <1 9 0x4>;
     };
 
-    gic_lpi_base: syscon@0x80000000 {
-            compatible = "gic-lpi-base";
-            reg = <0x0 0x80000000 0x0 0x100000>;
-            max-gic-redistributors = <8>;
-    };
-
     timer {
             compatible = "arm,armv8-timer";
             interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
--git a/arch/arm/dts/fsl-ls2080a.dtsi b/arch/arm/dts/fsl-ls2080a.dtsi

index 7374d580e07e..278daeeb6eea 100644

arch/arm/dts/fsl-ls2080a.dtsi +0 -7
@@ -27,12 +27,6 @@
             interrupts = <1 9 0x4>;
     };
 
-    gic_lpi_base: syscon@0x80000000 {
-            compatible = "gic-lpi-base";
-            reg = <0x0 0x80000000 0x0 0x100000>;
-            max-gic-redistributors = <8>;
-    };
-
     timer {
             compatible = "arm,armv8-timer";
             interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
--git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl-lx2160a.dtsi

index
a6f0e9bc56be..3b5f0d119e76 100644

arch/arm/dts/fsl-lx2160a.dtsi +0 -0
@@ -43,12 +43,6 @@
             interrupts = <1 9 0x4>;
     };
 
Quoted 11 lines
Quoted 11 lines
arch/arm/dts/fsl-lx2160a.dtsi +0 -7
-    gic_lpi_base: syscon@0x80000000 {
-            compatible = "gic-lpi-base";
-            reg = <0x0 0x80000000 0x0 0x200000>;
-            max-gic-redistributors = <16>;
-    };
-
     timer {
             compatible = "arm,armv8-timer";
             interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */
--

2.17.1

Tom,

Quoted 9 lines

I agree that bindings patch is essential for device-tree changes. But merging this patch will break Layerscape Platforms.
We have requested Rayagonda to submit Binding patch to upstream for review.

If first patch of binding gets submitted timely, can we defer this patch.

Regards
Priyanka

++Bharat, Roman and Henrik.

author
#4 lore raw
Quoted 157 lines · Rayagonda Kokatanur
Quoted 155 lines · Priyanka Jain (OSS)
Quoted 139 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Z.Q. Hou
Sent: Friday, September 10, 2021 12:13 PM
To: Tom Rini <[email protected]>; [email protected]; [email protected]
Cc: Priyanka Jain <[email protected]>
Subject: RE: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround"

+ author of gic_lpi_syscon driver

Hi Rayagonda,

Please add the binding for gic_lpi_syscon driver.

Thanks,
Zhiqiang

arch/arm/cpu/armv8/fsl-layerscape/soc.c DECLARE_GLOBAL_DATA_PTR; #ifdef

Quoted 33 lines

-----Original Message-----
From: Tom Rini <[email protected]>
Sent: 2021年8月26日 5:05
To: [email protected]
Cc: Z.Q. Hou <[email protected]>; Priyanka Jain <[email protected]>
Subject: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround"

Ad-hoc bindings that are not part of the upstream device tree / bindings are not allowed in-tree. Only bindings that are in-progress with upstream and then re-synced once agreed upon are.

This reverts commit af288cb291da3abef6be0875527729296f7de7a0.

---
 arch/arm/cpu/armv8/fsl-layerscape/soc.c | 17 +----------------
 arch/arm/dts/fsl-ls1028a.dtsi           |  6 ------
 arch/arm/dts/fsl-ls1088a.dtsi           |  6 ------
 arch/arm/dts/fsl-ls2080a.dtsi           |  6 ------
 arch/arm/dts/fsl-lx2160a.dtsi           |  6 ------
 5 files changed, 1 insertion(+), 40 deletions(-)
arch/arm/cpu/armv8/fsl-layerscape/soc.c +0 -0
index 42a096854629..166662a64baf 100644
@@ -43,22 +43,7 @@ DECLARE_GLOBAL_DATA_PTR;  #ifdef

CONFIG_GIC_V3_ITS

Quoted 84 lines
arch/arm/cpu/armv8/fsl-layerscape/soc.c +1 -16
 int ls_gic_rd_tables_init(void *blob)  {
-    struct fdt_memory lpi_base;
-    fdt_addr_t addr;
-    fdt_size_t size;
-    int offset, ret;
-
-    offset = fdt_path_offset(gd->fdt_blob, "/syscon@0x80000000");
-    addr = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, offset,
 "reg",
-                                              0, &size, false);
-
-    lpi_base.start = addr;
-    lpi_base.end = addr + size - 1;
-    ret = fdtdec_add_reserved_memory(blob, "lpi_rd_table", &lpi_base,
 NULL, false);
-    if (ret) {
-            debug("%s: failed to add reserved memory\n", __func__);
-            return ret;
-    }
+    int ret;
 
     ret = gic_lpi_tables_init();
     if (ret)
(quoted diff) +0 -0

b/arch/arm/dts/fsl-ls1028a.dtsi index 50f9b527cde1..53b052ed3271 100644

arch/arm/dts/fsl-ls1028a.dtsi +0 -6
@@ -44,12 +44,6 @@
                                      IRQ_TYPE_LEVEL_LOW)>;
     };
 
-    gic_lpi_base: syscon@0x80000000 {
-            compatible = "gic-lpi-base";
-            reg = <0x0 0x80000000 0x0 0x100000>;
-            max-gic-redistributors = <2>;
-    };
-
     timer {
             compatible = "arm,armv8-timer";
             interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | diff --git

a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi index 64caa600ad77..3a5a50fb8313 100644

arch/arm/dts/fsl-ls1088a.dtsi +0 -7
@@ -27,12 +27,6 @@
             interrupts = <1 9 0x4>;
     };
 
-    gic_lpi_base: syscon@0x80000000 {
-            compatible = "gic-lpi-base";
-            reg = <0x0 0x80000000 0x0 0x100000>;
-            max-gic-redistributors = <8>;
-    };
-
     timer {
             compatible = "arm,armv8-timer";
             interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
--git a/arch/arm/dts/fsl-ls2080a.dtsi b/arch/arm/dts/fsl-ls2080a.dtsi

index 7374d580e07e..278daeeb6eea 100644

arch/arm/dts/fsl-ls2080a.dtsi +0 -7
@@ -27,12 +27,6 @@
             interrupts = <1 9 0x4>;
     };
 
-    gic_lpi_base: syscon@0x80000000 {
-            compatible = "gic-lpi-base";
-            reg = <0x0 0x80000000 0x0 0x100000>;
-            max-gic-redistributors = <8>;
-    };
-
     timer {
             compatible = "arm,armv8-timer";
             interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */ diff
--git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl-lx2160a.dtsi

index
a6f0e9bc56be..3b5f0d119e76 100644

arch/arm/dts/fsl-lx2160a.dtsi +0 -0
@@ -43,12 +43,6 @@
             interrupts = <1 9 0x4>;
     };
 
Quoted 9 lines

arch/arm/dts/fsl-lx2160a.dtsi line 48

Quoted 9 lines
arch/arm/dts/fsl-lx2160a.dtsi +0 -6
-    gic_lpi_base: syscon@0x80000000 {
-            compatible = "gic-lpi-base";
-            reg = <0x0 0x80000000 0x0 0x200000>;
-            max-gic-redistributors = <16>;
-    };
-
     timer {
             compatible = "arm,armv8-timer";
             interrupts = <1 13 0x8>, /* Physical Secure PPI, active-low */

Tom,

I agree that bindings patch is essential for device-tree changes. But merging this patch will break Layerscape Platforms.
We have requested Rayagonda to submit Binding patch to upstream for review.

Quoted 7 lines
Quoted 5 lines

If first patch of binding gets submitted timely, can we defer this patch.

Regards
Priyanka

++Bharat, Roman and Henrik.

Yes, please keep me in the loop on this binding being reviewed upstream. Also, please check the tree for other bindings that haven't been submitted, but also haven't been noticed yet. There is not supposed to be anything outside of the -u-boot.dtsi files that can't be replaced by dropping in a newer set of upstream dts files. And the -u-boot.dtsi files are for u-boot specific bindings (that we're working on upstreaming) or actively in-review bindings upstream.

Signature · 1 line
Tom
#5 lore raw

Re: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset

Quoted 3 lines · Rayagonda Kokatanur
Quoted 2 lines

On Mon, Sep 13, 2021 at 11:29 AM Priyanka Jain (OSS) <[email protected]> wrote:

..

Quoted 13 lines
Quoted 6 lines
Quoted 6 lines

Tom,

I agree that bindings patch is essential for device-tree changes. But merging this patch will break Layerscape Platforms.
We have requested Rayagonda to submit Binding patch to upstream for review.

Quoted 6 lines
Quoted 5 lines

If first patch of binding gets submitted timely, can we defer this patch.

Regards
Priyanka

++Bharat, Roman and Henrik.

Quoted 7 lines

Yes, please keep me in the loop on this binding being reviewed upstream. Also, please check the tree for other bindings that haven't been submitted, but also haven't been noticed yet. There is not supposed to be anything outside of the -u-boot.dtsi files that can't be replaced by dropping in a newer set of upstream dts files. And the -u-boot.dtsi files are for u-boot specific bindings (that we're working on upstreaming) or actively in-review bindings upstream.

Are there any news on this topic? Was there a submission to linux for the binding in the meantime? Unfortunately, I wasn't in the loop here (albeit being the Reported-by: one). Until now, this patch is a prerequisite for my ls1028a device tree sync series [1].

-michael

[1] https://lore.kernel.org/u-boot/[email protected]/