Skip to contentSkip to conversation

clk: socfpga: agilex: fix duplicate s2f_user0_clk

PATCH Superseded Dinh Nguyen 2 participants 4 messages Sep 13, 2021 – Sep 16, 2021

Subsystems (3)
Stable branch Common clk Arm/socfpga clock framework support

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Dinh Nguyen

author maintainer
#0 lore raw

PATCH 1/1 clk: socfpga: agilex: fix duplicate s2f_user0_clk

Remove the duplicate s2f_user0_clk.

Fixes f817c132db67 ("clk: socfpga: agilex: fix up s2f_user0_clk

representation")

Cc [email protected]
Signed-off-by Dinh Nguyen <[email protected]>
---
 drivers/clk/socfpga/clk-agilex.c | 2 --
 1 file changed, 2 deletions(-)
drivers/clk/socfpga/clk-agilex.c +0 -2
index 242e94c0cf8a..b4d300fbbc66 100644
@@ -312,8 +312,6 @@ static const struct stratix10_gate_clock agilex_gate_clks[] = {
 	  4, 0x44, 28, 1, 0, 0, 0},
 	{ AGILEX_CS_TIMER_CLK, "cs_timer_clk", NULL, noc_mux, ARRAY_SIZE(noc_mux), 0, 0x24,
 	  5, 0, 0, 0, 0x30, 1, 0},
-	{ AGILEX_S2F_USER0_CLK, "s2f_user0_clk", NULL, s2f_usr0_mux, ARRAY_SIZE(s2f_usr0_mux), 0, 0x24,
-	  6, 0, 0, 0, 0, 0, 0},
 	{ AGILEX_EMAC0_CLK, "emac0_clk", NULL, emac_mux, ARRAY_SIZE(emac_mux), 0, 0x7C,
 	  0, 0, 0, 0, 0x94, 26, 0},
 	{ AGILEX_EMAC1_CLK, "emac1_clk", NULL, emac_mux, ARRAY_SIZE(emac_mux), 0, 0x7C,
Signature · 1 line
2.25.1
maintainer
#1 lore raw

Quoting Dinh Nguyen (2021-09-13 06:21:02)

Quoted 1 line

Remove the duplicate s2f_user0_clk.

To fix what in particular? The patch is tagged for stable so I can only imagine there's some badness that would be good to fix?

Quoted 6 lines
Fixes f817c132db67 ("clk: socfpga: agilex: fix up s2f_user0_clk

representation")

Cc [email protected]
Signed-off-by Dinh Nguyen <[email protected]>

---

maintainer
#2 lore raw

Quoting Stephen Boyd (2021-09-14 18:16:08)

Quoted 6 lines

Quoting Dinh Nguyen (2021-09-13 06:21:02)

Quoted 1 line

Remove the duplicate s2f_user0_clk.

To fix what in particular? The patch is tagged for stable so I can only imagine there's some badness that would be good to fix?

Ah this is the patch that was missing. Please squash the two together and resend with more info.

author maintainer
#3 lore raw
Quoted 11 lines · Stephen Boyd

Quoting Stephen Boyd (2021-09-14 18:16:08)

Quoted 6 lines

Quoting Dinh Nguyen (2021-09-13 06:21:02)

Quoted 1 line

Remove the duplicate s2f_user0_clk.

To fix what in particular? The patch is tagged for stable so I can only imagine there's some badness that would be good to fix?

Ah this is the patch that was missing. Please squash the two together and resend with more info.

Sorry about that. Will do.

Dinh