Fix the pwm regulator supply properties

PATCH Applied Anand Moon 3 participants 8 messages Sep 19, 2021 – Sep 21, 2021

Subsystems (2)

Device tree bindings Arm/Amlogic Meson SoC support

lore

Share & tools

lore

Anand Moon

author

2021-09-19 20:29 UTC #0 lore raw

v2 cover Fix the pwm regulator supply properties

Changes PWM supply properties help fix internal link of PWM to main 12V supply as per the shematics.

V1: https://lkml.org/lkml/2021/6/29/288

Thanks
-Anand

Anand Moon (3):
arm64: dts: meson-g12a: Fix the pwm regulator supply properties
arm64: dts: meson-g12b: Fix the pwm regulator supply properties
arm64: dts: meson-sm1: Fix the pwm regulator supply properties

 arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts       | 2 +-
 arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts         | 2 +-
 arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts      | 2 +-
 arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi | 4 ++--
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi   | 4 ++--
 arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi        | 4 ++--
 arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts   | 2 +-
 arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts  | 2 +-
 arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi       | 2 +-
 arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts        | 2 +-
 10 files changed, 13 insertions(+), 13 deletions(-)

--
2.33.0

Anand Moon

author

2021-09-19 20:29 UTC #1 lore raw

PATCH v2 1/3 arm64: dts: meson-g12a: Fix the pwm regulator supply properties

After enabling CONFIG_REGULATOR_DEBUG=y we observe below debug logs. Changes help link VDDCPU pwm regulator to 12V regulator supply instead of dummy regulator.

[   11.602281] pwm-regulator regulator-vddcpu: Looking up pwm-supply property
               in node /regulator-vddcpu failed
[   11.602344] VDDCPU: supplied by regulator-dummy
[   11.602365] regulator-dummy: could not add device link regulator.11: -ENOENT
[   11.602548] VDDCPU: 721 <--> 1022 mV at 1022 mV, enabled

Fixes e9bc0765cc12 ("arm64: dts: meson-g12a: enable DVFS on G12A boards")

Cc Neil Armstrong <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
 arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts  | 2 +-
 arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts    | 2 +-
 arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts +1 -1

index 81269ccc2496..d8838dde0f0f 100644
@@ -139,7 +139,7 @@ vddcpu: regulator-vddcpu {
 		regulator-min-microvolt = <721000>;
 		regulator-max-microvolt = <1022000>;
 
-		vin-supply = <&dc_in>;
+		pwm-supply = <&dc_in>;
 
 		pwms = <&pwm_AO_cd 1 1250 0>;
 		pwm-dutycycle-range = <100 0>;

arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts +1 -1

index a26bfe72550f..4b5d11e56364 100644
@@ -139,7 +139,7 @@ vddcpu: regulator-vddcpu {
 		regulator-min-microvolt = <721000>;
 		regulator-max-microvolt = <1022000>;
 
-		vin-supply = <&main_12v>;
+		pwm-supply = <&main_12v>;
 
 		pwms = <&pwm_AO_cd 1 1250 0>;
 		pwm-dutycycle-range = <100 0>;

arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts +1 -1

index 579f3d02d613..b4e86196e346 100644
@@ -139,7 +139,7 @@ vddcpu: regulator-vddcpu {
 		regulator-min-microvolt = <721000>;
 		regulator-max-microvolt = <1022000>;
 
-		vin-supply = <&dc_in>;
+		pwm-supply = <&dc_in>;
 
 		pwms = <&pwm_AO_cd 1 1250 0>;
 		pwm-dutycycle-range = <100 0>;

--
2.33.0

Anand Moon

author

2021-09-19 20:29 UTC #2 lore raw

PATCH v2 2/3 arm64: dts: meson-g12b: Fix the pwm regulator supply properties

In reply to Anand Moon

After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs. Changes help link VDDCP_A and VDDCPU_B pwm regulator to 12V regulator supply instead of dummy regulator.

[    4.147196] VDDCPU_A: will resolve supply early: pwm
[    4.147216] pwm-regulator regulator-vddcpu-a: Looking up pwm-supply from device tree
[    4.147227] pwm-regulator regulator-vddcpu-a: Looking up pwm-supply property in node /regulator-vddcpu-a failed
[    4.147258] VDDCPU_A: supplied by regulator-dummy
[    4.147288] regulator-dummy: could not add device link regulator.12: -ENOENT
[    4.147353] VDDCPU_A: 721 <--> 1022 mV at 871 mV, enabled
[    4.152014] VDDCPU_B: will resolve supply early: pwm
[    4.152035] pwm-regulator regulator-vddcpu-b: Looking up pwm-supply from device tree
[    4.152047] pwm-regulator regulator-vddcpu-b: Looking up pwm-supply property in node /regulator-vddcpu-b failed
[    4.152079] VDDCPU_B: supplied by regulator-dummy
[    4.152108] regulator-dummy: could not add device link regulator.13: -ENOENT

Fixes c6d29c66e582 ("arm64: dts: meson-g12b-khadas-vim3: add initial device-tree")

Fixes d14734a04a8a ("arm64: dts: meson-g12b-odroid-n2: enable DVFS")

Fixes 3cb74db9b256 ("arm64: dts: meson: convert ugoos-am6 to common w400 dtsi")

Cc Neil Armstrong <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
 arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi | 4 ++--
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi   | 4 ++--
 arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi        | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi +2 -2

index f42cf4b8af2d..16dd409051b4 100644
@@ -18,7 +18,7 @@ vddcpu_a: regulator-vddcpu-a {
 		regulator-min-microvolt = <690000>;
 		regulator-max-microvolt = <1050000>;
 
-		vin-supply = <&dc_in>;
+		pwm-supply = <&dc_in>;
 
 		pwms = <&pwm_ab 0 1250 0>;
 		pwm-dutycycle-range = <100 0>;

@@ -37,7 +37,7 @@ vddcpu_b: regulator-vddcpu-b {
 		regulator-min-microvolt = <690000>;
 		regulator-max-microvolt = <1050000>;
 
-		vin-supply = <&vsys_3v3>;
+		pwm-supply = <&vsys_3v3>;
 
 		pwms = <&pwm_AO_cd 1 1250 0>;
 		pwm-dutycycle-range = <100 0>;

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +2 -2

index 344573e157a7..4f33820aba1f 100644
@@ -130,7 +130,7 @@ vddcpu_a: regulator-vddcpu-a {
 		regulator-min-microvolt = <721000>;
 		regulator-max-microvolt = <1022000>;
 
-		vin-supply = <&main_12v>;
+		pwm-supply = <&main_12v>;
 
 		pwms = <&pwm_ab 0 1250 0>;
 		pwm-dutycycle-range = <100 0>;

@@ -149,7 +149,7 @@ vddcpu_b: regulator-vddcpu-b {
 		regulator-min-microvolt = <721000>;
 		regulator-max-microvolt = <1022000>;
 
-		vin-supply = <&main_12v>;
+		pwm-supply = <&main_12v>;
 
 		pwms = <&pwm_AO_cd 1 1250 0>;
 		pwm-dutycycle-range = <100 0>;

arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi +2 -2

index feb088504740..b40d2c1002c9 100644
@@ -96,7 +96,7 @@ vddcpu_a: regulator-vddcpu-a {
 		regulator-min-microvolt = <721000>;
 		regulator-max-microvolt = <1022000>;
 
-		vin-supply = <&main_12v>;
+		pwm-supply = <&main_12v>;
 
 		pwms = <&pwm_ab 0 1250 0>;
 		pwm-dutycycle-range = <100 0>;

@@ -115,7 +115,7 @@ vddcpu_b: regulator-vddcpu-b {
 		regulator-min-microvolt = <721000>;
 		regulator-max-microvolt = <1022000>;
 
-		vin-supply = <&main_12v>;
+		pwm-supply = <&main_12v>;
 
 		pwms = <&pwm_AO_cd 1 1250 0>;
 		pwm-dutycycle-range = <100 0>;

--
2.33.0

Anand Moon

author

2021-09-19 20:30 UTC #3 lore raw

PATCH v2 3/3 arm64: dts: meson-sm1: Fix the pwm regulator supply properties

In reply to Anand Moon

After enabling CONFIG_REGULATOR_DEBUG=y we observe below debug logs. Changes help link VDDCPU pwm regulator to 12V regulator supply instead of dummy regulator.

[   11.602281] pwm-regulator regulator-vddcpu: Looking up pwm-supply property
               in node /regulator-vddcpu failed
[   11.602344] VDDCPU: supplied by regulator-dummy
[   11.602365] regulator-dummy: could not add device link regulator.11: -ENOENT
[   11.602548] VDDCPU: 721 <--> 1022 mV at 1022 mV, enabled

Fixes 88d537bc92ca ("arm64: dts: meson: convert meson-sm1-odroid-c4 to dtsi")

Fixes 700ab8d83927 ("arm64: dts: khadas-vim3: add support for the SM1 based VIM3L")

Fixes 3d9e76483049 ("arm64: dts: meson-sm1-sei610: enable DVFS")

Fixes 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts")

Cc Neil Armstrong <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
 arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts  | 2 +-
 arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts | 2 +-
 arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi      | 2 +-
 arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts       | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts +1 -1

index effaa138b5f9..212c6aa5a3b8 100644
@@ -173,7 +173,7 @@ vddcpu: regulator-vddcpu {
 		regulator-min-microvolt = <690000>;
 		regulator-max-microvolt = <1050000>;
 
-		vin-supply = <&dc_in>;
+		pwm-supply = <&dc_in>;
 
 		pwms = <&pwm_AO_cd 1 1250 0>;
 		pwm-dutycycle-range = <100 0>;

arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts +1 -1

index f2c098143594..9c0b544e2209 100644
@@ -24,7 +24,7 @@ vddcpu: regulator-vddcpu {
 		regulator-min-microvolt = <690000>;
 		regulator-max-microvolt = <1050000>;
 
-		vin-supply = <&vsys_3v3>;
+		pwm-supply = <&vsys_3v3>;
 
 		pwms = <&pwm_AO_cd 1 1250 0>;
 		pwm-dutycycle-range = <100 0>;

arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi +1 -1

index fd0ad85c165b..f05bc9756393 100644
@@ -116,7 +116,7 @@ vddcpu: regulator-vddcpu {
 		regulator-min-microvolt = <721000>;
 		regulator-max-microvolt = <1022000>;
 
-		vin-supply = <&main_12v>;
+		pwm-supply = <&main_12v>;
 
 		pwms = <&pwm_AO_cd 1 1250 0>;
 		pwm-dutycycle-range = <100 0>;

arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts +1 -1

index 2194a778973f..427475846fc7 100644
@@ -185,7 +185,7 @@ vddcpu: regulator-vddcpu {
 		regulator-min-microvolt = <690000>;
 		regulator-max-microvolt = <1050000>;
 
-		vin-supply = <&dc_in>;
+		pwm-supply = <&dc_in>;
 
 		pwms = <&pwm_AO_cd 1 1500 0>;
 		pwm-dutycycle-range = <100 0>;

--
2.33.0

Neil Armstrong

2021-09-20 08:29 UTC #4 lore raw

In reply to Anand Moon

Hi,

Quoted 13 lines · Anand Moon

Changes PWM supply properties help fix internal link of PWM to main 12V supply as per the shematics.
V1: https://lkml.org/lkml/2021/6/29/288
Thanks
-Anand
Anand Moon (3):
arm64: dts: meson-g12a: Fix the pwm regulator supply properties
arm64: dts: meson-g12b: Fix the pwm regulator supply properties
arm64: dts: meson-sm1: Fix the pwm regulator supply properties

Quoted 11 lines

 arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts       | 2 +-
 arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts         | 2 +-
 arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts      | 2 +-
 arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi | 4 ++--
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi   | 4 ++--
 arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi        | 4 ++--
 arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts   | 2 +-
 arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts  | 2 +-
 arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi       | 2 +-
 arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts        | 2 +-
 10 files changed, 13 insertions(+), 13 deletions(-)

Thanks for fixing all the other boards !

I'll let a few days for Martin to review, but it's ok for me.

Neil

Quoted 4 lines

--
2.33.0

Martin Blumenstingl

reviewer Reviewed-by on the v2 series

2021-09-20 20:13 UTC #5 lore raw

In reply to Anand Moon

On Sun, Sep 19, 2021 at 10:29 PM Anand Moon <[email protected]> wrote:
[...]

Quoted 4 lines

Anand Moon (3):
arm64: dts: meson-g12a: Fix the pwm regulator supply properties
arm64: dts: meson-g12b: Fix the pwm regulator supply properties
arm64: dts: meson-sm1: Fix the pwm regulator supply properties

all three get my:

Reviewed-by Martin Blumenstingl <[email protected]>

Thanks for working on this!
I haven't runtime tested the patches but I expect that they will work in the same way that the Meson8/8b/8m2 patches with the same change did.

Neil, some of these boards are covered by Kernel CI. I suggest queueing the patches in v5.16/dt64 and then seeing if there's any feedback from the auto-builders.

Best regards,
Martin

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Neil Armstrong

2021-09-21 07:21 UTC #6 lore raw

Quoted 9 lines · Martin Blumenstingl

On Sun, Sep 19, 2021 at 10:29 PM Anand Moon <[email protected]> wrote:
[...]
Quoted 4 lines
Anand Moon (3):
arm64: dts: meson-g12a: Fix the pwm regulator supply properties
arm64: dts: meson-g12b: Fix the pwm regulator supply properties
arm64: dts: meson-sm1: Fix the pwm regulator supply properties
all three get my:
Reviewed-by Martin Blumenstingl <[email protected]>

Quoted 8 lines

Thanks for working on this!
I haven't runtime tested the patches but I expect that they will work in the same way that the Meson8/8b/8m2 patches with the same change did.
Neil, some of these boards are covered by Kernel CI. I suggest queueing the patches in v5.16/dt64 and then seeing if there's any feedback from the auto-builders.

Acked !

Neil

Quoted 5 lines

Best regards,
Martin

Neil Armstrong

Applied

2021-09-21 07:23 UTC #7 lore raw

In reply to Anand Moon

Hi,

Quoted 9 lines · Anand Moon

Changes PWM supply properties help fix internal link of PWM to main 12V supply as per the shematics.
V1: https://lkml.org/lkml/2021/6/29/288
Thanks
-Anand
[...]

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v5.16/dt64)

[1/3] arm64: dts: meson-g12a: Fix the pwm regulator supply properties

      https://git.kernel.org/amlogic/c/085675117ecf5e02c4220698fd549024ec64ad2c
[2/3] arm64: dts: meson-g12b: Fix the pwm regulator supply properties
      https://git.kernel.org/amlogic/c/62183863f708c2464769e0d477c8ce9f3d326feb
[3/3] arm64: dts: meson-sm1: Fix the pwm regulator supply properties
      https://git.kernel.org/amlogic/c/0b26fa8a02c2834f1fa8a206a285b9f84c4ad764

Signature · 1 line

Neil