Skip to contentSkip to conversation

ARM: dts: spear13xx: Drop malformed 'interrupt-map' on PCI nodes

PATCH Superseded Rob Herring 2 participants 5 messages Sep 28, 2021 – Oct 22, 2021 Device tree bindings

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 ARM: dts: spear13xx: Drop malformed 'interrupt-map' on PCI nodes

The spear13xx PCI 'interrupt-map' property is not parse-able. '#interrupt-cells' is missing and there are 3 #address-cells. Based on the driver, the only supported interrupt is for MSI. Therefore, 'interrupt-map' is not needed.

Cc Viresh Kumar <[email protected]>
Cc Shiraz Hashim <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 arch/arm/boot/dts/spear1310.dtsi | 6 ------
 arch/arm/boot/dts/spear1340.dtsi | 2 --
 2 files changed, 8 deletions(-)
arch/arm/boot/dts/spear1310.dtsi +0 -6
index c4b49baf9804..2f746a9428a7 100644
@@ -82,8 +82,6 @@ pcie0: pcie@b1000000 {
 			reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
 			reg-names = "dbi", "config";
 			interrupts = <0 68 0x4>;
-			interrupt-map-mask = <0 0 0 0>;
-			interrupt-map = <0x0 0 &gic 0 68 0x4>;
 			num-lanes = <1>;
 			phys = <&miphy0 1>;
 			phy-names = "pcie-phy";

@@ -101,8 +99,6 @@ pcie1: pcie@b1800000 {
 			reg = <0xb1800000 0x4000>, <0x90000000 0x20000>;
 			reg-names = "dbi", "config";
 			interrupts = <0 69 0x4>;
-			interrupt-map-mask = <0 0 0 0>;
-			interrupt-map = <0x0 0 &gic 0 69 0x4>;
 			num-lanes = <1>;
 			phys = <&miphy1 1>;
 			phy-names = "pcie-phy";

@@ -120,8 +116,6 @@ pcie2: pcie@b4000000 {
 			reg = <0xb4000000 0x4000>, <0xc0000000 0x20000>;
 			reg-names = "dbi", "config";
 			interrupts = <0 70 0x4>;
-			interrupt-map-mask = <0 0 0 0>;
-			interrupt-map = <0x0 0 &gic 0 70 0x4>;
 			num-lanes = <1>;
 			phys = <&miphy2 1>;
 			phy-names = "pcie-phy";
arch/arm/boot/dts/spear1340.dtsi +0 -2
index 1a8f5e8b10e3..827e887afbda 100644
@@ -47,8 +47,6 @@ pcie0: pcie@b1000000 {
 			reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
 			reg-names = "dbi", "config";
 			interrupts = <0 68 0x4>;
-			interrupt-map-mask = <0 0 0 0>;
-			interrupt-map = <0x0 0 &gic 0 68 0x4>;
 			num-lanes = <1>;
 			phys = <&miphy0 1>;
 			phy-names = "pcie-phy";
Signature · 1 line
2.30.2
Acked-by on v1 1/1
#1 lore raw
Quoted 50 lines · Rob Herring

The spear13xx PCI 'interrupt-map' property is not parse-able. '#interrupt-cells' is missing and there are 3 #address-cells. Based on the driver, the only supported interrupt is for MSI. Therefore, 'interrupt-map' is not needed.

Cc Viresh Kumar <[email protected]>
Cc Shiraz Hashim <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 arch/arm/boot/dts/spear1310.dtsi | 6 ------
 arch/arm/boot/dts/spear1340.dtsi | 2 --
 2 files changed, 8 deletions(-)
arch/arm/boot/dts/spear1310.dtsi +0 -6
index c4b49baf9804..2f746a9428a7 100644
@@ -82,8 +82,6 @@ pcie0: pcie@b1000000 {
 			reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
 			reg-names = "dbi", "config";
 			interrupts = <0 68 0x4>;
-			interrupt-map-mask = <0 0 0 0>;
-			interrupt-map = <0x0 0 &gic 0 68 0x4>;
 			num-lanes = <1>;
 			phys = <&miphy0 1>;
 			phy-names = "pcie-phy";

@@ -101,8 +99,6 @@ pcie1: pcie@b1800000 {
 			reg = <0xb1800000 0x4000>, <0x90000000 0x20000>;
 			reg-names = "dbi", "config";
 			interrupts = <0 69 0x4>;
-			interrupt-map-mask = <0 0 0 0>;
-			interrupt-map = <0x0 0 &gic 0 69 0x4>;
 			num-lanes = <1>;
 			phys = <&miphy1 1>;
 			phy-names = "pcie-phy";

@@ -120,8 +116,6 @@ pcie2: pcie@b4000000 {
 			reg = <0xb4000000 0x4000>, <0xc0000000 0x20000>;
 			reg-names = "dbi", "config";
 			interrupts = <0 70 0x4>;
-			interrupt-map-mask = <0 0 0 0>;
-			interrupt-map = <0x0 0 &gic 0 70 0x4>;
 			num-lanes = <1>;
 			phys = <&miphy2 1>;
 			phy-names = "pcie-phy";
arch/arm/boot/dts/spear1340.dtsi +0 -0
index 1a8f5e8b10e3..827e887afbda 100644

arch/arm/boot/dts/spear1340.dtsi pcie0: pcie@b1000000 { · line 52

Quoted 8 lines
arch/arm/boot/dts/spear1340.dtsi +0 -2
@@ -47,8 +47,6 @@ pcie0: pcie@b1000000 {
 			reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
 			reg-names = "dbi", "config";
 			interrupts = <0 68 0x4>;
-			interrupt-map-mask = <0 0 0 0>;
-			interrupt-map = <0x0 0 &gic 0 68 0x4>;
 			num-lanes = <1>;
 			phys = <&miphy0 1>;
 			phy-names = "pcie-phy";
Acked-by Viresh Kumar <[email protected]>
Signature · 1 line
viresh
author maintainer
#2 lore raw
Quoted 54 lines · Viresh Kumar
Quoted 52 lines · Rob Herring

The spear13xx PCI 'interrupt-map' property is not parse-able. '#interrupt-cells' is missing and there are 3 #address-cells. Based on the driver, the only supported interrupt is for MSI. Therefore, 'interrupt-map' is not needed.

Cc Viresh Kumar <[email protected]>
Cc Shiraz Hashim <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 arch/arm/boot/dts/spear1310.dtsi | 6 ------
 arch/arm/boot/dts/spear1340.dtsi | 2 --
 2 files changed, 8 deletions(-)
arch/arm/boot/dts/spear1310.dtsi +0 -6
index c4b49baf9804..2f746a9428a7 100644
@@ -82,8 +82,6 @@ pcie0: pcie@b1000000 {
                      reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
                      reg-names = "dbi", "config";
                      interrupts = <0 68 0x4>;
-                     interrupt-map-mask = <0 0 0 0>;
-                     interrupt-map = <0x0 0 &gic 0 68 0x4>;
                      num-lanes = <1>;
                      phys = <&miphy0 1>;
                      phy-names = "pcie-phy";

@@ -101,8 +99,6 @@ pcie1: pcie@b1800000 {
                      reg = <0xb1800000 0x4000>, <0x90000000 0x20000>;
                      reg-names = "dbi", "config";
                      interrupts = <0 69 0x4>;
-                     interrupt-map-mask = <0 0 0 0>;
-                     interrupt-map = <0x0 0 &gic 0 69 0x4>;
                      num-lanes = <1>;
                      phys = <&miphy1 1>;
                      phy-names = "pcie-phy";

@@ -120,8 +116,6 @@ pcie2: pcie@b4000000 {
                      reg = <0xb4000000 0x4000>, <0xc0000000 0x20000>;
                      reg-names = "dbi", "config";
                      interrupts = <0 70 0x4>;
-                     interrupt-map-mask = <0 0 0 0>;
-                     interrupt-map = <0x0 0 &gic 0 70 0x4>;
                      num-lanes = <1>;
                      phys = <&miphy2 1>;
                      phy-names = "pcie-phy";
arch/arm/boot/dts/spear1340.dtsi +0 -0
index 1a8f5e8b10e3..827e887afbda 100644
@@ -47,8 +47,6 @@ pcie0: pcie@b1000000 {
                      reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
                      reg-names = "dbi", "config";
Quoted 8 lines

arch/arm/boot/dts/spear1340.dtsi pcie0: pcie@b1000000 { · line 52

Quoted 6 lines
arch/arm/boot/dts/spear1340.dtsi +0 -2
                      interrupts = <0 68 0x4>;
-                     interrupt-map-mask = <0 0 0 0>;
-                     interrupt-map = <0x0 0 &gic 0 68 0x4>;
                      num-lanes = <1>;
                      phys = <&miphy0 1>;
                      phy-names = "pcie-phy";
Acked-by Viresh Kumar <[email protected]>

Are you going to apply this?

Rob

#3 lore raw
Quoted 64 lines · Rob Herring
Quoted 54 lines · Viresh Kumar
Quoted 52 lines · Rob Herring

The spear13xx PCI 'interrupt-map' property is not parse-able. '#interrupt-cells' is missing and there are 3 #address-cells. Based on the driver, the only supported interrupt is for MSI. Therefore, 'interrupt-map' is not needed.

Cc Viresh Kumar <[email protected]>
Cc Shiraz Hashim <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 arch/arm/boot/dts/spear1310.dtsi | 6 ------
 arch/arm/boot/dts/spear1340.dtsi | 2 --
 2 files changed, 8 deletions(-)
arch/arm/boot/dts/spear1310.dtsi +0 -6
index c4b49baf9804..2f746a9428a7 100644
@@ -82,8 +82,6 @@ pcie0: pcie@b1000000 {
                      reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
                      reg-names = "dbi", "config";
                      interrupts = <0 68 0x4>;
-                     interrupt-map-mask = <0 0 0 0>;
-                     interrupt-map = <0x0 0 &gic 0 68 0x4>;
                      num-lanes = <1>;
                      phys = <&miphy0 1>;
                      phy-names = "pcie-phy";

@@ -101,8 +99,6 @@ pcie1: pcie@b1800000 {
                      reg = <0xb1800000 0x4000>, <0x90000000 0x20000>;
                      reg-names = "dbi", "config";
                      interrupts = <0 69 0x4>;
-                     interrupt-map-mask = <0 0 0 0>;
-                     interrupt-map = <0x0 0 &gic 0 69 0x4>;
                      num-lanes = <1>;
                      phys = <&miphy1 1>;
                      phy-names = "pcie-phy";

@@ -120,8 +116,6 @@ pcie2: pcie@b4000000 {
                      reg = <0xb4000000 0x4000>, <0xc0000000 0x20000>;
                      reg-names = "dbi", "config";
                      interrupts = <0 70 0x4>;
-                     interrupt-map-mask = <0 0 0 0>;
-                     interrupt-map = <0x0 0 &gic 0 70 0x4>;
                      num-lanes = <1>;
                      phys = <&miphy2 1>;
                      phy-names = "pcie-phy";
arch/arm/boot/dts/spear1340.dtsi +0 -0
index 1a8f5e8b10e3..827e887afbda 100644
@@ -47,8 +47,6 @@ pcie0: pcie@b1000000 {
                      reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
                      reg-names = "dbi", "config";
Quoted 8 lines

arch/arm/boot/dts/spear1340.dtsi pcie0: pcie@b1000000 { · line 52

Quoted 6 lines
arch/arm/boot/dts/spear1340.dtsi +0 -2
                      interrupts = <0 68 0x4>;
-                     interrupt-map-mask = <0 0 0 0>;
-                     interrupt-map = <0x0 0 &gic 0 68 0x4>;
                      num-lanes = <1>;
                      phys = <&miphy0 1>;
                      phy-names = "pcie-phy";
Acked-by Viresh Kumar <[email protected]>
Quoted 1 line

Are you going to apply this?

No, you or Arnd can directly apply it. I don't send pull requests for SPEAr anymore due to very low traffic.

Signature · 1 line
viresh
author maintainer
#4 lore raw
Quoted 66 lines · Viresh Kumar
Quoted 64 lines · Rob Herring
Quoted 62 lines · Viresh Kumar
Quoted 50 lines · Rob Herring

The spear13xx PCI 'interrupt-map' property is not parse-able. '#interrupt-cells' is missing and there are 3 #address-cells. Based on the driver, the only supported interrupt is for MSI. Therefore, 'interrupt-map' is not needed.

Cc Viresh Kumar <[email protected]>
Cc Shiraz Hashim <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 arch/arm/boot/dts/spear1310.dtsi | 6 ------
 arch/arm/boot/dts/spear1340.dtsi | 2 --
 2 files changed, 8 deletions(-)
arch/arm/boot/dts/spear1310.dtsi +0 -6
index c4b49baf9804..2f746a9428a7 100644
@@ -82,8 +82,6 @@ pcie0: pcie@b1000000 {
                      reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
                      reg-names = "dbi", "config";
                      interrupts = <0 68 0x4>;
-                     interrupt-map-mask = <0 0 0 0>;
-                     interrupt-map = <0x0 0 &gic 0 68 0x4>;
                      num-lanes = <1>;
                      phys = <&miphy0 1>;
                      phy-names = "pcie-phy";

@@ -101,8 +99,6 @@ pcie1: pcie@b1800000 {
                      reg = <0xb1800000 0x4000>, <0x90000000 0x20000>;
                      reg-names = "dbi", "config";
                      interrupts = <0 69 0x4>;
-                     interrupt-map-mask = <0 0 0 0>;
-                     interrupt-map = <0x0 0 &gic 0 69 0x4>;
                      num-lanes = <1>;
                      phys = <&miphy1 1>;
                      phy-names = "pcie-phy";

@@ -120,8 +116,6 @@ pcie2: pcie@b4000000 {
                      reg = <0xb4000000 0x4000>, <0xc0000000 0x20000>;
                      reg-names = "dbi", "config";
                      interrupts = <0 70 0x4>;
-                     interrupt-map-mask = <0 0 0 0>;
-                     interrupt-map = <0x0 0 &gic 0 70 0x4>;
                      num-lanes = <1>;
                      phys = <&miphy2 1>;
                      phy-names = "pcie-phy";
arch/arm/boot/dts/spear1340.dtsi +0 -0
index 1a8f5e8b10e3..827e887afbda 100644

arch/arm/boot/dts/spear1340.dtsi pcie0: pcie@b1000000 { · line 52

Quoted 8 lines
arch/arm/boot/dts/spear1340.dtsi +0 -2
@@ -47,8 +47,6 @@ pcie0: pcie@b1000000 {
                      reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
                      reg-names = "dbi", "config";
                      interrupts = <0 68 0x4>;
-                     interrupt-map-mask = <0 0 0 0>;
-                     interrupt-map = <0x0 0 &gic 0 68 0x4>;
                      num-lanes = <1>;
                      phys = <&miphy0 1>;
                      phy-names = "pcie-phy";
Acked-by Viresh Kumar <[email protected]>
Quoted 4 lines
Quoted 1 line

Are you going to apply this?

No, you or Arnd can directly apply it. I don't send pull requests for SPEAr anymore due to very low traffic.

Sigh. Where is this tribal knowledge documented?

[email protected] should be listed in the MAINTAINERS entry if that is the case (yes, I know they don't want to be).

Rob