Skip to contentSkip to conversation

staging: vt6655: Rename byPreambleType field

PATCH RESEND New Karolina Drobnik 1 participant 1 message Oct 18, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH RESEND v3 1/1 staging: vt6655: Rename byPreambleType field

Drop Hungarian notation prefix in byPreambleType member of struct vnt_private. Change it to use snake case.

Fix issue detected by checkpatch.pl:
CHECK: Avoid CamelCase: <byPreambleType>

---
v3:
* Revert parameter name change in bb_get_frame_time function, update patch description

v2:
* Revert whitespace comment change for by_pkt_type parameter

 drivers/staging/vt6655/baseband.c    |  2 +-
 drivers/staging/vt6655/device.h      |  2 +-
 drivers/staging/vt6655/device_main.c |  8 ++---
 drivers/staging/vt6655/rxtx.c        | 50 ++++++++++++++--------------
 4 files changed, 31 insertions(+), 31 deletions(-)
drivers/staging/vt6655/baseband.c +1 -1
index 0bae35af6e0f..5efca92f1f18 100644
@@ -1764,7 +1764,7 @@ void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length,
 	u32 count = 0;
 	u32 tmp;
 	int ext_bit;
-	u8 preamble_type = priv->byPreambleType;
+	u8 preamble_type = priv->preamble_type;
 
 	bit_count = frame_length * 8;
 	ext_bit = false;
drivers/staging/vt6655/device.h +1 -1
index 92d6f82f939f..4706bde1ec1d 100644
@@ -203,7 +203,7 @@ struct vnt_private {
 	unsigned char byMinChannel;
 	unsigned char byMaxChannel;
 
-	unsigned char byPreambleType;
+	unsigned char preamble_type;
 	unsigned char byShortPreamble;
 
 	unsigned short wCurrentRate;
drivers/staging/vt6655/device_main.c +4 -4
index 24f0e346da12..212d2a287b2c 100644
@@ -177,11 +177,11 @@ device_set_options(struct vnt_private *priv)
 	priv->byPacketType = priv->byBBType;
 	priv->byAutoFBCtrl = AUTO_FB_0;
 	priv->bUpdateBBVGA = true;
-	priv->byPreambleType = 0;
+	priv->preamble_type = 0;
 
 	pr_debug(" byShortRetryLimit= %d\n", (int)priv->byShortRetryLimit);
 	pr_debug(" byLongRetryLimit= %d\n", (int)priv->byLongRetryLimit);
-	pr_debug(" byPreambleType= %d\n", (int)priv->byPreambleType);
+	pr_debug(" preamble_type= %d\n", (int)priv->preamble_type);
 	pr_debug(" byShortPreamble= %d\n", (int)priv->byShortPreamble);
 	pr_debug(" byBBType= %d\n", (int)priv->byBBType);
 }
@@ -1424,10 +1424,10 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
 	if (changed & BSS_CHANGED_ERP_PREAMBLE) {
 		if (conf->use_short_preamble) {
 			MACvEnableBarkerPreambleMd(priv->port_offset);
-			priv->byPreambleType = true;
+			priv->preamble_type = true;
 		} else {
 			MACvDisableBarkerPreambleMd(priv->port_offset);
-			priv->byPreambleType = false;
+			priv->preamble_type = false;
 		}
 	}
 
drivers/staging/vt6655/rxtx.c +25 -25

143 lines not on this page · raw message

Signature · 1 line
2.30.2