staging: vt6655: Rename byPreambleType field
PATCH v3 1/1 staging: vt6655: Rename byPreambleType field
Drop Hungarian notation prefix in byPreambleType member of struct vnt_private. Change it to use snake case.
Fix issue detected by checkpatch.pl:
CHECK: Avoid CamelCase: <byPreambleType>
--- drivers/staging/vt6655/baseband.c | 2 +- drivers/staging/vt6655/device.h | 2 +- drivers/staging/vt6655/device_main.c | 8 ++--- drivers/staging/vt6655/rxtx.c | 50 ++++++++++++++-------------- 4 files changed, 31 insertions(+), 31 deletions(-)
drivers/staging/vt6655/baseband.c +1 -1
@@ -1764,7 +1764,7 @@ void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length,u32 count =0 ;u32 tmp;int ext_bit; -u8 preamble_type = priv->byPreambleType; +u8 preamble_type = priv->preamble_type; bit_count = frame_length *8 ; ext_bit = false;
drivers/staging/vt6655/device.h +1 -1
@@ -203,7 +203,7 @@ struct vnt_private {unsigned char byMinChannel;unsigned char byMaxChannel; -unsigned char byPreambleType; +unsigned char preamble_type;unsigned char byShortPreamble;unsigned short wCurrentRate;
drivers/staging/vt6655/device_main.c +4 -4
@@ -177,11 +177,11 @@ device_set_options(struct vnt_private *priv) priv->byPacketType = priv->byBBType; priv->byAutoFBCtrl =AUTO_FB_0 ; priv->bUpdateBBVGA = true; - priv->byPreambleType =0 ; + priv->preamble_type =0 ;pr_debug (" byShortRetryLimit= %d\n" , (int )priv->byShortRetryLimit);pr_debug (" byLongRetryLimit= %d\n" , (int )priv->byLongRetryLimit); -pr_debug (" byPreambleType= %d\n" , (int )priv->byPreambleType); +pr_debug (" preamble_type= %d\n" , (int )priv->preamble_type);pr_debug (" byShortPreamble= %d\n" , (int )priv->byShortPreamble);pr_debug (" byBBType= %d\n" , (int )priv->byBBType); }
@@ -1424,10 +1424,10 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,if (changed &BSS_CHANGED_ERP_PREAMBLE ) {if (conf->use_short_preamble) {MACvEnableBarkerPreambleMd (priv->port_offset); - priv->byPreambleType = true; + priv->preamble_type = true; }else {MACvDisableBarkerPreambleMd (priv->port_offset); - priv->byPreambleType = false; + priv->preamble_type = false; } }
drivers/staging/vt6655/rxtx.c +25 -25
143 lines not on this page · raw message
Signature · 1 line
2.30.2
Greg KH
maintainerQuoted 6 lines · Karolina Drobnik
Drop Hungarian notation prefix in
byPreambleTypemember of structvnt_private. Change it to use snake case.Fix issue detected by checkpatch.pl:
CHECK: Avoid CamelCase: <byPreambleType>
Quoted 8 lines
Signed-off-by Karolina Drobnik <[email protected]>--- drivers/staging/vt6655/baseband.c | 2 +- drivers/staging/vt6655/device.h | 2 +- drivers/staging/vt6655/device_main.c | 8 ++--- drivers/staging/vt6655/rxtx.c | 50 ++++++++++++++-------------- 4 files changed, 31 insertions(+), 31 deletions(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot