Skip to contentSkip to conversation

riscv: switch to relative extable

PATCH Superseded Jisheng Zhang 2 participants 8 messages Oct 20, 2021 – Oct 22, 2021

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover riscv: switch to relative extable

From: Jisheng Zhang <[email protected]>

Similar as other architectures such as arm64, x86 and so on, use offsets relative to the exception table entry values rather than absolute addresses for both the exception locationand the fixup.

patch1 consolidates the __ex_table construction, it's a great code clean up even w/o the 2nd patch.

patch2 does the real job.

Since v1:
- fix build error for NOMMU case, thank [email protected]

Jisheng Zhang (2):
riscv: consolidate __ex_table construction
riscv: switch to relative exception tables

 arch/riscv/include/asm/Kbuild    |  1 -
 arch/riscv/include/asm/extable.h | 25 ++++++++++++++++++++
 arch/riscv/include/asm/futex.h   | 12 +++-------
 arch/riscv/include/asm/uaccess.h | 40 +++++++++++---------------------
 arch/riscv/lib/uaccess.S         |  4 ++--
 arch/riscv/mm/extable.c          |  2 +-
 scripts/mod/modpost.c            | 27 +++++++++++++++++++++
 scripts/sorttable.c              |  2 +-
 8 files changed, 73 insertions(+), 40 deletions(-)
 create mode 100644 arch/riscv/include/asm/extable.h
Signature · 1 line
2.33.0
#1 lore raw

PATCH v2 1/2 riscv: consolidate __ex_table construction

From: Jisheng Zhang <[email protected]>

Consolidate all the __ex_table constuction code with a _ASM_EXTABLE helper.

There should be no functional change as a result of this patch.

---
 arch/riscv/include/asm/futex.h   | 12 +++-------
 arch/riscv/include/asm/uaccess.h | 40 +++++++++++---------------------
 2 files changed, 17 insertions(+), 35 deletions(-)
arch/riscv/include/asm/futex.h +3 -9
index 1b00badb9f87..3191574e135c 100644
@@ -30,10 +30,7 @@
 	"3:	li %[r],%[e]				\n"	\
 	"	jump 2b,%[t]				\n"	\
 	"	.previous				\n"	\
-	"	.section __ex_table,\"a\"		\n"	\
-	"	.balign " RISCV_SZPTR "			\n"	\
-	"	" RISCV_PTR " 1b, 3b			\n"	\
-	"	.previous				\n"	\
+		_ASM_EXTABLE(1b, 3b)				\
 	: [r] "+r" (ret), [ov] "=&r" (oldval),			\
 	  [u] "+m" (*uaddr), [t] "=&r" (tmp)			\
 	: [op] "Jr" (oparg), [e] "i" (-EFAULT)			\
@@ -103,11 +100,8 @@ futex_atomic_cmpxchg_inatomic(u32 *uval, u32 __user *uaddr,
 	"4:	li %[r],%[e]				\n"
 	"	jump 3b,%[t]				\n"
 	"	.previous				\n"
-	"	.section __ex_table,\"a\"		\n"
-	"	.balign " RISCV_SZPTR "			\n"
-	"	" RISCV_PTR " 1b, 4b			\n"
-	"	" RISCV_PTR " 2b, 4b			\n"
-	"	.previous				\n"
+		_ASM_EXTABLE(1b, 4b)			\
+		_ASM_EXTABLE(2b, 4b)			\
 	: [r] "+r" (ret), [v] "=&r" (val), [u] "+m" (*uaddr), [t] "=&r" (tmp)
 	: [ov] "Jr" (oldval), [nv] "Jr" (newval), [e] "i" (-EFAULT)
 	: "memory");
arch/riscv/include/asm/uaccess.h +14 -26
index f314ff44c48d..35802e72ace8 100644
@@ -10,6 +10,12 @@
 
 #include <asm/pgtable.h>		/* for TASK_SIZE */
 
+#define _ASM_EXTABLE(from, to)						\
+	"	.pushsection	__ex_table, \"a\"\n"			\
+	"	.balign "	RISCV_SZPTR "	 \n"			\
+	"	" RISCV_PTR	"(" #from "), (" #to ")\n"		\
+	"	.popsection\n"
+
 /*
  * User space memory access functions
  */
@@ -93,10 +99,7 @@ do {								\
 		"	li %1, 0\n"				\
 		"	jump 2b, %2\n"				\
 		"	.previous\n"				\
-		"	.section __ex_table,\"a\"\n"		\
-		"	.balign " RISCV_SZPTR "\n"			\
-		"	" RISCV_PTR " 1b, 3b\n"			\
-		"	.previous"				\
+			_ASM_EXTABLE(1b, 3b)			\
 		: "+r" (err), "=&r" (__x), "=r" (__tmp)		\
 		: "m" (*(ptr)), "i" (-EFAULT));			\
 	(x) = __x;						\
@@ -125,11 +128,8 @@ do {								\
 		"	li %2, 0\n"				\
 		"	jump 3b, %3\n"				\
 		"	.previous\n"				\
-		"	.section __ex_table,\"a\"\n"		\
-		"	.balign " RISCV_SZPTR "\n"			\
-		"	" RISCV_PTR " 1b, 4b\n"			\
-		"	" RISCV_PTR " 2b, 4b\n"			\
-		"	.previous"				\
+			_ASM_EXTABLE(1b, 4b)			\
+			_ASM_EXTABLE(2b, 4b)			\
 		: "+r" (err), "=&r" (__lo), "=r" (__hi),	\
 			"=r" (__tmp)				\
 		: "m" (__ptr[__LSW]), "m" (__ptr[__MSW]),	\
@@ -233,10 +233,7 @@ do {								\
 		"	li %0, %4\n"				\
 		"	jump 2b, %1\n"				\
 		"	.previous\n"				\
-		"	.section __ex_table,\"a\"\n"		\
-		"	.balign " RISCV_SZPTR "\n"			\
-		"	" RISCV_PTR " 1b, 3b\n"			\
-		"	.previous"				\
+			_ASM_EXTABLE(1b, 3b)			\
 		: "+r" (err), "=r" (__tmp), "=m" (*(ptr))	\
 		: "rJ" (__x), "i" (-EFAULT));			\
 } while (0)
@@ -262,11 +259,8 @@ do {								\
 		"	li %0, %6\n"				\
 		"	jump 3b, %1\n"				\
 		"	.previous\n"				\
-		"	.section __ex_table,\"a\"\n"		\
-		"	.balign " RISCV_SZPTR "\n"			\
-		"	" RISCV_PTR " 1b, 4b\n"			\
-		"	" RISCV_PTR " 2b, 4b\n"			\
-		"	.previous"				\
+			_ASM_EXTABLE(1b, 4b)			\
+			_ASM_EXTABLE(2b, 4b)			\
 		: "+r" (err), "=r" (__tmp),			\
 			"=m" (__ptr[__LSW]),			\
 			"=m" (__ptr[__MSW])			\
@@ -417,10 +411,7 @@ unsigned long __must_check clear_user(void __user *to, unsigned long n)
 		"	li %[err], %[efault]\n"			\
 		"	jump 1b, %[rc]\n"			\
 		".previous\n"					\
-		".section __ex_table,\"a\"\n"			\
-		".balign " RISCV_SZPTR "\n"			\
-		"	" RISCV_PTR " 1b, 2b\n"			\
-		".previous\n"					\
+		_ASM_EXTABLE(1b, 2b)				\
 			: [ret] "=&r" (__ret),			\
 			  [rc]  "=&r" (__rc),			\
 			  [ptr] "+A" (*__ptr),			\
@@ -443,10 +434,7 @@ unsigned long __must_check clear_user(void __user *to, unsigned long n)
 		"	li %[err], %[efault]\n"			\
 		"	jump 1b, %[rc]\n"			\
 		".previous\n"					\
-		".section __ex_table,\"a\"\n"			\
-		".balign " RISCV_SZPTR "\n"			\
-		"	" RISCV_PTR " 1b, 2b\n"			\
-		".previous\n"					\
+		_ASM_EXTABLE(1b, 2b)				\
 			: [ret] "=&r" (__ret),			\
 			  [rc]  "=&r" (__rc),			\
 			  [ptr] "+A" (*__ptr),			\
Signature · 1 line
2.33.0
#2 lore raw

Re: [PATCH v2 1/2] riscv: consolidate __ex_table construction

Quoted 48 lines · Jisheng Zhang

From: Jisheng Zhang <[email protected]>

Consolidate all the __ex_table constuction code with a _ASM_EXTABLE helper.

There should be no functional change as a result of this patch.

---
  arch/riscv/include/asm/futex.h   | 12 +++-------
  arch/riscv/include/asm/uaccess.h | 40 +++++++++++---------------------
  2 files changed, 17 insertions(+), 35 deletions(-)
arch/riscv/include/asm/futex.h +3 -9
index 1b00badb9f87..3191574e135c 100644
@@ -30,10 +30,7 @@
  	"3:	li %[r],%[e]				\n"	\
  	"	jump 2b,%[t]				\n"	\
  	"	.previous				\n"	\
-	"	.section __ex_table,\"a\"		\n"	\
-	"	.balign " RISCV_SZPTR "			\n"	\
-	"	" RISCV_PTR " 1b, 3b			\n"	\
-	"	.previous				\n"	\
+		_ASM_EXTABLE(1b, 3b)				\
  	: [r] "+r" (ret), [ov] "=&r" (oldval),			\
  	  [u] "+m" (*uaddr), [t] "=&r" (tmp)			\
  	: [op] "Jr" (oparg), [e] "i" (-EFAULT)			\
@@ -103,11 +100,8 @@ futex_atomic_cmpxchg_inatomic(u32 *uval, u32 __user *uaddr,
  	"4:	li %[r],%[e]				\n"
  	"	jump 3b,%[t]				\n"
  	"	.previous				\n"
-	"	.section __ex_table,\"a\"		\n"
-	"	.balign " RISCV_SZPTR "			\n"
-	"	" RISCV_PTR " 1b, 4b			\n"
-	"	" RISCV_PTR " 2b, 4b			\n"
-	"	.previous				\n"
+		_ASM_EXTABLE(1b, 4b)			\
+		_ASM_EXTABLE(2b, 4b)			\
  	: [r] "+r" (ret), [v] "=&r" (val), [u] "+m" (*uaddr), [t] "=&r" (tmp)
  	: [ov] "Jr" (oldval), [nv] "Jr" (newval), [e] "i" (-EFAULT)
  	: "memory");
arch/riscv/include/asm/uaccess.h +0 -0
index f314ff44c48d..35802e72ace8 100644

arch/riscv/include/asm/uaccess.h line 18

Quoted 9 lines
arch/riscv/include/asm/uaccess.h +6 -0
@@ -10,6 +10,12 @@
 
  #include <asm/pgtable.h>		/* for TASK_SIZE */
 
+#define _ASM_EXTABLE(from, to)						\
+	"	.pushsection	__ex_table, \"a\"\n"			\
+	"	.balign "	RISCV_SZPTR "	 \n"			\
+	"	" RISCV_PTR	"(" #from "), (" #to ")\n"		\
+	"	.popsection\n"
+

The jump_label mechanism could use this macro too,
see arch/riscv/include/asm/jump_label.h, maybe move the above into asm.h and also do some replace in next patch ?

Question: the jump label use relative address, but why not trigger the Section mismatch issue?

#3 lore raw

Re: [PATCH v2 1/2] riscv: consolidate __ex_table construction

Quoted 52 lines · On Thu, 21 Oct 2021 19:38:41 +0800 Kefeng Wang <[email protected]>…
Quoted 51 lines · Jisheng Zhang

From: Jisheng Zhang <[email protected]>

Consolidate all the __ex_table constuction code with a _ASM_EXTABLE helper.

There should be no functional change as a result of this patch.

---
  arch/riscv/include/asm/futex.h   | 12 +++-------
  arch/riscv/include/asm/uaccess.h | 40 +++++++++++---------------------
  2 files changed, 17 insertions(+), 35 deletions(-)
arch/riscv/include/asm/futex.h +3 -9
index 1b00badb9f87..3191574e135c 100644
@@ -30,10 +30,7 @@
  	"3:	li %[r],%[e]				\n"	\
  	"	jump 2b,%[t]				\n"	\
  	"	.previous				\n"	\
-	"	.section __ex_table,\"a\"		\n"	\
-	"	.balign " RISCV_SZPTR "			\n"	\
-	"	" RISCV_PTR " 1b, 3b			\n"	\
-	"	.previous				\n"	\
+		_ASM_EXTABLE(1b, 3b)				\
  	: [r] "+r" (ret), [ov] "=&r" (oldval),			\
  	  [u] "+m" (*uaddr), [t] "=&r" (tmp)			\
  	: [op] "Jr" (oparg), [e] "i" (-EFAULT)			\
@@ -103,11 +100,8 @@ futex_atomic_cmpxchg_inatomic(u32 *uval, u32 __user *uaddr,
  	"4:	li %[r],%[e]				\n"
  	"	jump 3b,%[t]				\n"
  	"	.previous				\n"
-	"	.section __ex_table,\"a\"		\n"
-	"	.balign " RISCV_SZPTR "			\n"
-	"	" RISCV_PTR " 1b, 4b			\n"
-	"	" RISCV_PTR " 2b, 4b			\n"
-	"	.previous				\n"
+		_ASM_EXTABLE(1b, 4b)			\
+		_ASM_EXTABLE(2b, 4b)			\
  	: [r] "+r" (ret), [v] "=&r" (val), [u] "+m" (*uaddr), [t] "=&r" (tmp)
  	: [ov] "Jr" (oldval), [nv] "Jr" (newval), [e] "i" (-EFAULT)
  	: "memory");
arch/riscv/include/asm/uaccess.h +0 -0
index f314ff44c48d..35802e72ace8 100644
@@ -10,6 +10,12 @@
 
  #include <asm/pgtable.h>		/* for TASK_SIZE */
 
Quoted 10 lines

arch/riscv/include/asm/uaccess.h line 18

Quoted 6 lines
arch/riscv/include/asm/uaccess.h +6 -0
+#define _ASM_EXTABLE(from, to)						\
+	"	.pushsection	__ex_table, \"a\"\n"			\
+	"	.balign "	RISCV_SZPTR "	 \n"			\
+	"	" RISCV_PTR	"(" #from "), (" #to ")\n"		\
+	"	.popsection\n"
+  

The jump_label mechanism could use this macro too,
see arch/riscv/include/asm/jump_label.h, maybe move the above into asm.h and also do some replace in next patch ?

jump_label entry is a bit different with ex_table: two relative offsets and a key which should be "long" type.

Quoted 3 lines

Question: the jump label use relative address, but why not trigger the Section mismatch issue?

FWICT, modpost doesn't check __jump_table section

#4 lore raw

Re: [PATCH v2 1/2] riscv: consolidate __ex_table construction

Quoted 66 lines · Jisheng Zhang
Quoted 52 lines · On Thu, 21 Oct 2021 19:38:41 +0800 Kefeng Wang <[email protected]>…
Quoted 51 lines · Jisheng Zhang

From: Jisheng Zhang <[email protected]>

Consolidate all the __ex_table constuction code with a _ASM_EXTABLE helper.

There should be no functional change as a result of this patch.

---
   arch/riscv/include/asm/futex.h   | 12 +++-------
   arch/riscv/include/asm/uaccess.h | 40 +++++++++++---------------------
   2 files changed, 17 insertions(+), 35 deletions(-)
arch/riscv/include/asm/futex.h +3 -9
index 1b00badb9f87..3191574e135c 100644
@@ -30,10 +30,7 @@
   	"3:	li %[r],%[e]				\n"	\
   	"	jump 2b,%[t]				\n"	\
   	"	.previous				\n"	\
-	"	.section __ex_table,\"a\"		\n"	\
-	"	.balign " RISCV_SZPTR "			\n"	\
-	"	" RISCV_PTR " 1b, 3b			\n"	\
-	"	.previous				\n"	\
+		_ASM_EXTABLE(1b, 3b)				\
   	: [r] "+r" (ret), [ov] "=&r" (oldval),			\
   	  [u] "+m" (*uaddr), [t] "=&r" (tmp)			\
   	: [op] "Jr" (oparg), [e] "i" (-EFAULT)			\
@@ -103,11 +100,8 @@ futex_atomic_cmpxchg_inatomic(u32 *uval, u32 __user *uaddr,
   	"4:	li %[r],%[e]				\n"
   	"	jump 3b,%[t]				\n"
   	"	.previous				\n"
-	"	.section __ex_table,\"a\"		\n"
-	"	.balign " RISCV_SZPTR "			\n"
-	"	" RISCV_PTR " 1b, 4b			\n"
-	"	" RISCV_PTR " 2b, 4b			\n"
-	"	.previous				\n"
+		_ASM_EXTABLE(1b, 4b)			\
+		_ASM_EXTABLE(2b, 4b)			\
   	: [r] "+r" (ret), [v] "=&r" (val), [u] "+m" (*uaddr), [t] "=&r" (tmp)
   	: [ov] "Jr" (oldval), [nv] "Jr" (newval), [e] "i" (-EFAULT)
   	: "memory");
arch/riscv/include/asm/uaccess.h +0 -0
index f314ff44c48d..35802e72ace8 100644
@@ -10,6 +10,12 @@
 
   #include <asm/pgtable.h>		/* for TASK_SIZE */
 
Quoted 10 lines

arch/riscv/include/asm/uaccess.h line 18

Quoted 6 lines
arch/riscv/include/asm/uaccess.h +6 -0
+#define _ASM_EXTABLE(from, to)						\
+	"	.pushsection	__ex_table, \"a\"\n"			\
+	"	.balign "	RISCV_SZPTR "	 \n"			\
+	"	" RISCV_PTR	"(" #from "), (" #to ")\n"		\
+	"	.popsection\n"
+

The jump_label mechanism could use this macro too,
see arch/riscv/include/asm/jump_label.h, maybe move the above into asm.h and also do some replace in next patch ?

Quoted 8 lines

jump_label entry is a bit different with ex_table: two relative offsets and a key which should be "long" type.

Quoted 3 lines

Question: the jump label use relative address, but why not trigger the Section mismatch issue?

FWICT, modpost doesn't check __jump_table section

OK, missing that.

Quoted 4 lines

.

#5 lore raw

PATCH v2 2/2 riscv: switch to relative exception tables

In reply to Jisheng Zhang

From: Jisheng Zhang <[email protected]>

Similar as other architectures such as arm64, x86 and so on, use offsets relative to the exception table entry values rather than absolute addresses for both the exception locationand the fixup.

However, RISCV label difference will actually produce two relocations, a pair of R_RISCV_ADD32 and R_RISCV_SUB32. Take below simple code for example:

$ cat test.S
.section .text
1:
        nop
.section __ex_table,"a"
        .balign 4
        .long (1b - .)
.previous
$ riscv64-linux-gnu-gcc -c test.S
$ riscv64-linux-gnu-readelf -r test.o
Relocation section '.rela__ex_table' at offset 0x100 contains 2 entries:
  Offset          Info           Type           Sym. Value    Sym. Name + Addend
000000000000  000600000023 R_RISCV_ADD32     0000000000000000 .L1^B1 + 0
000000000000  000500000027 R_RISCV_SUB32     0000000000000000 .L0  + 0

The modpost will complain the R_RISCV_SUB32 relocation, so we need to patch modpost.c to skip this relocation for .rela__ex_table section.

After this patch, the __ex_table section size of defconfig vmlinux is reduced from 7072 Bytes to 3536 Bytes.

---
 arch/riscv/include/asm/Kbuild    |  1 -
 arch/riscv/include/asm/extable.h | 25 +++++++++++++++++++++++++
 arch/riscv/include/asm/uaccess.h |  4 ++--
 arch/riscv/lib/uaccess.S         |  4 ++--
 arch/riscv/mm/extable.c          |  2 +-
 scripts/mod/modpost.c            | 27 +++++++++++++++++++++++++++
 scripts/sorttable.c              |  2 +-
 7 files changed, 58 insertions(+), 7 deletions(-)
 create mode 100644 arch/riscv/include/asm/extable.h
arch/riscv/include/asm/Kbuild +0 -1
index 445ccc97305a..57b86fd9916c 100644
@@ -1,6 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0
 generic-y += early_ioremap.h
-generic-y += extable.h
 generic-y += flat.h
 generic-y += kvm_para.h
 generic-y += user.h
arch/riscv/include/asm/extable.h new file +25 -0
new file mode 100644
index 000000000000..bc439b0fdb29
@@ -0,0 +1,25 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _ASM_RISCV_EXTABLE_H
+#define _ASM_RISCV_EXTABLE_H
+
+/*
+ * The exception table consists of pairs of relative offsets: the first
+ * is the relative offset to an instruction that is allowed to fault,
+ * and the second is the relative offset at which the program should
+ * continue. No registers are modified, so it is entirely up to the
+ * continuation code to figure out what to do.
+ *
+ * All the routines below use bits of fixup code that are out of line
+ * with the main instruction path.  This means when everything is well,
+ * we don't even have to jump over them.  Further, they do not intrude
+ * on our cache or tlb entries.
+ */
+
+struct exception_table_entry {
+	int insn, fixup;
+};
+
+#define ARCH_HAS_RELATIVE_EXTABLE
+
+extern int fixup_exception(struct pt_regs *regs);
+#endif
arch/riscv/include/asm/uaccess.h +2 -2
index 35802e72ace8..540903c7d3e8 100644
@@ -12,8 +12,8 @@
 
 #define _ASM_EXTABLE(from, to)						\
 	"	.pushsection	__ex_table, \"a\"\n"			\
-	"	.balign "	RISCV_SZPTR "	 \n"			\
-	"	" RISCV_PTR	"(" #from "), (" #to ")\n"		\
+	"	.balign		4\n"					\
+	"	.long		(" #from " - .), (" #to " - .)\n"	\
 	"	.popsection\n"
 
 /*
arch/riscv/lib/uaccess.S +2 -2
index 63bc691cff91..55f80f84e23f 100644
@@ -7,8 +7,8 @@
 100:
 	\op \reg, \addr
 	.section __ex_table,"a"
-	.balign RISCV_SZPTR
-	RISCV_PTR 100b, \lbl
+	.balign 4
+	.long (100b - .), (\lbl - .)
 	.previous
 	.endm
 
arch/riscv/mm/extable.c +1 -1
index 2fc729422151..6aa8ffac4be7 100644
@@ -17,7 +17,7 @@ int fixup_exception(struct pt_regs *regs)
 
 	fixup = search_exception_tables(regs->epc);
 	if (fixup) {
-		regs->epc = fixup->fixup;
+		regs->epc = (unsigned long)&fixup->fixup + fixup->fixup;
 		return 1;
 	}
 	return 0;
scripts/mod/modpost.c +27 -0
index cb8ab7d91d30..0aa14b5bd124 100644
@@ -1830,6 +1830,27 @@ static int addend_mips_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r)
 	return 0;
 }
 
+#ifndef EM_RISCV
+#define EM_RISCV		243
+#endif
+
+#ifndef R_RISCV_SUB32
+#define R_RISCV_SUB32		39
+#endif
+
+static int addend_riscv_rela(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r)
+{
+	unsigned int r_typ = ELF_R_TYPE(r->r_info);
+	const char *fromsec;
+
+	fromsec = sech_name(elf, sechdr);
+	fromsec += strlen(".rela");
+
+	if (!strcmp("__ex_table", fromsec) && r_typ == R_RISCV_SUB32)
+		return 1;	/* skip this */
+	return 0;
+}
+
 static void section_rela(const char *modname, struct elf_info *elf,
 			 Elf_Shdr *sechdr)
 {
@@ -1866,6 +1887,12 @@ static void section_rela(const char *modname, struct elf_info *elf,
 		r_sym = ELF_R_SYM(r.r_info);
 #endif
 		r.r_addend = TO_NATIVE(rela->r_addend);
+		switch (elf->hdr->e_machine) {
+		case EM_RISCV:
+			if (addend_riscv_rela(elf, sechdr, &r))
+				continue;
+			break;
+		}
 		sym = elf->symtab_start + r_sym;
 		/* Skip special sections */
 		if (is_shndx_special(sym->st_shndx))
scripts/sorttable.c +1 -1
index 6ee4fa882919..39e86e4acea3 100644
@@ -346,6 +346,7 @@ static int do_file(char const *const fname, void *addr)
 	case EM_PARISC:
 	case EM_PPC:
 	case EM_PPC64:
+	case EM_RISCV:
 		custom_sort = sort_relative_table;
 		break;
 	case EM_ARCOMPACT:
@@ -353,7 +354,6 @@ static int do_file(char const *const fname, void *addr)
 	case EM_ARM:
 	case EM_MICROBLAZE:
 	case EM_MIPS:
-	case EM_RISCV:
 	case EM_XTENSA:
 		break;
 	default:
Signature · 1 line
2.33.0
#6 lore raw

Re: [PATCH v2 2/2] riscv: switch to relative exception tables

Quoted 34 lines · Jisheng Zhang

From: Jisheng Zhang <[email protected]>

Similar as other architectures such as arm64, x86 and so on, use offsets relative to the exception table entry values rather than absolute addresses for both the exception locationand the fixup.

However, RISCV label difference will actually produce two relocations, a pair of R_RISCV_ADD32 and R_RISCV_SUB32. Take below simple code for example:

$ cat test.S
.section .text
1:
         nop
.section __ex_table,"a"
         .balign 4
         .long (1b - .)
.previous
$ riscv64-linux-gnu-gcc -c test.S
$ riscv64-linux-gnu-readelf -r test.o
Relocation section '.rela__ex_table' at offset 0x100 contains 2 entries:
   Offset          Info           Type           Sym. Value    Sym. Name + Addend
000000000000  000600000023 R_RISCV_ADD32     0000000000000000 .L1^B1 + 0
000000000000  000500000027 R_RISCV_SUB32     0000000000000000 .L0  + 0

The modpost will complain the R_RISCV_SUB32 relocation, so we need to patch modpost.c to skip this relocation for .rela__ex_table section.

After this patch, the __ex_table section size of defconfig vmlinux is reduced from 7072 Bytes to 3536 Bytes.

---

...

Quoted 33 lines
scripts/mod/modpost.c +21 -0
index cb8ab7d91d30..0aa14b5bd124 100644
@@ -1830,6 +1830,27 @@ static int addend_mips_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r)
  	return 0;
  }
 
+#ifndef EM_RISCV
+#define EM_RISCV		243
+#endif
+
+#ifndef R_RISCV_SUB32
+#define R_RISCV_SUB32		39
+#endif
+
+static int addend_riscv_rela(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r)
+{
+	unsigned int r_typ = ELF_R_TYPE(r->r_info);
+	const char *fromsec;
+
+	fromsec = sech_name(elf, sechdr);
+	fromsec += strlen(".rela");
+
+	if (!strcmp("__ex_table", fromsec) && r_typ == R_RISCV_SUB32)
+		return 1;	/* skip this */
+	return 0;
+}
+
  static void section_rela(const char *modname, struct elf_info *elf,
  			 Elf_Shdr *sechdr)
  {

scripts/mod/modpost.c static void section_rela(const char *modname, struct elf_info *elf, · line 1892

Quoted 6 lines
scripts/mod/modpost.c +3 -0
@@ -1866,6 +1887,12 @@ static void section_rela(const char *modname, struct elf_info *elf,
  		r_sym = ELF_R_SYM(r.r_info);
  #endif
  		r.r_addend = TO_NATIVE(rela->r_addend);
+		switch (elf->hdr->e_machine) {
+		case EM_RISCV:
+			if (addend_riscv_rela(elf, sechdr, &r))

directly use
if (!strcmp("__ex_table", fromsec) && ELF_R_TYPE(r.r_info) == R_RISCV_SUB32)

Quoted 27 lines
scripts/mod/modpost.c +3 -0
+				continue;
+			break;
+		}
  		sym = elf->symtab_start + r_sym;
  		/* Skip special sections */
  		if (is_shndx_special(sym->st_shndx))
scripts/sorttable.c +1 -1
index 6ee4fa882919..39e86e4acea3 100644
@@ -346,6 +346,7 @@ static int do_file(char const *const fname, void *addr)
  	case EM_PARISC:
  	case EM_PPC:
  	case EM_PPC64:
+	case EM_RISCV:
  		custom_sort = sort_relative_table;
  		break;
  	case EM_ARCOMPACT:
@@ -353,7 +354,6 @@ static int do_file(char const *const fname, void *addr)
  	case EM_ARM:
  	case EM_MICROBLAZE:
  	case EM_MIPS:
-	case EM_RISCV:
  	case EM_XTENSA:
  		break;
  	default:
#7 lore raw

Re: [PATCH v2 2/2] riscv: switch to relative exception tables

Quoted 72 lines · On Thu, 21 Oct 2021 19:42:48 +0800 Kefeng Wang <[email protected]>…
Quoted 34 lines · Jisheng Zhang

From: Jisheng Zhang <[email protected]>

Similar as other architectures such as arm64, x86 and so on, use offsets relative to the exception table entry values rather than absolute addresses for both the exception locationand the fixup.

However, RISCV label difference will actually produce two relocations, a pair of R_RISCV_ADD32 and R_RISCV_SUB32. Take below simple code for example:

$ cat test.S
.section .text
1:
         nop
.section __ex_table,"a"
         .balign 4
         .long (1b - .)
.previous
$ riscv64-linux-gnu-gcc -c test.S
$ riscv64-linux-gnu-readelf -r test.o
Relocation section '.rela__ex_table' at offset 0x100 contains 2 entries:
   Offset          Info           Type           Sym. Value    Sym. Name + Addend
000000000000  000600000023 R_RISCV_ADD32     0000000000000000 .L1^B1 + 0
000000000000  000500000027 R_RISCV_SUB32     0000000000000000 .L0  + 0

The modpost will complain the R_RISCV_SUB32 relocation, so we need to patch modpost.c to skip this relocation for .rela__ex_table section.

After this patch, the __ex_table section size of defconfig vmlinux is reduced from 7072 Bytes to 3536 Bytes.

---

...

Quoted 33 lines
scripts/mod/modpost.c +21 -0
index cb8ab7d91d30..0aa14b5bd124 100644
@@ -1830,6 +1830,27 @@ static int addend_mips_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r)
  	return 0;
  }
 
+#ifndef EM_RISCV
+#define EM_RISCV		243
+#endif
+
+#ifndef R_RISCV_SUB32
+#define R_RISCV_SUB32		39
+#endif
+
+static int addend_riscv_rela(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r)
+{
+	unsigned int r_typ = ELF_R_TYPE(r->r_info);
+	const char *fromsec;
+
+	fromsec = sech_name(elf, sechdr);
+	fromsec += strlen(".rela");
+
+	if (!strcmp("__ex_table", fromsec) && r_typ == R_RISCV_SUB32)
+		return 1;	/* skip this */
+	return 0;
+}
+
  static void section_rela(const char *modname, struct elf_info *elf,
  			 Elf_Shdr *sechdr)
  {
@@ -1866,6 +1887,12 @@ static void section_rela(const char *modname, struct elf_info *elf,
Quoted 8 lines

scripts/mod/modpost.c static void section_rela(const char *modname, struct elf_info *elf, · line 1892

Quoted 6 lines
scripts/mod/modpost.c +3 -0
  		r_sym = ELF_R_SYM(r.r_info);
  #endif
  		r.r_addend = TO_NATIVE(rela->r_addend);
+		switch (elf->hdr->e_machine) {
+		case EM_RISCV:
+			if (addend_riscv_rela(elf, sechdr, &r))  

directly use
if (!strcmp("__ex_table", fromsec) && ELF_R_TYPE(r.r_info) == R_RISCV_SUB32)

My local initial patch is as direct as this LoC;) then later I thought we may need do something more in future. But now I think we can do code refactoring then. Will send patch v3 soon.

Thanks

Quoted 20 lines
Quoted 20 lines
scripts/mod/modpost.c +3 -0
+				continue;
+			break;
+		}
  		sym = elf->symtab_start + r_sym;
  		/* Skip special sections */
  		if (is_shndx_special(sym->st_shndx))
scripts/sorttable.c +1 -0
index 6ee4fa882919..39e86e4acea3 100644
@@ -346,6 +346,7 @@ static int do_file(char const *const fname, void *addr)
  	case EM_PARISC:
  	case EM_PPC:
  	case EM_PPC64:
+	case EM_RISCV:
  		custom_sort = sort_relative_table;
  		break;
  	case EM_ARCOMPACT:
@@ -353,7 +354,6 @@ static int do_file(char const *const fname, void *addr)
Quoted 8 lines

scripts/sorttable.c static int do_file(char const *const fname, void *addr) · line 359

Quoted 8 lines
scripts/sorttable.c +0 -1
  	case EM_ARM:
  	case EM_MICROBLAZE:
  	case EM_MIPS:
-	case EM_RISCV:
  	case EM_XTENSA:
  		break;
  	default:

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv