Skip to contentSkip to conversation

riscv: do not select non-existing config ANON_INODES

PATCH Applied Lukas Bulwahn 3 participants 3 messages Oct 22, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 riscv: do not select non-existing config ANON_INODES

Commit 99cdc6c18c2d ("RISC-V: Add initial skeletal KVM support") selects the config ANON_INODES in config KVM, but the config ANON_INODES is removed since commit 5dd50aaeb185 ("Make anon_inodes unconditional") in 2018.

Hence, ./scripts/checkkconfigsymbols.py warns on non-existing symbols:

ANON_INODES
Referencing files: arch/riscv/kvm/Kconfig

Remove selecting the non-existing config ANON_INODES.

---
 arch/riscv/kvm/Kconfig | 1 -
 1 file changed, 1 deletion(-)
arch/riscv/kvm/Kconfig +0 -1
index a712bb910cda..f5a342fa1b1d 100644
@@ -22,7 +22,6 @@ config KVM
 	depends on RISCV_SBI && MMU
 	select MMU_NOTIFIER
 	select PREEMPT_NOTIFIERS
-	select ANON_INODES
 	select KVM_MMIO
 	select KVM_GENERIC_DIRTYLOG_READ_PROTECT
 	select HAVE_KVM_VCPU_ASYNC_IOCTL
Signature · 1 line
2.26.2
maintainer Applied
#1 lore raw
Quoted 22 lines · Lukas Bulwahn

Commit 99cdc6c18c2d ("RISC-V: Add initial skeletal KVM support") selects the config ANON_INODES in config KVM, but the config ANON_INODES is removed since commit 5dd50aaeb185 ("Make anon_inodes unconditional") in 2018.

Hence, ./scripts/checkkconfigsymbols.py warns on non-existing symbols:

ANON_INODES
Referencing files: arch/riscv/kvm/Kconfig

Remove selecting the non-existing config ANON_INODES.

---
  arch/riscv/kvm/Kconfig | 1 -
  1 file changed, 1 deletion(-)
arch/riscv/kvm/Kconfig +0 -0
index a712bb910cda..f5a342fa1b1d 100644

arch/riscv/kvm/Kconfig config KVM · line 27

Quoted 7 lines
arch/riscv/kvm/Kconfig +0 -1
@@ -22,7 +22,6 @@ config KVM
  	depends on RISCV_SBI && MMU
  	select MMU_NOTIFIER
  	select PREEMPT_NOTIFIERS
-	select ANON_INODES
  	select KVM_MMIO
  	select KVM_GENERIC_DIRTYLOG_READ_PROTECT
  	select HAVE_KVM_VCPU_ASYNC_IOCTL

Queued, thanks.

Paolo

maintainer
#2 lore raw
Quoted 18 lines · Paolo Bonzini
Quoted 16 lines · Lukas Bulwahn

Commit 99cdc6c18c2d ("RISC-V: Add initial skeletal KVM support") selects the config ANON_INODES in config KVM, but the config ANON_INODES is removed since commit 5dd50aaeb185 ("Make anon_inodes unconditional") in 2018.

Hence, ./scripts/checkkconfigsymbols.py warns on non-existing symbols:

ANON_INODES
Referencing files: arch/riscv/kvm/Kconfig

Remove selecting the non-existing config ANON_INODES.

---
  arch/riscv/kvm/Kconfig | 1 -
  1 file changed, 1 deletion(-)
Quoted 15 lines

arch/riscv/kvm/Kconfig config KVM · line 27

Quoted 13 lines
arch/riscv/kvm/Kconfig +0 -1
index a712bb910cda..f5a342fa1b1d 100644
@@ -22,7 +22,6 @@ config KVM
      depends on RISCV_SBI && MMU
      select MMU_NOTIFIER
      select PREEMPT_NOTIFIERS
-     select ANON_INODES
      select KVM_MMIO
      select KVM_GENERIC_DIRTYLOG_READ_PROTECT
      select HAVE_KVM_VCPU_ASYNC_IOCTL

Queued, thanks.

Thanks Paolo for applying this directly.

Regards,
Anup

Quoted 3 lines

Paolo