iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config
Subsystems (2)
PATCH 1/1 iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config
Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC") adds the config IMX8QXP_ADC for this new driver, which depends on the non-existing config ARCH_MXC_ARM64.
Hence, ./scripts/checkkconfigsymbols.py warns:
ARCH_MXC_ARM64
Referencing files: drivers/iio/adc/Kconfig
Probably, the existing config ARCH_MXC is intended to be referred here. So, repair the dependency to refer to that config.
--- drivers/iio/adc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/Kconfig +1 -1
@@ -532,7 +532,7 @@ config IMX7D_ADC config IMX8QXP_ADC tristate "NXP IMX8QXP ADC driver" - depends on ARCH_MXC_ARM64 || COMPILE_TEST + depends on ARCH_MXC || COMPILE_TEST depends on HAS_IOMEM help Say yes here to build support for IMX8QXP ADC.
Signature · 1 line
2.26.2
Hi Lukas,
Quoted 7 lines · Lukas Bulwahn
Commit
1e23dcaa1a9f("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC") adds the configIMX8QXP_ADCfor this new driver, which depends on the non-existing configARCH_MXC_ARM64.Hence,
./scripts/checkkconfigsymbols.pywarns:
Quoted 8 lines
ARCH_MXC_ARM64
Referencing files:drivers/iio/adc/KconfigProbably, the existing config
ARCH_MXCis intended to be referred here. So, repair the dependency to refer to that config.Fixes 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")Signed-off-by Lukas Bulwahn <[email protected]>
This looks good.
The incorrect ARCH_MXC_ARM64 symbol probably came when porting the driver from the NXP downstream kernel:
Quoted 19 lines · On Thu, 11 Nov 2021 07:31:25 -0300 Fabio Estevam <[email protected]> wrote:
Hi Lukas,
Quoted 7 lines · Lukas Bulwahn
Commit
1e23dcaa1a9f("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC") adds the configIMX8QXP_ADCfor this new driver, which depends on the non-existing configARCH_MXC_ARM64.Hence,
./scripts/checkkconfigsymbols.pywarns:Quoted 8 lines
ARCH_MXC_ARM64
Referencing files:drivers/iio/adc/KconfigProbably, the existing config
ARCH_MXCis intended to be referred here. So, repair the dependency to refer to that config.Fixes 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")Signed-off-by Lukas Bulwahn <[email protected]>
Quoted 6 lines
This looks good.
The incorrect
ARCH_MXC_ARM64symbol probably came when porting the driver from the NXP downstream kernel:Reviewed-by Fabio Estevam <[email protected]>
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan