Skip to contentSkip to conversation

iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config

PATCH Applied Lukas Bulwahn 3 participants 3 messages Nov 11, 2021 – Nov 12, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config

Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC") adds the config IMX8QXP_ADC for this new driver, which depends on the non-existing config ARCH_MXC_ARM64.

Hence, ./scripts/checkkconfigsymbols.py warns:

ARCH_MXC_ARM64
Referencing files: drivers/iio/adc/Kconfig

Probably, the existing config ARCH_MXC is intended to be referred here. So, repair the dependency to refer to that config.

Fixes 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
---
 drivers/iio/adc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/Kconfig +1 -1
index 8bf5b62a73f4..3363af15a43f 100644
@@ -532,7 +532,7 @@ config IMX7D_ADC
 
 config IMX8QXP_ADC
 	tristate "NXP IMX8QXP ADC driver"
-	depends on ARCH_MXC_ARM64 || COMPILE_TEST
+	depends on ARCH_MXC || COMPILE_TEST
 	depends on HAS_IOMEM
 	help
 	  Say yes here to build support for IMX8QXP ADC.
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#1 lore raw

Hi Lukas,

Quoted 7 lines · Lukas Bulwahn

Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC") adds the config IMX8QXP_ADC for this new driver, which depends on the non-existing config ARCH_MXC_ARM64.

Hence, ./scripts/checkkconfigsymbols.py warns:

Quoted 8 lines

ARCH_MXC_ARM64
Referencing files: drivers/iio/adc/Kconfig

Probably, the existing config ARCH_MXC is intended to be referred here. So, repair the dependency to refer to that config.

Fixes 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")

This looks good.

The incorrect ARCH_MXC_ARM64 symbol probably came when porting the driver from the NXP downstream kernel:

maintainer Applied
#2 lore raw
Quoted 19 lines · On Thu, 11 Nov 2021 07:31:25 -0300 Fabio Estevam <[email protected]> wrote:

Hi Lukas,

Quoted 7 lines · Lukas Bulwahn

Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC") adds the config IMX8QXP_ADC for this new driver, which depends on the non-existing config ARCH_MXC_ARM64.

Hence, ./scripts/checkkconfigsymbols.py warns:

Quoted 8 lines

ARCH_MXC_ARM64
Referencing files: drivers/iio/adc/Kconfig

Probably, the existing config ARCH_MXC is intended to be referred here. So, repair the dependency to refer to that config.

Fixes 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
Quoted 6 lines

This looks good.

The incorrect ARCH_MXC_ARM64 symbol probably came when porting the driver from the NXP downstream kernel:

Applied to the fixes-togreg branch of iio.git

Thanks,

Jonathan