Skip to contentSkip to conversation

PCI: apple: Assorted #PERST fixes

PATCH Superseded Marc Zyngier 1 participant 1 message Nov 23, 2021 PCI

lore
Share & tools
lore
#0 lore raw

v3 cover PCI: apple: Assorted #PERST fixes

Apologies for the rapid fire (I tend to be much more conservative when resending series), but given that this series has a direct impact on other projects (such as u-boot), I'm trying to converge as quickly as possible.

This series aims at fixing a number of issues for the recently merged Apple PCIe driver, all revolving around the mishandling of #PERST:

- we didn't properly drive #PERST, and we didn't follow the specified timings

- the DT had the wrong polarity, which has impacts on the driver itself

Hopefully, this should address all the issues reported so far.

* From v2:
- Fixed DT
- Fixed #PERST polarity in the driver
- Collected Pali's ack on patch #1

[1] https://lore.kernel.org/r/[email protected]

Marc Zyngier (3):
PCI: apple: Follow the PCIe specifications when resetting the port
arm64: dts: apple: t8103: Fix PCIe #PERST polarity
PCI: apple: Fix #PERST polarity

 arch/arm64/boot/dts/apple/t8103.dtsi |  7 ++++---
 drivers/pci/controller/pcie-apple.c  | 12 +++++++++++-
 2 files changed, 15 insertions(+), 4 deletions(-)
Signature · 1 line
2.30.2