drm/bridge: anx7625: fix an error code in anx7625_register_audio()
Subsystems (4)
PATCH 1/1 drm/bridge: anx7625: fix an error code in anx7625_register_audio()
This code accidentally returns IS_ERR(), which is 1, instead of propagating the negative error code. The caller doesn't check for errors so it doesn't affect run time at all.
Fixes 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/analogix/anx7625.c +1 -1
@@ -1636,7 +1636,7 @@ static int anx7625_register_audio(struct device *dev, struct anx7625_data *ctx) sizeof(codec_data));if (IS_ERR (ctx->audio_pdev)) -return IS_ERR (ctx->audio_pdev); +return PTR_ERR (ctx->audio_pdev);DRM_DEV_DEBUG_DRIVER (dev,"bound to %s" ,HDMI_CODEC_DRV_NAME );
Signature · 1 line
2.20.1
Quoted 6 lines · Dan Carpenter
This code accidentally returns
IS_ERR(), which is 1, instead of propagating the negative error code. The caller doesn't check for errors so it doesn't affect run time at all.Fixes 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Tzung-Bi Shih <[email protected]>
Robert Foss
AppliedQuoted 10 lines · Tzung-Bi Shih
Quoted 6 lines · Dan Carpenter
This code accidentally returns
IS_ERR(), which is 1, instead of propagating the negative error code. The caller doesn't check for errors so it doesn't affect run time at all.Fixes 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")Signed-off-by Dan Carpenter <[email protected]>Reviewed-by Tzung-Bi Shih <[email protected]>
Applied to drm-misc-next.