Skip to contentSkip to conversation

drm/bridge: anx7625: fix an error code in anx7625_register_audio()

PATCH Applied Dan Carpenter 3 participants 3 messages Nov 24, 2021 – Nov 25, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bridge: anx7625: fix an error code in anx7625_register_audio()

This code accidentally returns IS_ERR(), which is 1, instead of propagating the negative error code. The caller doesn't check for errors so it doesn't affect run time at all.

Fixes 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/analogix/anx7625.c +1 -1
index 001fb39d9919..f56e106b445d 100644
@@ -1636,7 +1636,7 @@ static int anx7625_register_audio(struct device *dev, struct anx7625_data *ctx)
 							sizeof(codec_data));
 
 	if (IS_ERR(ctx->audio_pdev))
-		return IS_ERR(ctx->audio_pdev);
+		return PTR_ERR(ctx->audio_pdev);
 
 	DRM_DEV_DEBUG_DRIVER(dev, "bound to %s", HDMI_CODEC_DRV_NAME);
 
Signature · 1 line
2.20.1
Applied
#2 lore raw
Quoted 10 lines · Tzung-Bi Shih
Quoted 6 lines · Dan Carpenter

This code accidentally returns IS_ERR(), which is 1, instead of propagating the negative error code. The caller doesn't check for errors so it doesn't affect run time at all.

Fixes 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")

Applied to drm-misc-next.