max96712: Depend on VIDEO_V4L2
Subsystems (2)
PATCH 1/1 max96712: Depend on VIDEO_V4L2
Depend on VIDEO_V4L2 for the driver actually depends on it, failing to compile otherwise.
Signed-off-by Sakari Ailus <[email protected]>
--- drivers/staging/media/max96712/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/staging/media/max96712/Kconfig +1 -0
@@ -3,6 +3,7 @@ config VIDEO_MAX96712 tristate "Maxim MAX96712 Quad GMSL2 Deserializer support" depends on I2C depends on OF_GPIO + depends on VIDEO_V4L2 select V4L2_FWNODE select VIDEO_V4L2_SUBDEV_API select MEDIA_CONTROLLER
Signature · 1 line
2.30.2
Hi Sakari,
Quoting Sakari Ailus (2021-11-26 08:06:23)
Quoted 2 lines
Depend on
VIDEO_V4L2for the driver actually depends on it, failing to compile otherwise.
Given that this matches how I added the same for max9286, I think this way is better than select.
Thanks,
Reviewed-by Kieran Bingham <[email protected]>
Quoted 20 lines
Signed-off-by Sakari Ailus <[email protected]>--- drivers/staging/media/max96712/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/staging/media/max96712/Kconfig +1
-0@@ -3,6 +3,7 @@ config VIDEO_MAX96712 tristate "Maxim MAX96712 Quad GMSL2 Deserializer support" depends on I2C depends on OF_GPIO + depends on VIDEO_V4L2 select V4L2_FWNODE select VIDEO_V4L2_SUBDEV_API select MEDIA_CONTROLLERSignature · 1 line
2.30.2
Hi Sakari,
Thanks for your work.
Quoted 4 lines · Sakari Ailus
Depend on
VIDEO_V4L2for the driver actually depends on it, failing to compile otherwise.Signed-off-by Sakari Ailus <[email protected]>
Reviewed-by Niklas Söderlund <[email protected]>
Quoted 19 lines
--- drivers/staging/media/max96712/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/staging/media/max96712/Kconfig +1
-0@@ -3,6 +3,7 @@ config VIDEO_MAX96712 tristate "Maxim MAX96712 Quad GMSL2 Deserializer support" depends on I2C depends on OF_GPIO + depends on VIDEO_V4L2 select V4L2_FWNODE select VIDEO_V4L2_SUBDEV_API select MEDIA_CONTROLLERSignature · 1 line
2.30.2
Signature · 2 lines
Kind Regards, Niklas Söderlund