Skip to contentSkip to conversation

max96712: Depend on VIDEO_V4L2

PATCH In review Sakari Ailus 3 participants 3 messages Nov 26, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 max96712: Depend on VIDEO_V4L2

Depend on VIDEO_V4L2 for the driver actually depends on it, failing to compile otherwise.

---
 drivers/staging/media/max96712/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/media/max96712/Kconfig +1 -0
index 258d47644cbd..acde14fd5c4d 100644
@@ -3,6 +3,7 @@ config VIDEO_MAX96712
 	tristate "Maxim MAX96712 Quad GMSL2 Deserializer support"
 	depends on I2C
 	depends on OF_GPIO
+	depends on VIDEO_V4L2
 	select V4L2_FWNODE
 	select VIDEO_V4L2_SUBDEV_API
 	select MEDIA_CONTROLLER
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw

Hi Sakari,

Quoting Sakari Ailus (2021-11-26 08:06:23)

Quoted 2 lines

Depend on VIDEO_V4L2 for the driver actually depends on it, failing to compile otherwise.

Given that this matches how I added the same for max9286, I think this way is better than select.

Thanks,

Quoted 20 lines
---
 drivers/staging/media/max96712/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/media/max96712/Kconfig +1 -0
index 258d47644cbd..acde14fd5c4d 100644
@@ -3,6 +3,7 @@ config VIDEO_MAX96712
        tristate "Maxim MAX96712 Quad GMSL2 Deserializer support"
        depends on I2C
        depends on OF_GPIO
+       depends on VIDEO_V4L2
        select V4L2_FWNODE
        select VIDEO_V4L2_SUBDEV_API
        select MEDIA_CONTROLLER
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#2 lore raw
In reply to Sakari Ailus

Hi Sakari,

Thanks for your work.

Quoted 4 lines · Sakari Ailus

Depend on VIDEO_V4L2 for the driver actually depends on it, failing to compile otherwise.

Quoted 19 lines
---
 drivers/staging/media/max96712/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/media/max96712/Kconfig +1 -0
index 258d47644cbd..acde14fd5c4d 100644
@@ -3,6 +3,7 @@ config VIDEO_MAX96712
 	tristate "Maxim MAX96712 Quad GMSL2 Deserializer support"
 	depends on I2C
 	depends on OF_GPIO
+	depends on VIDEO_V4L2
 	select V4L2_FWNODE
 	select VIDEO_V4L2_SUBDEV_API
 	select MEDIA_CONTROLLER
Signature · 1 line
2.30.2
Signature · 2 lines
Kind Regards,
Niklas Söderlund