Skip to contentSkip to conversation

arm64: dts: sm8350: add support for Microsoft Surface Duo 2

PATCH Superseded Katherine Perez 3 participants 4 messages Dec 8, 2021 – Dec 9, 2021

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover arm64: dts: sm8350: add support for Microsoft Surface Duo 2

Add initial support for the Microsoft Surface Duo 2 based on the sm8350-mtp DT.

Katherine Perez (1):
arm64: dts: add minimal DTS for Microsoft Surface Duo2

 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 .../qcom/sm8350-microsoft-surface-duo2.dts    | 369 ++++++++++++++++++
 2 files changed, 370 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts

--
2.31.1

#1 lore raw

PATCH v3 1/1 arm64: dts: add minimal DTS for Microsoft Surface Duo 2

This is a minimal devicetree for Microsoft Surface Duo 2 with SM8350 Chipset

---

Changes since v1:
- Change remoteprocs firmware-naming scheme to qcom/sm8350/microsft/*
- Add chassis-type

 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 .../qcom/sm8350-microsoft-surface-duo2.dts    | 369 ++++++++++++++++++
 2 files changed, 370 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
index 6b816eb33309..a8cc6bd3c423 100644
@@ -106,4 +106,5 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-mtp.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-sony-xperia-edo-pdx203.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-sony-xperia-edo-pdx206.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8350-hdk.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= sm8350-microsoft-surface-duo2.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8350-mtp.dtb
arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts new file +369 -0

369 lines not on this page · raw message

--
2.31.1

Reviewed-by on v3 1/1
#2 lore raw

Re: [PATCH v3 1/1] arm64: dts: add minimal DTS for Microsoft Surface Duo 2

Quoted 2 lines · Katherine Perez

This is a minimal devicetree for Microsoft Surface Duo 2 with SM8350 Chipset

Signature · 1 line
~Vinod
Reviewed-by on v3 1/1
#3 lore raw

Re: [PATCH v3 1/1] arm64: dts: add minimal DTS for Microsoft Surface Duo 2

In reply to Katherine Perez

Hi!

Quoted 18 lines · Katherine Perez

This is a minimal devicetree for Microsoft Surface Duo 2 with SM8350 Chipset

---

Changes since v1:
- Change remoteprocs firmware-naming scheme to qcom/sm8350/microsft/*
- Add chassis-type

  arch/arm64/boot/dts/qcom/Makefile             |   1 +
  .../qcom/sm8350-microsoft-surface-duo2.dts    | 369 ++++++++++++++++++
  2 files changed, 370 insertions(+)

create mode 100644 arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts

--
2.31.1

[...]

arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts line 8

Quoted 11 lines
arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts new file +8 -0
@@ -0,0 +1,369 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (C) 2021, Microsoft Corporation
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>

This is now included in sm8350.dtsi

[...]

arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts line 336

Quoted 4 lines
arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts new file +4 -0
+&usb_1 {
+	dr_mode = "peripheral";
+};
+

Looks like you forgot to enable usb_1, but other than these two nits:

Konrad