DRM kmap() fixes and kmap_local_page() conversions
Subsystems (7)
cover DRM kmap() fixes and kmap_local_page() conversions
From: Ira Weiny <[email protected]>
This series starts by converting the last easy kmap() uses to kmap_local_page().
There is one more call to kmap() wrapped in ttm_bo_kmap_ttm(). Unfortunately, ttm_bo_kmap_ttm() is called in a number of different ways including some which are not thread local. I have a patch to convert that call. However, it is not straight forward so it is not included in this series.
The final 2 patches fix bugs found while working on the ttm_bo_kmap_ttm() conversion.
Ira Weiny (7):
drm/i915: Replace kmap() with kmap_local_page()
drm/amd: Replace kmap() with kmap_local_page()
drm/gma: Remove calls to kmap()
drm/radeon: Replace kmap() with kmap_local_page()
drm/msm: Alter comment to use kmap_local_page()
drm/amdgpu: Ensure kunmap is called on error
drm/radeon: Ensure kunmap is called on error
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 ++++---- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + drivers/gpu/drm/gma500/gma_display.c | 6 ++---- drivers/gpu/drm/gma500/mmu.c | 8 ++++---- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 4 ++-- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 ++++---- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- drivers/gpu/drm/i915/gt/shmem_utils.c | 4 ++-- drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++-- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- drivers/gpu/drm/radeon/radeon_uvd.c | 1 +
13 files changed, 32 insertions(+), 32 deletions(-)
--
2.31.1
PATCH 1/7 drm/i915: Replace kmap() with kmap_local_page()
From: Ira Weiny <[email protected]>
kmap() is being deprecated and these usages are all local to the thread so there is no reason kmap_local_page() can't be used.
Replace kmap() calls with kmap_local_page().
--- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 4 ++-- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 ++++---- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- drivers/gpu/drm/i915/gt/shmem_utils.c | 4 ++-- drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- 6 files changed, 16 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_shmem.c +2 -2
@@ -597,9 +597,9 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *dev_priv,if (err <0 ) goto fail; - vaddr =kmap (page); + vaddr =kmap_local_page (page);memcpy (vaddr, data, len); -kunmap (page); +kunmap_local (vaddr); err = pagecache_write_end(file, file->f_mapping, offset, len, len,
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +4 -4
@@ -144,7 +144,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj,intel_gt_flush_ggtt_writes (&to_i915 (obj->base.dev)->gt); p =i915_gem_object_get_page (obj, offset >>PAGE_SHIFT ); - cpu =kmap (p) +offset_in_page (offset); + cpu =kmap_local_page (p) +offset_in_page (offset);drm_clflush_virt_range (cpu,sizeof (*cpu));if (*cpu != (u32 )page) { pr_err("Partial view for %lu [%u] (offset=%llu, size=%u [%llu, row size %u], fence=%d, tiling=%d, stride=%d) misalignment, expected write to page (%llu + %u [0x%llx]) of 0x%x, found 0x%x\n",
@@ -162,7 +162,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj, } *cpu =0 ;drm_clflush_virt_range (cpu,sizeof (*cpu)); -kunmap (p); +kunmap_local (cpu); out:__i915_vma_put (vma);
@@ -237,7 +237,7 @@ static int check_partial_mappings(struct drm_i915_gem_object *obj,intel_gt_flush_ggtt_writes (&to_i915 (obj->base.dev)->gt); p =i915_gem_object_get_page (obj, offset >>PAGE_SHIFT ); - cpu =kmap (p) +offset_in_page (offset); + cpu =kmap_local_page (p) +offset_in_page (offset);drm_clflush_virt_range (cpu,sizeof (*cpu));if (*cpu != (u32 )page) { pr_err("Partial view for %lu [%u] (offset=%llu, size=%u [%llu, row size %u], fence=%d, tiling=%d, stride=%d) misalignment, expected write to page (%llu + %u [0x%llx]) of 0x%x, found 0x%x\n",
@@ -255,7 +255,7 @@ static int check_partial_mappings(struct drm_i915_gem_object *obj, } *cpu =0 ;drm_clflush_virt_range (cpu,sizeof (*cpu)); -kunmap (p); +kunmap_local (cpu);if (err)return err;
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +2 -2
@@ -743,7 +743,7 @@ static void swizzle_page(struct page *page)char *vaddr;int i; - vaddr =kmap (page); + vaddr =kmap_local_page (page);for (i =0 ; i <PAGE_SIZE ; i +=128 ) {memcpy (temp, &vaddr[i],64 );
@@ -751,7 +751,7 @@ static void swizzle_page(struct page *page)memcpy (&vaddr[i +64 ], temp,64 ); } -kunmap (page); +kunmap_local (vaddr); }/**
drivers/gpu/drm/i915/gt/shmem_utils.c +2 -2
@@ -104,7 +104,7 @@ static int __shmem_rw(struct file *file, loff_t off,if (IS_ERR (page))return PTR_ERR (page); - vaddr =kmap (page); + vaddr =kmap_local_page (page);if (write) {memcpy (vaddr +offset_in_page (off), ptr, this);set_page_dirty (page);
@@ -112,7 +112,7 @@ static int __shmem_rw(struct file *file, loff_t off,memcpy (ptr, vaddr +offset_in_page (off), this); }mark_page_accessed (page); -kunmap (page); +kunmap_local (vaddr);put_page (page); len -= this;
drivers/gpu/drm/i915/i915_gem.c +4 -4
@@ -196,14 +196,14 @@ shmem_pread(struct page *page, int offset, int len, char __user *user_data,char *vaddr;int ret; - vaddr =kmap (page); + vaddr =kmap_local_page (page);if (needs_clflush)drm_clflush_virt_range (vaddr + offset, len); ret =__copy_to_user (user_data, vaddr + offset, len); -kunmap (page); +kunmap_local (vaddr);return ret ? -EFAULT :0 ; }
@@ -618,7 +618,7 @@ shmem_pwrite(struct page *page, int offset, int len, char __user *user_data,char *vaddr;int ret; - vaddr =kmap (page); + vaddr =kmap_local_page (page);if (needs_clflush_before)drm_clflush_virt_range (vaddr + offset, len);
@@ -627,7 +627,7 @@ shmem_pwrite(struct page *page, int offset, int len, char __user *user_data,if (!ret && needs_clflush_after)drm_clflush_virt_range (vaddr + offset, len); -kunmap (page); +kunmap_local (vaddr);return ret ? -EFAULT :0 ; }
drivers/gpu/drm/i915/i915_gpu_error.c +2 -2
@@ -1094,9 +1094,9 @@ i915_vma_coredump_create(const struct intel_gt *gt,drm_clflush_pages (&page,1 ); - s =kmap (page); + s =kmap_local_page (page); ret =compress_page (compress, s, dst, false); -kunmap (page); +kunmap_local (s);drm_clflush_pages (&page,1 );
Signature · 1 line
2.31.1
Re: [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()
drivers/gpu/drm/i915/gem/i915_gem_shmem.c i915_gem_object_create_shmem_from_data(struct drm_i915_private *dev_priv, · line 602
Quoted 5 lines · On Fri, Dec 10, 2021 at 03:23:58PM -0800, [email protected] wrote:
drivers/gpu/drm/i915/gem/i915_gem_shmem.c +2
-2- vaddr =kmap (page); + vaddr =kmap_local_page (page);memcpy (vaddr, data, len); -kunmap (page); +kunmap_local (vaddr);
memcpy_to_page?
Re: [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()
Quoted 8 lines · Christoph Hellwig
drivers/gpu/drm/i915/gem/i915_gem_shmem.c i915_gem_object_create_shmem_from_data(struct drm_i915_private *dev_priv, · line 602
Quoted 5 lines · On Fri, Dec 10, 2021 at 03:23:58PM -0800, [email protected] wrote:
drivers/gpu/drm/i915/gem/i915_gem_shmem.c +2
-2- vaddr =kmap (page); + vaddr =kmap_local_page (page);memcpy (vaddr, data, len); -kunmap (page); +kunmap_local (vaddr);
memcpy_to_page?
Opps! Yea!
David, Daniel,
Do you prefer me to resent the entire series or reply to this message with a V2?
Ira
Re: [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()
In reply to [email protected]Quoted 38 lines · On Fri, Dec 10, 2021 at 03:23:58PM -0800, [email protected] wrote:
From: Ira Weiny <[email protected]>
kmap()is being deprecated and these usages are all local to the thread so there is no reasonkmap_local_page()can't be used.Replace
kmap()calls withkmap_local_page().Signed-off-by Ira Weiny <[email protected]>--- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 4 ++-- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 ++++---- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- drivers/gpu/drm/i915/gt/shmem_utils.c | 4 ++-- drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- 6 files changed, 16 insertions(+), 16 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_shmem.c +2
-2@@ -597,9 +597,9 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *dev_priv,if (err <0 ) goto fail; - vaddr =kmap (page); + vaddr =kmap_local_page (page);memcpy (vaddr, data, len); -kunmap (page); +kunmap_local (vaddr); err = pagecache_write_end(file, file->f_mapping, offset, len, len,drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +0
-0
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c static int check_partial_mapping(struct drm_i915_gem_object *obj, · line 147
Quoted 5 lines
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +1
-1@@ -144,7 +144,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj,intel_gt_flush_ggtt_writes (&to_i915 (obj->base.dev)->gt); p =i915_gem_object_get_page (obj, offset >>PAGE_SHIFT ); - cpu =kmap (p) +offset_in_page (offset); + cpu =kmap_local_page (p) +offset_in_page (offset);
Does kunmap_local() do some magic to make it work even when you don't pass in the same value you got from kmap_local_page()?
Quoted 12 lines
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +1
-1drm_clflush_virt_range (cpu,sizeof (*cpu));if (*cpu != (u32 )page) { pr_err("Partial view for %lu [%u] (offset=%llu, size=%u [%llu, row size %u], fence=%d, tiling=%d, stride=%d) misalignment, expected write to page (%llu + %u [0x%llx]) of 0x%x, found 0x%x\n",@@ -162,7 +162,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj, } *cpu =0 ;drm_clflush_virt_range (cpu,sizeof (*cpu)); -kunmap (p); +kunmap_local (cpu); out:__i915_vma_put (vma);
Signature · 2 lines
Ville Syrjälä Intel
Re: [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()
Quoted 41 lines · Ville Syrjälä
Quoted 40 lines · On Fri, Dec 10, 2021 at 03:23:58PM -0800, [email protected] wrote:
From: Ira Weiny <[email protected]>
kmap()is being deprecated and these usages are all local to the thread so there is no reasonkmap_local_page()can't be used.Replace
kmap()calls withkmap_local_page().Signed-off-by Ira Weiny <[email protected]>--- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 4 ++-- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 ++++---- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- drivers/gpu/drm/i915/gt/shmem_utils.c | 4 ++-- drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- 6 files changed, 16 insertions(+), 16 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_shmem.c +2
-2@@ -597,9 +597,9 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *dev_priv,if (err <0 ) goto fail; - vaddr =kmap (page); + vaddr =kmap_local_page (page);memcpy (vaddr, data, len); -kunmap (page); +kunmap_local (vaddr); err = pagecache_write_end(file, file->f_mapping, offset, len, len,drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +0
-0@@ -144,7 +144,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj,intel_gt_flush_ggtt_writes (&to_i915 (obj->base.dev)->gt);
Quoted 6 lines
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c static int check_partial_mapping(struct drm_i915_gem_object *obj, · line 147
Quoted 3 lines
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +1
-1p =i915_gem_object_get_page (obj, offset >>PAGE_SHIFT ); - cpu =kmap (p) +offset_in_page (offset); + cpu =kmap_local_page (p) +offset_in_page (offset);Does
kunmap_local()do some magic to make it work even when you don't pass in the same value you got fromkmap_local_page()?
Yes. It sounds like a patch like this would be nice to clarify?
Ira
include/linux/highmem-internal.h +11 -0
@@ -246,6 +246,17 @@ do { \__kunmap_atomic (__addr); \ }while (0 ) +/** +* kunmap_local - Unmap a page mapped via kmap_local_page(). +* @__addr: An address within the page mapped +* +* __addr is often an address returned from kmap_local_page(). However, +* this address can be any address within the mapped page. It does not need to +* be the exact address returned from kmap_local_page() +* +* Unmapping should be done in the reverse order of the mapping. See +* kmap_local_page() for details. + */#define kunmap_local (__addr) \ do { \ BUILD_BUG_ON(__same_type((__addr), struct page *)); \
PATCH v2 1/1 drm/i915: Replace kmap() with kmap_local_page()
In reply to [email protected]From: Ira Weiny <[email protected]>
kmap() is being deprecated and these usages are all local to the thread so there is no reason kmap_local_page() can't be used.
Replace kmap() calls with kmap_local_page().
---
NOTE: I'm sending as a follow on to the V1 patch. Please let me know if you prefer the entire series instead.
Changes for V2:
From Christoph Helwig
Prefer the use of memcpy_*_page() where appropriate.
--- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 ++---- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 8 ++++---- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- drivers/gpu/drm/i915/gt/shmem_utils.c | 7 ++----- drivers/gpu/drm/i915/i915_gem.c | 8 ++++---- drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- 6 files changed, 16 insertions(+), 21 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_shmem.c +2 -4
@@ -589,7 +589,7 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *dev_priv, do { unsigned int len = min_t(typeof(size), size, PAGE_SIZE); struct page *page; - void *pgdata, *vaddr; + void *pgdata; err = pagecache_write_begin(file, file->f_mapping, offset, len, 0,
@@ -597,9 +597,7 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *dev_priv,if (err <0 ) goto fail; - vaddr =kmap (page); -memcpy (vaddr, data, len); -kunmap (page); +memcpy_to_page (page,0 , data, len); err = pagecache_write_end(file, file->f_mapping, offset, len, len,
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +4 -4
@@ -144,7 +144,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj,intel_gt_flush_ggtt_writes (&to_i915 (obj->base.dev)->gt); p =i915_gem_object_get_page (obj, offset >>PAGE_SHIFT ); - cpu =kmap (p) +offset_in_page (offset); + cpu =kmap_local_page (p) +offset_in_page (offset);drm_clflush_virt_range (cpu,sizeof (*cpu));if (*cpu != (u32 )page) { pr_err("Partial view for %lu [%u] (offset=%llu, size=%u [%llu, row size %u], fence=%d, tiling=%d, stride=%d) misalignment, expected write to page (%llu + %u [0x%llx]) of 0x%x, found 0x%x\n",
@@ -162,7 +162,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj, } *cpu =0 ;drm_clflush_virt_range (cpu,sizeof (*cpu)); -kunmap (p); +kunmap_local (cpu); out:__i915_vma_put (vma);
@@ -237,7 +237,7 @@ static int check_partial_mappings(struct drm_i915_gem_object *obj,intel_gt_flush_ggtt_writes (&to_i915 (obj->base.dev)->gt); p =i915_gem_object_get_page (obj, offset >>PAGE_SHIFT ); - cpu =kmap (p) +offset_in_page (offset); + cpu =kmap_local_page (p) +offset_in_page (offset);drm_clflush_virt_range (cpu,sizeof (*cpu));if (*cpu != (u32 )page) { pr_err("Partial view for %lu [%u] (offset=%llu, size=%u [%llu, row size %u], fence=%d, tiling=%d, stride=%d) misalignment, expected write to page (%llu + %u [0x%llx]) of 0x%x, found 0x%x\n",
@@ -255,7 +255,7 @@ static int check_partial_mappings(struct drm_i915_gem_object *obj, } *cpu =0 ;drm_clflush_virt_range (cpu,sizeof (*cpu)); -kunmap (p); +kunmap_local (cpu);if (err)return err;
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +2 -2
@@ -743,7 +743,7 @@ static void swizzle_page(struct page *page)char *vaddr;int i; - vaddr =kmap (page); + vaddr =kmap_local_page (page);for (i =0 ; i <PAGE_SIZE ; i +=128 ) {memcpy (temp, &vaddr[i],64 );
@@ -751,7 +751,7 @@ static void swizzle_page(struct page *page)memcpy (&vaddr[i +64 ], temp,64 ); } -kunmap (page); +kunmap_local (vaddr); }/**
drivers/gpu/drm/i915/gt/shmem_utils.c +2 -5
@@ -97,22 +97,19 @@ static int __shmem_rw(struct file *file, loff_t off,unsigned int this =min_t (size_t,PAGE_SIZE -offset_in_page (off), len);struct page *page; -void *vaddr; page =shmem_read_mapping_page_gfp (file->f_mapping, pfn,GFP_KERNEL );if (IS_ERR (page))return PTR_ERR (page); - vaddr =kmap (page);if (write) { -memcpy (vaddr +offset_in_page (off), ptr, this); +memcpy_to_page (page,offset_in_page (off), ptr, this);set_page_dirty (page); }else { -memcpy (ptr, vaddr +offset_in_page (off), this); +memcpy_from_page (ptr, page,offset_in_page (off), this); }mark_page_accessed (page); -kunmap (page);put_page (page); len -= this;
drivers/gpu/drm/i915/i915_gem.c +4 -4
@@ -196,14 +196,14 @@ shmem_pread(struct page *page, int offset, int len, char __user *user_data,char *vaddr;int ret; - vaddr =kmap (page); + vaddr =kmap_local_page (page);if (needs_clflush)drm_clflush_virt_range (vaddr + offset, len); ret =__copy_to_user (user_data, vaddr + offset, len); -kunmap (page); +kunmap_local (vaddr);return ret ? -EFAULT :0 ; }
@@ -618,7 +618,7 @@ shmem_pwrite(struct page *page, int offset, int len, char __user *user_data,char *vaddr;int ret; - vaddr =kmap (page); + vaddr =kmap_local_page (page);if (needs_clflush_before)drm_clflush_virt_range (vaddr + offset, len);
@@ -627,7 +627,7 @@ shmem_pwrite(struct page *page, int offset, int len, char __user *user_data,if (!ret && needs_clflush_after)drm_clflush_virt_range (vaddr + offset, len); -kunmap (page); +kunmap_local (vaddr);return ret ? -EFAULT :0 ; }
drivers/gpu/drm/i915/i915_gpu_error.c +2 -2
@@ -1094,9 +1094,9 @@ i915_vma_coredump_create(const struct intel_gt *gt,drm_clflush_pages (&page,1 ); - s =kmap (page); + s =kmap_local_page (page); ret =compress_page (compress, s, dst, false); -kunmap (page); +kunmap_local (s);drm_clflush_pages (&page,1 );
Signature · 1 line
2.31.1
PATCH 2/7 drm/amd: Replace kmap() with kmap_local_page()
In reply to [email protected]From: Ira Weiny <[email protected]>
kmap() is being deprecated. These maps are thread local and can be replaced with kmap_local_page().
Replace kmap() with kmap_local_page()
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +4 -4
@@ -2281,9 +2281,9 @@ static ssize_t amdgpu_iomem_read(struct file *f, char __user *buf,if (p->mapping != adev->mman.bdev.dev_mapping)return -EPERM ; - ptr =kmap (p); + ptr =kmap_local_page (p); r =copy_to_user (buf, ptr + off, bytes); -kunmap (p); +kunmap_local (ptr);if (r)return -EFAULT ;
@@ -2332,9 +2332,9 @@ static ssize_t amdgpu_iomem_write(struct file *f, const char __user *buf,if (p->mapping != adev->mman.bdev.dev_mapping)return -EPERM ; - ptr =kmap (p); + ptr =kmap_local_page (p); r =copy_from_user (ptr + off, buf, bytes); -kunmap (p); +kunmap_local (ptr);if (r)return -EFAULT ;
Signature · 1 line
2.31.1
PATCH 3/7 drm/gma: Remove calls to kmap()
In reply to [email protected]From: Ira Weiny <[email protected]>
kmap() is being deprecated and these instances are easy to convert to kmap_local_page().
Furthermore, in gma_crtc_cursor_set() use the memcpy_from_page() helper instead of an open coded use of kmap_local_page().
--- drivers/gpu/drm/gma500/gma_display.c | 6 ++---- drivers/gpu/drm/gma500/mmu.c | 8 ++++---- 2 files changed, 6 insertions(+), 8 deletions(-)
drivers/gpu/drm/gma500/gma_display.c +2 -4
@@ -334,7 +334,7 @@ int gma_crtc_cursor_set(struct drm_crtc *crtc,struct gtt_range *gt;struct gtt_range *cursor_gt = gma_crtc->cursor_gt;struct drm_gem_object *obj; -void *tmp_dst, *tmp_src; +void *tmp_dst;int ret =0 , i, cursor_pages;/* If we didn't get a handle then turn the cursor off */
@@ -400,9 +400,7 @@ int gma_crtc_cursor_set(struct drm_crtc *crtc,/* Copy the cursor to cursor mem */ tmp_dst = dev_priv->vram_addr + cursor_gt->offset;for (i =0 ; i < cursor_pages; i++) { - tmp_src =kmap (gt->pages[i]); -memcpy (tmp_dst, tmp_src,PAGE_SIZE ); -kunmap (gt->pages[i]); +memcpy_from_page (tmp_dst, gt->pages[i],0 ,PAGE_SIZE ); tmp_dst +=PAGE_SIZE ; }
drivers/gpu/drm/gma500/mmu.c +4 -4
@@ -184,17 +184,17 @@ struct psb_mmu_pd *psb_mmu_alloc_pd(struct psb_mmu_driver *driver, pd->invalid_pte =0 ; } - v =kmap (pd->dummy_pt); + v =kmap_local_page (pd->dummy_pt);for (i =0 ; i < (PAGE_SIZE /sizeof (uint32_t )); ++i) v[i] = pd->invalid_pte; -kunmap (pd->dummy_pt); +kunmap_local (v); - v =kmap (pd->p); + v =kmap_local_page (pd->p);for (i =0 ; i < (PAGE_SIZE /sizeof (uint32_t )); ++i) v[i] = pd->invalid_pde; -kunmap (pd->p); +kunmap_local (v);clear_page (kmap (pd->dummy_page));kunmap (pd->dummy_page);
Signature · 1 line
2.31.1
PATCH 4/7 drm/radeon: Replace kmap() with kmap_local_page()
In reply to [email protected]From: Ira Weiny <[email protected]>
kmap() is being deprecated and this usage is local to the thread. Use kmap_local_page() instead.
--- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/radeon/radeon_ttm.c +2 -2
@@ -907,11 +907,11 @@ static ssize_t radeon_ttm_gtt_read(struct file *f, char __user *buf, page = rdev->gart.pages[p];if (page) { - ptr =kmap (page); + ptr =kmap_local_page (page); ptr += off; r =copy_to_user (buf, ptr, cur_size); -kunmap (rdev->gart.pages[p]); +kunmap_local (ptr); }else r =clear_user (buf, cur_size);
Signature · 1 line
2.31.1
PATCH 5/7 drm/msm: Alter comment to use kmap_local_page()
In reply to [email protected]From: Ira Weiny <[email protected]>
kmap() is being deprecated. So this comment could be misleading in the future.
Change this comment to point to using kmap_local_page(). While here remove 'we' from the comment.
--- drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/msm_gem_submit.c +2 -2
@@ -438,8 +438,8 @@ static int submit_reloc(struct msm_gem_submit *submit, struct msm_gem_object *obreturn -EINVAL ; } -/* For now, just map the entire thing. Eventually we probably -* to do it page-by-page, w/ kmap() if not vmap()d.. +/* For now, just map the entire thing. Eventually it should probably +* be done page-by-page, w/ kmap_local_page() if not vmap()d.. */ ptr =msm_gem_get_vaddr_locked (&obj->base);
Signature · 1 line
2.31.1
PATCH 6/7 drm/amdgpu: Ensure kunmap is called on error
In reply to [email protected]From: Ira Weiny <[email protected]>
The default case leaves the buffer object mapped in error.
Add amdgpu_bo_kunmap() to that case to ensure the mapping is cleaned up.
---
NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual bug.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +1 -0
@@ -889,6 +889,7 @@ static int amdgpu_uvd_cs_msg(struct amdgpu_uvd_cs_ctx *ctx,return 0 ;default : +amdgpu_bo_kunmap (bo);DRM_ERROR ("Illegal UVD message type (%d)!\n" , msg_type); }
Signature · 1 line
2.31.1
Christian König
maintainerRe: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error
Am 11.12.21 um 00:24 schrieb [email protected]:
Quoted 5 lines
From: Ira Weiny <[email protected]>
The default case leaves the buffer object mapped in error.
Add
amdgpu_bo_kunmap()to that case to ensure the mapping is cleaned up.
Mhm, good catch. But why do you want to do this in the first place?
Christian.
Quoted 22 lines
Signed-off-by Ira Weiny <[email protected]>---
NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual bug.--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + 1 file changed, 1 insertion(+)nice
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +1
-0@@ -889,6 +889,7 @@ static int amdgpu_uvd_cs_msg(struct amdgpu_uvd_cs_ctx *ctx,return 0 ;default : +amdgpu_bo_kunmap (bo);DRM_ERROR ("Illegal UVD message type (%d)!\n" , msg_type); }
Re: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error
Quoted 8 lines · Christian König
Am 11.12.21 um 00:24 schrieb [email protected]:
Quoted 5 lines
From: Ira Weiny <[email protected]>
The default case leaves the buffer object mapped in error.
Add
amdgpu_bo_kunmap()to that case to ensure the mapping is cleaned up.Mhm, good catch. But why do you want to do this in the first place?
I'm not sure I understand the question.
Any mapping of memory should be paired with an unmapping when no longer needed. And this is supported by the call to amdgpu_bo_kunmap() in the other non-default cases.
Do you believe the mapping is not needed?
Ira
Quoted 24 lines
Christian.
Quoted 20 lines
Signed-off-by Ira Weiny <[email protected]>---
NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual bug.--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + 1 file changed, 1 insertion(+)nice
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +1
-0@@ -889,6 +889,7 @@ static int amdgpu_uvd_cs_msg(struct amdgpu_uvd_cs_ctx *ctx,return 0 ;default : +amdgpu_bo_kunmap (bo);DRM_ERROR ("Illegal UVD message type (%d)!\n" , msg_type); }
Christian König
maintainerRe: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error
Am 14.12.21 um 04:37 schrieb Ira Weiny:
Quoted 7 lines · Christian König
Quoted 6 lines
Am 11.12.21 um 00:24 schrieb [email protected]:
Quoted 5 lines
From: Ira Weiny <[email protected]>
The default case leaves the buffer object mapped in error.
Add
amdgpu_bo_kunmap()to that case to ensure the mapping is cleaned up.
Quoted 8 lines
Quoted 1 line
Mhm, good catch. But why do you want to do this in the first place?
I'm not sure I understand the question.
Any mapping of memory should be paired with an unmapping when no longer needed. And this is supported by the call to
amdgpu_bo_kunmap()in the other non-default cases.Do you believe the mapping is not needed?
No, the unmapping is not needed here. See the function amdgpu_bo_kmap(), it either creates the mapping or return the cached pointer.
A call to amdgpu_bo_kunmap() is only done in a few places where we know that the created mapping most likely won't be needed any more. If that's not done the mapping is automatically destroyed when the BO is moved or freed up.
I mean good bug fix, but you seem to see this as some kind of prerequisite to some follow up work converting TTM to use kmap_local() which most likely won't work in the first place.
Regards,
Christian.
Quoted 24 lines
Ira
Quoted 21 lines
Christian.
Quoted 19 lines
Signed-off-by Ira Weiny <[email protected]>---
NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual bug.--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + 1 file changed, 1 insertion(+)nice
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +1
-0@@ -889,6 +889,7 @@ static int amdgpu_uvd_cs_msg(struct amdgpu_uvd_cs_ctx *ctx,return 0 ;default : +amdgpu_bo_kunmap (bo);DRM_ERROR ("Illegal UVD message type (%d)!\n" , msg_type); }
Re: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error
Quoted 11 lines · Christian König
Am 14.12.21 um 04:37 schrieb Ira Weiny:
Quoted 10 lines · Christian König
Quoted 7 lines
Am 11.12.21 um 00:24 schrieb [email protected]:
Quoted 5 lines
From: Ira Weiny <[email protected]>
The default case leaves the buffer object mapped in error.
Add
amdgpu_bo_kunmap()to that case to ensure the mapping is cleaned up.Mhm, good catch. But why do you want to do this in the first place?
I'm not sure I understand the question.
Quoted 8 lines
Quoted 5 lines
Any mapping of memory should be paired with an unmapping when no longer needed. And this is supported by the call to
amdgpu_bo_kunmap()in the other non-default cases.Do you believe the mapping is not needed?
No, the unmapping is not needed here. See the function
amdgpu_bo_kmap(), it either creates the mapping or return the cached pointer.
Ah I missed that. Thanks.
Quoted 8 lines
A call to
amdgpu_bo_kunmap()is only done in a few places where we know that the created mapping most likely won't be needed any more. If that's not done the mapping is automatically destroyed when the BO is moved or freed up.I mean good bug fix, but you seem to see this as some kind of prerequisite to some follow up work converting TTM to use
kmap_local()which most likely won't work in the first place.
Sure. I see now that it is more complicated than I thought but I never thought of this as a strict prerequisite. Just something I found while trying to figure out how this works.
How much of a speed up is it to maintain the ttm_bo_map_kmap map type? Could this all be done with vmap and just remove the kmap stuff?
Ira
Quoted 29 lines
Regards,
Christian.Quoted 24 lines
Ira
Quoted 21 lines
Christian.
Quoted 19 lines
Signed-off-by Ira Weiny <[email protected]>---
NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual bug.--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + 1 file changed, 1 insertion(+)nice
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +1
-0@@ -889,6 +889,7 @@ static int amdgpu_uvd_cs_msg(struct amdgpu_uvd_cs_ctx *ctx,return 0 ;default : +amdgpu_bo_kunmap (bo);DRM_ERROR ("Illegal UVD message type (%d)!\n" , msg_type); }
Christian König
maintainerRe: [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error
Am 15.12.21 um 22:09 schrieb Ira Weiny:
Quoted 25 lines · Christian König
Quoted 11 lines
Am 14.12.21 um 04:37 schrieb Ira Weiny:
Quoted 10 lines · Christian König
Quoted 7 lines
Am 11.12.21 um 00:24 schrieb [email protected]:
Quoted 5 lines
From: Ira Weiny <[email protected]>
The default case leaves the buffer object mapped in error.
Add
amdgpu_bo_kunmap()to that case to ensure the mapping is cleaned up.Mhm, good catch. But why do you want to do this in the first place?
I'm not sure I understand the question.
Quoted 7 lines
Quoted 5 lines
Any mapping of memory should be paired with an unmapping when no longer needed. And this is supported by the call to
amdgpu_bo_kunmap()in the other non-default cases.Do you believe the mapping is not needed?
No, the unmapping is not needed here. See the function
amdgpu_bo_kmap(), it either creates the mapping or return the cached pointer.Ah I missed that. Thanks.
Quoted 4 lines
A call to
amdgpu_bo_kunmap()is only done in a few places where we know that the created mapping most likely won't be needed any more. If that's not done the mapping is automatically destroyed when the BO is moved or freed up.
Quoted 8 lines
Quoted 3 lines
I mean good bug fix, but you seem to see this as some kind of prerequisite to some follow up work converting TTM to use
kmap_local()which most likely won't work in the first place.Sure. I see now that it is more complicated than I thought but I never thought of this as a strict prerequisite. Just something I found while trying to figure out how this works.
How much of a speed up is it to maintain the
ttm_bo_map_kmapmap type?
Good question. I don't really know.
This used to be pretty important for older drivers since there the kernel needs to kmap individual pages and patch them up before sending the command stream to the hardware.
It most likely doesn't matter for modern hardware.
Quoted 1 line
Could this all be done with vmap and just remove the kmap stuff?
Maybe, but I wouldn't bet on it and I don't really want to touch any of the old drivers to figure that out.
Christian.
Quoted 29 lines
Ira
Quoted 26 lines
Regards,
Christian.Quoted 23 lines
Ira
Quoted 21 lines
Christian.
Quoted 19 lines
Signed-off-by Ira Weiny <[email protected]>---
NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual bug.--- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 + 1 file changed, 1 insertion(+)nice
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +1
-0@@ -889,6 +889,7 @@ static int amdgpu_uvd_cs_msg(struct amdgpu_uvd_cs_ctx *ctx,return 0 ;default : +amdgpu_bo_kunmap (bo);DRM_ERROR ("Illegal UVD message type (%d)!\n" , msg_type); }
PATCH 7/7 drm/radeon: Ensure kunmap is called on error
In reply to [email protected]From: Ira Weiny <[email protected]>
The default case leaves the buffer object mapped in error.
Add radeon_bo_kunmap() to that case to ensure the mapping is cleaned up.
---
NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual bug.
--- drivers/gpu/drm/radeon/radeon_uvd.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/radeon/radeon_uvd.c +1 -0
@@ -563,6 +563,7 @@ static int radeon_uvd_cs_msg(struct radeon_cs_parser *p, struct radeon_bo *bo,default : +radeon_bo_kunmap (bo);DRM_ERROR ("Illegal UVD message type (%d)!\n" , msg_type);return -EINVAL ; }
Signature · 1 line
2.31.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BUILD: failure for DRM kmap() fixes and kmap_local_page() conversions
In reply to [email protected]== Series Details ==
== Series Details ==
Series: DRM kmap() fixes and kmap_local_page() conversions
URL : https://patchwork.freedesktop.org/series/97889/
State : failure
== Summary ==
Applying: drm/i915: Replace kmap() with kmap_local_page()
Applying: drm/amd: Replace kmap() with kmap_local_page()
Applying: drm/gma: Remove calls to kmap()
Using index info to reconstruct a base tree...
M drivers/gpu/drm/gma500/gma_display.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/gma500/gma_display.c
CONFLICT (content): Merge conflict in drivers/gpu/drm/gma500/gma_display.c
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0003 drm/gma: Remove calls to kmap()
When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BUILD: failure for DRM kmap() fixes and kmap_local_page() conversions (rev2)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: DRM kmap() fixes and kmap_local_page() conversions (rev2)
URL : https://patchwork.freedesktop.org/series/97889/
State : failure
== Summary ==
Applying: drm/i915: Replace kmap() with kmap_local_page()
error: patch failed: include/linux/highmem-internal.h:246
error: include/linux/highmem-internal.h: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch Using index info to reconstruct a base tree...
Patch failed at 0001 drm/i915: Replace kmap() with kmap_local_page() When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BUILD: failure for DRM kmap() fixes and kmap_local_page() conversions (rev3)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: DRM kmap() fixes and kmap_local_page() conversions (rev3)
URL : https://patchwork.freedesktop.org/series/97889/
State : failure
== Summary ==
Applying: drm/i915: Replace kmap() with kmap_local_page() Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/gem/i915_gem_shmem.c
M drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
M drivers/gpu/drm/i915/i915_gem.c
M drivers/gpu/drm/i915/i915_gpu_error.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/i915/i915_gpu_error.c Auto-merging drivers/gpu/drm/i915/i915_gem.c
Auto-merging drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c Auto-merging drivers/gpu/drm/i915/gem/i915_gem_shmem.c
Applying: drm/amd: Replace kmap() with kmap_local_page()
Applying: drm/gma: Remove calls to kmap()
Using index info to reconstruct a base tree...
M drivers/gpu/drm/gma500/gma_display.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/gma500/gma_display.c
CONFLICT (content): Merge conflict in drivers/gpu/drm/gma500/gma_display.c
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0003 drm/gma: Remove calls to kmap()
When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
Quoted 5 lines · Ira Weiny
From: Ira Weiny <[email protected]>
This series starts by converting the last easy
kmap()uses tokmap_local_page().
Quoted 7 lines
There is one more call to
kmap()wrapped inttm_bo_kmap_ttm(). Unfortunately,ttm_bo_kmap_ttm()is called in a number of different ways including some which are not thread local. I have a patch to convert that call. However, it is not straight forward so it is not included in this series.The final 2 patches fix bugs found while working on the
ttm_bo_kmap_ttm()conversion.
Gentile ping on this series? Will it make this merge window?
Thanks,
Ira
Quoted 29 lines
Ira Weiny (7):
drm/i915: Replacekmap()withkmap_local_page()
drm/amd: Replacekmap()withkmap_local_page()
drm/gma: Remove calls tokmap()
drm/radeon: Replacekmap()withkmap_local_page()
drm/msm: Alter comment to usekmap_local_page()
drm/amdgpu: Ensure kunmap is called on error
drm/radeon: Ensure kunmap is called on error
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 8 ++++----drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c| 1 +drivers/gpu/drm/gma500/gma_display.c| 6 ++----drivers/gpu/drm/gma500/mmu.c| 8 ++++----drivers/gpu/drm/i915/gem/i915_gem_shmem.c| 4 ++--drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c| 8 ++++----drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c| 4 ++--drivers/gpu/drm/i915/gt/shmem_utils.c| 4 ++--drivers/gpu/drm/i915/i915_gem.c| 8 ++++----drivers/gpu/drm/i915/i915_gpu_error.c| 4 ++--drivers/gpu/drm/msm/msm_gem_submit.c| 4 ++--drivers/gpu/drm/radeon/radeon_ttm.c| 4 ++--drivers/gpu/drm/radeon/radeon_uvd.c| 1 +13 files changed, 32 insertions(+), 32 deletions(-)--
2.31.1
Quoted 11 lines · Ira Weiny
Quoted 10 lines · Ira Weiny
From: Ira Weiny <[email protected]>
This series starts by converting the last easy
kmap()uses tokmap_local_page().There is one more call to
kmap()wrapped inttm_bo_kmap_ttm(). Unfortunately,ttm_bo_kmap_ttm()is called in a number of different ways including some which are not thread local. I have a patch to convert that call. However, it is not straight forward so it is not included in this series.
Quoted 4 lines
Quoted 2 lines
The final 2 patches fix bugs found while working on the
ttm_bo_kmap_ttm()conversion.Gentile ping on this series? Will it make this merge window?
I think this fell through the cracks and so no. Note that generally we feature-freeze drm tree around -rc6 anyway for the upcoming merge window, so you were cutting this all a bit close anyway. Also looks like the ttm kmap caching question didn't get resolved?
Anyway if patches are stuck resend with RESEND and if people still don't pick them up poke me and I'll apply as fallback.
Cheers, Daniel
Quoted 33 lines
Thanks,
IraQuoted 29 lines
Ira Weiny (7):
drm/i915: Replacekmap()withkmap_local_page()
drm/amd: Replacekmap()withkmap_local_page()
drm/gma: Remove calls tokmap()
drm/radeon: Replacekmap()withkmap_local_page()
drm/msm: Alter comment to usekmap_local_page()
drm/amdgpu: Ensure kunmap is called on error
drm/radeon: Ensure kunmap is called on error
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 8 ++++----drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c| 1 +drivers/gpu/drm/gma500/gma_display.c| 6 ++----drivers/gpu/drm/gma500/mmu.c| 8 ++++----drivers/gpu/drm/i915/gem/i915_gem_shmem.c| 4 ++--drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c| 8 ++++----drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c| 4 ++--drivers/gpu/drm/i915/gt/shmem_utils.c| 4 ++--drivers/gpu/drm/i915/i915_gem.c| 8 ++++----drivers/gpu/drm/i915/i915_gpu_error.c| 4 ++--drivers/gpu/drm/msm/msm_gem_submit.c| 4 ++--drivers/gpu/drm/radeon/radeon_ttm.c| 4 ++--drivers/gpu/drm/radeon/radeon_uvd.c| 1 +13 files changed, 32 insertions(+), 32 deletions(-)--
2.31.1
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Quoted 12 lines · Daniel Vetter
Quoted 11 lines · Ira Weiny
Quoted 10 lines · Ira Weiny
From: Ira Weiny <[email protected]>
This series starts by converting the last easy
kmap()uses tokmap_local_page().There is one more call to
kmap()wrapped inttm_bo_kmap_ttm(). Unfortunately,ttm_bo_kmap_ttm()is called in a number of different ways including some which are not thread local. I have a patch to convert that call. However, it is not straight forward so it is not included in this series.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
The final 2 patches fix bugs found while working on the
ttm_bo_kmap_ttm()conversion.Gentile ping on this series? Will it make this merge window?
I think this fell through the cracks and so no. Note that generally we feature-freeze drm tree around -rc6 anyway for the upcoming merge window, so you were cutting this all a bit close anyway.
Ok, No problem. I just had not heard if this was picked up or not.
Quoted 2 lines
Also looks like the ttm
kmap caching question didn't get resolved?
I'm sorry I thought it was resolve for this series. Christian said the patches in this series were "a good bug fix" even if not strictly necessary.[1] Beyond this series I was discussing where to go from here, and is it possible to go further with more changes.[2] At the moment I don't think I will.
Christian did I misunderstand? I can drop patch 6 and 7 if they are not proper bug fixes or at least clarifications to the code.
Ira
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/
Quoted 44 lines
Anyway if patches are stuck resend with RESEND and if people still don't pick them up poke me and I'll apply as fallback.
Cheers, Daniel
Quoted 33 lines
Thanks,
IraQuoted 29 lines
Ira Weiny (7):
drm/i915: Replacekmap()withkmap_local_page()
drm/amd: Replacekmap()withkmap_local_page()
drm/gma: Remove calls tokmap()
drm/radeon: Replacekmap()withkmap_local_page()
drm/msm: Alter comment to usekmap_local_page()
drm/amdgpu: Ensure kunmap is called on error
drm/radeon: Ensure kunmap is called on error
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 8 ++++----drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c| 1 +drivers/gpu/drm/gma500/gma_display.c| 6 ++----drivers/gpu/drm/gma500/mmu.c| 8 ++++----drivers/gpu/drm/i915/gem/i915_gem_shmem.c| 4 ++--drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c| 8 ++++----drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c| 4 ++--drivers/gpu/drm/i915/gt/shmem_utils.c| 4 ++--drivers/gpu/drm/i915/i915_gem.c| 8 ++++----drivers/gpu/drm/i915/i915_gpu_error.c| 4 ++--drivers/gpu/drm/msm/msm_gem_submit.c| 4 ++--drivers/gpu/drm/radeon/radeon_ttm.c| 4 ++--drivers/gpu/drm/radeon/radeon_uvd.c| 1 +13 files changed, 32 insertions(+), 32 deletions(-)--
2.31.1Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Christian König
maintainerAm 20.01.22 um 00:55 schrieb Ira Weiny:
Quoted 23 lines · Daniel Vetter
Quoted 12 lines · Ira Weiny
Quoted 11 lines · Ira Weiny
Quoted 10 lines
From: Ira Weiny <[email protected]>
This series starts by converting the last easy
kmap()uses tokmap_local_page().There is one more call to
kmap()wrapped inttm_bo_kmap_ttm(). Unfortunately,ttm_bo_kmap_ttm()is called in a number of different ways including some which are not thread local. I have a patch to convert that call. However, it is not straight forward so it is not included in this series.Quoted 6 lines
Quoted 3 lines
Quoted 2 lines
The final 2 patches fix bugs found while working on the
ttm_bo_kmap_ttm()conversion.Gentile ping on this series? Will it make this merge window?
I think this fell through the cracks and so no. Note that generally we feature-freeze drm tree around -rc6 anyway for the upcoming merge window, so you were cutting this all a bit close anyway.
Ok, No problem. I just had not heard if this was picked up or not.
Quoted 2 lines
Also looks like the ttm
kmap caching question didn't get resolved?
Quoted 7 lines
I'm sorry I thought it was resolve for this series. Christian said the patches in this series were "a good bug fix" even if not strictly necessary.[1] Beyond this series I was discussing where to go from here, and is it possible to go further with more changes.[2] At the moment I don't think I will.
Christian did I misunderstand? I can drop patch 6 and 7 if they are not proper bug fixes or at least clarifications to the code.
Yeah, it is indeed a correct cleanup. I would just *not* put a CC stable on it because it doesn't really fix anything.
Christian.
Quoted 46 lines
Ira
[1] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2Fc3b173ea-6509-ebbe-b5f9-eeb29f1ce57e%40amd.com%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C5e0192210d4640adb88b08d9dba734b1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637782333459591089%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=4p7jCB6pB4nlcUtLWh6K2Sso9X%2BsRSK7mcD8UavzztQ%3D&reserved=0
[2] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2F20211215210949.GW3538886%40iweiny-DESK2.sc.intel.com%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C5e0192210d4640adb88b08d9dba734b1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637782333459591089%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=6%2BGfSKshg8Xr%2FXJshiU28yHzbg2HcVisVJLDU6tVUT4%3D&reserved=0Quoted 40 lines
Anyway if patches are stuck resend with RESEND and if people still don't pick them up poke me and I'll apply as fallback.
Cheers, Daniel
Quoted 31 lines
Thanks,
IraQuoted 28 lines
Ira Weiny (7):
drm/i915: Replacekmap()withkmap_local_page()
drm/amd: Replacekmap()withkmap_local_page()
drm/gma: Remove calls tokmap()
drm/radeon: Replacekmap()withkmap_local_page()
drm/msm: Alter comment to usekmap_local_page()
drm/amdgpu: Ensure kunmap is called on error
drm/radeon: Ensure kunmap is called on error
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 8 ++++----drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c| 1 +drivers/gpu/drm/gma500/gma_display.c| 6 ++----drivers/gpu/drm/gma500/mmu.c| 8 ++++----drivers/gpu/drm/i915/gem/i915_gem_shmem.c| 4 ++--drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c| 8 ++++----drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c| 4 ++--drivers/gpu/drm/i915/gt/shmem_utils.c| 4 ++--drivers/gpu/drm/i915/i915_gem.c| 8 ++++----drivers/gpu/drm/i915/i915_gpu_error.c| 4 ++--drivers/gpu/drm/msm/msm_gem_submit.c| 4 ++--drivers/gpu/drm/radeon/radeon_ttm.c| 4 ++--drivers/gpu/drm/radeon/radeon_uvd.c| 1 +13 files changed, 32 insertions(+), 32 deletions(-)--
2.31.1Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fblog.ffwll.ch%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C5e0192210d4640adb88b08d9dba734b1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637782333459591089%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=NLqm91HCdllhW%2BrQ8aHMLXhYGkOJrYffpjsIJZWaFBc%3D&reserved=0
Quoted 29 lines · Christian König
Am 20.01.22 um 00:55 schrieb Ira Weiny:
Quoted 28 lines · Daniel Vetter
Quoted 12 lines · Ira Weiny
Quoted 11 lines · Ira Weiny
Quoted 10 lines
From: Ira Weiny <[email protected]>
This series starts by converting the last easy
kmap()uses tokmap_local_page().There is one more call to
kmap()wrapped inttm_bo_kmap_ttm(). Unfortunately,ttm_bo_kmap_ttm()is called in a number of different ways including some which are not thread local. I have a patch to convert that call. However, it is not straight forward so it is not included in this series.Quoted 6 lines
Quoted 3 lines
Quoted 2 lines
The final 2 patches fix bugs found while working on the
ttm_bo_kmap_ttm()conversion.Gentile ping on this series? Will it make this merge window?
I think this fell through the cracks and so no. Note that generally we feature-freeze drm tree around -rc6 anyway for the upcoming merge window, so you were cutting this all a bit close anyway.
Ok, No problem. I just had not heard if this was picked up or not.
Quoted 2 lines
Also looks like the ttm
kmap caching question didn't get resolved?I'm sorry I thought it was resolve for this series. Christian said the patches in this series were "a good bug fix" even if not strictly necessary.[1] Beyond this series I was discussing where to go from here, and is it possible to go further with more changes.[2] At the moment I don't think I will.
Quoted 5 lines
Quoted 2 lines
Christian did I misunderstand? I can drop patch 6 and 7 if they are not proper bug fixes or at least clarifications to the code.
Yeah, it is indeed a correct cleanup. I would just *not* put a CC stable on it because it doesn't really fix anything.
Ok can you pls get the amd/radeon ones stuffed into alex' tree? Or do we want to put all the ttm ones into drm-misc instead?
-Daniel
Quoted 50 lines
Christian.
Quoted 46 lines
Ira
[1] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2Fc3b173ea-6509-ebbe-b5f9-eeb29f1ce57e%40amd.com%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C5e0192210d4640adb88b08d9dba734b1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637782333459591089%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=4p7jCB6pB4nlcUtLWh6K2Sso9X%2BsRSK7mcD8UavzztQ%3D&reserved=0
[2] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2F20211215210949.GW3538886%40iweiny-DESK2.sc.intel.com%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C5e0192210d4640adb88b08d9dba734b1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637782333459591089%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=6%2BGfSKshg8Xr%2FXJshiU28yHzbg2HcVisVJLDU6tVUT4%3D&reserved=0Quoted 40 lines
Anyway if patches are stuck resend with RESEND and if people still don't pick them up poke me and I'll apply as fallback.
Cheers, Daniel
Quoted 31 lines
Thanks,
IraQuoted 28 lines
Ira Weiny (7):
drm/i915: Replacekmap()withkmap_local_page()
drm/amd: Replacekmap()withkmap_local_page()
drm/gma: Remove calls tokmap()
drm/radeon: Replacekmap()withkmap_local_page()
drm/msm: Alter comment to usekmap_local_page()
drm/amdgpu: Ensure kunmap is called on error
drm/radeon: Ensure kunmap is called on error
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 8 ++++----drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c| 1 +drivers/gpu/drm/gma500/gma_display.c| 6 ++----drivers/gpu/drm/gma500/mmu.c| 8 ++++----drivers/gpu/drm/i915/gem/i915_gem_shmem.c| 4 ++--drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c| 8 ++++----drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c| 4 ++--drivers/gpu/drm/i915/gt/shmem_utils.c| 4 ++--drivers/gpu/drm/i915/i915_gem.c| 8 ++++----drivers/gpu/drm/i915/i915_gpu_error.c| 4 ++--drivers/gpu/drm/msm/msm_gem_submit.c| 4 ++--drivers/gpu/drm/radeon/radeon_ttm.c| 4 ++--drivers/gpu/drm/radeon/radeon_uvd.c| 1 +13 files changed, 32 insertions(+), 32 deletions(-)--
2.31.1Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fblog.ffwll.ch%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C5e0192210d4640adb88b08d9dba734b1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637782333459591089%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=NLqm91HCdllhW%2BrQ8aHMLXhYGkOJrYffpjsIJZWaFBc%3D&reserved=0
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Quoted 30 lines · Daniel Vetter
Quoted 29 lines · Christian König
Am 20.01.22 um 00:55 schrieb Ira Weiny:
Quoted 28 lines · Daniel Vetter
Quoted 12 lines · Ira Weiny
Quoted 11 lines · Ira Weiny
Quoted 10 lines
From: Ira Weiny <[email protected]>
This series starts by converting the last easy
kmap()uses tokmap_local_page().There is one more call to
kmap()wrapped inttm_bo_kmap_ttm(). Unfortunately,ttm_bo_kmap_ttm()is called in a number of different ways including some which are not thread local. I have a patch to convert that call. However, it is not straight forward so it is not included in this series.Quoted 6 lines
Quoted 3 lines
Quoted 2 lines
The final 2 patches fix bugs found while working on the
ttm_bo_kmap_ttm()conversion.Gentile ping on this series? Will it make this merge window?
I think this fell through the cracks and so no. Note that generally we feature-freeze drm tree around -rc6 anyway for the upcoming merge window, so you were cutting this all a bit close anyway.
Ok, No problem. I just had not heard if this was picked up or not.
Quoted 2 lines
Also looks like the ttm
kmap caching question didn't get resolved?I'm sorry I thought it was resolve for this series. Christian said the patches in this series were "a good bug fix" even if not strictly necessary.[1] Beyond this series I was discussing where to go from here, and is it possible to go further with more changes.[2] At the moment I don't think I will.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Christian did I misunderstand? I can drop patch 6 and 7 if they are not proper bug fixes or at least clarifications to the code.
Yeah, it is indeed a correct cleanup. I would just *not* put a CC stable on it because it doesn't really fix anything.
Ok can you pls get the amd/radeon ones stuffed into alex' tree? Or do we want to put all the ttm ones into drm-misc instead?
I just updated to the latest master and there is a minor conflict. Since this is not going in this window. Let me rebase and resend.
Ira
Quoted 2 lines
-Daniel