ACPI: Arm Generic Diagnostic Dump and Reset device
Subsystems (3)
v2 cover ACPI: Arm Generic Diagnostic Dump and Reset device
Arm Generic Diagnostic Dump and Reset device enables a maintainer to request OS to perform a diagnostic dump and reset a system via SDEI event or an interrupt. This patchset adds support for the SDEI path.
I do have a patch to enable the interrupt path as well but I'm holding it back since AGDI table is missing interrupt configuration fields (trigger type etc.).
The recently published specification is available at
https://developer.arm.com/documentation/den0093/latest
The patchset was tested on Ampere Altra/Mt. Jade.
The patchset applies on top of
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm master
git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
It seems that the correct order to upstream ACPICA patch first and backport it to kernel. Thus, I'm assuming this patchset should not get merged yet.
From v1:
* Moved pdata to the stack and dropped unnecessary kzalloc() in agdi_init()
* Changed the ACPICA patch upstreaming order comment in the paragraph above
Ilkka Koskinen (2):
ACPI: AGDI: Add AGDI tables to drivers/acpi
ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset
device
drivers/acpi/arm64/Kconfig | 8 +++ drivers/acpi/arm64/Makefile | 1 + drivers/acpi/arm64/agdi.c | 125 ++++++++++++++++++++++++++++++++++++ drivers/acpi/tables.c | 2 +- include/acpi/actbl2.h | 20 ++++++ 5 files changed, 155 insertions(+), 1 deletion(-) create mode 100644 drivers/acpi/arm64/agdi.c
Signature · 1 line
2.17.1
PATCH v2 1/2 ACPI: AGDI: Add AGDI tables to drivers/acpi
ACPI for Arm Components 1.1 Platform Design Document v1.1 [0] specifices Arm Generic Diagnostic Device Interface (AGDI). It allows an admin to issue diagnostic dump and reset via an SDEI event or an interrupt. This patch adds support to ACPI/AGDI tables.
[0] https://developer.arm.com/documentation/den0093/latest/
--- drivers/acpi/tables.c | 2 +- include/acpi/actbl2.h | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-)
drivers/acpi/tables.c +1 -1
@@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {ACPI_SIG_WDDT ,ACPI_SIG_WDRT ,ACPI_SIG_DSDT ,ACPI_SIG_FADT ,ACPI_SIG_PSDT ,ACPI_SIG_RSDT ,ACPI_SIG_XSDT ,ACPI_SIG_SSDT ,ACPI_SIG_IORT ,ACPI_SIG_NFIT ,ACPI_SIG_HMAT ,ACPI_SIG_PPTT , - ACPI_SIG_NHLT }; + ACPI_SIG_NHLT, ACPI_SIG_AGDI };#define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
include/acpi/actbl2.h +20 -0
@@ -24,6 +24,7 @@* file. Useful because they make it more difficult to inadvertently type in * the wrong signature. */ +#define ACPI_SIG_AGDI "AGDI"/* ARM Generic Diagnostic Dump and Reset Device Interface */ #define ACPI_SIG_BDAT "BDAT"/* BIOS Data ACPI Table */ #define ACPI_SIG_IORT "IORT"/* IO Remapping Table */ #define ACPI_SIG_IVRS "IVRS"/* I/O Virtualization Reporting Structure */
@@ -237,6 +238,25 @@ typedef struct acpi_aest_node_interrupt {#define ACPI_AEST_NODE_ERROR_RECOVERY 1#define ACPI_AEST_XRUPT_RESERVED 2/* 2 and above are reserved */ +/******************************************************************************* +* AGDI - Generic Diagnostic Dump and Reset Device Interface +* +* Document number: ARM DEN0093 +* +*******************************************************************************/ + +struct acpi_table_agdi { +struct acpi_table_header header; +u8 flags; +u8 reserved[3 ]; +u32 sdei_event; +u32 gsiv; +}; + +/* Masks for Flags field above for AGDI table */ + +#define ACPI_AGDI_SIGNALING_MODE (1) +/******************************************************************************* * * BDAT - BIOS Data ACPI Table
Signature · 1 line
2.17.1
Rafael J. Wysocki
maintainerRe: [PATCH v2 1/2] ACPI: AGDI: Add AGDI tables to drivers/acpi
include/acpi/actbl2.h
Quoted 31 lines · Ilkka Koskinen
ACPI for Arm Components 1.1 Platform Design Document v1.1 [0] specifices Arm Generic Diagnostic Device Interface (AGDI). It allows an admin to issue diagnostic dump and reset via an SDEI event or an interrupt. This patch adds support to ACPI/AGDI tables.
[0] https://developer.arm.com/documentation/den0093/latest/
Signed-off-by Ilkka Koskinen <ilkka(a)os.amperecomputing.com>--- drivers/acpi/tables.c | 2 +- include/acpi/actbl2.h | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-)drivers/acpi/tables.c +1
-1@@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {ACPI_SIG_WDDT ,ACPI_SIG_WDRT ,ACPI_SIG_DSDT ,ACPI_SIG_FADT ,ACPI_SIG_PSDT ,ACPI_SIG_RSDT ,ACPI_SIG_XSDT ,ACPI_SIG_SSDT ,ACPI_SIG_IORT ,ACPI_SIG_NFIT ,ACPI_SIG_HMAT ,ACPI_SIG_PPTT , - ACPI_SIG_NHLT }; + ACPI_SIG_NHLT, ACPI_SIG_AGDI };#define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)include/acpi/actbl2.h +0
-0
The changes in actbl2.h are ACPICA material and so they need to be routed through the upstream ACPICA project.
Moreover, you have already submitted a pull request with them to the
upstream: https://github.com/acpica/acpica/pull/737/commits/cf36a6d658ca5aa8c329c2edfc3322c095ffd844
Please wait until this gets integrated and repost the rest of the patches as incremental changes on top of that.
Re: [PATCH v2 1/2] ACPI: AGDI: Add AGDI tables to drivers/acpi
Quoted 37 lines · Rafael J. Wysocki
include/acpi/actbl2.h
Quoted 31 lines · Ilkka Koskinen
ACPI for Arm Components 1.1 Platform Design Document v1.1 [0] specifices Arm Generic Diagnostic Device Interface (AGDI). It allows an admin to issue diagnostic dump and reset via an SDEI event or an interrupt. This patch adds support to ACPI/AGDI tables.
[0] https://developer.arm.com/documentation/den0093/latest/
Signed-off-by Ilkka Koskinen <[email protected]>--- drivers/acpi/tables.c | 2 +- include/acpi/actbl2.h | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-)drivers/acpi/tables.c +1
-1@@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {ACPI_SIG_WDDT ,ACPI_SIG_WDRT ,ACPI_SIG_DSDT ,ACPI_SIG_FADT ,ACPI_SIG_PSDT ,ACPI_SIG_RSDT ,ACPI_SIG_XSDT ,ACPI_SIG_SSDT ,ACPI_SIG_IORT ,ACPI_SIG_NFIT ,ACPI_SIG_HMAT ,ACPI_SIG_PPTT , - ACPI_SIG_NHLT }; + ACPI_SIG_NHLT, ACPI_SIG_AGDI };#define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)include/acpi/actbl2.h +0
-0The changes in
actbl2.hare ACPICA material and so they need to be routed through the upstream ACPICA project.
Quoted 5 lines
Moreover, you have already submitted a pull request with them to the
upstream: https://github.com/acpica/acpica/pull/737/commits/cf36a6d658ca5aa8c329c2edfc3322c095ffd844Please wait until this gets integrated and repost the rest of the patches as incremental changes on top of that.
Thanks for clarifying the process, that makes sense to me. I'll wait until the patch gets merged into the kernel and submit what's left from the patchset as v3 then.
Thanks,
Ilkka
PATCH v2 2/2 ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset device
In reply to Ilkka KoskinenACPI for Arm Components 1.1 Platform Design Document v1.1 [0] specifices Arm Generic Diagnostic Device Interface (AGDI). It allows an admin to issue diagnostic dump and reset via an SDEI event or an interrupt. This patch implements SDEI path.
[0] https://developer.arm.com/documentation/den0093/latest/
--- drivers/acpi/arm64/Kconfig | 8 +++ drivers/acpi/arm64/Makefile | 1 + drivers/acpi/arm64/agdi.c | 125 ++++++++++++++++++++++++++++++++++++ 3 files changed, 134 insertions(+) create mode 100644 drivers/acpi/arm64/agdi.c
drivers/acpi/arm64/Kconfig +8 -0
@@ -8,3 +8,11 @@ config ACPI_IORT config ACPI_GTDT bool + +config ACPI_AGDI + bool "Arm Generic Diagnostic Dump and Reset Device Interface" + depends on ARM_SDE_INTERFACE + help + Arm Generic Diagnostic Dump and Reset Device Interface (AGDI) is + a standard that enables issuing a non-maskable diagnostic dump and + reset command.
drivers/acpi/arm64/Makefile +1 -0
@@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_ACPI_AGDI) += agdi.o obj-$(CONFIG_ACPI_IORT) += iort.o obj-$(CONFIG_ACPI_GTDT) += gtdt.o obj-y += dma.o
drivers/acpi/arm64/agdi.c new file +125 -0
125 lines not on this page · raw message
Signature · 1 line
2.17.1