Skip to contentSkip to conversation

IB/qib: Fix memory leak in qib_user_sdma_queue_pkts

PATCH Applied José Expósito 3 participants 3 messages Dec 8, 2021 – Dec 15, 2021 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IB/qib: Fix memory leak in qib_user_sdma_queue_pkts

Addresses-Coverity-ID: 1493352 ("Resource leak")

---
 drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/qib/qib_user_sdma.c +1 -1
index ac11943a5ddb..bf2f30d67949 100644
@@ -941,7 +941,7 @@ static int qib_user_sdma_queue_pkts(const struct qib_devdata *dd,
 					       &addrlimit) ||
 			    addrlimit > type_max(typeof(pkt->addrlimit))) {
 				ret = -EINVAL;
-				goto free_pbc;
+				goto free_pkt;
 			}
 			pkt->addrlimit = addrlimit;
 
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines

Subject: [PATCH] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts

Addresses-Coverity-ID: 1493352 ("Resource leak")

---
 drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/qib/qib_user_sdma.c +0 -0
index ac11943a5ddb..bf2f30d67949 100644

drivers/infiniband/hw/qib/qib_user_sdma.c static int qib_user_sdma_queue_pkts(const struct

Quoted 10 lines
drivers/infiniband/hw/qib/qib_user_sdma.c +1 -2
@@ -941,7 +941,7 @@ static int qib_user_sdma_queue_pkts(const struct
 qib_devdata *dd,
 					       &addrlimit) ||
 			    addrlimit > type_max(typeof(pkt->addrlimit))) {
 				ret = -EINVAL;
-				goto free_pbc;
+				goto free_pkt;
 			}
 			pkt->addrlimit = addrlimit;
 
--

Thanks for catching my mistake!

Mike

Fixes d39bf40e55e6 ("IB/qib: Protect from buffer overflow in struct qib_user_sdma_pkt fields"):