IB/qib: Fix memory leak in qib_user_sdma_queue_pkts
PATCH 1/1 IB/qib: Fix memory leak in qib_user_sdma_queue_pkts
Addresses-Coverity-ID: 1493352 ("Resource leak")
Signed-off-by José Expósito <[email protected]>
--- drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/qib/qib_user_sdma.c +1 -1
@@ -941,7 +941,7 @@ static int qib_user_sdma_queue_pkts(const struct qib_devdata *dd, &addrlimit) || addrlimit > type_max(typeof(pkt->addrlimit))) { ret = -EINVAL ; - goto free_pbc; + goto free_pkt; } pkt->addrlimit = addrlimit;
Signature · 1 line
2.25.1
Quoted 14 lines
Subject: [PATCH] IB/qib: Fix memory leak in
qib_user_sdma_queue_pktsAddresses-Coverity-ID: 1493352 ("Resource leak")
Signed-off-by José Expósito <[email protected]>--- drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/infiniband/hw/qib/qib_user_sdma.c +0
-0
drivers/infiniband/hw/qib/qib_user_sdma.c static int qib_user_sdma_queue_pkts(const struct
Quoted 10 lines
drivers/infiniband/hw/qib/qib_user_sdma.c +1
-2@@ -941,7 +941,7 @@ static int qib_user_sdma_queue_pkts(const struct qib_devdata *dd, &addrlimit) || addrlimit > type_max(typeof(pkt->addrlimit))) { ret = -EINVAL ; - goto free_pbc; + goto free_pkt; } pkt->addrlimit = addrlimit; --
Thanks for catching my mistake!
Mike
Acked-by Mike Marciniszyn <[email protected]>
Fixes d39bf40e55e6 ("IB/qib: Protect from buffer overflow in struct qib_user_sdma_pkt fields"):
Quoted 6 lines · José Expósito
Addresses-Coverity-ID: 1493352 ("Resource leak")
Signed-off-by José Expósito <[email protected]>Acked-by Mike Marciniszyn <[email protected]>--- drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc.
I wrote a commit message and added the missing fixes line, please take care in future.
Jason