clk: cdce9xx: Convert .of_xlate to .request
PATCH v2 1/2 clk: cdce9xx: Convert .of_xlate to .request
This xlate function just performs some checking. We can do this in request() instead and use the default xlate.
---
Changes in v2:
- Fix build error caused by mismatched function name
drivers/clk/clk-cdce9xx.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)
drivers/clk/clk-cdce9xx.c +3 -9
@@ -86,19 +86,13 @@ static int cdce9xx_reg_write(struct udevice *dev, u8 addr, u8 val)return ret; } -static int cdce9xx_clk_of_xlate (struct clk *clk, -struct ofnode_phandle_args *args) +static int cdce9xx_clk_request (struct clk *clk) {struct cdce9xx_clk_data *data =dev_get_priv (clk->dev); -if (args->args_count !=1 ) +if (clk->id > data->chip->num_outputs)return -EINVAL ; -if (args->args[0 ] > data->chip->num_outputs) -return -EINVAL ; - - clk->id = args->args[0 ]; -return 0 ; }
@@ -241,7 +235,7 @@ static const struct udevice_id cdce9xx_clk_of_match[] = { };static const struct clk_ops cdce9xx_clk_ops = { - .of_xlate = cdce9xx_clk_of_xlate, + .request = cdce9xx_clk_request, .get_rate = cdce9xx_clk_get_rate, .set_rate = cdce9xx_clk_set_rate, };
Signature · 1 line
2.33.0
PATCH v2 2/2 clk: cdce9xxx: Add maintainer
This adds an entry in MAINTAINERS for the cdce9xx driver, since it was not added when the driver was submitted. This will help future submitters figure out who to CC.
---
Tero, if you don't want to maintain this I'll resubmit this patch with the orphaned status. Alternatively, perhaps Tom wants to maintain this driver since it is used exclusively by boards he maintains.
(no changes since v1)
MAINTAINERS | 6 ++++++ 1 file changed, 6 insertions(+)
MAINTAINERS +6 -0
@@ -658,6 +658,12 @@ M: Simon Glass <[email protected]> S: Maintained F: tools/buildman/ +CDCE9XX CLOCK: +M: Tero Kristo <[email protected]> +S: Maintained +F: doc/device-tree-bindings/clock/ti,cdce9xx.txt +F: drivers/clk/clk-cdce9xx.c + CFI FLASH M: Stefan Roese <[email protected]> S: Maintained
Signature · 1 line
2.33.0
Re: [PATCH v2 2/2] clk: cdce9xxx: Add maintainer
Quoted 9 lines · Sean Anderson
This adds an entry in
MAINTAINERSfor the cdce9xx driver, since it was not added when the driver was submitted. This will help future submitters figure out who to CC.Signed-off-by Sean Anderson <[email protected]>---
Tero, if you don't want to maintain this I'll resubmit this patch with the orphaned status. Alternatively, perhaps Tom wants to maintain this driver since it is used exclusively by boards he maintains.
Well, I am not actively maintaining this, as I am not employed by TI anymore. :)
That said, I don't see how much work there is needed for this driver anyways, it is very simple, and it can be considered "completed". That's the reason I didn't initially put any maintainer on it. Marking it "orphaned" would be a bit too harsh status for it imho, as it is still used by TI platforms, and it gets actively tested by them.
-Tero
Quoted 24 lines
(no changes since v1)
MAINTAINERS | 6 ++++++ 1 file changed, 6 insertions(+)MAINTAINERS +6
-0@@ -658,6 +658,12 @@ M: Simon Glass <[email protected]> S: Maintained F: tools/buildman/ +CDCE9XX CLOCK: +M: Tero Kristo <[email protected]> +S: Maintained +F: doc/device-tree-bindings/clock/ti,cdce9xx.txt +F: drivers/clk/clk-cdce9xx.c + CFI FLASH M: Stefan Roese <[email protected]> S: Maintained
Re: [PATCH v2 2/2] clk: cdce9xxx: Add maintainer
Quoted 11 lines · Tero Kristo
Quoted 9 lines · Sean Anderson
This adds an entry in
MAINTAINERSfor the cdce9xx driver, since it was not added when the driver was submitted. This will help future submitters figure out who to CC.Signed-off-by Sean Anderson <[email protected]>---
Tero, if you don't want to maintain this I'll resubmit this patch with the orphaned status. Alternatively, perhaps Tom wants to maintain this driver since it is used exclusively by boards he maintains.
Quoted 3 lines
Well, I am not actively maintaining this, as I am not employed by TI anymore. :)
That said, I don't see how much work there is needed for this driver anyways, it is very simple, and it can be considered "completed". That's the reason I didn't initially put any maintainer on it. Marking it "orphaned" would be a bit too harsh status for it imho, as it is still used by TI platforms, and it gets actively tested by them.
Well, the issue that I would like to resolve is that in order to CC you I had to look up who did the initial commit, and even then the email was wrong (since it had your TI email). So for the benefit of future hackers, I would like to record your current email. I suppose your Reviewed-By on the first patch will do.
--Sean
Re: [PATCH v2 2/2] clk: cdce9xxx: Add maintainer
Quoted 15 lines · Sean Anderson
Quoted 13 lines · Tero Kristo
Quoted 9 lines · Sean Anderson
This adds an entry in
MAINTAINERSfor the cdce9xx driver, since it was not added when the driver was submitted. This will help future submitters figure out who to CC.Signed-off-by Sean Anderson <[email protected]>---
Tero, if you don't want to maintain this I'll resubmit this patch with the orphaned status. Alternatively, perhaps Tom wants to maintain this driver since it is used exclusively by boards he maintains.Well, I am not actively maintaining this, as I am not employed by TI anymore. :)
Quoted 7 lines
Quoted 1 line
That said, I don't see how much work there is needed for this driver anyways, it is very simple, and it can be considered "completed". That's the reason I didn't initially put any maintainer on it. Marking it "orphaned" would be a bit too harsh status for it imho, as it is still used by TI platforms, and it gets actively tested by them.
Well, the issue that I would like to resolve is that in order to CC you I had to look up who did the initial commit, and even then the email was wrong (since it had your TI email). So for the benefit of future hackers, I would like to record your current email. I suppose your Reviewed-By on the first patch will do.
Yes, I understand your point, however adding a maintainer entry for every tiny driver is a bit of an overkill. And well, it would also need an ack from the subsystem maintainer itself, whether he/she wants to share the workload on it or not.
U-boot contains a script called get_maintainer, that can be used to fetch the valid maintainer entry for a file. In this case, it reports Lukasz, which, imho, is just fine. cdce9xxx is not going to face many changes, and if any, those are just generic framework changes/fixes which can be handled just fine by the subsystem maintainers.
-Tero
Re: [PATCH v2 2/2] clk: cdce9xxx: Add maintainer
Quoted 18 lines · Tero Kristo
Quoted 17 lines · Sean Anderson
Quoted 14 lines · Tero Kristo
Quoted 9 lines · Sean Anderson
This adds an entry in
MAINTAINERSfor the cdce9xx driver, since it was not added when the driver was submitted. This will help future submitters figure out who to CC.Signed-off-by Sean Anderson <[email protected]>---
Tero, if you don't want to maintain this I'll resubmit this patch with the orphaned status. Alternatively, perhaps Tom wants to maintain this driver since it is used exclusively by boards he maintains.Well, I am not actively maintaining this, as I am not employed by TI anymore. :)
That said, I don't see how much work there is needed for this driver anyways, it is very simple, and it can be considered "completed". That's the reason I didn't initially put any maintainer on it. Marking it "orphaned" would be a bit too harsh status for it imho, as it is still used by TI platforms, and it gets actively tested by them.
Quoted 7 lines
Quoted 5 lines
Well, the issue that I would like to resolve is that in order to CC you I had to look up who did the initial commit, and even then the email was wrong (since it had your TI email). So for the benefit of future hackers, I would like to record your current email. I suppose your Reviewed-By on the first patch will do.
Yes, I understand your point, however adding a maintainer entry for every tiny driver is a bit of an overkill.
I think it's great to have. It helps submitters know who to CC, and it helps me know who I need a review/ack from. It also helps to know who has hardware if a change needs testing, though perhaps you don't have access to this hardware any more.
Quoted 1 line
And well, it would also need an ack from the subsystem maintainer itself, whether he/she wants to share the workload on it or not.
Because Lukasz has not been very active lately, I volunteered to be clock subsystem maintainer.
Quoted 1 line
U-boot contains a script called
get_maintainer, that can be used to fetch the valid maintainer entry for a file. In this case, it reports Lukasz, which, imho, is just fine. cdce9xxx is not going to face many changes, and if any, those are just generic framework changes/fixes which can be handled just fine by the subsystem maintainers.
And that is why I wanted to have your email in MAINTAINERS. But since you reviewed the other patch, I think it will pick up your new email. So I don't think this patch is necessary.
--Sean
Quoted 4 lines · Sean Anderson
This xlate function just performs some checking. We can do this in
request()instead and use the default xlate.Signed-off-by Sean Anderson <[email protected]>
Looks good to me now.
Quoted 44 lines
---
Changes in v2:
- Fix build error caused by mismatched function namedrivers/clk/clk-cdce9xx.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)drivers/clk/clk-cdce9xx.c +3
-9@@ -86,19 +86,13 @@ static int cdce9xx_reg_write(struct udevice *dev, u8 addr, u8 val)return ret; } -static int cdce9xx_clk_of_xlate (struct clk *clk, -struct ofnode_phandle_args *args) +static int cdce9xx_clk_request (struct clk *clk) {struct cdce9xx_clk_data *data =dev_get_priv (clk->dev); -if (args->args_count !=1 ) +if (clk->id > data->chip->num_outputs)return -EINVAL ; -if (args->args[0 ] > data->chip->num_outputs) -return -EINVAL ; - - clk->id = args->args[0 ]; -return 0 ; }@@ -241,7 +235,7 @@ static const struct udevice_id cdce9xx_clk_of_match[] = { };static const struct clk_ops cdce9xx_clk_ops = { - .of_xlate = cdce9xx_clk_of_xlate, + .request = cdce9xx_clk_request, .get_rate = cdce9xx_clk_get_rate, .set_rate = cdce9xx_clk_set_rate, };
Sean Anderson
AppliedRe: (subset) [PATCH v2 1/2] clk: cdce9xx: Convert .of_xlate to .request
In reply to Sean AndersonQuoted 4 lines · Sean Anderson
This xlate function just performs some checking. We can do this in
request()instead and use the default xlate.
Applied, thanks!
[1/2] clk: cdce9xx: Convert .of_xlate to .request
commit: f9489580750af51ef7214bb1937d4b1d3c00a333
Best regards,
Signature · 1 line
Sean Anderson <[email protected]>