Skip to contentSkip to conversation

memblock: fix memblock_phys_alloc() section mismatch error

PATCH Superseded Jackie Liu 2 participants 2 messages Dec 16, 2021

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Jackie Liu

author
#0 lore raw

PATCH 1/1 memblock: fix memblock_phys_alloc() section mismatch error

From: Jackie Liu <[email protected]>

Fix modpost Section mismatch error in memblock_phys_alloc()

[...]
WARNING: modpost: vmlinux.o(.text.unlikely+0x1dcc): Section mismatch in reference from the function memblock_phys_alloc() to the function .init.text:memblock_phys_alloc_range() The function memblock_phys_alloc() references
the function __init memblock_phys_alloc_range().
This is often because memblock_phys_alloc lacks a __init
annotation or the annotation of memblock_phys_alloc_range is wrong.

ERROR: modpost: Section mismatches detected. Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them. [...]

I have checked that the memblock_phys_alloc used in the source tree is all in the __init section, we should also let him save it in this section.

---
 include/linux/memblock.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/memblock.h +1 -1
index 8adcf1fa8096..8959d43bc76b 100644
@@ -405,7 +405,7 @@ phys_addr_t memblock_alloc_range_nid(phys_addr_t size,
 				      phys_addr_t end, int nid, bool exact_nid);
 phys_addr_t memblock_phys_alloc_try_nid(phys_addr_t size, phys_addr_t align, int nid);
 
-static inline phys_addr_t memblock_phys_alloc(phys_addr_t size,
+static inline phys_addr_t __init memblock_phys_alloc(phys_addr_t size,
 					      phys_addr_t align)
 {
 	return memblock_phys_alloc_range(size, align, 0,
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 12 lines · Jackie Liu

From: Jackie Liu <[email protected]>

Fix modpost Section mismatch error in memblock_phys_alloc()

[...]
WARNING: modpost: vmlinux.o(.text.unlikely+0x1dcc): Section mismatch in reference from the function memblock_phys_alloc() to the function .init.text:memblock_phys_alloc_range() The function memblock_phys_alloc() references
the function __init memblock_phys_alloc_range().
This is often because memblock_phys_alloc lacks a __init
annotation or the annotation of memblock_phys_alloc_range is wrong.

Quoted 6 lines

ERROR: modpost: Section mismatches detected. Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them. [...]

I have checked that the memblock_phys_alloc used in the source tree is all in the __init section, we should also let him save it in this section.

I don't know why compiler decided against inlining memblock_phys_alloc(), so better solution here would be to use __always_inline IMO.

Quoted 22 lines
---
 include/linux/memblock.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/memblock.h +1 -1
index 8adcf1fa8096..8959d43bc76b 100644
@@ -405,7 +405,7 @@ phys_addr_t memblock_alloc_range_nid(phys_addr_t size,
 				      phys_addr_t end, int nid, bool exact_nid);
 phys_addr_t memblock_phys_alloc_try_nid(phys_addr_t size, phys_addr_t align, int nid);
 
-static inline phys_addr_t memblock_phys_alloc(phys_addr_t size,
+static inline phys_addr_t __init memblock_phys_alloc(phys_addr_t size,
 					      phys_addr_t align)
 {
 	return memblock_phys_alloc_range(size, align, 0,
Signature · 1 line
2.25.1
Signature · 2 lines
Sincerely yours,
Mike.