Skip to contentSkip to conversation

MIPS: drop selected EARLY_PRINTK configs for MACH_REALTEK_RTL

PATCH Applied Sander Vanheule 2 participants 2 messages Dec 15, 2021 – Dec 16, 2021 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MIPS: drop selected EARLY_PRINTK configs for MACH_REALTEK_RTL

MACH_REALTEK_RTL declares that the system supports early printk , but this is not actually implemented as intended. The system is left with a non-functional early0 console because the setup_8250_early_printk_port() call provided for MIPS_GENERIC is never used to set this up. Generic ns16550a earlycon works, so devices should use that for early output. This means that SYS_HAS_EARLY_PRINTK and USE_GENERIC_EARLY_PRINTK_8250 do not need to be selected.

Additionally, as reported by Lukas Bulwahn, the selected symbol SYS_HAS_EARLY_PRINTK_8250 does not actually exist, so should also be dropped.

Cc Lukas Bulwahn <[email protected]>
Cc Bert Vermeulen <[email protected]>
---
 arch/mips/Kconfig | 3 ---
 1 file changed, 3 deletions(-)
arch/mips/Kconfig +0 -3
index 63eb66a22691..9a3a2330fc69 100644
@@ -642,9 +642,6 @@ config MACH_REALTEK_RTL
 	select SYS_SUPPORTS_MIPS16
 	select SYS_SUPPORTS_MULTITHREADING
 	select SYS_SUPPORTS_VPE_LOADER
-	select SYS_HAS_EARLY_PRINTK
-	select SYS_HAS_EARLY_PRINTK_8250
-	select USE_GENERIC_EARLY_PRINTK_8250
 	select BOOT_RAW
 	select PINCTRL
 	select USE_OF
Signature · 1 line
2.33.1
maintainer Applied
#1 lore raw
Quoted 35 lines · Sander Vanheule

MACH_REALTEK_RTL declares that the system supports early printk , but this is not actually implemented as intended. The system is left with a non-functional early0 console because the setup_8250_early_printk_port() call provided for MIPS_GENERIC is never used to set this up. Generic ns16550a earlycon works, so devices should use that for early output. This means that SYS_HAS_EARLY_PRINTK and USE_GENERIC_EARLY_PRINTK_8250 do not need to be selected.

Additionally, as reported by Lukas Bulwahn, the selected symbol SYS_HAS_EARLY_PRINTK_8250 does not actually exist, so should also be dropped.

Cc Lukas Bulwahn <[email protected]>
Cc Bert Vermeulen <[email protected]>
---
 arch/mips/Kconfig | 3 ---
 1 file changed, 3 deletions(-)
arch/mips/Kconfig +0 -3
index 63eb66a22691..9a3a2330fc69 100644
@@ -642,9 +642,6 @@ config MACH_REALTEK_RTL
 	select SYS_SUPPORTS_MIPS16
 	select SYS_SUPPORTS_MULTITHREADING
 	select SYS_SUPPORTS_VPE_LOADER
-	select SYS_HAS_EARLY_PRINTK
-	select SYS_HAS_EARLY_PRINTK_8250
-	select USE_GENERIC_EARLY_PRINTK_8250
 	select BOOT_RAW
 	select PINCTRL
 	select USE_OF
Signature · 1 line
2.33.1

applied to mips-next.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]