MIPS: drop selected EARLY_PRINTK configs for MACH_REALTEK_RTL
PATCH 1/1 MIPS: drop selected EARLY_PRINTK configs for MACH_REALTEK_RTL
MACH_REALTEK_RTL declares that the system supports early printk , but this is not actually implemented as intended. The system is left with a non-functional early0 console because the setup_8250_early_printk_port() call provided for MIPS_GENERIC is never used to set this up. Generic ns16550a earlycon works, so devices should use that for early output. This means that SYS_HAS_EARLY_PRINTK and USE_GENERIC_EARLY_PRINTK_8250 do not need to be selected.
Additionally, as reported by Lukas Bulwahn, the selected symbol SYS_HAS_EARLY_PRINTK_8250 does not actually exist, so should also be dropped.
--- arch/mips/Kconfig | 3 --- 1 file changed, 3 deletions(-)
arch/mips/Kconfig +0 -3
@@ -642,9 +642,6 @@ config MACH_REALTEK_RTL select SYS_SUPPORTS_MIPS16 select SYS_SUPPORTS_MULTITHREADING select SYS_SUPPORTS_VPE_LOADER - select SYS_HAS_EARLY_PRINTK - select SYS_HAS_EARLY_PRINTK_8250 - select USE_GENERIC_EARLY_PRINTK_8250 select BOOT_RAW select PINCTRL select USE_OF
Signature · 1 line
2.33.1
Quoted 35 lines · Sander Vanheule
MACH_REALTEK_RTLdeclares that the system supports early printk , but this is not actually implemented as intended. The system is left with a non-functional early0 console because thesetup_8250_early_printk_port()call provided forMIPS_GENERICis never used to set this up. Generic ns16550a earlycon works, so devices should use that for early output. This means thatSYS_HAS_EARLY_PRINTKandUSE_GENERIC_EARLY_PRINTK_8250do not need to be selected.Additionally, as reported by Lukas Bulwahn, the selected symbol
SYS_HAS_EARLY_PRINTK_8250does not actually exist, so should also be dropped.Cc Lukas Bulwahn <[email protected]>Cc Bert Vermeulen <[email protected]>Signed-off-by Sander Vanheule <[email protected]>--- arch/mips/Kconfig | 3 --- 1 file changed, 3 deletions(-)arch/mips/Kconfig +0
-3@@ -642,9 +642,6 @@ config MACH_REALTEK_RTL select SYS_SUPPORTS_MIPS16 select SYS_SUPPORTS_MULTITHREADING select SYS_SUPPORTS_VPE_LOADER - select SYS_HAS_EARLY_PRINTK - select SYS_HAS_EARLY_PRINTK_8250 - select USE_GENERIC_EARLY_PRINTK_8250 select BOOT_RAW select PINCTRL select USE_OFSignature · 1 line
2.33.1
applied to mips-next.
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]